[Help] IGCN 9.2 How to fix IGC.DataServer.exe Crash

[pimza1996]

@DragonSeth | How to fix IGC.DataServer.exe Crash (%n)
# Example #
Send Message : %n (IGC.DataServer Crash)
Images :

You must be registered to see links

Add Friends : %n (IGC.DataServer Crash)
Images :

You must be registered to see links

Search Party : %n (IGC.DataServer Crash)
Images :

You must be registered to see links

Search Guild : %n (IGC.DataServer Crash)
Images :

You must be registered to see links

IGC.DataServer.exe (Crash Dump File)
Images :

You must be registered to see links

- Thank for fix

 

[thevjfla]

@DragonSeth | How to fix IGC.DataServer.exe Crash (%n)
# Example #
Send Message : %n (IGC.DataServer Crash)
Images :

You must be registered to see links

Add Friends : %n (IGC.DataServer Crash)
Images :

You must be registered to see links

Search Party : %n (IGC.DataServer Crash)
Images :

You must be registered to see links

Search Guild : %n (IGC.DataServer Crash)
Images :

You must be registered to see links

IGC.DataServer.exe (Crash Dump File)
Images :

You must be registered to see links

- Thank for fix

Where %n in send message?

 

[pimza1996]

You can see sample photos.
%n -> IGC.DataServer.exe Crash

 

[DragonSeth]

Is this happening on the latest version? . If so I'll check the source.

 

[pimza1996]

Is this happening on the latest version? . If so I'll check the source.

yes i'm use server file last version : http://forum.ragezone.com/f197/release-multiserver-manager-pack-igcn-1150883/
ro
i'm a have one question why account not show HWID ?
images :

You must be registered to see links

//Thank you for answer

 

[DragonSeth]

Okay since this is a critical issue when I find some free time I will fix it and upload it.

 

[pimza1996]

Okay since this is a critical issue when I find some free time I will fix it and upload it.

list Command for crash

example :

You must be registered to see links

1. %n
2. %I
3. %L
4. %N
5. %S
6. %T
7. %z
8. %Z
9. %

Thank for fixed

 

[allexander]

@DragonSeth | How to fix IGC.DataServer.exe Crash (%n)
# Example #
Send Message : %n (IGC.DataServer Crash)
Images :

You must be registered to see links

Add Friends : %n (IGC.DataServer Crash)
Images :

You must be registered to see links

Search Party : %n (IGC.DataServer Crash)
Images :

You must be registered to see links

Search Guild : %n (IGC.DataServer Crash)
Images :

You must be registered to see links

IGC.DataServer.exe (Crash Dump File)
Images :

You must be registered to see links

- Thank for fix

Here you go, test it and let us know if it works:

so if it is possible you could share the code to fix the bug that crashes the DataServer ?? % n,% s,% d when used in frindsystem and cashshop gift.


Enviado do meu iPhone usando Tapatalk

This is not even close to a great solution, but it avoid the crashes, as intended. The Friend System is not crashing when % sign is typed. Can you be more specific?

StdAfx.h

#include <boost/algorithm/string/replace.hpp>

DSprotocol.cpp

void CDataServerProtocol::ReqInGameShopItemGift(short aIndex, ISHOP_ITEM_GIFT *aRecv)
{
    std::string strMessage;
...
    strMessage = aRecv->Message;
    boost::replace_all(strMessage, "%", "%%");

    this->m_ItemShopDB.ExecQuery("EXEC WZ_IBS_AddGift '%s', %d, %d,  %d, %d, '%s', '%s'", aRecv->TargetName, aRecv->ID1, aRecv->ID2,  aRecv->ID3, 2, aRecv->Name, strMessage.c_str());
...
}

void CDataServerProtocol::ReqInGameShopPackageGift(short aIndex, LPBYTE aRecv)
{
    std::string strMessage;
...
    strMessage = lpMsg->Message;
    boost::replace_all(strMessage, "%", "%%");

    for(int i=0;i<lpMsg->Count;i++)
    {
        lpItem = (ISHOP_ITEM_PACKAGE *)(aRecv + sizeof(ISHOP_ITEM_GIFT_PACKAGE) + i * sizeof(ISHOP_ITEM_PACKAGE));

        this->m_ItemShopDB.ExecQuery("EXEC WZ_IBS_AddGift '%s', %d, %d, %d, %d, '%s', '%s'",
            lpMsg->TargetName, lpItem->ID1, lpItem->ID2, lpItem->ID3,
            2, lpMsg->Name, strMessage.c_str());
...
}

-- Edit --

Friend System uses Binary storage, so it is not affected by % sign.

wsprintf(szMsg, "UPDATE T_FriendMail SET Subject=? where MemoIndex=%d AND GUID=%d", memo_index, guid);
this->m_MailDB.SetAsBinary(szMsg, (LPBYTE)lpMemoSendHdr->Subject, 60);
...
wsprintf(szMsg, "UPDATE T_FriendMail SET Memo=? where MemoIndex=%d AND GUID=%d", memo_index, guid);
this->m_MailDB.SetAsBinary(szMsg, (LPBYTE)sMemo, memo_size);

[]'s

 

[DragonSeth]

No worries new update coming soon. With the crash server fix and many other things

Spoiler

Spoiler

Spoiler

Spoiler

P.S: please ignore the broken models ^^ was doing some testing.

 

[pimza1996]

@DragonSeth, very good //thank for fixed

 

[thevjfla]

No worries new update coming soon. With the crash server fix and many other things

Spoiler

Spoiler

Spoiler

Spoiler

P.S: please ignore the broken models ^^ was doing some testing.

DragonSeth

In the original src have the same bug if put %n in find guild member and party too, check it if you not fixed already

 

[DragonSeth]

From what i can tell. There is no crash

 

[pimza1996]

@DragonSeth When will you update

 

[DragonSeth]

DragonSeth When will you update

(UPDATE COMING SOON) it's more than just a dataserver crash fix. It includes many new features and fixes.