[Add-on] GM notice Npc

[Soulfist]

This NPC is actually kind of useless but I got bored and scripted it. If you notice any problems let me know. I never had the opportunity to test it but if anyone could test it let me know!

/** 
* 
*@author Soulfist 
*/ 

importPackage(Packages.tools.MaplePacketCreator);

status = 0, sname = "DominoStory", n = ""; 
Op = ["Urgent", "Warning", "Ban", "Severe", "Communication"];  

function start() { 
    var t = "Welcome to"+sname+", I am the GM notice NPC, which type will it be?"; 
    for(var i = 0; i < Op.length; t += "\r\n#L"+i+"#"+Op[i]+"#l", i++); 
    cm.sendSimple(t); 
} 

function action(m, t, s) { 
    status++;
    if (m != 1) { 
        cm.dispose(); 
        return; 
    } 
    if (status == 1) { 
        if (cm.getPlayer().gmLevel() >= 3)
            cm.sendGetText("Please type your desired announcement:\r\n"); 
        else { 
            cm.sendOk("You aren't a GM, please don't cause trouble"); 
            cm.dispose(); 
        } 
    } else if (status == 2) { 
        n = cm.getText(); 
        cm.getClient().getChannelServer().getWorldInterface().broadcastGMMessage(null, MaplePacketCreator.serverNotice(6, "["+Op[s]+"] "+n).getBytes()); 
        cm.dispose(); 
    } 
} 

It basically just sends out a server notice so GMs can communicate across channels and such. Like I said its not too useful but maybe someone will like it ;)
Enjoy.

Note: It will only work if you have the "gmLevel" method. Those who dont can substitute it for "isGM" or w/e. Have fun

Edit 1: To make it for donors, change this bit.

cm.getPlayer().gmLevel() >= 2 

To

cm.getPlayer().gmLevel() > 1 

And of cource change the message and the types of announcements at the top, the loop is made to hold as many selections as you want, so enjoy...

[MentaL_BOT]

[xkelvin94]

Nice. =D

[Soulfist]

Thanks but its still somewhat useless ._.

I just couldnt think of any ideas, like yesterday.

-refers you to me and chris's JQ release-

[MonsterMS]

It's semi-useful. You could also make it a command. I'm pretty sure it's already out, but you could improve the command.

[XxОsirisxX]

I'm a bit tired. But again, that won't work and it's untested. :thumbsdown:

[Sharky]

I'm a bit tired. But again, that won't work and it's untested. :thumbsdown:

Excuse me sir, where's your proof that this doesn't work? It looks okay to me.

[Masuzu]

Excuse me sir, where's your proof that this doesn't work? It looks okay to me.

That's Osiris.

[NemesisToKill]

Excuse me sir, where's your proof that this doesn't work? It looks okay to me.

He calls a reference to MaplePacketCreator but doesn't import it.

Not sure if this is intended, but this logic does the opposite of what it's supposed to:

if (cm.getPlayer().gmLevel() <= 2) {
cm.sendGetText("Please type your desired announcement:\r\n");
      } else {
cm.sendOk("You aren't a GM, please don't cause trouble"); 

^means players can do it, and anyone whose gm level is greater than 2 can't do it, which contradicts the else statement.

He doesn't use a try-catch block for the WorldInterface method, so the NPC won't work if it throws a RemoteException.

Also, in the description he says that it's for GMs to communicate across channels, but the method he used will make it show to all players as well.

[Sharky]

He calls a reference to MaplePacketCreator but doesn't import it.

Not sure if this is intended, but this logic does the opposite of what it's supposed to:

if (cm.getPlayer().gmLevel() <= 2) {
cm.sendGetText("Please type your desired announcement:\r\n");
      } else {
cm.sendOk("You aren't a GM, please don't cause trouble"); 

^means players can do it, and anyone whose gm level is greater than 2 can't do it, which contradicts the else statement.

He doesn't use a try-catch block for the WorldInterface method, so the NPC won't work if it throws a RemoteException.

Also, in the description he says that it's for GMs to communicate across channels, but the method he used will make it show to all players as well.

Guess I should have looked at this npc a bit longer o-o Thanks for the reasoning.

[XxОsirisxX]

Excuse me sir, where's your proof that this doesn't work? It looks okay to me.

I may be inactive at coding at this moment, but I got an eye to detect error really fast if I go to compare.

The reason I said what I said is just simply because:

    function start() {
var t = "Welcome to"+sname+", I am the GM notice NPC, which type will it be?";
    for(var i = 0; i < Op.length; i++) {
t += "\r\n#L"+i+"#"+Op[i]+"#l";
   cm.sendSimple(t);
}

function action(m, t, s) { 

If you fail to see the huge fail in that syntax then I suggest you to re-read it until you do it because it's really clear.

[Sharky]

I may be inactive at coding at this moment, but I got an eye to detect error really fast if I go to compare.

The reason I said what I said is just simply because:

    function start() {
var t = "Welcome to"+sname+", I am the GM notice NPC, which type will it be?";
    for(var i = 0; i < Op.length; i++) {
t += "\r\n#L"+i+"#"+Op[i]+"#l";
   cm.sendSimple(t);
}

function action(m, t, s) { 

If you fail to see the huge fail in that syntax then I suggest you to re-read it until you do it because it's really clear.

Rofl I immediately caught that error when he first showed me the script, and pointed it out to him. I assumed he had fixed it.

[anitawu]

This is good idea. Let GM players able show message via NPC.

[Kars]

Delete the bracket after the "for(var i = 0; i < Op.length; i++)" thing and it will probably work.

[Soulfist]

I may be inactive at coding at this moment, but I got an eye to detect error really fast if I go to compare.

The reason I said what I said is just simply because:

    function start() {
var t = "Welcome to"+sname+", I am the GM notice NPC, which type will it be?";
    for(var i = 0; i < Op.length; i++) {
t += "\r\n#L"+i+"#"+Op[i]+"#l";
   cm.sendSimple(t);
}

function action(m, t, s) { 

If you fail to see the huge fail in that syntax then I suggest you to re-read it until you do it because it's really clear.

I see teh sytax error.

Fix3d

[itesuwon]

Yeah, It does kinda feels useless. You could just type !notice, but if the commands aren't working, this might be useful :P