[Add-On][v75+] Custom Fishing System

[FateJiki]

Due to a forum bug, the thread was deleted, so here, I just reposted it. Thanks to Shawn for finding my thread.

Made this a few months ago. I just wanted to give to the community a bit, I'm in a release mood.

Remember to give proper credits if you repost this thread anywhere else, no help will be given. Also, remember to 'thank' me if this helped you!


server.Fishing.java

/**
 *
 * @author FateJiki of RaGeZONE
 */
public class Fishing {
    public static void doFishing(client.MapleCharacter chr){
        int mesoMultiplier = 1;
        int expMultiplier = 1;
        switch(chr.getWorld()){
            case 0:
                mesoMultiplier = constants.ServerConstants.MESO_RATE;
                expMultiplier = constants.ServerConstants.EXP_RATE;
                break;
            case 1: // if you have bera
                mesoMultiplier = constants.ServerConstants.WORLD_1_MESORATE;
                expMultiplier = constants.ServerConstants.WORLD_1_EXPRATE;
                break;
            case 2: // if you have broa
                mesoMultiplier = constants.ServerConstants.WORLD_2_MESORATE;
                expMultiplier = constants.ServerConstants.WORLD_2_EXPRATE;
                break;
        }
        int mesoAward = (int)(1400.0 * Math.random() + 1201) * mesoMultiplier + (15 * chr.getLevel() / 5);
        int expAward = (int)(645.0 * Math.random()) * expMultiplier + (15 * chr.getLevel() / 2) / 6;
        if(chr.getLevel() >= 30 && chr.getMapId() == 251000100){
            int rand = (int)(3.0 * Math.random());
            switch(rand){
                case 0:
                    chr.gainMeso(mesoAward, true, true, true);
                    chr.getClient().getSession().write(MaplePacketCreator.catchMonster(9500336, 2000017, (byte)1));
                    chr.getMap().broadcastMessage(chr, MaplePacketCreator.catchMonster(9500336, 2000017, (byte)1), false);
                    break;
                case 1:
                    chr.gainExp(expAward, true, true);
                    chr.getClient().getSession().write(MaplePacketCreator.catchMonster(9500336, 2000017, (byte)1));
                    chr.getMap().broadcastMessage(chr, MaplePacketCreator.catchMonster(9500336, 2000017, (byte)1), false);
                    break;
                case 2:
                    chr.gainItem(getRandomItem(), (short)1, true);
                    chr.getClient().getSession().write(MaplePacketCreator.catchMonster(9500336, 2000017, (byte)1));
                    chr.getMap().broadcastMessage(chr, MaplePacketCreator.catchMonster(9500336, 2000017, (byte)1), false);
                    break;
                case 3: // if you have occupations
                    chr.gainOccEXP((int)((rand + (5.0 * Math.random())) * Math.random()));
                    chr.getClient().getSession().write(MaplePacketCreator.catchMonster(9500336, 2000017, (byte)1));
                    chr.getMap().broadcastMessage(chr, MaplePacketCreator.catchMonster(9500336, 2000017, (byte)1), false);
                    break;
            }
          
        } else {
            chr.dropMessage("You must be above level 30 to fish!");
        }
    }
    public static int getRandomItem(){
        int finalID = 0;
        int rand = (int)(100.0 * Math.random());
        int[] commons = {1002851, 2002020, 2002020, 2000006, 2000018, 2002018, 2002024, 2002027, 2002027, 2000018, 2000018, 2000018 , 2000018, 2002030, 2002018, 2000016}; // filler' up
        int[] uncommons = {1000025, 1002662, 1002812, 1002850, 1002881, 1002880, 1012072, 4020009, 2043220, 2043022, 2040543, 2044420, 2040943, 2043713, 2044220, 2044120, 2040429, 2043220, 2040943}; // filler' uptoo
        int[] rares = {1002859, 1002553, 01002762, 01002763, 01002764, 01002765, 01002766, 01002663, 1002788, 1002949, 2049100, 2340000, 2040822,2040822,2040822,2040822,2040822,2040822,2040822,2040822}; // filler' uplast
        if(rand >= 25){
            return commons[(int)(commons.length * Math.random())];
        } else if(rand <= 7 && rand >= 5){
            return uncommons[(int)(uncommons.length * Math.random())];
        } else if(rand <= 3){
            return rares[(int)(rares.length * Math.random())];
        }

        return finalID;
    }
} 

Replace net.channel.handler.useChairHandler.java with this :

package net.channel.handler;

import client.MapleClient;
import client.MapleInventoryType;
import net.AbstractMaplePacketHandler;
import tools.MaplePacketCreator;
import tools.data.input.SeekableLittleEndianAccessor;
import server.TimerManager;
import java.util.concurrent.ScheduledFuture;

public final class UseChairHandler extends AbstractMaplePacketHandler {
    public final void handlePacket(SeekableLittleEndianAccessor slea, MapleClient c) {
        int itemId = slea.readInt();
        if (c.getPlayer().getInventory(MapleInventoryType.SETUP).findById(itemId) == null) {
            return;
        }
        if(c.getPlayer().getMapId() == 251000100 && itemId == 3011000 && !c.getPlayer().isFishing){
        c.getPlayer().isFishing = true;
        }
        c.getPlayer().setChair(itemId);
        c.getPlayer().getMap().broadcastMessage(c.getPlayer(), MaplePacketCreator.showChair(c.getPlayer().getId(), itemId), false);
        c.getSession().write(MaplePacketCreator.enableActions());
    }
} 

Replace net.channel.handler.cancelChairHandler.java with this :

package net.channel.handler;

import client.MapleClient;
import net.AbstractMaplePacketHandler;
import tools.MaplePacketCreator;
import tools.data.input.SeekableLittleEndianAccessor;

public final class CancelChairHandler extends AbstractMaplePacketHandler {
    public final void handlePacket(SeekableLittleEndianAccessor slea, MapleClient c) {
        int id = slea.readShort();
        if (id == -1) { // Cancel Chair
            c.getPlayer().setChair(0);
            c.getPlayer().isFishing = false;
            c.getSession().write(MaplePacketCreator.cancelChair(-1));
            c.getPlayer().getMap().broadcastMessage(c.getPlayer(), MaplePacketCreator.showChair(c.getPlayer().getId(), 0), false);
        } else { // Use In-Map Chair
            c.getPlayer().setChair(id);
            c.getSession().write(MaplePacketCreator.cancelChair(id));
        }
    }
} 

And finally, go in ChannelServer.java and add this :

            @Override
            public void run(){
                for(MapleCharacter chr : getPlayerStorage().getAllCharacters()){
                    if(chr.isFishing && chr.getMapId() == 251000100){
                        server.Events.Fishing.doFishing(chr);
                    }
                }
            }
            }, 30000); 

under tMan.register , (in the run method.)

[MentaL_BOT]

[.:LastBreath:.]

Re-thanks for this :)

[AuroX]

Eh, umm, could I ask why when i use the catch function, the catch effect won't show?..O.o

[JakeK]

Still Loving this thread lol

[natkemon]

Ooo its finally unbugged.

Just wandering. Do you actually catch fish? Cause i catch mesos only...

I had to make a function in maplecharacter for cm.gainitem and cm.gainOccEXP

so respectively they look like this :

cm.gainitem:

    public void gainItem(int randomItem, short s, boolean b) {
        throw new UnsupportedOperationException("Not yet implemented");
    } 

cm.gainoccexp:

    public void gainOccEXP(int i) {
        throw new UnsupportedOperationException("Not yet implemented");
    } 

What do i replace instead of these 2 functions?

[FateJiki]

Yeah, I forgot to remove that packet-part. No, you won't see the catch animation.

[iAkira]

Ooo its finally unbugged.

Just wandering. Do you actually catch fish? Cause i catch mesos only...

I had to make a function in maplecharacter for cm.gainitem and cm.gainOccEXP

so respectively they look like this :

cm.gainitem:

    public void gainItem(int randomItem, short s, boolean b) {
        throw new UnsupportedOperationException("Not yet implemented");
    } 

cm.gainoccexp:

    public void gainOccEXP(int i) {
        throw new UnsupportedOperationException("Not yet implemented");
    } 

What do i replace instead of these 2 functions?

Remove this from Fishing.java:

                case 3: // if you have occupations
                    chr.gainOccEXP((int)((rand + (5.0 * Math.random())) * Math.random()));
                    chr.getClient().getSession().write(MaplePacketCreator.catchMonster(9500336, 2000017, (byte)1));
                    chr.getMap().broadcastMessage(chr, MaplePacketCreator.catchMonster(9500336, 2000017, (byte)1), false);
                    break; 

Remove this as well in MapleCharacter.java

public void gainOccEXP(int i) {
        throw new UnsupportedOperationException("Not yet implemented");
    } 

those are if you have Occupation system, guessing you don't have it.. also the gainItem not sure yet you should have it in MapleCharacter.java o.o

[JvlShiz(fail)]

I can understand why sources are so buggy and slow now.

[FateJiki]

I can understand why sources are so buggy and slow now.

I'd like you to elaborate yourself a bit more.


What can I do to improve my code?

[iAkira]

wait quick question, wouldn't this make the srv slow by reading that function in channelserver alot and check all character over and over o.O? idk not sure on how the servers works xD

[FateJiki]

wait quick question, wouldn't this make the srv slow by reading that function in channelserver alot and check all character over and over o.O? idk not sure on how the servers works xD

I don't think so.

I haven't really noticed.

[JvlShiz(fail)]

I'd like you to elaborate yourself a bit more.


What can I do to improve my code?

The main bottleneck here is that you're iterating over the WHOLE server. I know that if you had like 10 players that wouldn't be a problem, but try 900 and you'll see what I mean...

To speed it up, create a separate HashMap<Integer, Player> somewhere else. When somebody requests fishing or whatever, insert them into the hash map. Then in your timer method, iterate through this HashMap.

This means that if you have 900 players and only 10 of them chose fishing, the iterator would only have to iterate 10 times instead of 900. This greatly speeds it up by a ratio of 1:90.

This is only part of the performance problems.

- David

[natkemon]

Remove this from Fishing.java:

                case 3: // if you have occupations
                    chr.gainOccEXP((int)((rand + (5.0 * Math.random())) * Math.random()));
                    chr.getClient().getSession().write(MaplePacketCreator.catchMonster(9500336, 2000017, (byte)1));
                    chr.getMap().broadcastMessage(chr, MaplePacketCreator.catchMonster(9500336, 2000017, (byte)1), false);
                    break; 

Remove this as well in MapleCharacter.java

public void gainOccEXP(int i) {
        throw new UnsupportedOperationException("Not yet implemented");
    } 

those are if you have Occupation system, guessing you don't have it.. also the gainItem not sure yet you should have it in MapleCharacter.java o.o

I'm using MapleBlade and it doesn't seem to have the function :S thats why its not picking it up.

[Sparrow]

Lol at above,

Release Multi Worlds :P

[dmnhao]

can u also release the isFishing thingy under maplecharacter.java ?