"static {
gotomaps.put("gmmap", 180000000);
gotomaps.put("southperry", 60000);
gotomaps.put("amherst", 1010000);
...""private static HashMap<String, Integer> gotomaps = new HashMap<String, Integer>();
private static String[] tips = {
"Please only use @gm in emergencies or to report somebody.",
"To report a bug or make a suggestion, use the forum.",
"Please do not use @gm to ask if a GM is online.",
"Do not ask if you can receive help, just state your issue.",
"Do not say 'I have a bug to report', just state it.",
};
..."
Moople is really strange. Its player and admin commands are handled via switch cases but their GM commands are else ifs. Ain't nobody got time to unify the two. Maybe you should take care of that.
As for that @ goto command, I copy and pasted it from some 5-year old RZ thread until I realized how dumb it was that an entire hash map was being initialized every single time, just to be used a single time, then garbage collected, hence it was made to initialize only once.
I forgot what source it was (Astral?), but it had something close to what you have in mind. They handled commands with a map where the key was the string, and the value was an object with a method that executed the command code. Some people prefer each command to have its own class, and others like it all in one file. All comes down to preference I guess.
Thanks haha
:public class Command {
/**
* Actual typed string
*/
private String content;
/**
* onMap map the player is on
*/
private Map m;
/**
* chr player who sent the command
*/
private Character chr;
/**
* Is the command allowed to be executed?
* [USER=850422]return[/USER] true or false depending on wether it's allowed or not
*/
private boolean isAllowed() {
// todo: formulas
throw new NotImplementedException();
}
public Command(String content, Map m, Character chr) {
this.content = content;
this.m = m;
this.chr = chr;
}
public void execute() {
if (isAllowed()) {
// todo: execution part
}
}
/**
* Basically !, @, #, etc.
*/
public enum PrefixType {
PLAYER,
DONOR,
GM,
SUPERGM,
ADMIN
}
}I was thinking something more generic. Like, every command has it's own instance of the class Command. But then again, that's far ahead for the stage I'm currently in like I mentioned before
Well w/e let's get specific then xd. I'm improvising here, and probably overkilling on the documentation, but I'm planning to get some JavaDoc of all classes later on, so why not start right here.
Code:public class Command { /** * Actual typed string */ private String content; /** * onMap map the player is on */ private Map m; /** * chr player who sent the command */ private Character chr; /** * Is the command allowed to be executed? * [USER=850422]return[/USER] true or false depending on wether it's allowed or not */ private boolean isAllowed() { // todo: formulas throw new NotImplementedException(); } public Command(String content, Map m, Character chr) { this.content = content; this.m = m; this.chr = chr; } public void execute() { if (isAllowed()) { // todo: execution part } } /** * Basically !, @, #, etc. */ public enum PrefixType { PLAYER, DONOR, GM, SUPERGM, ADMIN } }
That's exactly what I understood lol [emoji1]. The wz edit removes the bulb kind of as a last resort. I gave it as a second option to the first one mentioned before me. The quest will still work with the wz edit, the bulb will just be gone if I understand the bulb edit correctly.
