Welcome!

Join our community of MMO enthusiasts and game developers! By registering, you'll gain access to discussions on the latest developments in MMO server files and collaborate with like-minded individuals. Join us today and unlock the potential of MMO server development!

Join Today!

Mangos Mangos + YTDB + Scriptdev2 + Changelog

Divine Celestial
Loyal Member
Joined
Nov 30, 2007
Messages
825
Reaction score
20
Mangos 9502 - 9541
Update SpellCastResult enum to 3.3.x state.
Updated behavior of auto shot according to the client changes.
Removed obsolete code for spell 18096 and ranks.
Removed facing limitation for spell 2764.
Add missing AI calls to inform summoner of summon-related events



Implement SPELL_EFFECT_RESTORE_ITEM_CHARGES

Also it application in special case of item 5513 and similar.
Finish impement new functionlity for item 5513 and similar.

* Implement recharge low rank item in inventory.
* Implement recharge item at loading after 15 offline mins
Move custom data from item spell charges sign to new field
`NoConsumable`.

Some items with negative by defaul charges not expected to be deletedt at
no charges.
In past this fixed by using positive charges amount in like cases in
different from
expected negative value. Adding new field for avoid this.



Gameobject casting improvements.

* Add IsHostileTo/IsFriendlyTo and implement expected way checks for diff.
world object types.
For controlled object check redirected to specific owner, for wild
gameobject base at gameobject faction.
If faction not set expected to be hostile to anyone.
* Update grid searchers to be usable with world object instead only unit
case.
Some grid searches lost redundent second object arg,
AnyAoETargetUnitInObjectRangeCheck lost hitHidden arg
(for hitHidden==true case added new
AnyAoEVisibleTargetUnitInObjectRangeCheck)
* Updated grid searchers used with gameobject area casts now.
Note: Gameobject area spell cast animation will still wrong show around
cast triggering target instead
center around gameobject.
* In case gameobject aura apply to target for restored use target itself
as caster because
we not have currently another way apply aura form wild gameobject.
Hotfix for low chance crash at not accessable gameobject cast.
Spell 16952 and ranks will now correctly proc from all cat form
abilities that add combo points
Fix spell 48920
Implement opcode CMSG_HEARTH_AND_RESURRECT
Fix a possible exploit in CMSG_HEARTH_AND_RESURRECT
Fixed talent 50391 and ranks in part apply rune cooldown expire
speed.

* Apply rune cooldown buff only for spell 48265
* Implement SPELL_AURA_MOD_POWER_REGEN_PERCENT work for POWER_RUNE

Thanks to Laise for problem research.
rewrote RA console using ACE

- moved SQL pinging to SqlDelayThread
- use sAccountMgr instead of explict sql queries
Implement account associated execute for RA commands

* Now at login by RA-connection RA-connection use account id/access level
for commands execute. So at login with moderator access by RA-connection
you
can execute only moderator level commands. For administrator level
accounts
allowed execute only console level commands if new config option
RA.Stricted = 0.
For security reasons by default RA.Stricted = 1.
* RA-connection executed commands now logged for associalted account id
* Some own account related commands allowed execute in RA-connection

NOTE: config version updated because RA.Stricted = 1 not compatible with
old
way work and this can break tools thta use RA-access if it not
disabled.
Yuo will need update mangosd.conf.
Remove linking mangosd with sockets library.

Recent RA reimplementation added by Arrai remove using sockets library for
last part mangosd code.
This let not link anymore sockets library with mangosd.

Now realmd is last sockets library user.
Prevent possible memory leak in WorldSession
Let build map extractor at Mac OSX

Also restore build at Windows (Win32 not have unistd.h)

Win32 ad.exe binary updated but not expected any functional differences.
Implement spells 58600 and 58601
Stacking Auras from dual wild weapons.
Use cooldown data from gameobejct trap tamplate if provided.
Implement effect SPELL_EFFECT_TEACH_TAXI_NODE(154)

Original patch writed by Sadikum.
Fix a typo from commit 9512
Fix CRLF in 9512_01_mangos_spell_proc_event.sql.
Avoid apply spell bonuses to glyph 42397 effect.
Make Player::IsValidPos const
Fixed check for SPELL_AURA_ALLOW_ONLY_ABILITY

Also remove public access to SpellAura::m_spellmod for avoid another hacks

with it use. Spellmods only for Player::ApplySpellMod use.
Fixed apply stamina part of 48263
Fix typo in opcode name.
Use selected target for target mode 38/46 when provided.

For cases where provided target is not valid (or not provided), normal
closest in range will be used.
Attack Power bonus for spell 64382.
Some percent target max health spells.

Thanks to timmit for research.
Implement item 46017 effect.
Avoid proc item 46017 effect from DoTs.
Implement proper work spells 59465 and 56151.
Item 23836 effect and spell 54757 not affcted caster spell power.
Implement cooldown reset part for spell 60970 work.
Implement first target of spell 1064 and ranks boost from 61301.



YTDB 292

+ All fixes from forum;
+ spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB;
+ fix respawn ores/viens - Outland/Northrend
+ fix data in "achievement_criteria_requirement"
+ processed 150 caches (3.3.2);
 
Divine Celestial
Loyal Member
Joined
Nov 30, 2007
Messages
825
Reaction score
20
Mangos 9542 - 9577
Make MovementGenerator::GetMovementGeneratorType() const
Really call ACHIEVEMENT_CRITERIA_TYPE_WIN_BG

Also make more wide set achievement type criterias expected requirement in
DB table.

Original patch in achievement call part provided BudIcePenguin.


Implement CONDITION_NOITEM.
Rename ObjectDefines.h -> ObjectGuid.h

Also move unrelated generic defines to Common.h
Less strict check in spell CheckTarget, and allow triggered spell.

Unit may be not selectable, but spell may be expected to target this unit
in any case.
Mostly known problem with npc->npc spells and dummy/triggered spells from
AI side.


Implement ObjectGuid wrapper for guid value

Only one example (mostly) case converted to use it.
Need lot work for finally switch to class obly use, so old low-level
defines still exist also (while used).
But some unused low-level defines dropped.


Lost new ObjectGuid.cpp at prev. commit.
One more typo :/
Hide unsafe templated ByteBuffer::append function only for internal
use.
Add and use PackedGuid wrapper.

Also
* use more wide bytebuff << >> operators for objects
* use at read packet faisl alsways exception way instead some time used
bool results.




Make some compiler happy with forward class declaration.
Make GCC really happy...
Fixed possible runtime crash.
Makes some arguments as references in some ByteBuffer operator
methods.
Allow summoned creatures use MovementType == RANDOM_MOTION_TYPE

Using creature_template.MovementType as default. For normal spawned
creatures, data from creature table will still apply and override
_template.
Radius is 5.0 as default, but may be changed in real-time from ai scripts
using function.
Move the code of glyph 55672 to a better place
Fix a typo from prev. commit:/
Update AiReaction enum.




Fixes possible runtime crash added by 9551
Fixed typos in header guards
Another update of AIReaction enum (and comments).
Use DEFAULT_WORLD_OBJECT_SIZE in ObjectPosSelector if size == 0.

This should fix a freeze in ObjectPosSelector.
If size == 0, m_anglestep became 0 -> freeze.





Remove some trailing whitespace and add comment for last commit.
Add detection code for partly cave area 3780
Restore build
] Add 2 unknown target flags.
Add function to manually start random movement.
Fix spell 60772
Implement glyph 55692
Create and use ObjectGuidGenerator/IdGenerator template classes.

* This is let finally hide guid structure in ObjectGuid.h/.cpp code.
* Shared related code.

NOTE: while switch to use new clasess one more problem has been detected
with not-safe code in .pdump work for future per-map multi-threading.
It's need rewrited before will possible safe use in like case.
For current single world thread case it's safe.
Add script calls for GameObject GossipHello and GossipSelect
Add structure and prevent spam for some LFG opcodes.
Thanks to Spp for help with researching CMSG_LFG_JOIN.




Add config option Network.KickOnBadPacket. If enabled, player will
be kicked on badly formatted (wrong structure) packet.
Use proper template arg instead default value
Use ObjectGuid in Map object stores/world access/search.
Implement SCRIPT_COMMAND_CREATE_ITEM to use when no spell exist
Implement SCRIPT_COMMAND_DESPAWN_SELF (self = creature in this
context)



YTDB 298
+ All fixes from forum;
+ spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB
+ filling "points_of_interest" - Dalaran, Shattrath, Exodar, Silvermoon
+ filling table "gossip_menu_option"
+ fix data "achievement_criteria_requirement"
+ fix data "milling_loot_template"
+ fix spawn "Razorfen Downs"
+ fix spawn "Scarlet Monastery"
+ full respawn loot "Trial of the Crusader"
+ processed 183 caches (3.3.2)
 
Divine Celestial
Loyal Member
Joined
Nov 30, 2007
Messages
825
Reaction score
20
Mangos 9578 - 9599
Use ObjectGuid in visibility sets
Use ObjectGuid in some loot code.

Also use ObjectGuidSet instead std::set<ObjectGuid>
Add ObjectGuid const& Object::GetObjectGuid() and restore build.
Fixed apply damage reduction to melee/ranged damage.
Send looted creature guid in proper field of loot packets.

Also use ObjectGuid in related functions.
Fixed speed recalculation at remove .mod speed rate while
mounted/etc.
Continue fix loot roll packets and related code.

* Propertly send itemSlot field and use it with looted target for roll
selection.
* Remove references to NumberOfPlayers useless data send in args
* Fixed long existed bug with roll show when single player from group can
roll item.
* Fixed possible crash at player leave group while item roll
* Fixed wrong item amount in stack in rolls inreasult use non-initilized
field as info source.
* Remove unused item guid field from Roll and not lost for nothing item
guids for this.

Thanks for help in research to TOM_RUS and j4r0d.
Restore lost `return` in prev. commit.
Remove a useless include
Fixed freeze after recent loot roll code changes.

Thanks to j4r0d for testing.
Really fix freeze :/
Add additional field for storage of speed_run rate of creature

This allow independent rate of walk vs run speed. Existing field renamed
to explicit speed_walk.
Note that default database rate for run is a result of the most common
value seen, 8.0/7.0
fixed mangos.sql
Fixed rest state remove at leave tavern
fix crash with ACHIEVEMENT_CRITERIA_REQUIRE_INSTANCE_SCRIPT

BattleGroundMap has no GetInstanceData() function
Fixed bug in instance binding in case heroic/25-man raids
difficulties

In fact typo in my old commit at adding support MapDifficulty.dbc.
Allow UTF8 strings via SOAP
Fix the amount of mana restored by spell 68082
Use area trigger zone check for inn leave case.

This is still have false cases but will more correct for specific area
triggers.
Also let cleanup code and store less data for Player.
create battleground map at bg creation

when a bg gets created it will also get it's map
(old behaviour was, that map got's created when first player entered the
instance)

the reason why battlegroundmaps aren't instantiated with a player object:
* the only information from player-class we need is
player->GetBattleGround()
also we can't use anything else
(e.g. playerlevel can be outside of bg-levelrange)
-> cause bgs depend pretty much on their maps this caused circualr
dependencies between map,bg,player
* battlegroundmaps will _always_ be prepared by the bgsystem to set
the proper data
* there is not much shared in the creational process with dungeonmaps
even the functioncall is different since players need to enqueue
first for bgs,
therefore again the player's way to that instance is only through
the bgMgr
update battlegrounds per map + cleanup at delete

this will be useful, if we have multithreaded mapupdates one day

since i couldn't reproduce any errors regarding to self deletions of
battlegrounds i removed the m_deleteThis variable
Adding a few research comments for unit_flags and rename one.
 
Divine Celestial
Loyal Member
Joined
Nov 30, 2007
Messages
825
Reaction score
20
Mangos 9600 - 9620
restored work of DeleteAllBattleGrounds
check for UNIT_FLAG_OOC_NOT_ATTACKABLE in
DynamicObjectUpdater::VisitHelper

this will solve the problem that spiritguides could get attacked
(for instance with spell 2121)

thx to DasMy who helped with research
Simplify creating mail draft with content text, cleanup includes.
Implement use of UNIT_FLAG_PASSIVE for creature.

Add function to check creatures own ability to initiate an attack in
MoveInLineOfSight.

Prevent unexpected call to AttackStart when having unit_state
stunned/died
SetSummonPoint for any summoned creature.

Should fix a crash where summoned attempt moveRandom without having a
valid summon point.
Send packed caster GUID for AFLAG_NOT_CASTER.
Fix SMSG_GUILD_INFO time part.
Fix typo that broke guild creation timestamps
Send zoneUnderAttack from EventAI if creature is a guard.
Use more readble format for default `gossip_menu_option` values.
Add index for some tables in characters DB.
Add to SendMonsterMove var args for optional values.

Also drop currently unused Unit::m_InteractionObject
Use stdarg.h instead outdated varargs.h

This must restore build at *nix
Objects HIGHGUID_MO_TRANSPORT not have entry part in guid.
Send AFLAG_NOT_CASTER only if casterguid == targetguid.
Fix ByteBuffer::appendPackGUID appending a superfluous byte.
Add WorldPacket.h to vcproj files.
More use ObjectGuid in spell/etc code
Reset more UNIT_FIELD_FLAGS at login.

Resolve linking problems for script DLLs




YTDB 313
+ All fixes from forum;
+ spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB
+ fix spawn and pool for all viens
+ fix data "creature_equip_template"
+ Icecrown Citadel (Raids) - all modes: N10/N25/H10/H25 - ("alpha") - (No loot from Lich-King in heroics)
+ processed 260 caches (3.3.2)
+ Thanks YTDB forum & UDB forum & CTDB forum & TDB forum, for the WDB caches 3.3.2.
+ All fixes from forum (Look under Accepted Patches Section);
+ Spawns;
+ Quest scripts;
+ Mob's gossip menus;
+ New templates from WDB
+ Correction of the fields in "creature_template" following WDB
+ Correction of spawn in "Maraudon"
+ processed 204 caches (3.3.2)
- Icecrown Citadel (Raid) - Is closed for now (The spawns are fully completed including Lich King) , Loot is 99% completed on all the difficulties, we will polish Icecrown in the next commit (Lich King is under "Repair" there are some questions about him) + read cache topic (And help us out))
 
Divine Celestial
Loyal Member
Joined
Nov 30, 2007
Messages
825
Reaction score
20
Mangos 9621 - 9637
Typo in CastSpell.

Not affect code work except restore small code speedup.
Add keys for gameobject table.
Fixed typo in mangos.conf comment.
varargs list (...) auto promote any float value to double and any
less int type to int.
Add absent empty lines in end of sql updates.
Fix one wrong cast case and simplify similar debug output.
Make mail load async.
Fix typo from [8408].
Replace some PQuery/PExecute by more simple Query/Execute.
Remove character data blob.

Update will create backup in data_backup table, just in case...
You can drop this when you think you don't need it anymore.
(I would recommend you to keep it for a few days/weeks)
Forgot to use git_id
Fix enum names.


Restore load/save known titles.
Some code clean up.
Remove fields 'data' and 'zone' from corpse table.
Restore load/save shown action bars.
Move item real-time/in-game duration counting flag to new
extraflags field.

Client expected only positive duration values, so stop use duration field
as signed.
Include recent field into mangos.sql
 
Divine Celestial
Loyal Member
Joined
Nov 30, 2007
Messages
825
Reaction score
20
Mangos 9638 - 9649
Replace all C assert()s with MaNGOS ASSERT() macro.
Display homebind messages only to affected players
Fix a typo in ReputationMgr
Fix typo; IN_MILISECONDS -> IN_MILLISECONDS.
Add info for know by client epic difficulty
Typo in UNDERWATER_INDARKWATER.
Changes in emotes work.

Waypoint/db script/event ai/'.npc playemote' emote data now auto select by
emote id way to execute:
oneshot or persistent state

So if in referenced DB data wrongly used state emote as oneshot case this
will work in different way now.
Add new emotes in enum that was missing after version update.
Really restore titles from data_backup table.
Fix current pet save in summoned state.

Thanks to hunuza for explcit bug line pointing ;)
Add comment to UNIT_BYTE1_FLAG_UNK_2 for further research
Replace some unnecessary Player::GetCorpse() calls.
 
Divine Celestial
Loyal Member
Joined
Nov 30, 2007
Messages
825
Reaction score
20
YTDB 314
+ all fixes from forum;
+ spawn;
+ quest scripts
+ mob's gossip menues;
+ new templates from WDB;
+ fix spawn: Blackrock Depths
+ fix spawn: Lower Blackrock Spire
+ fix spawn: Upper Blackrock Spire
+ fix spawn: Stratholme
+ mounts models fix;
+ fix quest conditions;
+ fix some vendors;
+ fix loot;
+ mob's stats fix;
+ filling "quest_poi" and "quest_poi_points" (Thanks Blizzy) ;
+ processed 265 caches (3.3.2) - last;
+ processed 28 caches (3.3.3);

Mangos 9650 - 9667
Some corpse related clean ups.

Old bones remove code anyway was dead, so remove it.
Correct code for quest points of interest.

Adjusting field names and type, and send data accordingly to avoid client
crash not using auto-generated id.

Due to the nature of the primary keys, two tables are truncated. Be sure
to make backup if you have data you do now want to loose.

In addition, speed up load times of data from quest_poi_points, thanks
Hunuza for helping out.
Avoid corpse save at arenas also, small cleanups.
Correctly update talent free points in diff cases.

Before at .unlearn or .learn all_mytalents commands free talent points not
updated correctly.
Same for .learn all_mypettalents.
Restore action bar proper content show at spec switch.
Fixed bug with possible double remove spell.

In case when saved in DB spell remove triggering by
dependendences chain self remove attempt.
Implement '.list talents' command.

Command show really know by selected player talent ranks,
including bugged cases like 2 rank same talent known and etc.
Also command claculated count of talents and total used talent
points cost of known talent ranks.

Can be helpful in bug debuging and cheating cases.
Not include in .list talents disabled spells

Also some more cleanups in free talent points update calls.
Remove SPELL_EFFECT_TITAN_GRIP flag at related spell remove.

This let have correct state for flag at .unlearn related spell and etc.
Not only at full talent reset.
Simplify resetTalent code.

Currently all code related to deepndent spells unlern exist in removeSpell

so not need do it in special way in talentReset.
Simplify talents reset for pet case.
Implement dual talent specializations in talent switch part.

* Implement talent specs switch functionality.
* Only gossip part still not implemented.
* At update server to this commit or later character talents will be reset

with some spam in logs about wrong places talents in character_spell.
It can be ignored as part of conversion to new table support.

Thanks to all getmangos.com community members who take part
in creating and updating original dual spec patch.
Use the db-user 'mangos' instead of 'root' in the config file.

Change done for consistence with 'mangos' created in sql/create_mysql.sql

NOTE: for secirity reason better not use this user name (and password)
in real configs/MySQL.
Include entry of gameobject in gobject near command
Fix what author of [9663] messed up, and include the changes in
mangos.sql
Add another exception to IsNoStackSpellDueToSpell.
Check max. honor points on characteacter login.
Implement 57849 and ranks.
 
Divine Celestial
Loyal Member
Joined
Nov 30, 2007
Messages
825
Reaction score
20
Mangos 9668 - 9678
Add .DS_Store to gitignore.
Restore build at some old GCC versions

Old GCC hash_map::erase not return next iterator point
Add dummy effect of spell 55364.
fix resilience applying to periodic leech auras
Add some research for spell attributes.
Updated OpenSSL to version 1.0.0.
Fixed few typos.

Conflicts:

src/game/Unit.cpp
Renamed HMACSHA1 to something that will not conflict with feature
HMACSHA256 and HMACSHA512.

Conflicts:

src/shared/Auth/AuthCrypt.cpp
src/shared/Auth/HMACSHA1.cpp
Small backport from other branch.

Conflicts:

src/game/Player.cpp
src/game/SharedDefines.h
src/game/UpdateFields.h
src/realmd/AuthCodes.h
src/shared/Auth/AuthCrypt.cpp
src/shared/Auth/HMACSHA1.cpp
Updated AuthResult enum.
Added some info about realm list and auth response packets.
Added few dbc structs and updated related enums.
Fixed realm flags enum.
Implemented SMSG_BUY_BANK_SLOT_RESULT opcode.
Fixed console spam.
How this happened?
Added one more git ignore.
Fixed VS2010 build after commits:

8f908

c5aa1
Fix crash in ActivateSpec
Fix SPELL_DAMAGE_CLASS_NONE hit result
Not counting gems at broken item for meta gem requirements.

This is fit as cleint show meta gem state and fix cheating with gems at
broken items.
Implement ITEM_MOD_BLOCK_VALUE support in item stat mods and
enhantments.
Some comments for realmd data.
 
Divine Celestial
Loyal Member
Joined
Nov 30, 2007
Messages
825
Reaction score
20
Code:
Mangos 9679 - 9709
Some more research on spell attributes.
Create new table character_stats for external tools.

Added new config value to define whether it should be updated.

This table will only be updated on logout, not on periodic save.
Add config to decide whether character stats should only be saved 
on logout.
Fixed random base poinst part calculation

0 - unused, 1 -> always +1, other in ranges (rand...1) or (1..rand)
Update IsExplicitDiscoverySpell/IsLootCraftingSpell and related code.
Clarify areatrigger related tables loading errors.
Clarify areatrigger related tables loading errors.

(based on 330 commit 71c1d67)
Implement AURA_252
Drop dead code in 3.x for spell 29801. 
Add helper function to check if a string is numeric

(based on DasBlub's repo commit 1d5b209)
Remove outdated spell proc data and update code for 44394 and ranks.
Code style cleanups in quest code.
Implement support weekly quests cooldowns.

Part code provided by zhenya.
Add to mangos.conf options for daily/weekly reset time.

* Quests.Daily.ResetHour (0..23) for daily quests
* Quests.Weekly.ResetWeekDay (0..6) and Quests.Weekly.ResetHour (0..23) 
for weekly quests.
* Drop time from character_queststatus_daily and use same way as weekly 
quest reset time store.
Fixed typo in daily quest reset time init.
Merge branch 'master' into 330
Fixed typo in daily/weekly flags conflict check.
fix item 47670 spell proc event
Up to date mangos_spell_check old data and add some new.
Merge branch 'master' into 330
Now BG honor marks not reawrded in BG

* And related spells not create items.
* Update code for allow creat marks for single existed case: outfield bg
  that not yet implemented in mangos.
Switch to support client 3.3.3a (build 11723)

Merge branch '330'

You need regenerate dbc/map/vmap files.

Thanks to TOM_RUS who make most work for adding 3.3.3 support. ;)
Update spell 6572 and ranks for 3.3.3
Not crash in case unknown spell expected to be learned at spec 
switch.

It will output error insteed and continue.
Fixed typo in error output string.
Fix 16972 and ranks.

Thanks to vdpqtc and darkstalker.
Include changes from [9692] to characters.sql

mangos.sql part already updated.
Fixed .pdump work after 'data' drop.

Also add `character_talent` including to pdump
Also drop save `item_text` as not used in items/mails now after switch to 
3.3.3
Drop item text ids generation.

Now item text not used as independent object (real item texts associated 
with item guid)
Update comments for two quest flags.
Fix basepoints calculation
Drop now redundent `item_text` table.

* In beggining bad news: at 3.3.3 switch has been forgoted 
item_instance.data field chnage.
  In result items with texts (mail copy in to inventory, some other) lost 
  text content.
* That why in current commit item_text droped without convertion. In 
result all itesm with texts
  will lost text. Sorry for this as i think small porblem :(
* Now text stored in item itself.
Include in pdumps more tables.

* character_account_data and then will partly included macros/settings 
local for character.
       Mostyl used account wide macros not included.
* character_declinedname
* character_equipmentsets
* character_glyphs
* character_pet_declinedname
Add to achievement_reward support gender dependent rewards.

For example for achievement 1793
Fixed typo.

This fixes assert in Player::AddQuest when quest log is full.
Correctly update next daily quest reset timestamp in DB after 
reset.
Fixed typo added by Vladimir to patch in [9704].
Also add check to prevent have NONE gender with some other for same entry
in `achievement_reward` and `locales_achievement_reward`.
Compile fix under GCC.
 change case 0 handle for basepoints calculation


YTDB316
+ All fixes from forum;
+ spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB;
+ fix fields "item_template" by WDB;
+ fix fields "quest_template" by WDB;
+ fix spawn: The Violet Hold;
+ fix spawn: The Obsidian Sanctum;
+ fix spawn: Utgarde Pinnacle;
+ processed 56 caches (3.3.3);
- last for 3.3.2;
 
Divine Celestial
Loyal Member
Joined
Nov 30, 2007
Messages
825
Reaction score
20
Code:
Mangos 9710 - 9748
Add gm possibilities reset talents for all specs.

* At login reset '.reset all talents' will reset all spec talents.
* New command '.reset specs' will reset its online/offline.
* Command '.reset talents' now not support offline player case.
Include in 9692_02_characters_mail.sql convertor for items.

It included in swith time sql update for use in cases not converted yes 
characters DB.
It can be not 100% safe used for already used in 3.3.3 mode chaarcters 
data.
BUT if you want you can use it at own choice ofc.

Fixed durability problem after switch. Converted non-bag items only.
Bags not have normally item text and durability.
Use enum for effect index
Update future release info in NEWS
Replace tab with spaces, just to make at least one push today.
Implement required basic elements for dual spec learn gossips.

Required DB data for real work. This is final part required at core side 
for support.

Also note that commit include

* generic implementation money cost gossip menu items so let
  implement in DB many money cost gossip operations with _fixed_ cost.
* useful CONDITION_SPELL that let implemtn menu item visible if specific
  spell known/don't known also wide used case for diff gossips.
Allow to vendor have same items in list with different extanded 
price.
Fixed [9716] sql update.
Grr... git_id tool corrupt old sql update (it drop sometime all except 
guards)
and i copy old not fixed version for restore :/
Use proper index for character_pet_declinedname in pdump code.
Drop very old item amount calculation hack code.

Use pre-calculated normal effect value as amount.
This also must fix recent item amount crafted items.
Implement Glyph of Siphon Life and fix Siphon Life proc
Updated high guids. Renamed few files. Added some comments.
Please include spell names in comments in code and and avoid its 
used in commit notes.
Finaly cleanup usage ventorslot values.

This is also fix recent showup problem buy items
from vendors in case when some items usable (and then show in list)
only for some class/races.
Temporary back to 0 player highguid.

This is resolve "none from players see each other" problem.
Please, reapply non-0 player guid only with or after this problem resolve.


Some ObjectGuid use cleanups added while reseach porblem source.
removed PlayerNotifier and related Map::UpdatePlayerVisibility 
function, used UpdateObjectVisibility instead

(based on SilverIce's repo commit e226019)
Note: this changes not affect in any good/bad way recent problem with 
player guids.
Restore map outdated format protection and copyright years.

Tom, please update in UpdateFields.h generator 2009->2010 ;)
Build equiped item data only for item's owner

This is must decrease amount of data send to network
at player enter to visibility radius for another player.

(based on SilverIce's repo commit 8c60a80)
Correct icon for one option in default gossip menu
Client not like vendor slot 0 so restore send slots counted from 1

This is must fix not selling first item in list by vendor.
Mail send related fixes in recent code.

* Avoid use explicit MailReciever/MailSender where not need.
  Types specially added for autoconvertion from common cases.

* Prevent allow copy text auction mails. It anyway store encoded data.
  Same for some another non-player mails.
Cleanup in skil steps code.

* Move step arg in SetSkill to end for make possible for it default value.

* Merge GetSkillStep function to SetSkill, base at fact that old 
GetSkillStep
  code can be != 0 only for already known spell, so at update
Remove another case hardcoded set skill step.

We not have currently way set proper set skill step at loading,
but this not required, because important only for new learned rank have 
different step.
Also drop outdated (as tested) comment.
Make Replenishment only affect its caster in arena
Removed outdated code for 33702,336***20572
Fix proc for 53709 and ranks
Added more usable interface for grid visits

(based on SilverIce's repo commit f20f01e)
Fix number of ticks calculation for 53209 (1978 and ranks part)
Restore build on *nix

Also fix my typo in Unit::SelectRandomUnfriendlyTarget
Use local var value instead recalculation.
Update in comment indexes for SpellEntry

No real code changes.
Implement DOT related part of 54049 and ranks
Final cleanup in non proper now EffectBasePoints use.
fix spell_check.sql
Prevent adding .vsp files from VS10 to repo
Update equipment at aura transform apply/remove for creature case
Implement show realm version and build in realm list.

* Rename `realmlist`.`color` field to `realmflags`

* Client 2.x and later support show in realm list supported
  client version for specific realm.

  For client 1.x this implemented by adding version to name
  in similar way as it look in more recent clients.

  For enable version show each affected realm must have in `realmflags` 
  set
  flag 4.

  For realm work with not officially supported builds (build > last 
  suported)
  will show version 0.0.0 and correct build value.
Fixed bg template max/min per team values
Fixed startup problems after recent realmd DB.
 
Divine Celestial
Loyal Member
Joined
Nov 30, 2007
Messages
825
Reaction score
20
Code:
Mangos 9749 - 9756
Partly revert "[9736] Added more usable interface for grid visits"

In part related broadcasts by explicit provided Map pointer (in different 
object GetMap() requested)

This is must fix recent crashes in Map::MessageBroadcast
Add structure of SMSG_REDIRECT_CLIENT (0x50D).

Thanks to TOM_RUS for help with research.
Add index by `spell` to `character_spell`

This is must fix porblem with long logins at
many broken spells in `character_spell` after client switch/etc.
Add storage for min/maxgold of gameobject
Add default value for parent-field in instance_template
Rename flight speed related auras and fix spell 40120
Possibility drop (hide infact) records from DBStore/SQLStorage.
Cleanups in `instance_template` and map entrance DBC data.
Fixed sql update version and related data
Avoid database query on tutorial save by caching tutorial state.



YTDB 317
+ switch 3.3.2 => 3.3.3a (templates/spawn/vendors)
+ all fixes from forum;
+ spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB
+ fix spawn: Utgarde Keep
+ fix spawn: Frozen Halls
+ fix spawn: Nexus
+ fix spawn: Azjol-Nerub
+ fix spawn: Ahn'kahet
+ fix spawn: Culling of Stratholme
+ fix spawn: Halls of Stone
+ fix spawn: Halls of Lightning
+ fix spawn: Hellfire Ramparts
+ processed 78 caches (3.3.3)




added 
realmd 3.3.3
characters 3.3.3
 
Divine Celestial
Loyal Member
Joined
Nov 30, 2007
Messages
825
Reaction score
20
Code:
Mangos 9757 - 9774
Add triggered spell(strength buff) for 71904
Include SharedDefines.h to AchievementMgr.h for provided used enum 
type definition.
Comment cleanups related to spell base points use.
Add missing argument causing crash using .list obj, after change in 
[9663]
Restore .list object output.

No reason have different command output in chat and console
just because need fix crash.
 Init client build at reconnect (logout back to char list)

This fix bug with show all realms as offline at view relam list after 
logout.
Use min/max BG/arena levels from DBC. Update table content.

* Use min/mac level from dbc because anyway list real selectable
  for player level bg/arena backets set min/max range.
* Drop related fields and update per team min/max values.
Remove outdated code for 15286
Prevent crash at use .npc delitem to item with multiply extanded 
costs.
Remove outdated code for 54936
Add the posibility to keep deleted characters in the database for a 
while and also add related commands.

Added commands:
* .character deleted list [$guid|$name]
* .character deleted restore $guid|$name [$newname]
* .character deleted delete $guid|$name
* .character deleted old [$keepdays]

Command .character delete renamed to .character erase
Fixed my last sec. fix problem :/

Also make $/# in consistence in new command help texts.
Fixed typo in characters.sql.
Use more proper std::istringstream for parse args.

This must fix build problem at *nix.
Fixed typos in mangosd.conf comments
Make GCC happy and restore buuild at *unix now really.

Just for note: this still look as not code problem but GCC bug in C++ std. 
library.
Fixed typo in code comment.
Fix periodic damage combat log displaying
 
Divine Celestial
Loyal Member
Joined
Nov 30, 2007
Messages
825
Reaction score
20
Code:
YTDB 319

+ All fixes from forum;
+ spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB
+ fix fields "item_template" by WDB
+ fix fields "gameobject_template" by WDB
+ fix fields "creature_template" by WDB
+ fix fields "quest_template" by WDB
+ fix spawn: The Culling of Stratholme
+ processed 112 caches (3.3.3)


Mangos 9775 - 9792
Cleanups in framework library.

* Removed last bits of threading in grid code.
* Removed some weird and unneeded declarations.
* General code style fixes.
* (Perhaps some things I forgot.)

Thanks to Lynx3d for the usual GCC-stabbing...
Set m_mover to NULL on remove SPELL_AURA_MOD_POSSESS by delete.

This should fix a related crash.
Fixed `instance_template` error output arg in one from cases.
Old gcc hash_map not have support for std::string keys.

In different from tr1 unordered_map
Drop trailing whitespaces.
Change CalcAbsorbResist/isBlocked to be called from target side
One more typo in instance_template loading error output.
Small clean up in 2 method names
Update 33851 and ranks according to 3.1.0 patch notes
Update 33851 and ranks according to 3.1.0 patch notes
Remove special dagger starting outfit amount.

Now DBC data provide special off-hand instead.
Also update structure comments.
Fixed crash at drop vendor items (anorther way).
Allow propertly remove attack speed buff/debuff at death.

Check wrong and redundent (not use in other similar auras).
If we use "debug bg" it must ignore that we are lonely on the bg.
Implement spell selection, for creatures in instances, based on map 
difficulty
No reason lost time at other checks if spell diff id not provided.
Fixed problem with character deleting at some server platforms.
Fix wrong damage dealing from commit [9784]
 
Divine Celestial
Loyal Member
Joined
Nov 30, 2007
Messages
825
Reaction score
20
Code:
Mangos 9793 - 9818
 Add 'Logout Player' output to the Char.log
Implement ".account characters" command

Console/chat command output characters list for specific account.
Fixed sql update for avoid apply problems.
Implement CONDITION_INSTANCE_SCRIPT (mapid, some_id)

True if mapid fit to called instance map id and instance script confirm success 
for some_id case.
Controlled unit should be a source of movement packets, not 
player-controller.

Now movements of controlled unit are visible for nearby players,
even when controller too far from controlled unit

This new type of packet broadcasting used in HandleMovementOpcodes handler only,

maybe it can be used somewhere else.

(based on SilverIce's repo commit d2387ca)
Prevent interect with NPC/Gameobject player in non-react state

* (stun,confuse,fleeing).
* This also fix cheating with taxi use.
Implement basic splitting for caster/target part damage/heal bonus 
calculations, periodic damage/heal over time auras will now store m_amount with 
caster side bonuses applied and calculate target part on each tick. Currently 
critical chance/bonus calculations are not affected by this change
Remove duplicate code causing next reset of daily/weekly quests to double 
up
Not need explicit value numbering for internal server side enum
Typo in enum name.
Fix 17962 damage broken after [9798] commit
Fix typo in taken damage/healing bonus calculations and fix damage of 
64085
Add script effect of spell 52941
Fixed lost flight mount/form for GM in old contentes.
Fixed player loading to transport.

Bug exist already some time but possible hide by another code way work or
client change maybe.
Add some missing (dummy) opcode handlers to the list.
Simplify TaxiPathNodes data use, specially for transport case.
Drop dead code after switch.
Move pre-switch sql updates (except realmd related) to subdir.
Update/fix some opcode names.
Fix a typo.
Add VS2010 project files to git_id
Add filter files to VC100 projects

Its store file groupping info into projects.
Some cleanups in vc100 project files.

* More wide use $() for have same textual values for all build modes
* Fix NoPCH_Debug build.
Add script effect of spell 44462
Add dummy effect of spell 53808
Fix display bug when spell with more than 1 persistent area aura effect 
had several icons

YTDB 320
+ all fixes from forum;
+ spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB;
+ fix all fields "*_template" by WDB
+ fix loot of Archavon the Stone Watcher
+ processed 133 caches (3.3.3a)
 
Divine Celestial
Loyal Member
Joined
Nov 30, 2007
Messages
825
Reaction score
20
Code:
Mangos 9819 - 9842
Rename some more opcodes.

Also fix the name of some older opcodes that were marked as obsolete but no 
longer are.
Fix some handlers (correctly use Handle_ServerSide).
Rename two more opcodes...
Fix link error in gcc after [9816] and include needed header
Really fixed link error in gcc after [9816].
Use in taxi flight movegen original taxipath data.
Rename one more opcode.
Fix spell 38736
Rename two more opcodes (related to projectiles).
Fix TARGET_AREAEFFECT_CUSTOM
Avoid redundent data copy in transport waypoints generation.
Implement taxi/transport event scripts support.
Fix type conversion in spell/healing bonus calculations
Move function to select an attacking target from EventAi to Creature 
class

Also rename function to a more descriptive name, SelectAttackingTarget
Allow TARGET_AREAEFFECT_CUSTOM to target invisible/not targetable npc if 
script target for them exists
 Fix damage bonus applying from 49471 and ranks to 49143 and ranks
Fix broken compilation after [9831]. Thanks to VladimirMangos.
Make log output code more consistent for diff build modes.

* Make possible have debug output if build in release mode.
* But preserver current optimization in avoid debug output args
  calculation if debug ouput disabled if done using DEBUG_LOG
* Implement in same way BASIC_LOG, DETAIL_LOG. Recommended use
  its instead explicit access to sLog
* Use variadic macros for DEBUG_LOG and other new defines.
  All supported VS/GCC have its support as C++ extension.
* Add DEBUG_FILTER_LOG and semilar defines for filered log output and use its.
* Also move recent added debug output for transport events under 
LOG_FILTER_TRANSPORT_MOVES
Remove calls to Taken part when its not used for damage dealing and fix 
HoT tick amount used in 18562 code(Thanks to insider42)
More log filters and macro uses.

* LogFilter_Weather
* LogFilter_PeriodicAffects
* LogFilter_PlayerMoves
* LogFilter_SQLText
* LogFilter_AIAndMovegens
* LogFilter_PlayerStats
Fix shadow damage part of 55090 and ranks
 Include Timer.h for getMSTime in SendMonsterMoveByPath
Really fix invisible target selection for TARGET_AREAEFFECT_CUSTOM
Remove a line of whitespace


YTDB 321

+ all fixes from forum;
+ spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB;
+ loot from Lich-King in Icecrown Citadel - H10/H25 (now all the loot in Icecrown Citadel)
+ processed 151 caches (3.3.3a)
 
Divine Celestial
Loyal Member
Joined
Nov 30, 2007
Messages
825
Reaction score
20
Code:
Mangos 9892 - 9901
Cleanups for BattleGroundEY code
Also prevent send uninitilized mark data in case BATTLEGROUND_EY end.
Simplify related code.
Fixed some spelling typos in function/structure names.
Move GetCastingTimeForBonus and some other code to 
GetSpellCastTimeForBonus.

Important changes:

* Chaged way caluclation "-5% of total per any additional effect" to percent
  apply instead use raw value that correct only for 3500 cast time spells.
* GetSpellCastTimeForBonus result now alwasy not applied to creature casted 
spells
  Before it not applied only to instant spells. Please test if this ok in all 
  cases.
* Leech effect modify spell casting time move into GetCastingTimeForBonus and 
then called
  also for melee spells. But only creature spells exist with melee class damage 
  and its
  not affected by GetCastingTimeForBonus anyway now.
Move DotFactor+GetSpellCastTimeForBonus call to 
CalculateDefaultCoefficient

* This coeff used if not spell_bonus_data provided for spell
* Continue prev. commit line expected that creature casts not affected by 
DotFactor
Cleanup spell bonus coeff use code

* Avoid coeff calculation if target value is 0.0f
* Avoid use spell_bonus_data coeffs for creature damage.
Avoid multiply AP bonus coeff. with spell power bonus.

Problem exist in original code before recent commits.
Implement redundent values check in `spell_bonus_data`

Also do table content cleanup base at added feature.

Original check code provided by nos4r2zod.
Fixed sql update for ptrev. commit.
Fix SPELL_MOD_SPELL_BONUS_DAMAGE applying
Second attempt fix sql update :/
Implement 71342 mount selection

Also added
mangos_scriptname_full
scriptdev2_script_full
 
Divine Celestial
Loyal Member
Joined
Nov 30, 2007
Messages
825
Reaction score
20
Code:
Mangos 9973 - 9999
Fixed selection BG map difficulty.

Thanks to insider42 for help in research problem.
Restore raid functionality broken after one from 3.3.x switches.

* Fixed typo in raid converting code that triggering raid disband at server 
restart.
* Fixed current subgroup show for character and update group memebers data at 
move its
  in diff subgroups.
Use special function for honored/xp kill check
Fixed typo in recently added group enums.
Update talent 16180 and ranks work.
Add explicit AP damage bonus for spells 55095, 55095.

Original patch provided johonson.
Update max cooldown length req. for spell casting at arena.
Remove target guid in spell with TARGET_FLAG_DEST_LOCATION

Corrects spell animations and visual going in weird directions for these kind of 
spells
For non-player at "offline" delete hostile references.

This must fix porblem with call message broadcast from unit destructor.
Group out of range member must based at client existances.
Also move empty mask check from build function to caller.
Leave at AFK applied only to battlegrounds (not arena)
Also restore build...
Implement item 43214 work.

* Original version suggested by timmit.
* Required DB support for target requirement.
Send SMSG_CORPSE_NOT_IN_INSTANCE if player in ghost form tries to enter an 
instance without player's corpse.
Talent 51459 and ranks affect only melee auto-attacks.
Restore work talent 12311 and ranks.

Thanks to insider42 for prepare patch for mangos.
Add correct spell chain data for 61024 and 61316.
Use unix styoe line ends in soem files
Use more correct data for prev. sql update.
Next step in fix SMSG_GROUP_LIST structure.

Now assistant/main tank/main assistant show properly
for viewer character also.

Thanks to insider42 for posting patch in Under review section.
Fixed MSG_PARTY_ASSIGNMENT processing.
Limit spell 50988, 59870 targets amounts to expected.
Fixed a bug/typo that prevent to summon a special flying mount.
Move GridMap class (and related structs/enums) to separate cpp/h.

Also rename some structs/enums and fix some code style.
Remove grid state debugging code and move state machine to MapManager.
Some changes in HashMapHolder.

* Use ACE_RW_Thread_Mutex, since there's much more reading than writing.
* Use read lock in Find(), and write lock in Insert() and Remove().
* Correctly lock the hashmap on outside calls.
Fix *nix build.
Remove a piece of trailing whitespace.

YTDB 324

+ All fixes from forum;
+ fix spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB
+ update fields "*_template" by WDB
+ processed 245 caches (3.3.3a)
 
Back
Top