Command help and Buffstat question.

[Silver Fang]

Hey again. I'm a total noob and dont understand whats wrong with my str/dex/int/luk command.

I think it may because I named it case stat? that it only recongizes the command by @stat only and not @str/dex/etc.
my code is here

You must be registered to see links

.


Also, could I get a general direction where I should change for buffs not fully canceling each other out in Solaxia?
I figured it has something to do in Maplecharacter and in Buffstats? Please forgive me if I'm wrong but I could really use some help right now..

 

[msdev83]

What argument does your switch statement receives?

 

[Silver Fang]

What argument does your switch statement receives?

I dont think they receive anything? correct me if I'm wrong

 

[msdev83]

It's impossible

switch/case satetments work as following

for example

int i = 0;
switch(i) {
case 0: // if i == 0
// do
case 1:
}

etc etc

it must receive some kind of argument if you use case.

 

[Eric]

I dont think they receive anything? correct me if I'm wrong

You can't switch-case nothing. Your argument in the switch is the first command argument (args[0]) from the command string being split. This means your switch will have cases for only the command name. ex: case "help":, case "credits":, etc. If you're doing str/dex/int, you would do case "str": case "dex": etc without breaking each time. You cannot pass case stat: because "stat" is not a string value type, it'd be referenced as nothing. If your source used enumeration types as commands, which Solaxia does not, then it would be valid.

Another thing is this won't work:

if (sub.length != 2) {
    player.message("Please use it as @str/dex/int/luk 10 for example.");
}

Where's your break or return? It just has fallthrough and will continue executing the command regardless of any of your checks. You need to return or break out of the current switch if something is wrong.

 

[Silver Fang]

You can't switch-case nothing. Your argument in the switch is the first command argument (args[0]) from the command string being split. This means your switch will have cases for only the command name. ex: case "help":, case "credits":, etc. If you're doing str/dex/int, you would do case "str": case "dex": etc without breaking each time. You cannot pass case stat: because "stat" is not a string value type, it'd be referenced as nothing. If your source used enumeration types as commands, which Solaxia does not, then it would be valid.

Another thing is this won't work:

if (sub.length != 2) {
    player.message("Please use it as @str/dex/int/luk 10 for example.");
}

Where's your break or return? It just has fallthrough and will continue executing the command regardless of any of your checks. You need to return or break out of the current switch if something is wrong.

Ah, I see, thank you. I'll add the break/return to the command. But do you have any idea of the buffstat problem? Where buffs completely cancels the whole buff instead of just one of the stat. (Ex. Rage/Bless, bless cancels rage cause it has W.DEF)

 

[Eric]

Ah, I see, thank you. I'll add the break/return to the command. But do you have any idea of the buffstat problem? Where buffs completely cancels the whole buff instead of just one of the stat. (Ex. Rage/Bless, bless cancels rage cause it has W.DEF)

Probably just poor implementation of buffs in Odin. The buff shouldn't ENTIRELY cancel, it should only cancel out that specific buffstat that's being overridden. Unless there's only one registered buffstat and it's being replaced, the buff should remain active. Your issue is likely in some buff function either in MapleCharacter, or in MapleStatEffect, both which should be improved.

 

[eshays]

bless cancels rage

IIRC it is supposed to, though as Eric said Solaxia does it wrong so you will have to fix.
I think it's bless first then rage and you will still have an increase of M.DEF, ACC, AVOID and also ATT from rage with W.DEF nullified.

 

[Silver Fang]

IIRC it is supposed to, though as Eric said Solaxia does it wrong so you will have to fix.
I think it's bless first then rage and you will still have an increase of M.DEF, ACC, AVOID and also ATT from rage with W.DEF nullified.

Even if you do that in Solaxia, the buffs get fully canceled instead of W.DEF being nullified.