Numbers of Bug in MetroMS

[Shawn]

and sendspawndata sends YOUR data.... so you yourself let the other player know you can been seen by him/her... thats what this does... thats why you check if you are hidden and if the player that you're sending it to is a GM and should be able to see you....

you add it for yourself too, you wouldn't see yourself if you don't make it send spawnPlayerMapObject, here, take a look :

mplew.writeMapleAsciiString(chr.getName());
mplew.writeShort(job);
addCharLook(mplew, chr, false);
mplew.writeInt(chr.getItemEffect());
mplew.writeInt(chr.getChair());
mplew.writeShort(chr.getPosition().x);
mplew.writeShort(chr.getPosition().y);
mplew.write(chr.getStance());

You just need these to see yourself, there should be something checked when a normal player enters a map with somebody in hide in there, which still needs to see himself, so you can't say just disable spawnPlayerMapObject, I can be wrong though.

    public void sendSpawnData(MapleClient client) {
        if ((this.isHidden() && gmLevel > 0) || !this.isHidden()) {
            client.getSession().write(MaplePacketCreator.spawnPlayerMapobject(this));
            for (int i = 0; i < 3; i++)
                if (pets[i] != null)
                    client.getSession().write(MaplePacketCreator.showPet(this, pets[i], false, false));
        }
    }

My sendspawndata already had a check for it and still does the same.




And are you sure this fixed it.
Anyways, if this doesn't fix it, I would start looking around in addPlayer in maplemap.java

yes you are wrong... sendSpawnData is only used to let others know you're there.... check the source.. the sendSpawnData is already like this.. it's just not working right... just overwrite it and your hide problem will be gone...

this function is used when you warp to the player... the bug is that when you warp with hide on.. the player sees you coming into the map.. thats cuz this function isnt working right...

really see now why ppl think no one here can code... so ill explain it with the check in the original code,

 if ((this.isHidden() && gmLevel > 0) || !this.isHidden()) { 
  

see this?

the code below that (which is the spawn and show pets packets) is executed when the following applies:

YOU are hidden AND YOUR gm level is higher then 0

OR

YOU are NOT hidden....

so if you think about you'll realize this code is ALWAYS executed.... and you always show up to the other player no matter what skill you use.... all clear to you now?

Stop talking to me like i'm a retard, I understand, I just overlooked ||.

Now explain to me, when maplepacketcreator sends a packet to a client, does that not make you invisible for yourself too? or does the client handle it differently.

Btw, just a fyi :

if (!this.isHidden() || client.getPlayer().gmLevel() > 0) {

Doesn't really make sense either. if you do want to use a check for being hidden and not being a gm and then ban a player if you're assured no normal player can get hide... use :

    public void sendSpawnData(MapleClient client) {
        if (!this.isHidden()) {
            client.getSession().write(MaplePacketCreator.spawnPlayerMapobject(this));
            for (int i = 0; i < 3; i++)
                if (pets[i] != null)
                    client.getSession().write(MaplePacketCreator.showPet(this, pets[i], false, false));
        } else if (this.gmLevel == 0) {
            this.ban("Using hide without being gm.", true);
        }
    }

well you're making it difficult to not talk to you like you're a retard....

we're talking about MetroMS/shootsource here... if you know the source you should know it's been made so GM's can see and talk to each other when in hide... so if you make it the way you do... GM's wont see each other and can't talk to each other...

i also changed the source so it's absolutely impossible for a player to get hide... not for long anyway...

Whoops

Oh and no, you just have to get rid of your immense ego.

don't have an ego at all actually... i don't like wasting time on explaining something you should have seen when i first posted the fix....

And even when I tried to prove him wrong, I did it without calling him names or judging his skills.



So? I didn't see it, now what? call me a retard? way to be mature.

i never called you names or judged your skills.... you just saw it that way....

i have nothing against you, let's just find more bugs together and improve the source ok?

on that... checking my server log i remembered another well problem or bug, i get a lot of WriteToClosedSessionException.... anyone know what bug causes those to pop up?

You told me I was a retard and reading my posts makes it hard to not act like you're speaking to a retard.

Fine with me, isn't that just dc's?

Oh btw, another thing that you might want to do is patch out spamming in transformations :
When you are in a pirate/windarcher transformation you can spam nearly all skills that you shouldn't be capable of using in GMS but can use in private servers with rebirths.
Reason being : shootsource is GMS-like and didn't add any checks.

How I fixed it as for now :
In applyAttack, in abstractdealdamagehandler.java, add a check to see if you're in transformation and the skill you're using is normally allowed, if not, return.
This will make it so that it doesn't do any damage.

Problems i'm running against :
NVM anyone knows the values for pirates and windarchers?

Also, this still shows the animation =D

Here are the quotes for you Deagan. I think you need to read them again to see who was the one acting with an ego. He never called you a retard, and still has yet to call you one. He stated it was hard to talk to you as if you weren't one AFTER you said not to talk to you like one.

@OnTopic: It's nice to see people actually helping to improve things, but I thought most of this has already been released in the Release section? When I first read this thread, I expected issues that have never been addressed before o.0

[bagger]

Here are the quotes for you Deagan. I think you need to read them again to see who was the one acting with an ego. He never called you a retard, and still has yet to call you one. He stated it was hard to talk to you as if you weren't one AFTER you said not to talk to you like one.

@OnTopic: It's nice to see people actually helping to improve things, but I thought most of this has already been released in the Release section? When I first read this thread, I expected issues that have never been addressed before o.0

well feel free to address them yourself....

anyone have that fix for poison yet?

[NyCPirate]

Here are the quotes for you Deagan. I think you need to read them again to see who was the one acting with an ego. He never called you a retard, and still has yet to call you one. He stated it was hard to talk to you as if you weren't one AFTER you said not to talk to you like one.

@OnTopic: It's nice to see people actually helping to improve things, but I thought most of this has already been released in the Release section? When I first read this thread, I expected issues that have never been addressed before o.0

People started releasing after this thread was made and they saw a couple of fixes here so they thought they can get they're e-penis bigger by releasing them.

[Mootykinz]

Thanks everyone for these fixes.

I had a fix for the chairs hp regen ...
but I completely forgot.

The GM Hide fix was really useful, as well as the pet.

Could anyone help me with my compiling problem for player commands?

I'm half retarded so I need assistance ..

http://forum.ragezone.com/f566/error...etroms-668739/

That's my thread, if anyone could help.

[Carrino]

People started releasing after this thread was made and they saw a couple of fixes here so they thought they can get they're e-penis bigger by releasing them.

And then they will make a repack based on metro and put some couple of fix here into the repack and claim it as their shit repacks.

[Deagan ツ]

Here are the quotes for you Deagan. I think you need to read them again to see who was the one acting with an ego. He never called you a retard, and still has yet to call you one. He stated it was hard to talk to you as if you weren't one AFTER you said not to talk to you like one.

@OnTopic: It's nice to see people actually helping to improve things, but I thought most of this has already been released in the Release section? When I first read this thread, I expected issues that have never been addressed before o.0

Making someone feel like a retard is equal to directly telling him he is one IMO.

Example :

"really see now why ppl think no one here can code... so ill explain it with the check in the original code,

PHP Code:
if ((this.isHidden() && gmLevel > 0) || !this.isHidden()) {
see this?

the code below that (which is the spawn and show pets packets) is executed when the following applies:

YOU are hidden AND YOUR gm level is higher then 0

OR

YOU are NOT hidden....

so if you think about you'll realize this code is ALWAYS executed.... and you always show up to the other player no matter what skill you use.... all clear to you now?"

+ actually telling me it's hard not to talk to me like a retard make sme obviously feel like one thus me replying like that.

Btw, mind your own business, we were over it already.

On-topic : about the transformation glitch I was talking about before, I will release a fix soon enough.

[Shinija]

Making someone feel like a retard is equal to directly telling him he is one IMO.


Btw, mind your own business, we were over it already.

Not really, Thats just your ego in the way,

Arguing in a OPEN thread where everyone can see it is everyones buisness, the fact that you didnt take it to PM is amusing somewhat ._.

[Deagan ツ]

Not really, Thats just your ego in the way,

Arguing in a OPEN thread where everyone can see it is everyones buisness, the fact that you didnt take it to PM is amusing somewhat ._.

He literally told me speaking to me makes it hard not to reply as if I am a retard speaking to, nothing to do with my ego.

It started off discussing a bug in metroms thus us not taking it private so that people could read it, it just ended with us already stopping with the discussion and shawn pulling it back up.

[Kaynu]

Not really, Thats just your ego in the way,

Arguing in a OPEN thread where everyone can see it is everyones buisness, the fact that you didnt take it to PM is amusing somewhat ._.

Flaw: you can't argue in a closed thread.
Fact: personal messages require more work.

[Shawn]

Making someone feel like a retard is equal to directly telling him he is one IMO.

Example :

"really see now why ppl think no one here can code... so ill explain it with the check in the original code,

PHP Code:
if ((this.isHidden() && gmLevel > 0) || !this.isHidden()) {
see this?

the code below that (which is the spawn and show pets packets) is executed when the following applies:

YOU are hidden AND YOUR gm level is higher then 0

OR

YOU are NOT hidden....

so if you think about you'll realize this code is ALWAYS executed.... and you always show up to the other player no matter what skill you use.... all clear to you now?"

+ actually telling me it's hard not to talk to me like a retard make sme obviously feel like one thus me replying like that.

Btw, mind your own business, we were over it already.

On-topic : about the transformation glitch I was talking about before, I will release a fix soon enough.

It's in an open forum in an open thread, therefore it's everyones' business. Thank you yet again for displaying what I meant by an ego. You are getting all pissy because I showed you that you were in the wrong. Who cares if it was over, it's pretty obvious you didn't learn anything from it. From what I read of his posts, he in no way was talking to you like a retard. He was explaining why you were wrong. I'm sorry if that made you butthurt because you were being taught what you were doing wrong and/or didn't understand properly.

I'm sure you're going to take offense to this. I am not intending to insult you. I'm merely showing you that you do in fact have an ego. Again, he never even remotely mentioned the word retard, or anything insulting until you brought it up. If it made you feel that way, maybe you need to learn to be more objective. Not every statement that counters yours is intended as an insult.

@NYCPirate: No. I am almost 100% positive people have released these fixes before, the Hide and a few others. I can double check, maybe I'm wrong. I swear I've seen them though. As I said before, when I first read this thread, I thought it was bugs that weren't already known. Having been in the help section for a long time now, I've seen numerous threads regarding a few of the bugs mentioned here, where people got helped. Idk... maybe I'm gettin old -_- (shhhh, don't comment to that )

[Deagan ツ]

It's in an open forum in an open thread, therefore it's everyones' business. Thank you yet again for displaying what I meant by an ego. You are getting all pissy because I showed you that you were in the wrong. Who cares if it was over, it's pretty obvious you didn't learn anything from it. From what I read of his posts, he in no way was talking to you like a retard. He was explaining why you were wrong. I'm sorry if that made you butthurt because you were being taught what you were doing wrong and/or didn't understand properly.

I'm sure you're going to take offense to this. I am not intending to insult you. I'm merely showing you that you do in fact have an ego. Again, he never even remotely mentioned the word retard, or anything insulting until you brought it up. If it made you feel that way, maybe you need to learn to be more objective. Not every statement that counters yours is intended as an insult.

@NYCPirate: No. I am almost 100% positive people have released these fixes before, the Hide and a few others. I can double check, maybe I'm wrong. I swear I've seen them though. As I said before, when I first read this thread, I thought it was bugs that weren't already known. Having been in the help section for a long time now, I've seen numerous threads regarding a few of the bugs mentioned here, where people got helped. Idk... maybe I'm gettin old -_- (shhhh, don't comment to that )

Okay so since when is seeing something (which obviously had hate intended) as rude equal to having an ego? The way he spoke made me feel like I was a retard, and that's what I replied about, after which he easily confessed it.

[Xerixe]

You told me I was a retard and reading my posts makes it hard to not act like you're speaking to a retard.

Fine with me, isn't that just dc's?

Oh btw, another thing that you might want to do is patch out spamming in transformations :
When you are in a pirate/windarcher transformation you can spam nearly all skills that you shouldn't be capable of using in GMS but can use in private servers with rebirths.
Reason being : shootsource is GMS-like and didn't add any checks.

How I fixed it as for now :
In applyAttack, in abstractdealdamagehandler.java, add a check to see if you're in transformation and the skill you're using is normally allowed, if not, return.
This will make it so that it doesn't do any damage.

Problems i'm running against :
NVM anyone knows the values for pirates and windarchers?

Also, this still shows the animation =D

Lol Deagan I link you will need to break it down for the noobs.

You guys mean something like this?

if (player.getBuffedValue(MapleBuffStat.MORPH) != null) {
            if ((attack.skill / 100000) != (player.getBuffedValue(MapleBuffStat.MORPH) / 10000)) {
                player.cancelEffectFromBuffStat(MapleBuffStat.MORPH);
                return;
            }
        }

This one will cancel morph and when they use a skill that isn't from the job they got the transformation from.
OH, and I'm not sure if this is how it works on the official server.

[bagger]

it isn't a real fix anyway.... that wont fix the spamming of skills that you CAN use with that job...

[mariokiller64]

The spamming skill fix isn't working.
When I'm a pirate doing a pirate transformation with pirate skills...my transformation stops.

[bagger]

another bug: when you have a top and bottom equipped and you equip an overall... the top is removed but the bottom stays equipped....

fix,

replace the following:

    private static final boolean isOverall(int itemId) {
        return itemId >= 1050000 && itemId < 1060000;
    }