[Release] Simple parameter checking for GM commands (stop GMs from crashing w/cmds)

[shingen]

Tired of GMs crashing the server because they forgot to add a parameter? To prevent this, use this simple check.

I've used this successfully with summon, item, job & level, and I'm sure it can be added to other commands too.

Don't ask me for support, because if you can't figure this out with the steps below, you shouldn't be bothering to make changes yourself. Wait for a repack with this implemented. This is not anti-leech. I'm just anti-stupid.


Repeat steps 1-3 as many times necessary, e.g., if you want level, job, summon & item fixed, repeat 4 times.

STEP 1

In players.cpp, look for:

else if(strcmp(command, "[B][U]xxxx[/U][/B]") == 0){

where xxxx = item, job, level or summon

STEP 2

and underneath it, add:

if(strlen(next_token) == 0){
				PlayersPacket::ShowNotice(player, "Enter valid parameter.", 1);
			}
			else
			{

STEP 3

and at the bottom of each command, right before the next

else if (command, "xxxxx" == 0 )

add

}

to close off the else statement started in step 2.

 

[theonendonly]

Re: [Release] Parameter checking for GM commands

thanks very dandy

 

[xnBlaze]

Re: [Release] Parameter checking for GM commands (stop GMs from crashing w/certain cm

that sucks, there must be one line you just add on top to make it work for all of the commands. -.-

 

[shingen]

Re: [Release] Parameter checking for GM commands (stop GMs from crashing w/certain cm

that sucks, there must be one line you just add on top to make it work for all of the commands. -.-

The way it's written, there is no one liner available as a fix, since most commands don't require parameter input at all.

The other alternative is to re-write chatHandler completely, but that's more of a pain than making these simple changes

 

[xnBlaze]

Re: [Release] Parameter checking for GM commands (stop GMs from crashing w/certain cm

True, I guess its a good script to put on certain ones that crashes.

 

[theonendonly]

Re: [Release] Parameter checking for GM commands (stop GMs from crashing w/certain cm

True, I guess its a good script to put on certain ones that crashes.

which is what i did i only put it on the ones that mainly crash the server

 

[Hobo17]

Re: [Release] Parameter checking for GM commands (stop GMs from crashing w/certain cm

Mines betterrrr. xD

http://forum.ragezone.com/f427/release-fixed-gm-commands-updated-more-391102/index3.html#post3368617

 

[shingen]

Re: [Release] Parameter checking for GM commands (stop GMs from crashing w/certain cm

Mines betterrrr. xD

http://forum.ragezone.com/f427/release-fixed-gm-commands-updated-more-391102/index3.html#post3368617

Had I known about yours, I probably wouldn't of bothered releasing this. This forum needs a better way to show releases.

BTW, the way you told me this was childish. You could have just said, 'I did something similar, take a look here' and I would have gotten the hint.

 

[greennona]

Re: [Release] Parameter checking for GM commands (stop GMs from crashing w/certain cm

I just do
if(strlen(next_token) == 0){

and add a extra { at the end of the command strip

 

[gunnerone]

Re: [Release] Parameter checking for GM commands (stop GMs from crashing w/certain cm

nice quick fix

 

[xCeNt3Rb0yx]

nice quick fix, simple to understand, thx

 

[k4ni]

if(next_token) is enough