[Release] Timer.cpp fix

[chrisli75]

I know some people that get errors coming from Timer.cpp and this may fix it.
In Timer.cpp find

void Timer::remove(int id){
    getTimer(id)->handler->remove(id);
    for(unsigned int i=0; i<timers.size(); i++){
        if(timers[i]->id == id){
            timers.erase(timers.begin()+i);
            break;
        }
    }
}

Add under

void Timer::remove2(int id){
    getTimer(id)->handler->remove(id);
    for(unsigned int i=0; i<timers.size(); i++){
        if(timers[i-1]->id == id){
            timers.erase(timers.begin()+i);
            break;
        }
    }
}

Save and exit.

Open Timer.h

Find

void remove(int id);

Add

void remove2(int id);

Then rebuild.
Should have no errors.

This has been tested and server has been running 5 hours without crashes!

Credits to me!

 

[georgekappa]

Nice.. ty

 

[Sparks]

wow THANK YOU!!! wait. So does this fix as well that whole error 38 thing? when there's to many players on the map and you dc and get that error?

 

[Derek3771]

What does this fix exactly my random server crashes every 4 mins.?

 

[chrisli75]

wow THANK YOU!!! wait. So does this fix as well that whole error 38 thing? when there's to many players on the map and you dc and get that error?

I'm not sure. I have never gotten error 38 before..

@Derek3771
I forgot what types of crash errors but this fixed mostly all my crashes.:juggle:

 

[chrisli75]

Please post comments!

 

[Aznbond]

Hmm.. so you're not sure what this fixes but it fixes something? o.o
I'll try it out and get back to you.

 

[chrisli75]

So does anyone have good comments or bad?
I still waiting

 

[Devin3k]

Nice release as always.
If you can work on the line 242 error :O
The most common error that happens if my server

 

[iFate]

After adding this, my characer fucked up. Click on him, DC. Not even an EoF error 38.

 

[chrisli75]

@iFate did you check you DB if your not in map 99999999 or some invalid map?
It works fine for me and my players.
Server been up for 8 hours now

 

[iFate]

I was chillin' in Maya's house... so it couldn't be the map?

 

[chrisli75]

I'm not sure try map 0 because this does not have to do this map

 

[d347hz]

You just make 2 checks, and how'd this help?

 

[chrisli75]

Well I'm kinda a C++ n00b but somehow this works for me.
With one check my server crashes and crashes at Timer.cpp
With two it does not crash 11 hours without any crashes

 

[d347hz]

Lol, get 50 players+ and say that again.

 

[chrisli75]

Off topic - I have about 15 players online right now(Due to DB wipe...) But later on in the day there will be more coming on

Please don't flame. I was just trying to help

 

[Krytical]

Thasts why your first one should continue; to your other one -_-

 

[Furyking]

So does this works?

 

[gpad]

anyone can confirm if this fix works? I really need a fix for the timer crash.