Scroll to Remove PK from Char

[MGProjects]

RefObjCommon

1	43605	ITEM_MALL_PKREMOVER	???? ???? ??? (???)	xxx	SN_ITEM_MALL_PKREMOVER	SN_ITEM_MALL_PKREMOVER_TT_DESC	1	0	3	3	13	14	180000	3	0	1	1	1	255	0	1	0	0	129	0	0	0	0	0	0	0	-1	0	-1	0	-1	0	-1	0	-1	0	0	0	0	0	0	0	100	0	0	0	xxx	item\etc\drop_mall_scroll.bsr	Premium\etc\pkremover.ddj	xxx	xxx	22005

RefObjItem

22005	1	2	0	0	1	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	1000	????(?)	1	[USU1:SKILL_MALL_PKREMOVER]                                                                                                      	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	-1	xxx	0	0	0

RefSkill

1	34005	1013	SKILL_MALL_PKREMOVER	???? ????	SKILL_MALL_PKREMOVER	0	1	1	0	0	0	0	0	1000	0	0	0	3599	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	1	0	0	0	0	0	0	0	0	0	0	0	0	3	0	0	255	255	0	0	0	0	0	255	255	255	255	item\etc\mall_optlevel_upgrade_scroll_1.ddj	SN_SKILL_MALL_PKREMOVER	xxx	SN_SKILL_MALL_PKREMOVER_TT_DESC	xxx	0	0	3	1667396966	1851946342	1685418593	1500	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0	0

Procedure

_TimedJob

		if(@JobID = '34005') -- Pk Remover
		begin

                        Update _Char Set DailyPK = 0 Where CharID = @CharID
                        Update _Char Set TotalPK = 0 Where CharID = @CharID
                        Update _Char Set PKPenaltyPoint = 0 Where CharID = @CharID
			return -3
		end

 

[lemoniscool]

could you please add the icon you used for this?

 

[RevoLand]

Instead of giving them Fish and making 10+ threads why you can't simply do that?

        if(@JobID = '34005') -- Pk Remover 
        begin 
             --code goes here
            return -3 
        end

 

[Jangan]

erm... can you just reduce the above code to this.

[COLOR=#007700]if(@[/COLOR][COLOR=#0000BB]JobID [/COLOR][COLOR=#007700]= [/COLOR][COLOR=#DD0000]'34005'[/COLOR][COLOR=#007700]) -- [/COLOR][COLOR=#0000BB]Pk Remover 
        begin 

                        Update _Char Set DailyPK [/COLOR][COLOR=#007700]= [/COLOR][COLOR=#0000BB]0 Where CharID [/COLOR][COLOR=#007700]= @[/COLOR][COLOR=#0000BB]CharID 
                        Update _Char Set TotalPK [/COLOR][COLOR=#007700]= [/COLOR][COLOR=#0000BB]0 Where CharID [/COLOR][COLOR=#007700]= @[/COLOR][COLOR=#0000BB]CharID 
                        Update _Char Set PKPenaltyPoint [/COLOR][COLOR=#007700]= [/COLOR][COLOR=#0000BB]0 Where CharID [/COLOR][COLOR=#007700]= @[/COLOR][COLOR=#0000BB]CharID 
            [/COLOR][COLOR=#007700]return -[/COLOR][COLOR=#0000BB]3 
        end 
[/COLOR]

into

[COLOR=#007700]if(@[/COLOR][COLOR=#0000BB]JobID [/COLOR][COLOR=#007700]= [/COLOR][COLOR=#DD0000]'34005'[/COLOR][COLOR=#007700]) -- [/COLOR][COLOR=#0000BB]Pk Remover 
        begin 
[/COLOR][COLOR=#0000BB]            Update _Char Set DailyPK [COLOR=#007700]= [/COLOR]0, TotalPK [COLOR=#007700]= [/COLOR]0, PKPenaltyPoint [/COLOR][COLOR=#007700]= [/COLOR][COLOR=#0000BB]0 Where CharID [/COLOR][COLOR=#007700]= @[/COLOR][COLOR=#0000BB]CharID 
            [/COLOR][COLOR=#007700]return -[/COLOR][COLOR=#0000BB]3 
        end 
[/COLOR]

 

[Wynh]

if(@JobID = '34005') -- Pk Remover
begin

Update _Char Set DailyPK = 0 Where CharID = @CharID
Update _Char Set TotalPK = 0 Where CharID = @CharID
Update _Char Set PKPenaltyPoint = 0 Where CharID = @CharID
return -3
end

when i run query it error

Msg 137, Level 15, State 2, Line 1
Must declare the scalar variable "@JobID".
Msg 137, Level 15, State 2, Line 4
Must declare the scalar variable "@CharID".
Msg 137, Level 15, State 2, Line 5
Must declare the scalar variable "@CharID".
Msg 137, Level 15, State 2, Line 6
Must declare the scalar variable "@CharID".
Msg 178, Level 15, State 1, Line 7
A RETURN statement with a return value cannot be used in this context.

Vsro 1.88

 

[lemoniscool]

the code does the same anyways but i prefer statements like the one you used too Jangan, but i dont like the way this works anyways .. i dont want my players to be disconnected when they use an item .. isnt there any other way to update their status? i tried makeing the items teleport to the recall point but when doing this the buff isnt applied so the sql isnt executed either .. any ideas?

 

[Jangan]

of course there is ... if i had a sever to work with i can make you one.


what you basically do is use the cursor/transaction standards... "the same concept of my name changing method, or how guilds update levels everytime you level". http://forum.ragezone.com/f722/official-feature-perfect-fixed-character-810072/


this is just a theory.. if it does work with updating names and guild level, character level etc... it should work for the rest of the data.

 

[lemoniscool]

well the cursor in sql is used for something that equals a for each loop and the transaction is used to do something only if no errors are thrown or things like that .. it doesnt actually send the packet to the client that updates the status or things like that i think its hardcoded like the client notices the name starts with @, then opens that window and then sends a packet to the server that tells the server to execute the changename sp and after it the server sends a packet to the client with new informations .. like when useing a return scroll for example you have to give the item all itemtype ids = 3 so the server knows what it should do when useing this item

i was thinking about an item that gives the buff AND uses a teleport to town .. but the typeid 3 and 4 need to be 13 and 14 for the buff item and both need to be 3 for a return item .. and i dont know how these typeid's work or what values do what ..

 

[Mixizi]

Wow nice, that make an item use a sql procedure, nice way I love

 

[Royalblade]

Lemoniscool, i personally havent tried it out yet, however why not a trigger on _inventory for refitemid from _items?

Also, there isn't actually a need of disconnecting the chars. Teleportation should work alright shouldnt it?

 

[lemoniscool]

what do you mean Royalblade? didnt understand what youre suggesting but youre right teleporting would be enough thats what i was trying but its not possible to make one item give a buff AND teleport ..

 

[Showtek]

Lemoniscool, i personally havent tried it out yet, however why not a trigger on _inventory for refitemid from _items?

Also, there isn't actually a need of disconnecting the chars. Teleportation should work alright shouldnt it?

Yep, tp works fine

 

[MaDenGo]

Yep, tp works fine

Tell us how you did via teleporting

 

[Caosfox]

use any teleport or any teleport scroll, and teleport to same place or another place

 

[MaDenGo]

i can't because when i press on the scroll i get direct Disconnect

 

[Caosfox]

replace return -3 for
set @NewJobID = @@identity
return @NewJobID

 

[MaDenGo]

replace return -3 for
set @NewJobID = @@identity
return @NewJobID

sorry i didn't get it

if(@JobID = '35046') -- Pk Remover 
        begin 
            Update _Char Set DailyPK = 0, TotalPK = 0, PKPenaltyPoint = 0 Where CharID = @CharID 
            return -3 
        end

Tell me or re-send to me again
Thanks again ^^

 

[Caosfox]

if(@JobID = '35046') -- Pk Remover
begin
Update _Char Set DailyPK = 0, TotalPK = 0, PKPenaltyPoint = 0 Where CharID = @CharID
set @NewJobID = @@identity
return @NewJobID
end

like this

 

[MaDenGo]

Msg 137, Level 15, State 1, Procedure _AddTimedJob, Line 57
Must declare the scalar variable "@NewJobID".
Msg 137, Level 15, State 2, Procedure _AddTimedJob, Line 58
Must declare the scalar variable "@NewJobID".


i got this when i execute

 

[Caosfox]

my bad, leave it this way:

if(@JobID = '35046') -- Pk Remover
begin
Update _Char Set DailyPK = 0, TotalPK = 0, PKPenaltyPoint = 0 Where CharID = @CharID
end