channel problem

[AkincanTR]

How can I fix unauthorized members can not change the channel?


My Code:

using GameServer.Networking;using GameServer.Networking.Packets;
using GameServer.Virtual_Objects.User;
using System;


namespace GameServer.Networking.Handlers
{
	internal class HANDLE_CHANNEL_SWITCH : PacketHandler
	{
		public HANDLE_CHANNEL_SWITCH()
		{
		}


		public override void Handle(virtualUser User)
		{
			bool flag;
			try
			{
				int num = int.Parse(base.getNextBlock());
				flag = (num == 1 || User.Rank > 2 ? false : num != 4);
				if (flag)
				{
					User.Channel = 1;
					User.Page = 0;
					User.send(new PACKET_CHANGE_CHANNEL(User));
					User.send(new PACKET_ROOM_LIST(User, User.Page));
					if (num != -1)
					{
						User.send(new PACKET_CHAT("SYSTEM", PACKET_CHAT.ChatType.Room_ToAll, "SYSTEM >> This Channel is not avaible yet!", (long)999, "NULL"));
					}
				}
				else
				{
					User.Channel = num;
					User.Page = 0;
					User.send(new PACKET_CHANGE_CHANNEL(User));
					User.send(new PACKET_ROOM_LIST(User, User.Page));
				}
			}
			catch
			{
			}
		}
	}
}

 

[DarkRaptor]

Which sources are you using?

 

[AkincanTR]

why do you ask?

 

[DarkRaptor]

Because your question is already answered for some server sources

Anyway, just change the flag value

flag = (num == 1 || User.Rank > 2 ? false : num != 4);

to make it always true by deleting the User.Rank check or just leaving it like this

EDIT: I messed up a bit for rushing:

flag = ( num == 1 ? true : false);

 

[AkincanTR]

not work.

 

[DarkRaptor]

Sigh... Just kill the condition. I don think you want to do that though. The channels are locked for regular users because they arent fully coded.

    try{                                    User.Channel = num;
					User.Page = 0;
					User.send(new PACKET_CHANGE_CHANNEL(User));
					User.send(new PACKET_ROOM_LIST(User, User.Page));}

 

[Taiga]

    try{                                    User.Channel = num;
                    User.Page = 0;
                    User.send(new PACKET_CHANGE_CHANNEL(User));
                    User.send(new PACKET_ROOM_LIST(User, User.Page));}

Why would you put a try & catch on a block that will never trigger an exception?

The fix for this problem:

Solution:

flag = (num > 4 || num < 1);

The reason why:
if the flag is true then the code will send the user to the first channel (CQC with id 1).
if the flag is false then the code will send you the the provided channel id.

with this line it will allow you to go to the other channels but it will not allow you to have 'fake' channel numbers, if it's a fake one then it will just send you to channel 1 (CQC).

This is basic programming logic people...

 

[DarkRaptor]

Thanks for your reply CodeDragon. Indeed, I tend to respect too much the original code and logic, that´s why I left the try{}. Next time I´ll post a better answer.