Eel Bug/Asal Glitch Fixes

[Alexsh]

Eel Bug:
-File:mover.cpp under the restat process [ CMover::ReState() ]

	time_t tmCur = (time_t)( CTime::GetCurrentTime().GetTime() );
	for( int i = 0 ; i < SM_MAX ; ++i )
	{
		if( m_dwSMTime[i] > 0 )
		{
			
		ItemProp* aItemprop = prj.GetItemProp( g_AddSMMode.dwSMItemID[i] );
			if( aItemprop )
			{
				if( i == SM_MAX_HP50 )
				{
					ResetDestParam( aItemprop->dwDestParam[0], m_nPlusMaxHitPoint, 1 );
					((CUser*)this)->AddSMMode( SM_MAX_HP50, 0 );
					m_dwSMTime[i] = 0;
				}
				g_dpDBClient.SendLogSMItemUse( "2", (CUser*)this, NULL, aItemprop );
			}
			else
			{
				WriteLog( "%s, %d\r\n\tNo SMItem dwSMItemID[%d] : %d / Name : %s", __FILE__, __LINE__, i, g_AddSMMode.dwSMItemID[i], m_szName );
			}
			
		}
	}

Asal Glitch:
-File:AttackArbiter.cpp under the PostAsalraalaikum process [ CAttackArbiter:ostAsalraalaikum() ]

	int nMP = m_pAttacker->GetManaPoint();						// ÀÏ´Ü ¹Þ¾Æ³õ°í
	int nPercent = m_pAttacker->GetManaPointPercent();
	if( m_pAttacker->IsPlayer() && m_pAttacker->IsSMMode( SM_MAINTAIN_MP ) == FALSE && nPercent < 100 )		// MP À¯·á¾ÆÀÌÅÛ ¸Ô¾úÀ»¶§´Â MP´â¸é ¾ÈµÈ´Ù.
		m_pAttacker->SetPointParam( DST_MP, 0 );				// 0À¸·Î ¸¸µë.
					if( m_pAttacker->GetHitPoint() >  m_pAttacker->GetMaxHitPoint() )
					 {
						 return ( ( ( m_pAttacker->GetStr() / 10 ) * dwSkillLevel ) * 0 );
					 }
					else if( m_pAttacker->GetManaPoint() >  m_pAttacker->GetMaxManaPoint() )
					{
						return ( ( ( m_pAttacker->GetStr() / 10 ) * dwSkillLevel ) * 0 );
					}
					else
					{
	return ( ( ( m_pAttacker->GetStr() / 10 ) * dwSkillLevel ) * ( 5 + nMP / 10 ) + nAddDmg );
					}

 

[ShadowDragon]

the asal fix is cool, I already have something similar in my source
but about the restat fix... why do you manually check if they have a grilled eel active? there's a function for checking if they have that type of item active. here's how:

IsSMMode(SM_MAX_HP50)

 

[Alexsh]

I've never tried it like that, but you still need to get the item itself in order for

ResetDestParam( aItemprop->dwDestParam[0], m_nPlusMaxHitPoint, 1 );

 

[ShadowDragon]

well, just from looking at the code for a few seconds, couldn't you do this?

ItemProp* aItemprop = prj.GetItemProp( g_AddSMMode.dwSMItemID[SM_MAX_HP50] );

 

[Alexsh]

No idea, lmfao. I'm still new to c++ for the most part.

 

[ShadowDragon]

ah, I see. so am I, but I seem to have a coder's brain lol
I don't know much about C++ specifically, but I excel at understanding the coding logic xD

here, I'll rewrite your coding in a way that makes sense to me:

	time_t tmCur = (time_t)( CTime::GetCurrentTime().GetTime() );
	ItemProp* aItemprop = prj.GetItemProp( g_AddSMMode.dwSMItemID[SM_MAX_HP50] );
	if( aItemprop && IsSMMode(SM_MAX_HP50) )
	{
		ResetDestParam( aItemprop->dwDestParam[0], m_nPlusMaxHitPoint, 1 );
		((CUser*)this)->AddSMMode( SM_MAX_HP50, 0 );
		m_dwSMTime[i] = 0;
		g_dpDBClient.SendLogSMItemUse( "2", (CUser*)this, NULL, aItemprop );
	}
	else
	{
		WriteLog( "%s, %d\r\n\tNo SMItem dwSMItemID[%d] : %d / Name : %s", __FILE__, __LINE__, i, g_AddSMMode.dwSMItemID[i], m_szName );
	}

The reason you can do it is because of this line:

if( i == SM_MAX_HP50 )

if i == SM_MAX_HP50 already, then there's no reason you can't do this:

ItemProp* aItemprop = prj.GetItemProp( g_AddSMMode.dwSMItemID[SM_MAX_HP50] );

I replaced the i with the value you were already checking for anyways

 

[Alexsh]

In that case you also need to change

m_dwSMTime[i] = 0;

And the difference between your edit and mine, is that mine checks for different items as well, not just eels. It checks for any item that uses an SM Mode. With your code it will try to delete an eel every time you restat, even if one's not active. Mine also checks if the timer of any SM Mode item is more than 0.

 

[ShadowDragon]

oh, right. that's because I forgot something xD let me edit it real quick lol

edit: there, it's fixed now

 

[Alexsh]

well, you also forgot

m_dwSMTime[i] = 0;

But yeah both ways work just as efficient.

 

[ShadowDragon]

well, you also forgot

m_dwSMTime[i] = 0;

well I forgot it cause I'm not really sure what that does.. lol mind explaining it?

 

[.dark.]

I believe this belongs in the tutorials section? I might be wrong tho.

You guys look cute fiddling with the source like this, keep on with the good work, this is how you learn it. :3

 

[GlaphanKing]

This should answer a lot of pservers questions. I visit a lot of them, and most have no idea how to fix these glitches.

And yes, perhaps this does belong in the tutorial section.

In the future you should compare the original code to the fix so people can understand why they are copy/pasting stuff blindly.

Thanks just the same.

 

[ShadowDragon]

In the future you should compare the original code to the fix so people can understand why they are copy/pasting stuff blindly.

I always do that ^^ lol

 

[cKenzy]

This is a Tutorial not a release :/:

 

[RckyCls]

What do you mean by Asal Glitch?

 

[Improved]

Moved to the tutorial section.

 

[Alexsh]

By asal glitch, I mean gear swapping. Making them hit much higher.

In the future you should compare the original code to the fix so people can understand why they are copy/pasting stuff blindly.

Thanks just the same.

The only reason I didn't go into detail is so that whomever uses can try and figure it out for themselves. Most likely everyone will just copy/paste it, but meh.

 

[Mootie]

By asal glitch, I mean gear swapping. Making them hit much higher.


The only reason I didn't go into detail is so that whomever uses can try and figure it out for themselves. Most likely everyone will just copy/paste it, but meh.

Anyone can CODE this by looking at the source and figuring it out for themselves, you're just spoonfeeding them.

 

[Alexsh]

Pretty much. :l But for most people they wont bother attempting to fix these types of minor glitches/bugs anyway.