Fix this uploader for me please!

Results 1 to 2 of 2
  1. #1
    Account Upgraded | Title Enabled! Taxic is offline
    MemberRank
    Nov 2011 Join Date
    The NetherlandsLocation
    203Posts

    Fix this uploader for me please!

    PHP Code:
    <link href="../default.css" rel="stylesheet" type="text/css" />
    <div align="center">
    <br />
    <br />
    <hr />
     <SCRIPT language="JavaScript">
    <!--
    //Disable right click script
    var message="";
    ///////////////////////////////////
    function clickIE() {if (document.all) {(message);return false;}}
    function clickNS(e) {if
    (document.layers||(document.getElementById&&!document.all)) {
    if (e.which==2||e.which==3) {(message);return false;}}}
    if (document.layers)
    {document.captureEvents(Event.MOUSEDOWN);document.onmousedown=clickNS;}
    else{document.onmouseup=clickNS;document.oncontextmenu=clickIE;}
    document.oncontextmenu=new Function("return false")
    // -->
                    </SCRIPT>
    <style type="text/css">
    </style>
    </head>
    <body>
    <BODY BGCOLOR="#000000" TEXT="#FFFFFF" LINK="#FFFFFF" VLINK="#FFFFFF">
    <? 
    include ("config.php");
    include (
    "_functions.php");
    $conn = @mssql_connect($DBHost$DBUser$DBPass); 
    @
    mssql_select_db($DB); 



    if (isset(
    $_GET['step'])) {
        
    $argv explode('-',$_GET['step']);
        
    settype($argv,'array'); 
        
    $_GET['step'] = @$argv[0];
        
    $_GET['url'] = @$argv[1];
        
    $_GET['do'] = @$argv[2];
        
    $_GET['mess'] = @$argv[3];
    }
    $step = !isset($_GET['step']) ? home $_GET['step'] ;
            if (
    $step == '1') { echo'

    <FORM METHOD=POST ACTION="?emblem=mod_upload&step=2">
      <p>User ID:
        <input name="user" type="textfield" />    
      <BR>
        Password:
        <input name="pass" type="password" />
      </p>
        <p><br />
        <input type="submit" value="Login" />
      </p>
    </form> '

     } if (
    $step == '2') { 
     
    $user1 clean($_POST['user']);
    $pass1 clean($_POST['pass']);
    {
     
    $query mssql_query_logged("SELECT AID From Login Where UserID = '$user1' AND Password = '$pass1' ");
                while(
    $r mssql_fetch_array($query)){
    if (
    mssql_num_rows($query) == 1){
                            
                            
    $query2 mssql_query_logged("
    SELECT     Login.UserID, Login.Password, ClanMember.Grade, Clan.EmblemUrl, Clan.Name, Clan.CLID
    FROM         ClanMember INNER JOIN
                          Clan ON ClanMember.CLID = Clan.CLID INNER JOIN
                          Login INNER JOIN
                          Character ON Login.AID = Character.AID ON ClanMember.CID = Character.CID Where Login.UserID = '
    $user1' and Login.Password = '$pass1' and ClanMember.Grade = '1' ");
                          if (
    mssql_num_rows($query2) >= '1'){
                          echo 
    '<form enctype="multipart/form-data" action="?emblem=mod_upload&step=done" method="POST">
      <p>Please choose a file 100KB max: 
        <input name="uploaded" type="file" />
      </p>
         <p><input type="submit" value="Upload" /></p>
          Clan Name:<select name="clan">'
    ;
                                for(
    $i='';$i < @mssql_num_rows($query2);++$i){
                                
    $row = @mssql_fetch_row($query2);
                                
    $ClanName $row[4];
                                echo 
    '<option value="'.$row[4].'">';echo $row[4];echo'</option>' ;
                                

                                }echo
    '</select></form>';
                                }}else { echo 
    " ERROR GEEN CLAN ";} }
                                }
                ;
            }  
        
        ; 
        
        if (
    $step == 'done') {                   
        
    $emblem $_POST['uploaded'] ;
        
    $CLID $_POST['clan'];
    $target "Emblem/";
    $target $target basename$_FILES['uploaded']['name']) ;
    $ok=1;
    if (!(
    $_FILES['uploaded']['size']  > '102400'))
    {
    //echo "Your file is too large.<br>";
    $ok=1;
    if((
    $_FILES['uploaded']['type'] == "image/jpeg"))

    $ok=1;
    //echo "Wrong file type.<br>";
    }
    if((
    $_FILES['uploaded']['type'] == "image/GIF"))

    $ok=0;
    //echo "Wrong file type.<br>";
    }
    if((
    $_FILES['uploaded']['type'] == "image/PNG"))

    $ok=1;
    //echo "Wrong file type.<br>";
    }
    }
    else { 
    $ok=0;}

    //


    if ($ok==0)
    {
    echo 
    "Sorry your file was not uploaded<br />";
    echo 
    "Please check the file size or file type";
    }
    else
    {
    if(
    move_uploaded_file($_FILES['uploaded']['tmp_name'], $target))
    {
    echo 
    "The file ".basename$_FILES['uploadedfile']['name']). " has been uploaded<br />";
    mssql_query_logged ("UPDATE Clan SET EmblemChecksum = EmblemChecksum + 1 WHERE Name = '$CLID'");
    mssql_query_logged ("UPDATE Clan SET EmblemUrl = '".$target."' WHERE Name = '$CLID'");
    }
    else
    {
    echo 
    "Sorry, there was a problem uploading your file.";
    }}
    };
    ?>
    </div>
    <hr />
    Rotana's Clan Emblem uploader works perfectlly!

    BUT you can upload .php / .java / .EVERYFILETYPE so the hacker uploaded some .php files and hacked my website and database =S please someone can it fix 100% that you can upload ONLY image types like png, jpg etc..

    sorry for bad english

    /bump

    /bumpppppp


  2. #2
    Hi, I'm Omar! Vusion is offline
    MemberRank
    Jan 2011 Join Date
    HereLocation
    1,658Posts

    Re: Fix this uploader for me please!

    I'll do it in a few.



Advertisement