[Help] How to remove an excellent option (X-Team sources)

[allexander]

Hello,

like the title say i m looking for a way to remove zen exc option:

[IMG][/IMG]

i want to stop this option from being generated in to items or maby replace it.
@Luis_br, @Pyke, @myheart, @LTPTeam, @SmileYzn

Thank you.

[MentaL]

[myheart]

Hello,

like the title say i m looking for a way to remove zen exc option:

[IMG][/IMG]

i want to stop this option from being generated in to items or maby replace it.
@Luis_br, @Pyke, @myheart, @LTPTeam, @SmileYzn

Thank you.

in ItemOptionRate.cpp -CItemOptionRate::MakeNewOption()

ItemIndex >=(6,0) && < (12,0) !!

1 : Increases acquisition rate of Zen after Hunting monster +30%
2 : Defence success rate +10%
4 : Reflect damage +5%
8 : Damage decrease +4%
16 : Increase Max mana +4%
32 : Increase Max HP +4%

1. remove

while (true)
    {
  if (count >= value || count >= MaxNewOption)
  {
   break;
  }

  int value = 1 << (GetLargeRand() % MaxNewOption);

  if (((*option) & value) == 0)
  {
   (*option) |= value;
   count++;
  }
    }

    if (((*option) & 1) != 0)
    {
  (*option) &= ~1;
    }

2. replace with random option

while (true)
    {
  if (count >= value || count >= MaxNewOption)
  {
   break;
  }

  int value = 1 << (GetLargeRand() % MaxNewOption);

  if (((*option) & value) == 0 && value != 1)
  {
   (*option) |= value;
   count++;
  }
    }

3.remove and replace with special option if not exist

while (true)
    {
  if (count >= value || count >= MaxNewOption)
  {
   break;
  }

  int value = 1 << (GetLargeRand() % MaxNewOption);

  if (((*option) & value) == 0)
  {
   (*option) |= value;
   count++;
  }
    }

    if (((*option) & 1) != 0)
    {
  (*option) &= ~1;

  if (((*option) & OPTION INDEX) == 0)
  {
   (*option) |= OPTION INDEX;
  }
    }

4. replace with special option

while (true)
    {
  if (count >= value || count >= MaxNewOption)
  {
   break;
  }

  int value = 1 << (GetLargeRand() % MaxNewOption);

  if (value == 1)
  {
   if (((*option) & OPTION INDEX) == 0)
   {
    (*option) |= OPTION INDEX;
    count++;
   }
   
   continue;
  }

  if (((*option) & value) == 0)
  {
   (*option) |= value;
   count++;
  }
    }

[allexander]

ItemIndex >=(6,0) && < (12,0) !!

ItemIndex >= (6,0) && ItemIndex < (14,0) ring and pendant too

Thank you!

[myheart]

ItemIndex >= (6,0) && ItemIndex < (14,0) ring and pendant tooThank you!

you forgot wings items
(ItemIndex >= (6,0) && < (12,0)) || == (13,8) || == (13,9) || == (13,21) || == (13,22) || == (13,23) || == (13,24) is better

[allexander]

you forgot wings items
(ItemIndex >= (6,0) && ItemIndex < (12,0)) || ItemIndex == (13,8) || ItemIndex == (13,9) || ItemIndex == (13,21) || ItemIndex == (13,22) || ItemIndex == (13,23) || ItemIndex == (13,24) is better

OK tried "Remove" & "Replace with random option" and i still get the option with zen so maby im doing something wrong, here is how i applied the code:

bool CItemOptionRate::MakeNewOption(int ItemIndex,int value,BYTE* option) // OK
{
    (*option) = 0;

    int count = 0;

    int MaxNewOption = MAX_EXC_OPTION;

    if((ItemIndex >= GET_ITEM(12,3) && ItemIndex <= GET_ITEM(12,6)) || ItemIndex == GET_ITEM(12,42) || ItemIndex == GET_ITEM(12,49) || ItemIndex == GET_ITEM(13,30)) // 2sd Wings
    {
        MaxNewOption = ((ItemIndex==GET_ITEM(13,30))?4:3);
    }

    if((ItemIndex >= GET_ITEM(12,36) && ItemIndex <= GET_ITEM(12,40)) || ItemIndex == GET_ITEM(12,43) || ItemIndex == GET_ITEM(12,50)) // 3rd Wings
    {
        MaxNewOption = 4;
    }

    if(ItemIndex >= GET_ITEM(12,262) && ItemIndex <= GET_ITEM(12,265)) // Monster Wings
    {
        MaxNewOption = 2;
    }

    if(ItemIndex == GET_ITEM(12,266)) // Wings of Conqueror
    {
        MaxNewOption = 3;
    }

    if(ItemIndex == GET_ITEM(12,267)) // Wings of Angel and Devil
    {
        MaxNewOption = 3;
    }

    if(gCustomWing.CheckCustomWingByItem(ItemIndex) != 0)
    {
        MaxNewOption = 4;
    }

    if(ItemIndex == GET_ITEM(13,3)) // Dinorant
    {
        MaxNewOption = 3;
    }

    if(ItemIndex == GET_ITEM(13,37)) // Fenrir
    {
        MaxNewOption = 3;
    }

    if(ItemIndex >= (6,0) && ItemIndex < (14,0))
    {
        while (true)
        {
            if (count >= value || count >= MaxNewOption)
            {
                break;
            }

            int value = 1 << (GetLargeRand() % MaxNewOption);

            if (((*option) & value) == 0 && value != 1)
            {
                (*option) |= value;
                count++;
            }
        }
    }

    while(true)
    {
        if(count >= value || count >= MaxNewOption)
        {
            break;
        }

        int value = 1 << (GetLargeRand()%MaxNewOption);

        if(((*option) & value) == 0)
        {
            (*option) |= value;
            count++;
        }
    }
    
    return 1;
}

i made a minor change because i couldn't compile the source without it maybe that is the problem:
Util.cpp

void SetLargeRand() // OK
{
    seed = std::mt19937(std::random_device()());
    dist = std::uniform_int_distribution<int>(0,2147483647);
}

without that extra pair of round brackets i get this error:

Error C2039 'generate': is not a member of 'std::random_device'    

C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\VC\Tools\MSVC\14.22.27905\include\random    1274

About wings they are included in ItemIndex >= (6,0) && ItemIndex < (14,0) but if is safe to add them idividually than i will.

Thank you.

[myheart]

two while loops??

if(ItemIndex >= (6,0) && ItemIndex < (14,0))
{

}

this is bad
---------------------------------------------------------------------------------------------------

void SetLargeRand() // OK
{
seed = std::mt19937(std::random_device()());
dist = std::uniform_int_distribution<int>(0,2147483647);
}

void SetLargeRand()
{
    std::random_device rd;
    seed = std::mt19937(rd());
    dist = std::uniform_int_distribution<int>(0,2147483647);
}

[allexander]

two while loops??



this is bad
---------------------------------------------------------------------------------------------------

void SetLargeRand()
{
    std::random_device rd;
    seed = std::mt19937(rd());
    dist = std::uniform_int_distribution<int>(0,2147483647);
}

ok, removed the second "while" loop and replaced the SetLargeRand but they still drop items +zen

btw using this source.

[myheart]

ok, removed the second "while" loop and replaced the SetLargeRand but they still drop items +zen
btw using this source.

if(ItemIndex >= (6,0) && ItemIndex < (14,0)){
}

i means this is wrong
GET_ITEM(6,0) not (6,0)

[allexander]

i means this is wrong
GET_ITEM(6,0) not (6,0)

Still not working:

bool CItemOptionRate::MakeNewOption(int ItemIndex,int value,BYTE* option) // OK
{
    (*option) = 0;

    int count = 0;

    int MaxNewOption = MAX_EXC_OPTION;

    if(ItemIndex >= GET_ITEM(6,0) && ItemIndex < GET_ITEM(12,0))
    {
        while (true)
        {
            if (count >= value || count >= MaxNewOption)
            {
                break;
            }

            int value = 1 << (GetLargeRand() % MaxNewOption);

            if (((*option) & value) == 0 && value != 1)
            {
                (*option) |= value;
                count++;
            }
        }
    }

    return 1;
}

- - - Updated - - -

I don't think "MakeNewOption" even work... at least not with box drop

[myheart]

Still not working:I don't think "MakeNewOption" even work... at least not with box drop

box drop: ItemBag.cpp - CItemBag::GetItemNewOption