[Release] Legend.mu client & server source code S16 1.1

[dudusiao]

You need 5.7.XX (5.7.29, 5.7.31 or 5.7.33) version

Dont uset lower or higher.

i'm using 8.0.23 (latest) and everything works :D

[metallica]

Its regarding that mysql 8 dont support INSERT DELAYED, it's just ignore by that version

PrepareStatement(MULOG_STATEMENT_ITEM_DROP, "INSERT DELAYED INTO log_item_drop (server, account_id, account, char_id, char_name, player_data, item_data, `comment`) VALUES (?, ?, ?, ?, ?, ?, ?, ?)", CONNECTION_ASYNC);

Maybe it's not a big problem anyway

[ispyder]

Its regarding that mysql 8 dont support INSERT DELAYED, it's just ignore by that version

PrepareStatement(MULOG_STATEMENT_ITEM_DROP, "INSERT DELAYED INTO log_item_drop (server, account_id, account, char_id, char_name, player_data, item_data, `comment`) VALUES (?, ?, ?, ?, ?, ?, ?, ?)", CONNECTION_ASYNC);

Maybe it's not a big problem anyway

https://mysqlserverteam.com/removal-...-in-mysql-5-7/

We removed the support for INSERT DELAYED in 5.7 and onwards. INSERT DELAYED has a lot of limitations and issues attached to it, and with InnoDB as default engine it becomes even less relevant. We decided to keep the INSERT/REPLACE DELAYED syntax, but convert it to INSERT/REPLACE with a warning before execution. (Remove INSERT DELAYED, WL#6073)

So, it seems that STARTING with MySQL 5.7, INSERT DELAYED can be used but internally it will be converted to only INSERT.

So, to keep the real INSERT DELAYED behaviour, MySQL 5.6.xx must be used?

We either rely on the old DELAYED behaviour of MySQL to insert this data, or the C++ code of the GameServer must be updated to insert on different threads (didn't check the code to see how it's actually done since I don't have the code at the moment).

But that delayed is needed (if something similar is not implemented in the C++ code), otherwise calls that block may happen.

[metallica]

https://mysqlserverteam.com/removal-...-in-mysql-5-7/


So, it seems that STARTING with MySQL 5.7, INSERT DELAYED can be used but internally it will be converted to only INSERT.

So, to keep the real INSERT DELAYED behaviour, MySQL 5.6.xx must be used?

We either rely on the old DELAYED behaviour of MySQL to insert this data, or the C++ code of the GameServer must be updated to insert on different threads (didn't check the code to see how it's actually done since I don't have the code at the moment).

But that delayed is needed (if something similar is not implemented in the C++ code), otherwise calls that block may happen.

Good Point, @Mulegend is there a strong reason for "INSERT DELAYED"? or is something that we could change on the source and use only INSERT with MYSQL 8.X?

[Sam3000]

Good Point, @Mulegend is there a strong reason for "INSERT DELAYED"? or is something that we could change on the source and use only INSERT with MYSQL 8.X?

Anyway it's async logs, i think it maybe even udp.

[phgkhh]

I see server, logged in but cant create character, do I need to change anything in database?

https://youtu.be/ypTKOMVO5H0

[metallica]

I see server, logged in but cant create character, do I need to change anything in database?

https://youtu.be/ypTKOMVO5H0

What database are you using? any error on logs?

[phgkhh]

Hi bro @metallica,

I use database from @ispyder in page 18, which updated till post #258
I check log on player, there is no problem as below:

2021-03-24_10:58:25 INFO [ LOGIN REQUEST ] Success [SRV 0 -- 1501 - IP: 192.168.1.200 - MAC: ########## - Account: 3-hellboy - ]
2021-03-24_10:58:35 INFO [ CHARACTER CREATE ] [SRV 0 -- 1501 - IP: 192.168.1.200 - MAC: ########## - Account: 3-hellboy - ] Created character [Angel] class 32

[JesusCry]

Here is DB installation script for Linux databse server - https://github.com/sergey-gr/legend.mu-db

[cinus]

Hi bro @metallica,

I use database from @ispyder in page 18, which updated till post #258
I check log on player, there is no problem as below:

Check well there is in another log for sure

[phgkhh]

Check well there is in another log for sure

You are right, under ServerLink_log/Database, I got this error:

2021-03-25_00:00:03 INFO Connected to MySQL database at 127.0.0.1
2021-03-25_00:00:03 INFO DatabasePool 'database_character' opened successfully. 3 total connections running.
2021-03-25_00:00:49 ERROR SQL(p): INSERT INTO character_info (account_id, race, name, strength, agility, vitality, energy, leadership, life, mana, points, level, world, world_x, world_y, slot) VALUES (1, 32, 'Angel', 22, 25, 20, 15, 0, 80, 30, 0, 1, 3, 130, 130, 2)
[ERROR]: [1364] Field 'authority' doesn't have a default value
2021-03-25_00:00:49 ERROR Unhandled MySQL errno 1364. Unexpected behaviour possible.
2021-03-25_00:00:49 WARN Transaction aborted. 1 queries not executed.

Also, under ConnectServer_log/Database, I have this account error:

2021-03-25_00:00:02 INFO DatabasePool 'database_login' opened successfully. 3 total connections running.
2021-03-25_00:00:42 ERROR SQL(p): INSERT INTO accounts_status (account_id, server_group, current_server, start_server, dest_server, dest_world, dest_x, dest_y, warp_time, warp_auth_1, warp_auth_2, warp_auth_3, warp_auth_4, last_ip, last_mac, last_online, online, disk_serial) VALUES (1, 0, 0, 0, -1, -1, -1, -1, 0, 0, 0, 0, 0, '192.168.1.200', '34:68:95:78:4F:AA', '2021-03-25 00:00:42', 1, 1691623990)
[ERROR]: [1364] Field 'type' doesn't have a default value
2021-03-25_00:00:42 ERROR Unhandled MySQL errno 1364. Unexpected behaviour possible.
2021-03-25_00:00:42 WARN Transaction aborted. 3 queries not executed.

What should I do for it?

[Mulegend]

Good Point, @Mulegend is there a strong reason for "INSERT DELAYED"? or is something that we could change on the source and use only INSERT with MYSQL 8.X?

You can use INSERT INTO, it depends on your computing power, remember that it is a log, it just lowers insert priority

"INSERT DELAYED, it gets an okay from the server at once, and the row is queued to be inserted when the table is not in use by any other threa"

[cinus]

You are right, under ServerLink_log/Database, I got this error:



Also, under ConnectServer_log/Database, I have this account error:


What should I do for it?

You have answers in your log bro :D

[ERROR]: [1364] Field 'authority' doesn't have a default value
and here
[ERROR]: [1364] Field 'type' doesn't have a default value

design table and change on 0 default value

[VadimashRS]

@myheart try hook legend dll to 16 1-3 1.19.55 KOR
https://www.mediafire.com/folder/hjicwh1r4vfhe/1.19.55

[Sam3000]

Updated db https://github.com/samik3k/mu_online_lgnd
Updated all schemas, set not null where it needs
Done skill tables, missing skill_attack_time and some columns in skill_template, like rank and req_guild_status.
But skills are working.

Have 2 sets of tables, with '_orig' postfix for latest commit by mesosa and my currently in use.

Looking for other tables and thinking about starting to set foreign keys.

PS.
2021-03-27_02:59:38 ERROR LoadSkillLearn() item: 6642 +0
2021-03-27_02:59:38 ERROR LoadSkillRequire() skill: 736

In lorencia test NPC shops, skills, socket items and other.

PPS. if you set in character_info.first_time = 1 as default you will get wings and starter equipment.