Gunz VIP WALL

[bulli10]

actully it work perfect ... in my server 1 thing that noone never release has released just click on the thx button noobs ...

[Vusion]

actully it work perfect ... in my server 1 thing that noone never release has released just click on the thx button noobs ...

Restart your client, timer is reset.

>him not knowing that was totally client sided proves he doesn't know what he's doing.

[iDelta123]

Another poor coding.

LOL, oops.
I posted ZPostAdminAnnounce, i meant ZPostVIPAnnounce.
It was my old code..

[qet123]

LOL, oops.
I posted ZPostAdminAnnounce, i meant ZPostVIPAnnounce.
It was my old code..

if it's ZPostVipAnnounce, then show us all the code to decide if it's stable!

[Phoenix]

Stay on topic in order to avoid all the spam. Thanks.

[Joe9099]

Best thing i would do would be to make it work via the database, so when logging in your account is checked via database on when you last did the wall etc...

[Superior]

Great release!

[Rejain]

dosent work.

[gaspartx]

MMatchObject.h - Line 1184

inline bool IsVipGrade(MMatchUserGradeID nGrade) 
{
	if (nGrade == MMUG_VIP1)
		return true;

	return false;
}

MMatchObject.h - Line 1192

inline bool IsVipGrade(MMatchObject* pObject) 
{
	if (pObject == NULL) return false;

	return IsVipGrade(pObject->GetAccountInfo()->m_nUGrade);
}

MMatchServer_Admin.cpp - Function OnAdminAnnounce add this:

if (!IsAdminGrade(pObj) && !IsVipGrade(pObj))
{
DisconnectObject(uidAdmin);
return;
}

For More Security (:

[SecretsOThePast]

This is awful. Take a look at an improper implementation, but it's better than having no server checks at all:

Ideally you would want to save the time to a database, grab the variable from the database and load it into memory. Use a UNIX timestamp that gets loaded from the account information upon login. Since I don't feel like typing all of that here and writing the storedproc, here's a cheap implementation that should get you started with an idea of what should be done:

Bottom of MMatchObject::MMatchObject, MMatchObject.cpp

m_dwLastAnnounceMessageTime = timeGetTime();

MMatchObject.h, in any public space in the class of MMatchObject:

DWORD m_dwLastAnnounceMessageTime;

Modified command handler (MMATCH_VIP_REQUEST_CHAT)

void MMatchServer::OnRequestVIP(const MUID& uidAdmin, const MUID& uidVictim, const char* szMessage)
{
MMatchObject* pVIP= GetObject(uidAdmin);
if(pVIP== NULL) return;

if (!IsVIPGrade(pVIP)) return; // Should return the UGrade of VIP Status. You can include something like || IsAdminGrade(pVip) here but I would do it inside the function for cleanliness.

if(!(timeGetTime() < pVIP->m_dwLastAnnounceMessageTime)) return; //This should be changed to load from the account info as a unix timestamp, not a timeGetTime variable stored in runtime memory. Otherwise, you can relog and spam the server!

MCommand* pCmd = CreateCommand(MC_ADMIN_ANNOUNCE, MUID(0,0));
pCmd->AddParameter(new MCmdParamUID(uidAdmin));
pCmd->AddParameter(new MCmdParamStr(szMessage));
pCmd->AddParameter(new MCmdParamUInt(0));
RouteToAllClient(pCmd);

pVIP->m_dwLastAnnounceMessageTime = timeGetTime() + 3600000; //Probably should load this from some server INI (or better yet, add varying grades that have different times per grade!)


}