Lobby Website Chat

[qet123]

You guys are acting worse then needed..
Add a filter to it..

Sent from my GT-I9070 using Tapatalk 2

We will

[qet123]

TCHAR g_szDB_LOBBY_CHAT[] = _T("{CALL spInsertLobbyChat ('%s', '%s')}");
bool MMatchDBMgr::LobbyChat(const TCHAR* szName, const char* szMsg) 
{
	_STATUS_DB_START;
	if(strstr(szName, ";")) return false;
	if (!CheckOpen()) return false;

	CString strSQL;

	try {
		strSQL.Format( g_szDB_LOBBY_CHAT, szName, szMsg );
		m_DB.ExecuteSQL( strSQL );
	} 
	catch(CDBException* e) {

		ExceptionHandler(strSQL, e);
		return false;
	}
	_STATUS_DB_END(12);
	return true;
}

Imagine what would happen if someone used a spambot on your lobby.

Our full version that it won't print same message more than 2 times.

[Solaire]

TCHAR g_szDB_LOBBY_CHAT[] = _T("{CALL spInsertLobbyChat ('%s', '%s')}");
bool MMatchDBMgr::LobbyChat(const TCHAR* szName, const char* szMsg) 
{
    _STATUS_DB_START;
    if(strstr(szName, ";")) return false;
    if (!CheckOpen()) return false;

    CString strSQL;

    try {
        strSQL.Format( g_szDB_LOBBY_CHAT, szName, szMsg );
        m_DB.ExecuteSQL( strSQL );
    } 
    catch(CDBException* e) {

        ExceptionHandler(strSQL, e);
        return false;
    }
    _STATUS_DB_END(12);
    return true;
}

Our full version that it won't print same message more than 2 times.

Don't need the ";", I could still use the ' and launch a DoS attack by generating SQL errors.

[qet123]

Don't need the ";", I could still use the ' and launch a DoS attack by generating SQL errors.

I knew you gonna answer that, all what I want is to develop gunz and making it active again, but you're making it harder for me and for others, Why you don't just release fixes and help each others ?

[Dave]

Don't need the ";", I could still use the ' and launch a DoS attack by generating SQL errors.

You can still use it, if(strstr(szName, ";")) return false;
szName.

Anyway, you'll learn more of your mistakes if you actually find the solution yourself.

[qet123]

You can still use it, if(strstr(szName, ";")) return false;
szName.

Anyway, you'll learn more of your mistakes if you actually find the solution yourself.

It won't enter the message if it gots ;

[Vusion]

How about you actually fully integrate chat into website allow people to submit messages in lobby chat through the website.

[Solaire]

It won't enter the message if it gots ;

You can still use it, if(strstr(szName, ";")) return false;
szName.

Are you serious?

I knew you gonna answer that

No you didn't, you would of have changed your code if you did.

, all what I want is to develop gunz and making it active again, but you're making it harder for me and for others, Why you don't just release fixes and help each others ?

Because fuck GunZ, that's why. Hence I've contributed more to GunZ than you ever have or ever will, so no point in going that way.

[Vusion]

Don't need the ";", I could still use the ' and launch a DoS attack by generating SQL errors.

I'm probably gonna write an advanced spam filter for the chat since the current one is fucked up as it is. :/

It won't enter the message if it gots ;

He'll enter random queries which /do not/ have ";" that would generate SQL errors.

[Tankado]

ok, guys Qet/i know what we did wrong,
we make mistakes but we leurn from it ,
and it was a good idea :)

- Tankado

[Solaire]

I'm probably gonna write an advanced spam filter for the chat since the current one is fucked up as it is.

Been there with Goat ages ago, simply add a variable to MMatchObject holding the last time a chat was submitted (using timeGetTime() or similar), then check if the delay is at least 500 (1000 is default client). You should simply drop the message though, nothing more, considering people may spike and spam 3 messages at once due to 3 seconds of net inactivity.

[Vusion]

Been there with Goat ages ago, simply add a variable to MMatchObject holding the last time a chat was submitted (using timeGetTime() or similar), then check if the delay is at least 500 (1000 is default client). You should simply drop the message though, nothing more, considering people may spike and spam 3 messages at once due to 3 seconds of net inactivity.

Was talking about something similar with SuperWaffle just before you posted that. I was gonna increment variable x which I'm going to declare and whenever x is divisible by 3, store timeGetTime() and whenever another's message is sent, if the difference between the time stored and the current time is less than 3000, throw a message.

[qet123]

dwCurrentTime = timeGetTime();
if (dwStartTime + 250 < dwCurrentTime)
{	
	dwStartTime = dwCurrentTime;
	SpamLobby(GetCharUID(&MyUID), GetChannelUID(&ChannelUID), "Message");
}

[Vusion]

dwCurrentTime = timeGetTime();
if (dwStartTime + 250 < dwCurrentTime)
{	
	dwStartTime = dwCurrentTime;
	SpamLobby(GetCharUID(&MyUID), GetChannelUID(&ChannelUID), "Message");
}

Great, you can apply the maths. Who can't, lmao. You've already shown you hardly can do anything on your own. Every release you've made or contributed to has to be flawed.

[jur13n]

250?

/10char