[RELEASE] Negative Bounty Fix

Quote:

---

Originally Posted by 3ddy

dordort i thot u from GzN lol....orhhzzz i noe liao u take hacks from here and post in GzN to become a reg+ or a mod noob

---

oi im from GzN DONT KNOCK IT!

Forget about me already? :p

People. Why beside me money ceased to go in minus, but started to go in plus ??? :D

Thank you that who will help !!!

not working for me still goes minus

same wtf?

My bounty still negative....=/ what I should do ? I have to delet the Accounts Table?

Works fine 4 me :D

If you bounty stills negative...You should go to
GunzDB > Tables > sp.Character > And put the bounty of all character to positive and after edit your spBuyBountyItem procedure ;D

Quote:

---

Originally Posted by -Lambda-

Yeah, i release this fix :juggle:

First, edit your spBuyBountyItem procedure

You have this procedure:

Code:

---

CREATE PROCEDURE [dbo].[spBuyBountyItem]
    @nCID INT,
    @nItemID INT,
    @nPrice INT
AS
BEGIN
    SET NOCOUNT ON;
 
    UPDATE Character SET BP = BP-@nPrice
    INSERT INTO Items
    VALUES(@nCID,@nItemID,NULL)
    SELECT 0 OrderCIID
 
END

---

Ok, the bug is in this line:

Code:

---

UPDATE Character SET BP = BP-@nPrice

---

This line, set the ALL characters BP to negative but dont have a WHERE CID = @nCID

This is a fixed procedure

Code:

---

CREATE PROCEDURE [dbo].[spBuyBountyItem]
    @nCID INT,
    @nItemID INT,
    @nPrice INT
AS
BEGIN
    SET NOCOUNT ON;
 
    UPDATE Character SET BP = BP-@nPrice WHERE CID = @nCID
    INSERT INTO Items
    VALUES(@nCID,@nItemID,NULL)
    SELECT 0 OrderCIID
 
END

---

Credits to me

---

wow.. the credits go to u i dindt know that well i have a question..

when i buy a quest item and rejoin server im negative umm how i fix that? is ur thing broken?

nope it works for some and not for others(like me)

This has only recently started to happen on our server recently, I haven't figured out why quest items are giving negative bounty yet.

Milz just make the standard bounty 99999999 and hold that with 1 single line of code then your ppl wil never have - bounty

I could do that, or I could find a proper fix.

Nice!!
thanks!

I noticed it. Quest Items give negative bounty...

Quote:

---

Originally Posted by Linear88

I noticed it. Quest Items give negative bounty...

---

Edit the monsters to drop required quest items then.

It works. I checked my procedure. I thought I added it long ago. It was in the old database... Well I fixed it just now.

This just doesn't work for me.. in the DB, my characters are always getting set to 102828686 some odd maximum bounty, then I buy something, logout, login, my bounty is negative, logout, login, my bounty is maximum again..

Also, should the BP be "money" type? INT seems better...

Edit.. solved.. there were some UPDATE Character lines in my Sell/BuyBountyItem procedures.. also I changed all my BP to BIGINT type now.. there's no reason they should be money type..

Quote:

---

Originally Posted by etiolated

This just doesn't work for me.. in the DB, my characters are always getting set to 102828686 some odd maximum bounty, then I buy something, logout, login, my bounty is negative, logout, login, my bounty is maximum again..

Also, should the BP be "money" type? INT seems better...

Edit.. solved.. there were some UPDATE Character lines in my Sell/BuyBountyItem procedures.. also I changed all my BP to BIGINT type now.. there's no reason they should be money type..

---

Post the new procedure please?

It's the same procedure I suppose, I had different problems than this in the end.. my new problems are with quest items causing negative bounty, but I know why this happens already... and I don't think there's a fix.. and if you notice, quest item purchase doesn't seem to use any stored procedure..

thanx alot

Excelent Post Man... Really Awesome..
Thanks :D