Fixed my plugin class. Turns out I had to duplicate the ChannelBuffer and create another instance for plugin clientmessage handling.
Code:Map<MessageType, ClientMessage> Messages = new HashMap<MessageType, ClientMessage>(); { Messages.put(MessageType.HOTEL_MSG, new ClientMessage(id, msg.duplicate())); Messages.put(MessageType.PLUGIN_MSG, new ClientMessage(id, msg.duplicate())); }
For your future commits and push, could you please commit/push just the modified files ? Merging your commit gave me headaches and was very diffucult.
Thanks ! :)
Yup, but i made some other things i didn't pushed.
Anyway, i merged your work and i get some IndexOutOfBounds exeception when Netty bind client connection, just after called channelOpen @ ConnectionHandler.java. Debug traces shows that an error made by Netty, but maybe by misconfiguration at launch ?!
If you don't get this error, maybe it's because i use a newer version of Netty, i'm gonna try with yours.
Nope, you are using deprecated Netty - the Java NIO Client Server Socket Framework - JBoss Community version which is 3.2.7 Final. But, on this page, we can see that netty was moved and is not part of jboss anymore.
Netty official site is Netty: Home now and provide 3.5.0 final ;)
EDIT: Tryed with your version and got same errors. Do you get that errors or that my jdk who plays tricks on me ?
Just found where the problem came from, it's when emulator convert byte[] to int for header decoding. (It's in sierra.network.decode i guess ...).
Anyway, that's not a real problem, because if the conversion don't work, he just skip the message, but since it's happening only when login, i guess the packets making Exceptions are for SSO Login. Not sure, but i i'll take a look.
I did some updates on Sierra like :
- User (proper) disconnection if already connected
- Catalogue exceptions (quite all of them i guess ?)
- Inventory errors on wall item
- Moving wall items
- Stacking
- Improved Move/Rotate and add Stacking too
- Cleaned DB
- Libs are included and links are relative.
- Room search with Regex pattern
- User wave
- VERY BASIC item activation for default & gates. Anyway - Not going to work on this, looking for a better solution ( like function array ? )
- Some important exceptions making user crash.
- Some warning deletion.
- Lot of various fixes
Check my repo, if you want me to make some pull request of my work for your repo, just ask ;)
Last edited by Shynoshy; 22-06-12 at 03:46 AM.
Well I don't think it will degrade your quality. But I do understand that you would probably want to get things done yourself.
He seems legitimate.
Few Questions:
A. Where da CMS go? SierraHotel branch ain't working for me.
B. What kinds of functions need to be coded before Sierra is ready to march?
Anyways, loving the project, going to use this to help me learn.
Yeah seriously, come on Alex, this guy legit seems like he wants to help you :)