Massive Usage of RAM ?

[Bjork]

Hi there. It's not a help request but more a question.

My emulator based on Plus Emu (x64 build) seems to use a lot of RAM in my opinion. Like on this screenshot, 22 hours of uptime 1GB+ of RAM used for a peak of 15 users maybe. (i had 4GB+ on 3 days of uptime)

My first thought was to test Group Member List (See function in spoiler) with a group with 650+ users in it, the RAM takes 3-4Mb when a change the page. But i'm not really sure, maybe i'm wrong.

Spoiler:

internal List<GroupUser> GetGroupUsersByString(Group Group, String SearchVal, uint Req)
        {
            List<GroupUser> Users = new List<GroupUser>();
            if (string.IsNullOrWhiteSpace(SearchVal))
            {
                if (Req == 0)
                    foreach (GroupUser U in Group.Members.Values)
                        Users.Add(U);
                else
                    foreach (GroupUser U in Group.Admins.Values)
                        Users.Add(U);
            }
            else
            {
                using (IQueryAdapter dbClient = SilverwaveEnvironment.GetDatabaseManager().getQueryreactor())
                {
                    dbClient.setQuery("SELECT id FROM users WHERE username LIKE @query");
                    dbClient.addParameter("query", "%" + SearchVal + "%");
                    DataTable Table = dbClient.getTable();
                    if (Table == null)
                    {
                        if (Req == 0)
                            foreach (GroupUser U in Group.Members.Values)
                                Users.Add(U);
                        else
                            foreach (GroupUser U in Group.Admins.Values)
                                Users.Add(U);
                    }
                    else
                    {
                        foreach (DataRow Row in Table.Rows)
                        {
                            if (Group.Members.ContainsKey((uint)Row[0]))
                                Users.Add(Group.Members[(uint)Row[0]]);
                        }
                    }
                }
            }
            return Users;
        }

If so, someone knows why it takes a lot of RAM ? Or Is it normal ?

PS: I have 800k registered users just for you to know.

@Claudi0 @Sledmore

[MentaL]

[Hoshiko]

Well, that's what happens when teenagers starting their first project decide to work on a Habbo Emulator (.. without having any knowledge of the runtime, language and etc)

[Sledmore]

Hey,

uhm in Plus/Butterfly there is a few pointless/memory wasting methods. I can't remember a lot as I've done quite a bit on my edit, however I remember these:

• There is a dictionary in the RoomManager for each rooms RoomData, as far as I remember it's never removed, only the value from the LoadedRooms dictionary.
• The emulator caches a users Habbo or the other instance for the players data (I've forgotten which) in several parts of the emulator, and that is also never removed (GetHabboById -method(s) I think).
• The offline messages save up in a dictionary on boot up.

(In addition to that items may fetch the item owner and store their data too and never remove it until you restart the emulator.)

And that's just 3 simple mistakes, so you can expect a ton more in the emulator. Have you tried running with more than 15 online?

If it helps; I have about 1,000 daily peaked and are currently on 4 days, 14 hours uptime w/ 2 GB memory being used by the emulator. (I dispose of the cached users when necessary). But I've never really bothered to monitor the memory usage.

Perhaps you should profile the emulator and gather some info, Visual Studios is so good for profiling & debugging. It helped me fix up a ton of issues.

[Bjork]

Hey,

uhm in Plus/Butterfly there is a few pointless/memory wasting methods. I can't remember a lot as I've done quite a bit on my edit, however I remember these:

• There is a dictionary in the RoomManager for each rooms RoomData, as far as I remember it's never removed, only the value from the LoadedRooms dictionary.
• The emulator caches a users Habbo or the other instance for the players data (I've forgotten which) in several parts of the emulator, and that is also never removed (GetHabboById -method(s) I think).
• The offline messages save up in a dictionary on boot up.

(In addition to that items may fetch the item owner and store their data too and never remove it until you restart the emulator.)

And that's just 3 simple mistakes, so you can expect a ton more in the emulator. Have you tried running with more than 15 online?

If it helps; I have about 1,000 daily peaked and are currently on 4 days, 14 hours uptime w/ 2 GB memory being used by the emulator. (I dispose of the cached users when necessary). But I've never really bothered to monitor the memory usage.

Perhaps you should profile the emulator and gather some info, Visual Studios is so good for profiling & debugging. It helped me fix up a ton of issues.

Yes i tried with 100 online users but in a short amount of time so i can't be based on this.

I removed offline messages because for me it's useless so i'll look in the others things you said. i currently ran a profiler (Redgate) so i'll see what i'll find in it.