@
vista4life I've made cookies, you wanna come over?
Back on-topic: I really hope those who still think its a good idea to add backdoors in their servers sees why it is a bad idea. It will at one point sooner or later be discovered. Especially when many people are using the software. I remember some people pointed out the disabled exploit in bfly once it was leaked. The reason why I disabled it was that I did not want to get up 3AM just because some idiot had managed to get hold of one of the executables and managed to decompile it and find the exploit. Just think about how much damage this could have done if this was a popular emulator and the exploit was known at a far later stage.
I can see there are many things that can be greatly improved in the source code after briefly going through it. Empty catch-blocks is one thing, but long files that registers packets that can be eliminated by the use of annotations and class-loaders is another. But there is a lot of code here I don't consider as good, but much of it is ok. That being said, error and exception-handling in general can be greatly improved (What is the point of having logging framework when you're not even using them???).
My first impressions:
+ There are very few blobs
+ Nice oo and well-structured class hierarchies and packages
- Why the exploits
- Having actions that sends messages to certain users (due to whatever) is kinda unprofessional
- Hairy SQL statements
- Poor exception handling, SQL connection usage can be simplified by try-with-resource
- Package registers can be simplified by using annotations