Azure Emulator 1.0 [Dev Release] - [Regularly Updated] - [Stable and Fast]

[FatalLulz]

No more off-topic flaming, insulting, rabbling on about how they renamed the emulator, spam or anything like that. This is a release thread. It is for bug reporting, criticising (constructive criticism related directly to the code) or fixes.

Anyone not following the rules from now on gets an instant infraction.

[Dtox]

Waiting for a update... To much bugs --

[C0R3G4M3R]

We hope to release a new build next week ;)

- Started with 45 issues [bugs] now like 28 to go.

Waiting for a update... To much bugs --

Many people are waiting for the next Update, but as you can see there are some bugs left. It could come out this week (already Sunday so I think next week). I think it would be a good idea if there were updates like every 3rd day in the week or something like that with fixes & so on.

[Anthologique]

Many people are waiting for the next Update, but as you can see there are some bugs left. It could come out this week (already Sunday so I think next week). I think it would be a good idea if there were updates like every 3rd day in the week or something like that with fixes & so on.

No, no, no the emulator is very not ready for this moment.
Please wait, stil exist 41 bugs and the system commands to finish.
Azure is not ready, sorry.

[Jamal7]

94 issues created by our reporters. 41 still need to be done. I promise you guys there will be soon a release. You guys want to see the progress? Visit http://goo.gl/NB2Uv3 look around and report bugs to us so we can fix them! You can report bugs/issues here in this thread ;)

[maritnmine]

Imma do a code review of some central classes since I'm bored and I got some time to kill.
Azure.cs:
- Inconsistent naming conventions (See http://i.imgur.com/BALWugh.png), I suggest you follow the MSDN C# conventions.
- Don't do "using Timer = System.Timers.Timer;"
- Don't have one line per character for AllowedChars
- Bad naming for namespaces: http://i.imgur.com/6OHYXgq.png
- Don't run GC.Collect on console clearing, let the system take care of this unless you have a command like "flush memory" or something like that.
Azure.Initialize():
- Let the database manager build the query string (The current solution is bad OO)
- Use getters with access modifiers for these fields under LibraryParser http://i.imgur.com/VowSUZD.png (Again, bad OO)
- ServerLanguage = (Convert.ToString(GetConfig().Data["system.lang"])); Redundant Convert.ToString
- Timer = new Timer {Interval = ConsoleTimer}; I like initializing methods this way (I really miss it while coding in Java :(
Azure.cs cont.:
- Is this decompiled code? http://i.imgur.com/jUXC2om.png
- GetHabboForName, GetHabboForId1: Bad naming conventions, another example of bad OO, these should be moved to a HabboManager or HabboFactory/whatever.
- Comment does not describe the actual function of this method: http://i.imgur.com/OcPwzdq.png
- PerformShutDown: This function looks like my cereal.
- If you use the SQL API correctly, this function is not needed: http://i.imgur.com/EvQI7CS.png


- You have several classes for console writing: OutPut and Out. (I really don't see why you renamed this class)


Game.cs:
- Bad naming convnetions on fields as with Azure.cs
- Why on earth are you Thread sleeping when starting the emu? (http://i.imgur.com/cEAqnMy.png) Nevertheless, having a proressbar is pointless.
- http://i.imgur.com/6vCQZk8.png Use 0 instead of '0' so the SQL interpreter doesn't have to parse a string to an int, and use != instead of <>. Also, don't execute queries with a variable using String.format. Just use the normal string + operator instead
- This looks broken syntax wise http://i.imgur.com/MQ9OgCM.png (Missing brackets after if-statement)


Conclusion:
- It is obvious by looking at the amount of string.Format and String.Concat that the emulator is from a deobfuscated source.
- Follow regular C# conventions (variables starting with underscore looks ugly), have a look at StyleCop for this.
- Stop doing weird things on SQL level (like <>)
- (See habbo.cs updating activity_balance): Don't use LIMIT 1; on updates when you already have the PK of the table in the WHERE clause, it is redundant.
- Much of the code needs more space in general.


2/10 - would slap coder.
Edit:
I forgot to mention the use of var, but I guess you all know my take on var.

[Aq12]

Let me just say this.. I may not be known on RZ, because basically I browse as a guest.. I have studied many languages and took many IT courses and so when I say my next statement, I want the developers to know what I'm talking about. @maritnmine and The General are both correct. This is a very underdeveloped emulator. Imho, you are better off using butterfly, searching for fixes and implementing it yourself. Not to mention, it already looks like the developers did that, but recoded it to make it look like their own code (which is a waste of time). That's the problem with this community; use the resources that's already given to you.. but don't claim them as your own. I give this emulator 3/10 only because they actually released something. Most emus don't even get released. I don't see this being better than any emulator for that matter, unless your next version is a complete rewrite.

Tip: Features are awesome but mechanics are better. A user can't enjoy that feature if he/she is lagging.

[maritnmine]

You were doing good up until that part, I can see General's puppet strings :o.

For comparison, Uber was -1/10 would kill. I was literary screaming at my pc "WHY WOULD ANYONE DO <something> THIS WAY" like five times or something.

- - - Updated - - -

Let me just say this.. I may not be known on RZ, because basically I browse as a guest.. I have studied many languages and took many IT courses and so when I say my next statement, I want the developers to know what I'm talking about. @maritnmine and The General are both correct. This is a very underdeveloped emulator. Imho, you are better off using butterfly, searching for fixes and implementing it yourself. Not to mention, it already looks like the developers did that, but recoded it to make it look like their own code (which is a waste of time). That's the problem with this community; use the resources that's already given to you.. but don't claim them as your own. I give this emulator 3/10 only because they actually released something.

^this

[Jamal7]

Fixes =>
[+]Wired Highscores.
[+]New Build
[+]LTD
[+]Interaction types
[+]Dices
[+]Mod Tools
[+]Language System
[+]New Commands System
[+]Plugin System
[+]Cleaned Code
[+]Code Documentation
--------------------------------------
Status => 101 issues / 41 left.
--------------------------------------
Next Build =>
[+]Fully Working Moderation tools!
[+]Working Camera!
[+]Room Thumbnails!
[+]More Issues fixed.
[+]New Habbo Release.
[+]More Commands included.
[+]More Plugins included.
[+]And More...

Main thread has been updated!

[C0R3G4M3R]

Is there a .sql that update the datebase for people who have a older version datebase? i cant start my emu now when i run it. i habe add thinks what the emu says there was missing but still i got a error http://prntscr.com/6bh6sh

Same here.. And I found a bad bug -> can't create rooms, could someone upload the Habbo.swf?

[xKADOx]

Awesome update. @djoeyk its very easy to update, you just need to add a column 'hidewall' in rooms_data. read the error before ask for help! :p

[Anibaaal]

Ok, here're some bugs I found. Some of them are arleady reported and others aren't:

-Game gates: You have to start the game once and stop it in order to unlock the gates.

-Stacked gates: Gates over a furni can be opened but can't be closed.

-Pressure plates: Pressure plates are not changing the furni state. For example, both Wired Pressure plate and the Habbowood tile should light up when standing on them.

-Room promotion: is buyable but not working as intended. Event doesn't show up in the navigator.

-Avatar effects: The client crashes when you buy an Avatar effect in the catalogue and you have to either create a new account or clear your avatar effects from database.

-White wallpapers and floors: Some spaces are missing and show as white wallpapers or white floor. I don't know if it's a SWF problem.

-Groups:
---Group gates are not working correctly, they only open for the group owner. If you stand in the tile the gate is in, in doesn't close after you walk away.
---Group furni doesn't show group colors.

-Furnis with variable height: This furnis don't work correctly when stacked.-Red and Blue Spades Card Tile: There's no interaction for this furnis, it's supposed to act like Banzai Random teleport. If you set the interaction type the same as Banzai tele, they will interact to each other. For example, if you stand on a Halloween tele you can get telepored to a banzai tele.

-Clothing gates: not working.

-Move-Rotate wired: this wired is teleporting furni instead of moving it.
---Example:
------Current wired does this █░░░░░█
------Habbo wired does this (fluid movement) █ █ █ █ █

-Monsterplants: not working.

Good luck!

[KyleeIsProzZ]

Is there a .sql that update the datebase for people who have a older version datebase? i cant start my emu now when i run it. i habe add thinks what the emu says there was missing but still i got a error http://prntscr.com/6bh6sh

Run these in your database:

ALTER TABLE `server_fuses` ADD COLUMN `alias`  varchar(255) NOT NULL;

And:

ALTER TABLE `rooms_data` CHANGE `allow_hidewall` `hidewall` ENUM('0','1') CHARACTER SET latin1 COLLATE latin1_swedish_ci NOT NULL DEFAULT '0';

If anyone else has any of djoeyk errors, run these above in your,
Database..

------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Ok, here're some bugs I found. Some of them are arleady reported and others aren't:

-Game gates: You have to start the game once and stop it in order to unlock the gates.

-Stacked gates: Gates over a furni can be opened but can't be closed.

-Pressure plates: Pressure plates are not changing the furni state. For example, both Wired Pressure plate and the Habbowood tile should light up when standing on them.

-Room promotion: is buyable but not workin as intended. Event doesn't show up in the navigator.

-Avatar effects: The client crashes when you buy an Avatar effect in the catalogue and you have to either create a new account or clear your avatar effects from database.

-White wallpapers and floors: Some spaces are missing and show as white wallpapers or white floor. I don't know if it's a SWF problem.

-Groups:
---Group gates are not working correctly, they only open for the group owner. If you stand in the tile the gate is in, in doesn't close after you walk away.
---Group furni doesn't show group colors.

-Furnis with variable height: This furnis don't work correctly when stacked.-Red and Blue Spades Card Tile: There's no interaction for this furnis, it's supposed to act like Banzai Random teleport. If you set the interaction type the same as Banzai tele, they will interact to each other. For example, if you stand on a Halloween tele you can get telepored to a banzai tele.

-Clothing gates: not working.

-Move-Rotate wired: this wired is teleporting furni instead of moving it.
---Example:
------Current wired does this █░░░░░█
------Habbo wired does this (fluid movement) █ █ █ █ █

-Monsterplants: not working.

Good luck!

Some of these are Already on our Issues list,
thanks for reporting the rest, we will add the ones that are not on the list :)

[Jamal7]

Habbo.swf : https://www.mediafire.com/?co5qz23vwppha0u

[C0R3G4M3R]

Run these in your database:

ALTER TABLE `server_fuses` ADD COLUMN `alias`  varchar(255) NOT NULL;

And:

ALTER TABLE `rooms_data` CHANGE `allow_hidewall` `hidewall` ENUM('0','1') CHARACTER SET latin1 COLLATE latin1_swedish_ci NOT NULL DEFAULT '0';

If anyone else has any of djoeyk errors, run these above in your,
Database..

Thank you! Works fine now *-*

Bugs:
- if you sit with the :sit command and doubleclick something you get invisible and the chat goes to the left side
- online time dosen't count
- doorbell isn't working