Duplicate Itemid Fix!!

[toperwin]

Ago i saw verry long ago to fix it with something like "SQL_NO_CACHE" but didn't work for me,.. sow thats reason why i post a new fix by me ;p

Search into /HabboHotel/Users/Iventory/IventoryComponent.cs for:

public void AddItem(uint Id, uint BaseItem, string ExtraData)

Replace that WHOLE void with:

        public void AddItem(uint Id, uint BaseItem, string ExtraData)
        {
            try
            {
                lock (this.InventoryItems)
                {
                    InventoryItems.Add(new UserItem(Id, BaseItem, ExtraData));

                    using (DatabaseClient dbClient = UberEnvironment.GetDatabase().GetClient())
                    {
                        dbClient.AddParamWithValue("extra_data", ExtraData);
                        dbClient.ExecuteQuery("INSERT INTO user_items (id,user_id,base_item,extra_data) VALUES ('" + Id + "','" + UserId + "','" + BaseItem + "',@extra_data)");
                    }
                }
            }
            catch (Exception)
            {
                this.AddItem(Id, BaseItem, ExtraData);
            }
        }

U maybe think, isnt this going to give u other errors, or a insta loop or whatever? -> NO! :D
Bcouse the change to get itemid error with much ppl online is 1 at 20/50 ,... just say to the script to try it again ;) and it will work,...
I doesn't got ANY duplicate itemid error/disconnect anymore :D

[MentaL]

[Davidaap]

nice mattie :)

[PEjump2]

This won't fix it completly, this will just create loops,
and loops will create an memory leak,
and when you've got 200+ online you'r computer would burn away..

Tip:
To fix this, add an sort of an check that checks if the item already exists :)

[toperwin]

This won't fix it completly, this will just create loops,
and loops will create an memory leak,
and when you've got 200+ online you'r computer would burn away..

Tip:
To fix this, add an sort of an check that checks if the item already exists :)

AGAIN! can u read?
It doesnt create loops bcouse you have just 1 at 50 times that duplicate itemid fix,...
change that u get a loop from 500000000 is change 1 at 9999999999999999999999999999999999999
It just let it repeat 1/2 times bcouse than the item works with buying,.....
sow it doesnt create unendless loop (if u dont got a selfmade sucking emulator like you got) and it doesnt burn your emulator ;) it just works and fix the problem,.. if u dont like it dont use it!

[vista4life]

sigh.. add a hashtable for item's that will fix almost all problems ;)

Example:


if (mRemovedItems.Contains(Id))
mRemovedItems.Remove(Id);
if (mAddedItems.ContainsKey(Id))
return;

[rafa95123]

So, this work our no?

[PEjump2]

So, this work our no?

Nope, this will just create loops, and loops will create a few memory leaks & lagg on you'r hotel so, i don't recommend to use this 'fix'.

[rafa95123]

Ok Thanks ;D

[1ntel]

sigh.. add a hashtable for item's that will fix almost all problems ;)

Example:


if (mRemovedItems.Contains(Id))
mRemovedItems.Remove(Id);
if (mAddedItems.ContainsKey(Id))
return;

Thats what you did in martinmines fix for VG, and its a complete mess i would never go that way about to fixing it really.

[vista4life]

Thats what you did in martinmines fix for VG, and its a complete mess i would never go that way about to fixing it really.

good to see that ur totaly agree with ur buggy leaked source =]

that happens when something leaks ;) because that source you have is full bugs and full testing stuff and trust me this is the best fix todo that thing and beside ask martin about it;)

think before you post..

[toperwin]

Btw into that catch,.. just place a return >,< i found that not all emulators accept this code (bcouse my stable one does they drived about 2days with this working, but my other one for fun with battlebanzai etz he gave stackoverflow,...)

if ur emulator don't accept this code and give stackoverflow, than just into the catch place a return or whatever u wanted ;p

[masood104]

so whats the final fix for this xD? that doesn't cause loops or w.e