FunCMS - Beta release

Page 2 of 2 FirstFirst 12
Results 16 to 24 of 24
  1. #16
    hoi ik ben cool Merijn is offline
    MemberRank
    Dec 2009 Join Date
    The NetherlandsLocation
    492Posts

    Re: FunCMS - Beta release

    Good luck with learning PHP, here some tips.

    This is your 'beveiliging.php' in the housekeeping:

    PHP Code:
    if($userinfo['rank'] < 5) {
    Header("Location: ../ingelogd");

    So, what would happen if I disable the location header? It would do let me create a news message if I want to, haha. Put a exit; into the end of a header("Location: "); otherwise, it would be vulnerable =P.

    Maybe some other useful tips,
    1. Use a template engine such as smarty or raintpl.
    2. use require for important files such as configuration files.
    3.
    PHP Code:
    $gebruikersnaam $_SESSION['gebruikersnaam']; 
    Maybe you need to check if the session ['gebruikersnaam']; exists, before you create the session? Could lead to E_NOTICE messages. I guess that's why you're using error_reporting(0); =P.

    4. You put a query in the global file, so every page you're loading, there will be one query executed? Could be done better.

    There is much more I can say, but I guess you have enough now.

    Goodluck!

  2. #17
    Valued Member KevinZuiker is offline
    MemberRank
    May 2012 Join Date
    On EarthLocation
    114Posts

    Re: FunCMS - Beta release

    Quote Originally Posted by MerijnZ View Post
    Good luck with learning PHP, here some tips.

    This is your 'beveiliging.php' in the housekeeping:

    PHP Code:
    if($userinfo['rank'] < 5) {
    Header("Location: ../ingelogd");

    So, what would happen if I disable the location header? It would do let me create a news message if I want to, haha. Put a exit; into the end of a header("Location: "); otherwise, it would be vulnerable =P.

    Maybe some other useful tips,
    1. Use a template engine such as smarty or raintpl.
    2. use require for important files such as configuration files.
    3.
    PHP Code:
    $gebruikersnaam $_SESSION['gebruikersnaam']; 
    Maybe you need to check if the session ['gebruikersnaam']; exists, before you create the session? Could lead to E_NOTICE messages. I guess that's why you're using error_reporting(0); =P.

    4. You put a query in the global file, so every page you're loading, there will be one query executed? Could be done better.

    There is much more I can say, but I guess you have enough now.

    Goodluck!
    Thanks, I will use this in my next CMS :)

  3. #18
    Apprentice UnstucK is offline
    MemberRank
    Nov 2013 Join Date
    13Posts

    Re: FunCMS - Beta release

    It's pretty nice even though it's looking like an edit which is not good at all.

    Anyway the Index & Regist page are horribly made and don't even like those but you get my respect for the rest of the pages because they are nice for sure!

    Keep it up brother.

  4. #19
    Novice maxwellEU is offline
    MemberRank
    Nov 2013 Join Date
    1Posts

    Re: FunCMS - Beta release

    Thanks i quite like it cant wait for next release

    Sent from my RM-825_eu_euro1_310 using Tapatalk

  5. #20
    Valued Member madsmartapple is offline
    MemberRank
    Mar 2011 Join Date
    United StatesLocation
    145Posts

    Re: FunCMS - Beta release

    It's not that bad but I honestly really am not a big fan of it. It's a bit plain.

  6. #21
    Novice Atakan Aydin is offline
    MemberRank
    Dec 2013 Join Date
    4Posts

    Re: FunCMS - Beta release

    Nice!

  7. #22
    "(still lacks brains)" NoBrain is offline
    MemberRank
    Sep 2011 Join Date
    United KingdomLocation
    2,658Posts

    Re: FunCMS - Beta release

    Design is too clustered, I prefer simplicity over a clustered heavy jQuery design. I will review the PHP later.

    Sent from my Windows Phone 8S by HTC using Tapatalk

  8. #23
    Banned Rizzie is offline
    BannedRank
    Jan 2013 Join Date
    11Posts

    Re: FunCMS - Beta release

    The /me looks a little like HoloCMS, because of that Help tool thing.

  9. #24
    Apprentice Sir Jacob is offline
    MemberRank
    Jan 2014 Join Date
    everywhereLocation
    15Posts

    Re: FunCMS - Beta release

    Blegh.. that index.. I'll give you a 7.



Page 2 of 2 FirstFirst 12

Advertisement