Habbo4.1 [PHP5, OOP, TPL, MySQLi]

Tnxx for this release maybe an good layout for an RP?

Quote:

---

Originally Posted by Dannie

This cms works perfectly with IIS!

---

Glad to hear, hadn't tested yet.

Sent from my GT-I8260 using Tapatalk

Jamal:

Don't think it's a layout that you'd use for roleplay hotels but anyway good luck!

Actually it is better off for a rp.

Going to update it tomorrow with the latest version. It now has cached avatars.

Quote:

---

Originally Posted by Vaulient

Actually it is better off for a rp.

---

And how do you work that out?

The skin itself , it's more suitable for a rp

Update 13:

Spoiler:

- Fixed SSO problem

https://mega.co.nz/#!x1JhWAxD!EERvuQ...EeNQxIUvZHKKfI

Have you already tried RainTPL for your template system ?

I use it for personal purpose, it's lightweight ( compared to the famous
Smarty and others ) but powerful and easy to use.

I used it on earlier projects. I wanted to create my own engine now.:thumbup1:

Busy on new theme!

Spoiler:

http://img843.imageshack.us/img843/1645/hj5o.png

Hey.
I want to give you some tips with your code.

PHP Code:

---

class User{
    public function database($h, $u, $p, $db){
        $this->conn = new mysqli($h,$u,$p,$db); // So i don't have to use global.
    }

public function grabData($k) {
    $q = $this->conn->query("SELECT * FROM users WHERE username = '$this->session'");
    $r = mysqli_fetch_assoc($q);

    return $r[$k];
}
} 


---

The grabData() method is pretty inefficient. I would store the result which is given in a private attribute, so it doesn't have to run the query everytime grabData is called.
Another tip is, that you use dependency injection with the database. The method database() will create an mysqli instance everytime when you use the User object.
I would pass the Database as a parameter so the database() method looks a bit like this.

PHP Code:

---

class User{
/* ... */
public function database(MySQLi $connection)
{
this->conn = $connection;
} 


---

And if you want to call this function, you simply do this:

PHP Code:

---

$connection = new MySQLi('bla','bla','bla','bla');

$user = new User('blabla');
$user->database($connection); 


---

I would put the $connection variable in the core file, so you only use one instance of it.

I've rewritten the User class with minor adjustments:

PHP Code:

---

class User {
    
    private $row = null;
    
    public function __construct($session) {
        $this->session = $session;
    }
    
    public function database($connection){
        $this->conn = $connection; // Dependency Injection, maybe put this in the constructor
    }

    public function grabData($k) {
        if (is_null($this->row)){
        $q = $this->conn->query("SELECT * FROM users WHERE username = '$this->session'");
        $this->row = mysqli_fetch_assoc($q);
        }
        
        return $this->row[$k];
    }
    
    // Call RefreshRow() if something has been updated in the database
    public function RefreshRow()
    {
        $q = $this->conn->query("SELECT * FROM users WHERE username = '$this->session'");
        $this->row = mysqli_fetch_assoc($q);
    }
} 


---

I didnt't test anything so forgive me if I made any mistakes.
Hope I could help!

It looks really good. Keep up the good work!


Verzonden vanaf mijn iPhone met behulp van Tapatalk

I got a white client, how do i fix it? Plz reply fast!

$q = $this->conn->query("SELECT * FROM users WHERE username = '$this->session'");

This is where prepared statements are for...

Also, I hate the style (no offence) but it looks TOO small in my opinion and really messy. I don't know much about your PHP but like above: that's what prepared statements are for..

Won't use it as I use my own custom CMS but still good attempt.