Welcome!

Join our community of MMO enthusiasts and game developers! By registering, you'll gain access to discussions on the latest developments in MMO server files and collaborate with like-minded individuals. Join us today and unlock the potential of MMO server development!

Join Today!

Illumina CMS [PHP, OOP, Phoenix/Butterfly, Updated]

Status
Not open for further replies.
Newbie Spellweaver
Joined
Jan 9, 2011
Messages
70
Reaction score
8
There is issue with the staff pages, two out of four of them work do you any solutions?

Such as Founders and mods page work but not managers or admin it shows 404 error, which the pages are there so I'm not sure why it says 404 every minute.
 
Newbie Spellweaver
Joined
Jan 26, 2013
Messages
85
Reaction score
15
DmijuCN - Illumina CMS [PHP, OOP, Phoenix/Butterfly, Updated] - RaGEZONE Forums


any way to fix/remove this?
 

Attachments

You must be registered for see attachments list
I'm-a ruin you, punt!
Joined
Apr 6, 2008
Messages
575
Reaction score
193
Has anyone actually noticed the un-escaped SQL query or is it just me? ;)

Code:
if(isAllowed($_POST["Username"], $_POST["Password"]))

(The function from: admin_required.php)
Code:
    function isAllowed($username, $password) {
        global $db;
        if($check = $db->query("SELECT username,password,rank FROM users WHERE username = '" . $username . "'")) {
            while($data = $check->fetch_assoc()) {
                $dbPassword = $data['password'];
                $dbRank = $data['rank'];
            }
        }
 
The one and only!
Loyal Member
Joined
Nov 24, 2008
Messages
2,529
Reaction score
1,435
Has anyone actually noticed the un-escaped SQL query or is it just me? ;)

Code:
if(isAllowed($_POST["Username"], $_POST["Password"]))

(The function from: admin_required.php)
Code:
    function isAllowed($username, $password) {
        global $db;
        if($check = $db->query("SELECT username,password,rank FROM users WHERE username = '" . $username . "'")) {
            while($data = $check->fetch_assoc()) {
                $dbPassword = $data['password'];
                $dbRank = $data['rank'];
            }
        }
Hardly shocking is it haha, we all seem to expect security holes like this in Jonty's releases.
 
Junior Spellweaver
Joined
Aug 8, 2009
Messages
139
Reaction score
13
Has anyone actually noticed the un-escaped SQL query or is it just me? ;)

Code:
if(isAllowed($_POST["Username"], $_POST["Password"]))

(The function from: admin_required.php)
Code:
    function isAllowed($username, $password) {
        global $db;
        if($check = $db->query("SELECT username,password,rank FROM users WHERE username = '" . $username . "'")) {
            while($data = $check->fetch_assoc()) {
                $dbPassword = $data['password'];
                $dbRank = $data['rank'];
            }
        }

Oh wow! So would I have to remove
function isAllowed($username, $password) {
and the exploit will go? or the whole thing
function isAllowed($username, $password) {
global $db;
if($check = $db->query("SELECT username,password,rank FROM users WHERE username = '" . $username . "'")) {
while($data = $check->fetch_assoc()) {
$dbPassword = $data['password'];
$dbRank = $data['rank'];
}
}
 
I'm-a ruin you, punt!
Joined
Apr 6, 2008
Messages
575
Reaction score
193
Oh wow! So would I have to remove and the exploit will go? or the whole thing

No of course you don’t remove the entire function, which is vital. Just add the following at the very top of the “isAllowed” function.

Code:
$username = $db->real_escape_string($username);

To be quite frank, I don’t know why you are all still swarming this poop. It’s a half arsed attempt at something good. He can’t even make his mind up between prepared statements or normal queries. It’s just complete poop.

Edit:

Just to ensure you can’t call me a faggot or a hater, take a look at this. This just defeats the purpose of a prepared statement.
Code:
$db->prepare("INSERT INTO users (username,password,mail,auth_ticket,rank,look,gender,motto,home_room,credits,activity_points,last_online,account_created,ip_last,ip_reg) VALUES ('" . $username . "','" . $passwordHash . "','" . $email . "','','" . $rank . "','" . $figure . "','" . $sex . "', '" . $motto . "', '" . $homeroom . "','15000','1000','','" . date('d-M-Y') . "', '".$_SERVER['REMOTE_ADDR']."', '".$_SERVER['REMOTE_ADDR']."')")) {
 
Joined
Apr 30, 2007
Messages
2,339
Reaction score
1,547
No of course you don’t remove the entire function, which is vital. Just add the following at the very top of the “isAllowed” function.

Code:
$username = $db->real_escape_string($username);

To be quite frank, I don’t know why you are all still swarming this poop. It’s a half arsed attempt at something good. He can’t even make his mind up between prepared statements or normal queries. It’s just complete poop.

Edit:

Just to ensure you can’t call me a faggot or a hater, take a look at this. This just defeats the purpose of a prepared statement.
Code:
$db->prepare("INSERT INTO users (username,password,mail,auth_ticket,rank,look,gender,motto,home_room,credits,activity_points,last_online,account_created,ip_last,ip_reg) VALUES ('" . $username . "','" . $passwordHash . "','" . $email . "','','" . $rank . "','" . $figure . "','" . $sex . "', '" . $motto . "', '" . $homeroom . "','15000','1000','','" . date('d-M-Y') . "', '".$_SERVER['REMOTE_ADDR']."', '".$_SERVER['REMOTE_ADDR']."')")) {

Feel free to release an entire CMS of your own, then you're allowed to critisize. This is why RaGEZONE is dying, peace.
 
I'm-a ruin you, punt!
Joined
Apr 6, 2008
Messages
575
Reaction score
193
Feel free to release an entire CMS of your own, then you're allowed to critisize. This is why RaGEZONE is dying, peace.

RaGEZONE is dying because of cancers like you releasing infected poop so you can destroy others. Don’t expect anyone to cry about your departure.
 
Junior Spellweaver
Joined
Aug 8, 2009
Messages
139
Reaction score
13
If I was e-whoring let me assure you I wouldn’t be posting poop in your thread. The truth of the matter is you always do this when you’re caught. As for me releasing an exploit, I doubt it when I’ve never released anything on to RaGEZONE that could be infected.

But carry on, how’s the downtime going?

Thanks, and did I do it right?
$username = $db->real_escape_string($username);
global $light;
if($light->hashing_method == "Normal") {
return sha1(md5($pass) . strtolower($user));
}
else if($light->hashing_method == "MD5") {
return md5($pass);
}
 
I'm-a ruin you, punt!
Joined
Apr 6, 2008
Messages
575
Reaction score
193
Thanks ;D

LOL! It should look like this.

Code:
    function isAllowed($username, $password) {
        $username = $db->real_escape_string($username);
        global $db;
        if($check = $db->query("SELECT username,password,rank FROM users WHERE username = '" . $username . "'")) {
            while($data = $check->fetch_assoc()) {
                $dbPassword = $data['password'];
                $dbRank = $data['rank'];
            }
        }
        $enterPassword = hashPass($password, $username);
        if($enterPassword != $dbPassword) {
            return false;
        }
        else if(!hasFuse($username, 'login')) {
            return false;
        }
        return true;
    }
 
Junior Spellweaver
Joined
Aug 8, 2009
Messages
139
Reaction score
13
LOL! It should look like this.

Code:
    function isAllowed($username, $password) {
        $username = $db->real_escape_string($username);
        global $db;
        if($check = $db->query("SELECT username,password,rank FROM users WHERE username = '" . $username . "'")) {
            while($data = $check->fetch_assoc()) {
                $dbPassword = $data['password'];
                $dbRank = $data['rank'];
            }
        }
        $enterPassword = hashPass($password, $username);
        if($enterPassword != $dbPassword) {
            return false;
        }
        else if(!hasFuse($username, 'login')) {
            return false;
        }
        return true;
    }

My bad, Thanks Again... !
 
Status
Not open for further replies.
Back
Top