[Mercury Emulator] Fixes & Edits [Topic] [Post Your Bugs and Fixes]

Quote:

---

Originally Posted by sunnie

I have this error, and cant fix it? :
Can someone help me?

---

Whats in ItemManager,cs on line 50 to 65?

This: {
';'
});
height = Convert.ToDouble(array[0]);
}
else
{
height = Convert.ToDouble(dataRow["stack_height"]);
}
bool stackable = Convert.ToInt32(dataRow["can_stack"]) == 1;
bool walkable = Convert.ToInt32(dataRow["is_walkable"]) == 1;
bool isSeat = Convert.ToInt32(dataRow["can_sit"]) == 1;
bool allowRecycle = Convert.ToInt32(dataRow["allow_recycle"]) == 1;
bool allowTrade = Convert.ToInt32(dataRow["allow_trade"]) == 1;
bool allowMarketplaceSell = Convert.ToInt32(dataRow["allow_marketplace_sell"]) == 1;
bool allowGift = Convert.ToInt32(dataRow["allow_gift"]) == 1;

Fix For Wired Condition Furni State and Position Match

Replace ALL your HabboHotel\Rooms\Wired\Handlers\Conditions\ItemsCoincide.cs

to:

Spoiler:

using Mercury.HabboHotel.Items;
using Mercury.HabboHotel.Pathfinding;
using System;
using System.Collections.Generic;


namespace Mercury.HabboHotel.Rooms.Wired.Handlers.Conditions
{
internal class ItemsCoincide : WiredItem
{
private WiredItemType mType = WiredItemType.ConditionFurniCoincides;
private RoomItem mItem;
private Room mRoom;


private string mString;
private string mExtra;
private string mExtra2;


private List<RoomItem> mItems;


public WiredItemType Type
{
get
{
return this.mType;
}
}
public RoomItem Item
{
get
{
return this.mItem;
}
set
{
this.mItem = value;
}
}
public Room Room
{
get
{
return this.mRoom;
}
}
public List<RoomItem> Items
{
get
{
return this.mItems;
}
set
{
this.mItems = value;
}
}
public string OtherString
{
get
{
return mString;
}
set
{
mString = value;
}
}
public string OtherExtraString
{
get
{
return mExtra;
}
set
{
mExtra = value;
}
}
public string OtherExtraString2
{
get
{
return mExtra2;
}
set
{
mExtra2 = value;
}
}
public bool OtherBool
{
get
{
return true;
}
set
{
}
}


public int Delay
{
get
{
return 0;
}
set
{
}
}


public ItemsCoincide(RoomItem Item, Room Room)
{
this.mItem = Item;
this.mRoom = Room;
this.mItems = new List<RoomItem>();
this.mString = "";
this.mExtra = "";
this.mExtra2 = "";
}


public bool Execute(params object[] Stuff)
{
bool UseExtradata = false;
bool UseRot = false;
bool UsePos = false;


try
{
if (String.IsNullOrWhiteSpace(mString))
{
return false;
}
else
{
string[] Booleans = mString.ToLower().Split(',');
UseExtradata = Booleans[0] == "true";
UseRot = Booleans[1] == "true";
UsePos = Booleans[2] == "true";
}
}
catch { }


bool EDApproved = true;
bool RotApproved = true;
bool PosApproved = true;


foreach (RoomItem current in this.mItems)
{
string[] splitter = mExtra.Split('/');
string WItem = "";
int tryes = 0;
foreach (string str in splitter)
{
string itemid = current.Id.ToString();
if (splitter[tryes].Split('|')[0] == itemid)
WItem = splitter[tryes];
else
{
tryes++;
continue;
}
}
string[] WSplitted = WItem.Split('|');

RoomItem orItem = mRoom.GetRoomItemHandler().GetItem(current.Id);




if(current.RoomId == 0 || orItem == null || orItem.RoomId == 0)
{
continue;
}


if (UseRot)
{
if (current.Rot.ToString() != WSplitted[2])
{
RotApproved = false;
}
}


if (UseExtradata)
{
if (current.ExtraData == "")
{
current.ExtraData = "0";
}


if (current.ExtraData != WSplitted[1])
{
EDApproved = false;
}
}


if (UsePos)
{
string[] coords = WSplitted[3].Split(',');
string X = coords[0];
string Y = coords[1];
//string Z = coords[3];
if ((current.GetX.ToString() != X) || (current.GetY.ToString() != Y))
{
PosApproved = false;
}
}
}





if (EDApproved && PosApproved && RotApproved)
{
return true;
}
else
{
return false;
}
}
}
}

Quote:

---

Originally Posted by cabeludo007

Fix For Wired Condition Furni State and Position Match

Replace ALL your HabboHotel\Rooms\Wired\Handlers\Conditions\ItemsCoincide.cs

to:

Spoiler:

using Mercury.HabboHotel.Items;
using Mercury.HabboHotel.Pathfinding;
using System;
using System.Collections.Generic;


namespace Mercury.HabboHotel.Rooms.Wired.Handlers.Conditions
{
internal class ItemsCoincide : WiredItem
{
private WiredItemType mType = WiredItemType.ConditionFurniCoincides;
private RoomItem mItem;
private Room mRoom;


private string mString;
private string mExtra;
private string mExtra2;


private List<RoomItem> mItems;


public WiredItemType Type
{
get
{
return this.mType;
}
}
public RoomItem Item
{
get
{
return this.mItem;
}
set
{
this.mItem = value;
}
}
public Room Room
{
get
{
return this.mRoom;
}
}
public List<RoomItem> Items
{
get
{
return this.mItems;
}
set
{
this.mItems = value;
}
}
public string OtherString
{
get
{
return mString;
}
set
{
mString = value;
}
}
public string OtherExtraString
{
get
{
return mExtra;
}
set
{
mExtra = value;
}
}
public string OtherExtraString2
{
get
{
return mExtra2;
}
set
{
mExtra2 = value;
}
}
public bool OtherBool
{
get
{
return true;
}
set
{
}
}


public int Delay
{
get
{
return 0;
}
set
{
}
}


public ItemsCoincide(RoomItem Item, Room Room)
{
this.mItem = Item;
this.mRoom = Room;
this.mItems = new List<RoomItem>();
this.mString = "";
this.mExtra = "";
this.mExtra2 = "";
}


public bool Execute(params object[] Stuff)
{
bool UseExtradata = false;
bool UseRot = false;
bool UsePos = false;


try
{
if (String.IsNullOrWhiteSpace(mString))
{
return false;
}
else
{
string[] Booleans = mString.ToLower().Split(',');
UseExtradata = Booleans[0] == "true";
UseRot = Booleans[1] == "true";
UsePos = Booleans[2] == "true";
}
}
catch { }


bool EDApproved = true;
bool RotApproved = true;
bool PosApproved = true;


foreach (RoomItem current in this.mItems)
{
string[] splitter = mExtra.Split('/');
string WItem = "";
int tryes = 0;
foreach (string str in splitter)
{
string itemid = current.Id.ToString();
if (splitter[tryes].Split('|')[0] == itemid)
WItem = splitter[tryes];
else
{
tryes++;
continue;
}
}
string[] WSplitted = WItem.Split('|');

RoomItem orItem = mRoom.GetRoomItemHandler().GetItem(current.Id);




if(current.RoomId == 0 || orItem == null || orItem.RoomId == 0)
{
continue;
}


if (UseRot)
{
if (current.Rot.ToString() != WSplitted[2])
{
RotApproved = false;
}
}


if (UseExtradata)
{
if (current.ExtraData == "")
{
current.ExtraData = "0";
}


if (current.ExtraData != WSplitted[1])
{
EDApproved = false;
}
}


if (UsePos)
{
string[] coords = WSplitted[3].Split(',');
string X = coords[0];
string Y = coords[1];
//string Z = coords[3];
if ((current.GetX.ToString() != X) || (current.GetY.ToString() != Y))
{
PosApproved = false;
}
}
}





if (EDApproved && PosApproved && RotApproved)
{
return true;
}
else
{
return false;
}
}
}
}

---

Works, thanks!

Quote:

---

Originally Posted by cabeludo007

Fix For Wired Condition Furni State and Position Match

Replace ALL your HabboHotel\Rooms\Wired\Handlers\Conditions\ItemsCoincide.cs

to:

Spoiler:

using Mercury.HabboHotel.Items;
using Mercury.HabboHotel.Pathfinding;
using System;
using System.Collections.Generic;


namespace Mercury.HabboHotel.Rooms.Wired.Handlers.Conditions
{
internal class ItemsCoincide : WiredItem
{
private WiredItemType mType = WiredItemType.ConditionFurniCoincides;
private RoomItem mItem;
private Room mRoom;


private string mString;
private string mExtra;
private string mExtra2;


private List<RoomItem> mItems;


public WiredItemType Type
{
get
{
return this.mType;
}
}
public RoomItem Item
{
get
{
return this.mItem;
}
set
{
this.mItem = value;
}
}
public Room Room
{
get
{
return this.mRoom;
}
}
public List<RoomItem> Items
{
get
{
return this.mItems;
}
set
{
this.mItems = value;
}
}
public string OtherString
{
get
{
return mString;
}
set
{
mString = value;
}
}
public string OtherExtraString
{
get
{
return mExtra;
}
set
{
mExtra = value;
}
}
public string OtherExtraString2
{
get
{
return mExtra2;
}
set
{
mExtra2 = value;
}
}
public bool OtherBool
{
get
{
return true;
}
set
{
}
}


public int Delay
{
get
{
return 0;
}
set
{
}
}


public ItemsCoincide(RoomItem Item, Room Room)
{
this.mItem = Item;
this.mRoom = Room;
this.mItems = new List<RoomItem>();
this.mString = "";
this.mExtra = "";
this.mExtra2 = "";
}


public bool Execute(params object[] Stuff)
{
bool UseExtradata = false;
bool UseRot = false;
bool UsePos = false;


try
{
if (String.IsNullOrWhiteSpace(mString))
{
return false;
}
else
{
string[] Booleans = mString.ToLower().Split(',');
UseExtradata = Booleans[0] == "true";
UseRot = Booleans[1] == "true";
UsePos = Booleans[2] == "true";
}
}
catch { }


bool EDApproved = true;
bool RotApproved = true;
bool PosApproved = true;


foreach (RoomItem current in this.mItems)
{
string[] splitter = mExtra.Split('/');
string WItem = "";
int tryes = 0;
foreach (string str in splitter)
{
string itemid = current.Id.ToString();
if (splitter[tryes].Split('|')[0] == itemid)
WItem = splitter[tryes];
else
{
tryes++;
continue;
}
}
string[] WSplitted = WItem.Split('|');

RoomItem orItem = mRoom.GetRoomItemHandler().GetItem(current.Id);




if(current.RoomId == 0 || orItem == null || orItem.RoomId == 0)
{
continue;
}


if (UseRot)
{
if (current.Rot.ToString() != WSplitted[2])
{
RotApproved = false;
}
}


if (UseExtradata)
{
if (current.ExtraData == "")
{
current.ExtraData = "0";
}


if (current.ExtraData != WSplitted[1])
{
EDApproved = false;
}
}


if (UsePos)
{
string[] coords = WSplitted[3].Split(',');
string X = coords[0];
string Y = coords[1];
//string Z = coords[3];
if ((current.GetX.ToString() != X) || (current.GetY.ToString() != Y))
{
PosApproved = false;
}
}
}





if (EDApproved && PosApproved && RotApproved)
{
return true;
}
else
{
return false;
}
}
}
}

---

Tanks works fine, and for the wired "The effect is repeated" ?

Quote:

---

Originally Posted by jordynegen11

for your first bug: structure and outgoing id are right. You don't have any mysql errors?

---

No, I don't get any...

I have changed it to:

Spoiler:

PHP Code:

---

GameClient clientByUserID = MercuryEnvironment.GetGame().GetClientManager().GetClientByUserID(UserId);
ServerMessage serverMessage = new ServerMessage(Outgoing.ModerationToolRoomVisitsMessageComposer);
serverMessage.AppendUInt(UserId);
serverMessage.AppendString(MercuryEnvironment.GetGame().GetClientManager().GetNameById(UserId));
if ((clientByUserID != null) && (clientByUserID.GetHabbo().visitedRooms.Count > 0))
{
    serverMessage.AppendInt32(clientByUserID.GetHabbo().visitedRooms.Count);
    foreach (RoomData data in clientByUserID.GetHabbo().visitedRooms)
    {
        serverMessage.AppendBoolean(false);
        serverMessage.AppendUInt(data.Id);
        serverMessage.AppendString(data.Name);
        serverMessage.AppendInt32(0);
        serverMessage.AppendInt32(1);
    }
    return serverMessage;
}
serverMessage.AppendInt32(0);
return serverMessage; 


---

a few days ago, to spare queries, but still no luck.

- - - Updated - - -

Found yet another bug:
You can put furniture in the door XD

http://i.imgur.com/XB4ywiW.png

Quote:

---

Originally Posted by BaasHotel

Found yet another bug:
You can put furniture in the door XD

http://i.imgur.com/XB4ywiW.png

---

You can also do that in Habbo, so probably it's not a bug. :P

But if you want to fix it anyway, find

Code:

---

internal bool SetFloorItem(GameClient Session, RoomItem Item, int newX, int newY, int newRot, bool newItem, bool OnRoller, bool sendMessage, bool updateRoomUserStatuses)
                {

---

And add:

Code:

---

if (newX == room.GetGameMap().Model.DoorX && newY == room.GetGameMap().Model.DoorY)
            {
                return false;
            }

---

Quote:

---

Originally Posted by MrPudding

You can also do that in Habbo, so probably it's not a bug. :P

But if you want to fix it anyway, find

Code:

---

internal bool SetFloorItem(GameClient Session, RoomItem Item, int newX, int newY, int newRot, bool newItem, bool OnRoller, bool sendMessage, bool updateRoomUserStatuses)
        {

---

And add:

Code:

---

if (newX == room.GetGameMap().Model.DoorX && newY == room.GetGameMap().Model.DoorY)
            {
                return false;
            }

---

---

I never noticed that you can actually do that on Habbo haha. o.o But thank you, your fix works like a charm! (:

Quote:

---

Originally Posted by MrPudding

You can also do that in Habbo, so probably it's not a bug. :P

---

Not in all rooms as far as I know.

BUG: When having an account ID of 1500 or higher you get a delay when picking up furni.

Quote:

---

Originally Posted by Bullies

BUG: When having an account ID of 1500 or higher you get a delay when picking up furni.

---

http://forum.ragezone.com/f353/mercu...ml#post8211740

Fix for wired move and rotate: (after unloading the room, the move and rotate data got mixed up)

Spoiler:

Go to:
HabboHotel/Items/Interactor/InteractorWired.cs

Change:

PHP Code:

---

case InteractionType.actionmoverotate:
{
    ServerMessage serverMessage13 = new ServerMessage(Outgoing.WiredEffectMessageComposer);
    serverMessage13.AppendBoolean(false);
    serverMessage13.AppendInt32(5);
    serverMessage13.AppendInt32(list.Count);
    foreach (RoomItem current13 in list)
    {
        serverMessage13.AppendUInt(current13.Id);
    }
    serverMessage13.AppendInt32(Item.GetBaseItem().SpriteId);
    serverMessage13.AppendUInt(Item.Id);
    serverMessage13.AppendString(ExtraInfo);
    serverMessage13.AppendInt32(2);
    serverMessage13.AppendInt32(int.Parse(ExtraInfo.Split(new char[]
    {
        ';'
    })[0]));
    serverMessage13.AppendInt32(int.Parse(ExtraInfo.Split(new char[]
    {
        ';'
    })[1]));
    serverMessage13.AppendInt32(0);
    serverMessage13.AppendInt32(4);
    serverMessage13.AppendInt32(i);
    serverMessage13.AppendInt32(0);
    serverMessage13.AppendInt32(0);
    Session.SendMessage(serverMessage13);
    return;
} 


---

To:

PHP Code:

---

case InteractionType.actionmoverotate:
{
    ServerMessage serverMessage13 = new ServerMessage(Outgoing.WiredEffectMessageComposer);
    serverMessage13.AppendBoolean(false);
    serverMessage13.AppendInt32(5);
    serverMessage13.AppendInt32(list.Count);
    foreach (RoomItem current13 in list)
    {
        serverMessage13.AppendUInt(current13.Id);
    }
    serverMessage13.AppendInt32(Item.GetBaseItem().SpriteId);
    serverMessage13.AppendUInt(Item.Id);
    serverMessage13.AppendString(ExtraInfo);
    serverMessage13.AppendInt32(2);
    serverMessage13.AppendInt32(int.Parse(ExtraInfo.Split(new char[]
    {
        ';'
    })[1]));
    serverMessage13.AppendInt32(int.Parse(ExtraInfo.Split(new char[]
    {
        ';'
    })[0]));
    serverMessage13.AppendInt32(0);
    serverMessage13.AppendInt32(4);
    serverMessage13.AppendInt32(i);
    serverMessage13.AppendInt32(0);
    serverMessage13.AppendInt32(0);
    Session.SendMessage(serverMessage13);
    return;
} 


---

Quote:

---

Originally Posted by Bullies

BUG: When having an account ID of 1500 or higher you get a delay when picking up furni.

---

In RoomItemHandling.cs :

Replace

Code:

---

                                ServerMessage serverMessage = new ServerMessage(Outgoing.PickUpFloorItemMessageComposer);
                                serverMessage.AppendString(roomItem.Id + string.Empty);
                                serverMessage.AppendBoolean(false);
                                serverMessage.AppendInt32(0);
                                serverMessage.AppendUInt(roomItem.UserID);

---

To:

Code:

---

                                ServerMessage serverMessage = new ServerMessage(Outgoing.PickUpFloorItemMessageComposer);
                                serverMessage.AppendString(roomItem.Id + string.Empty);
                                serverMessage.AppendBoolean(false);
                                serverMessage.AppendUInt(Session.GetHabbo().Id);
                                serverMessage.AppendInt32(0);

---

And also replace:

Code:

---

                                        ServerMessage serverMessage2 = new ServerMessage(Outgoing.PickUpFloorItemMessageComposer);
                                        serverMessage2.AppendString(Item.Id + string.Empty);
                                        serverMessage2.AppendBoolean(false);
                                        serverMessage2.AppendInt32((!WasPicked && Item.GetBaseItem().InteractionType == InteractionType.moplaseed) ? -1 : 0);
                                        if (WasPicked)
                                        {
                                                serverMessage2.AppendUInt(Item.UserID);
                                        }
                                        else
                                        {
                                                serverMessage2.AppendInt32(0);
                                        }

---

To:

Code:

---

                                        ServerMessage serverMessage2 = new ServerMessage(Outgoing.PickUpFloorItemMessageComposer);
                                        serverMessage2.AppendString(Item.Id + string.Empty);
                                        serverMessage2.AppendBoolean(false);
                                        if (WasPicked)
                                        {
                                                serverMessage2.AppendUInt(Item.UserID);
                                        }
                                        else
                                        {
                                                serverMessage2.AppendInt32(-1);
                                        }
                                        serverMessage2.AppendInt32(0);

---

This will fix the pick up delay issues aswell as adding the pickup animation (the one where the item goes to your inventory) :)

I'm working on some wireds atm and found something which I think is actually a bug by the habbo.swf, but I'm not sure.

When you set a start and end date/time for the 'Viking wired' (wf_cnd_date_rng_active) (interactiontype: conditiondaterangeactive) like 2014/10/11 23:56, the timestamp gets saved the right way, but when you reopen the wired screen, it shows 2014/10/11 11:56
I'm almost certain that it's because of the am/pm thing, but when I save the displayed date/time once again, the timestamp will get overwritten with the actual 2014/10/11 11:56 timestamp.

@MrPudding Thanks bro, working! =D
@BaasHotel Also working, thanks!