R63b - Perfect packet char filter

[George2000]

Hi, I've made a packet filter that filters ANY char other then A-Z a-z 0-9 and -

For example, you will get:
Received packet [0][0][0][36][15][160][0][32]RELEASE63-201205240929-144271078

Code:

   public string FromCharToString(string Data)
        {
            string Filtered = Data;
            Regex lettersOnly = new Regex("^[a-zA-Z]{1,25}$");
            Regex numbersOnly = new Regex("^[0-9]$");

            foreach (char C in Filtered)
            {
                if (C.ToString() == "-" || lettersOnly.IsMatch(C.ToString()) || numbersOnly.IsMatch(C.ToString()))
                    continue;

                Filtered = Filtered.Replace(C.ToString(), "[" + (int)C + "]");
            }

            return Filtered;
        } 

Credits:

Me - creating code
Google - example regex.

[MentaL]

[AWA]

you can't really credit google for this, can you?

[Shebsonwai]

Maybe you should tell us where to put this code.

[Makarov]

Suggestion: Show us some results!

Sent from my DROID RAZR using Tapatalk 2

[FullmetalPride]

Still don't get what I put with packets to put them into an emulator..

[Zak©]

@Above
Tbh this is a key feature for a basic packet logger.

It has nothing to really do with emulators.

Thanks, i guess it's useful.

[Droppy]

Code complete, with modifications to save packets, packets writing, among others.
Sorry For My Bad English, I'm Brazillian!

using System;
using System.Collections.Generic;
using System.Linq;
using System.Resources;
using System.Text.RegularExpressions;
using System.Text;

/*
 * By Droppy and George2000
 * Do not remove this -> Compulsory license in the 'Creative Commons License' (Which we are using now) 
 */

namespace ConsoleApplication20
{
    class Program
    {
        public static void FromCharToString(string Data)
        {
            string Filtered = Data;
            Regex lettersOnly = new Regex("^[a-zA-Z]{1,25}$");
            Regex numbersOnly = new Regex("^[0-9]$");

            foreach (char C in Filtered)
            {
                if (C.ToString() == "-" || lettersOnly.IsMatch(C.ToString()) || numbersOnly.IsMatch(C.ToString()))
                    continue;

                Filtered = Filtered.Replace(C.ToString(), "[" + (int)C + "]");
            }
            TimeSpan span = (DateTime.Now - DateTime.Now);


            Console.ForegroundColor = ConsoleColor.Yellow;
            Console.Write("Result: ");
            Console.ResetColor();
            Console.WriteLine(Filtered);
            Console.WriteLine("Saved in lastPacket.txt");                                                        
            string[] Write = { "###################################", "### Credits: Droppy, George2000 ###", "###################################", "Packets (decoded): " + Filtered, "Packets (encoded): " + Data };
            System.IO.File.WriteAllLines(@"lastPacket.txt", Write);
            Console.WriteLine("     ");

        }  

        static void Main(string[] args)
        {
            Console.ForegroundColor = ConsoleColor.Green;
            Console.WriteLine("############################################################");
            Console.WriteLine("### By: Droppy and George2000 - Creative Commons License ###");
            Console.WriteLine("############################################################");
            Console.WriteLine("### The last package will be saved in lastPacket.txt     ###");
            Console.WriteLine("############################################################");
            Console.WriteLine("     ");
            Console.ResetColor();
            Console.ForegroundColor = ConsoleColor.DarkRed;
            
            Console.WriteLine("Started!");

            Console.ResetColor();
            Console.WriteLine("     ");
            goto Programe;
        Programe:
            Console.ForegroundColor = ConsoleColor.Blue;
            Console.Write("Write Packets: ");
            Console.ResetColor();
            string phrase = Console.ReadLine();
            FromCharToString(phrase);
            
            goto Programe;
        }
    }
}
//Enjoy the code!

Enjoy It :D

[FullmetalPride]

@Above
Tbh this is a key feature for a basic packet logger.

It has nothing to really do with emulators.

Thanks, i guess it's useful.

I really have to start learning code..


Couldn't even tell it was only a piece, ffs..

[maritnmine]

   public string FromCharToString(string Data)
        {
            string Filtered = Data;
            Regex lettersOnly = new Regex("^[a-zA-Z]{1,25}$");
            Regex numbersOnly = new Regex("^[0-9]$");

            foreach (char C in Filtered)
            {
                if (C.ToString() == "-" || lettersOnly.IsMatch(C.ToString()) || numbersOnly.IsMatch(C.ToString()))
                    continue;

                Filtered = Filtered.Replace(C.ToString(), "[" + (int)C + "]");
            }

            return Filtered;
        } 

Slow algorithm is slow :)
#1: Each time you call the function, you have to create two new Regexes each time.
#2: Running a for-statement on a string is faster than a foreach :) (Read on MSDN)
#3: This thing could have been done way easier, like this :D

http://pastebin.com/cMGVgDLB

Code may be a bit longer, but it is way faster :)

- Martin

[Quackster]

Why isn't the method static?

[George2000]

Why isn't the method static?

Not really needed in my emulator, since it's only used in the same class or methods with the class as parameter.