Re: [REL] Fresh Emulator - Butterfly - Stable - Phoenix DB
Re: [REL] Fresh Emulator - Butterfly - Stable - Phoenix DB
Quote:
Originally Posted by
Joshu4
New Commands & Better Stability .. Could be done by a decent C# themselves but thanks Jonty.
Wouldn't use it though, the code is probably messy.
You wouldn't know messy code if it slapped you in the face.
Feel free to read it, it's clean as fuck. No documentation, though.
- - - Updated - - -
Quote:
Originally Posted by
Multify
Are there groups in it?
Yes, Groups is coded. I do believe you need to uncomment a line I commented related to prepping a user for the room load, which adds the groups of the room into a dictionary.
- - - Updated - - -
Quote:
Originally Posted by
Abbes
"no ragrets"
- Jonteh, the morning after
Pretty much lol
- - - Updated - - -
Quote:
Originally Posted by
Johno
@
Jonteh Nice work on the emulator, thanks for the release.
Lets try and avoid any other issues and stick the the threads topic which is the emulator
Welcome, I guess. Sure as shit better than that emulator you're using now.
Re: [REL] Fresh Emulator - Butterfly - Stable - Phoenix DB
Quote:
Originally Posted by
Jonteh
I know of none, though we did have marketplace and convertcredits disabled in this build.
Instead of being a bitch (like usual) - feel free to tell me how you're "exploiting" this and I'll post up a fix. If you want to bitch, or complain, then at least have the decency to help the people who want to use this.
lol.
Going to be honest...
The only thing i really like about you is your signature... on an unrelated note, Your code may be "clean" to the extent but don't act like your methods were the best...
1. Calling functions for each command equals the most unnecessary method in the world
Next time, you should use a better method... even a switch case i suppose would be better than that. I suggest using class per command next time.
2. Even though your Queries were clean, They're about 500 people on fresh...
Automatically updating the query makes no sense when a user gets married, thats why we have a save function on the user logout to save fields that were loaded on the login...
Cache the Marriages on the user login with an Dictionary and if your emulator doesn't close frequently, process it in the game loop
Basically what I'm trying to say is to run your queries before hand and after hand.
3. Most of your commands are missing null references.
4. Spacing out the code doesn't mean the code is clean
After Looking at this emulators Habbo class, It makes no sense to me how anyone in their right mind hasn't changed the way this is coded... This is fucking Butterfly... Didn't mmartinentadsadsadf make a thread about how to improve butterfly? One big topic was Object Orientation "private/public" getters/setters will be nice thx kbye
5. No documentation... At all
Tbh... I have nothing more to say about this release, facepalm.
Jonty, Next time release something we can give thanks for instead of another reason to be fucking annoyed with you. o/
6. No Errors nor Exceptions...
What If I'm a user and I accidentally use the wrong database, suddenly trying to parse your command.. and its like "Oh, oh... Jonty can I have some help?"
I don't think anyone in their right mind would want to use this...
Re: [REL] Fresh Emulator - Butterfly - Stable - Phoenix DB
Quote:
Originally Posted by
Wotsuba
Going to be honest...
The only thing i really like about you is your signature... on an unrelated note, Your code may be "clean" to the extent but don't act like your methods were the best...
1. Calling functions for each command equals the most unnecessary method in the world
Next time, you should use a better method... even a switch case i suppose would be better than that. I suggest using class per command next time.
2. Even though your Queries were clean, They're about 500 people on fresh...
Automatically updating the query makes no sense when a user gets married, thats why we have a save function on the user logout to save fields that were loaded on the login...
Cache the Marriages on the user login with an Dictionary and if your emulator doesn't close frequently, process it in the game loop
Basically what I'm trying to say is to run your queries before hand and after hand.
3. Most of your commands are missing null references.
4. Spacing out the code doesn't mean the code is clean
After Looking at this emulators Habbo class, It makes no sense to me how anyone in their right mind hasn't changed the way this is coded... This is fucking Butterfly... Didn't mmartinentadsadsadf make a thread about how to improve butterfly? One big topic was Object Orientation "private/public" getters/setters will be nice thx kbye
5. No documentation... At all
Tbh... I have nothing more to say about this release, facepalm.
Jonty, Next time release something we can give thanks for instead of another reason to be fucking annoyed with you. o/
6. No Errors nor Exceptions...
What If I'm a user and I accidentally use the wrong database, suddenly trying to parse your command.. and its like "Oh, oh... Jonty can I have some help?"
I don't think anyone in their right mind would want to use this...
Then don't use it? Making a big deal out of it won't change anything just make something better!
Re: [REL] Fresh Emulator - Butterfly - Stable - Phoenix DB
Quote:
Originally Posted by
TardisHotel
I never said trading I said market place and that was between me and you I didn't mean for you to come on this thread and tell them, they can figure it out themselves.
Yeah dude keep exploits to yourself. They're what make retros interesting!!1!
Jonteh nice release but, don't kid yourself. You're never done working with retros, you're here forever. We all are. It's not even funny. This is an addiction.
Re: [REL] Fresh Emulator - Butterfly - Stable - Phoenix DB
Quote:
Originally Posted by
Jmandupree
Then don't use it? Making a big deal out of it won't change anything just make something better!
I have no intention on using this emulator, I was just giving my criticism about how the emulator can be improved, Remember this is RageZone
Hopefully coming up with all those comments on the emulator in just a few minutes would teach jonty on how to actually improve the next time if there is a v2 or whatever
Re: [REL] Fresh Emulator - Butterfly - Stable - Phoenix DB
somethings wrong, cause you cant buy anything :P
Re: [REL] Fresh Emulator - Butterfly - Stable - Phoenix DB
if you cannot edit anything it's probably a database error, I was having same error.
Re: [REL] Fresh Emulator - Butterfly - Stable - Phoenix DB
Quote:
Originally Posted by
Disguised
somethings wrong, cause you cant buy anything :P
It is the database, items table for some reason does not have auto increment on the id field, enable it and reboot the emu works great
Re: [REL] Fresh Emulator - Butterfly - Stable - Phoenix DB
Anyone of you who know where the incoming and outgoing is for i cant find them?
Re: [REL] Fresh Emulator - Butterfly - Stable - Phoenix DB
If you're going to attempt to trigger exceptions and troubleshoot it here is the log folder from fresh with 10 days uptime lol
https://fresh-hotel.org/logs.rar
Re: [REL] Fresh Emulator - Butterfly - Stable - Phoenix DB
Quote:
Originally Posted by
Muscab
Thanks for these, sure will help people fix any problems they find.
Re: [REL] Fresh Emulator - Butterfly - Stable - Phoenix DB
Re: [REL] Fresh Emulator - Butterfly - Stable - Phoenix DB
Quote:
Originally Posted by
Kerem Kurtuldu
Full SQL link pls ?? :S
http://johno.pl/downloads/freshemudb.zip
Re: [REL] Fresh Emulator - Butterfly - Stable - Phoenix DB
Don't forget to give wall_pos on your items table a default value as that tends to interfere with your catalog purchasing.
http://easycaptures.com/fs/uploaded/769/8142054362.png
Corn porn plz