Skybird Emu // Plus Edit // Secure // Stable //

[Unphased]

Hey Ragezone,
Just want to ask. Is this emulator safe or still have backdoors?

This version is clean :)

[NOC]

I have been handed this sledmore :

So, here are two simple fixes. (both in GroupManager.cs)

Replace both methods;
GetGroupUsersByString
GetGroupRequestsByString
With:

internal List<GroupUser> GetGroupUsersByString(Group Group, String SearchVal, uint Req)
{
var Users = new List<GroupUser>();
if (string.IsNullOrWhiteSpace(SearchVal))
{
if (Req == 0)
foreach (GroupUser U in Group.Members.Values)
Users.Add(U);
else
foreach (GroupUser U in Group.Admins.Values)
Users.Add(U);
}
else
{
using (IQueryAdapter dbClient = PlusEnvironment.GetDatabaseManager().getQueryreactor())
{
dbClient.setQuery("SELECT id FROM users WHERE username LIKE @query");
dbClient.addParameter("query", "%" + SearchVal + "%");
DataTable Table = dbClient.getTable();
if (Table == null)
{
if (Req == 0)
foreach (GroupUser U in Group.Members.Values)
Users.Add(U);
else
foreach (GroupUser U in Group.Admins.Values)
Users.Add(U);
}
else
{
foreach (DataRow Row in Table.Rows)
{
if (Group.Members.ContainsKey((uint)Row[0]))
Users.Add(Group.Members[(uint)Row[0]]);
}
}
}
}
return Users;
}

internal List<uint> GetGroupRequestsByString(Group Group, String SearchVal, uint Req)
{
if (string.IsNullOrWhiteSpace(SearchVal))
return Group.Requests;
var Users = new List<uint>();
using (IQueryAdapter dbClient = PlusEnvironment.GetDatabaseManager().getQueryreactor())
{
dbClient.setQuery("SELECT id FROM users WHERE username LIKE @query");
dbClient.addParameter("query", "%" + SearchVal + "%");
DataTable Table = dbClient.getTable();
if (Table != null)
{
foreach (DataRow Row in Table.Rows)
{
if (Group.Requests.Contains((uint)Row[0]))
Users.Add((uint)Row[0]);
}
}
}
return Users;
}

Well this emu has a exploit my db was dropped.

Maybe you should check things, instead of been a total arse to people

[13rad]

Well I'm sorry it just gets annoying.

[Lewislol]

Well this emu has a exploit my db was dropped.

@Sledmore posted this on another forum.

Hey.

So I check Habboons log files daily to see if there is anything I can fix and to improve the emulator, well today I'd found a user had accidentally typed a message in the groups searching input box, which was logged as a MySQL error. Well with further inspection I could drop any tables such (just like the old navigator issue, with the search query not being sanitized).

So, here are two simple fixes. (both in GroupManager.cs)

Replace both methods;

• GetGroupUsersByString
• GetGroupRequestsByString

With:
PHP:
internal List<GroupUser> GetGroupUsersByString(Group Group, String SearchVal, uint Req)
{
var Users = new List<GroupUser>();
if (string.IsNullOrWhiteSpace(SearchVal))
{
if (Req == 0)
foreach (GroupUser U in Group.Members.Values)
Users.Add(U);
else
foreach (GroupUser U in Group.Admins.Values)
Users.Add(U);
}
else
{
using (IQueryAdapter dbClient = PlusEnvironment.GetDatabaseManager().getQueryreactor())
{
dbClient.setQuery("SELECT id FROM users WHERE username LIKE @query");
dbClient.addParameter("query", "%" + SearchVal + "%");
DataTable Table = dbClient.getTable();
if (Table == null)
{
if (Req == 0)
foreach (GroupUser U in Group.Members.Values)
Users.Add(U);
else
foreach (GroupUser U in Group.Admins.Values)
Users.Add(U);
}
else
{
foreach (DataRow Row in Table.Rows)
{
if (Group.Members.ContainsKey((uint)Row[0]))
Users.Add(Group.Members[(uint)Row[0]]);
}
}
}
}
return Users;
}

internal List<uint> GetGroupRequestsByString(Group Group, String SearchVal, uint Req)
{
if (string.IsNullOrWhiteSpace(SearchVal))
return Group.Requests;
var Users = new List<uint>();
using (IQueryAdapter dbClient = PlusEnvironment.GetDatabaseManager().getQueryreactor())
{
dbClient.setQuery("SELECT id FROM users WHERE username LIKE @query");
dbClient.addParameter("query", "%" + SearchVal + "%");
DataTable Table = dbClient.getTable();
if (Table != null)
{
foreach (DataRow Row in Table.Rows)
{
if (Group.Requests.Contains((uint)Row[0]))
Users.Add((uint)Row[0]);
}
}
}
return Users;
}



You're welcome.

[NOC]

Which tables have been dropped so, i could replace it with an old one. *Ideas on how to get the tables that have been dropped back?*

You will be able to see from error logs / starting up errors of the emu, either open a backup in a text editor or the starting sql file and add the missing tables

[Keyuko]

What about diamond or a third currency support?

[Trever Wertman]

Currently I am developing the room promos.

[Kristophers]

Currently I am developing the room promos.

You've been going on about room promos for the longest now...

[Trever Wertman]

Except for the fact that if you check the development section, Ive made alot of progress.. Lmfao

[Receiver]

Anyone has fixes for this:
-Room name shows ... (3 points)
-Room doesnt show its an group room
-Wired isnt working 100%
-Searching stays on ''Searching...''

Here is 1 fix:
http://forum.ragezone.com/f353/plus-emu-fixed-979954/

[Bjork]

@IcePhreak and @Noman

http://forum.ragezone.com/f353/relea...ctions-969838/

[PSK]

RoomUserManager.cs

if (room.GetGameMap().IsValidStep2(User, new Vector2D(User.X, User.Y), new Vector2D(User.SetX, User.SetY), (User.GoalX == User.SetX && User.GoalY == User.SetY), User.AllowOverride))

Comment it ou delete this line and paste this above/instead:

if (room.GetGameMap().CanWalk(User.SetX, User.SetY, User.AllowOverride) || User.RidingHorse == true)

Credits to Bjork for fix.

[Jincos7s]

List of commands?

[Carlosso]

I have Skybird + IlluminaCMS but if I go to the client it doesn't connect, all settings are good, firewall.. ports..
Does someone know how to fix it? (there are no errors, it just doesn't connect)

[Hindi]

I have error in the Query caught. Any helps ? Also the DB dosen't execute successfully.