UberEmu Clone bug fix

[wichard]

Hello ragezone, after a time you have running your emu somethimes ive got a Clone bug.

Then u see my user 2+ times in a room.

Search for in Room.cs:

        public void RemoveUserFromRoom(GameClient Session, bool NotifyClient, bool NotifyKick)

Replace the whole void with:

        public void RemoveUserFromRoom(GameClient Session, bool NotifyClient, bool NotifyKick)
        {
            if (Session != null)
            {
                RoomUser roomUserByHabbo = this.GetRoomUserByHabbo(Session.GetHabbo().Id);
                TimedLock @lock = TimedLock.Lock(this.UserList);
                try
                {
                    if (!this.UserList.Remove(this.GetRoomUserByHabbo(Session.GetHabbo().Id)))
                    {
                        return;
                    }
                }
                catch
                {
                    return;
                }
                finally
                {
                    @lock.Dispose();
                }
                if (NotifyClient)
                {
                    if (NotifyKick)
                    {
                        Session.GetMessageHandler().GetResponse().Init(0x21);
                        Session.GetMessageHandler().GetResponse().AppendInt32(0xfa8);
                        Session.GetMessageHandler().SendResponse();
                    }
                    Session.GetMessageHandler().GetResponse().Init(0x12);
                    Session.GetMessageHandler().SendResponse();
                }
                List<RoomUser> list = new List<RoomUser>();
                using (TimedLock.Lock(this.UserList))
                {
                    if (!roomUserByHabbo.IsSpectator)
                    {
                        if (roomUserByHabbo != null)
                        {
                            this.UserMatrix[roomUserByHabbo.X, roomUserByHabbo.Y] = false;
                            ServerMessage message = new ServerMessage(0x1d);
                            message.AppendRawInt32(roomUserByHabbo.VirtualId);
                            this.SendMessage(message);
                        }
                        if (Session.GetHabbo() != null)
                        {
                            if (this.HasActiveTrade(Session.GetHabbo().Id))
                            {
                                this.TryStopTrade(Session.GetHabbo().Id);
                            }
                            if ((Session.GetHabbo().Username.ToLower() == this.Owner.ToLower()) && this.HasOngoingEvent)
                            {
                                this.Event = new RoomEvent(0, null, null, 0, new List<string>());
                                ServerMessage message2 = new ServerMessage(370);
                                message2.AppendStringWithBreak("-1");
                                this.SendMessage(message2);
                            }
                            Session.GetHabbo().OnLeaveRoom();
                        }
                    }
                    if (!roomUserByHabbo.IsSpectator)
                    {
                        this.UpdateUserCount();
                        List<RoomUser> list2 = new List<RoomUser>();
                        foreach (RoomUser user2 in this.UserList)
                        {
                            if (user2.IsBot)
                            {
                                list2.Add(user2);
                            }
                        }
                        foreach (RoomUser user3 in list2)
                        {
                            user3.BotAI.OnUserLeaveRoom(Session);
                            if ((user3.IsPet && (user3.PetData.OwnerId == Session.GetHabbo().Id)) && !this.CheckRights(Session, true))
                            {
                                list.Add(user3);
                            }
                        }
                    }
                }
                foreach (RoomUser user4 in list)
                {
                    Session.GetHabbo().GetInventoryComponent().AddPet(user4.PetData);
                    this.RemoveBot(user4.VirtualId, false);
                }
            }
        }

[MentaL]

[FlyCoder]

Nice release!

EDIT:
First post :)

[Richardjuhh]

NICE!! OMG i love this fix so much!!

2end post

[Subway]

Great but no images?

[1ntel]

This is not a proper fix, the issue is actually the TCP which causes this problem!! When closing the client!

[Subway]

ty matt, know he didn't fix anything.

[Mithex]

Thx for this m8!

[Richardjuhh]

This is not a proper fix, the issue is actually the TCP which causes this problem!! When closing the client!

Ok but in your emulator you have this problem!

thats because we use it!

[Emerica]

it's a good fix for normal UberEmu.
Thanks

[rafa95123]

Hey wichard, why of this Erro?



Help me please ?

[Richardjuhh]

Hey wichard, why of this Erro?



Help me please ?

Thinkemu is just based on blah emu..
blah emu used a other userlist or something

look at an original uber for the same code
after that look at blah
if you find...
copy
replace the line where you have the error.


And BlahEmulator has't got this error i think because some things are much better coded than the original!

[SlimHotel]

This is not how you really fix it the right way it's just a patch!~

[TenShie]

I'ts not to late to Post here.

It works an in Combination with the RoomManager fix 80% Stable

-TenShie