[Add-on] Avoid stupid SG chain bans and add MAC bans straight into source

[SuperLol]

    public void updateMacs(String macData) {
        boolean ban = false;
        try {
            if (macs.isEmpty()) {
                PreparedStatement ps = DatabaseConnection.getConnection().prepareStatement("SELECT macs FROM accounts WHERE id = ?");
                ps.setInt(1, accId);
                ResultSet rs = ps.executeQuery();
                if (rs.next()) {
                    String s = rs.getString("macs");
                    if (s != null) {
                        for (String mac : s.split(", ")) {
                            if (mac.length() != 0) {
                                macs.add(mac);
                            }
                        }
                    }
                }
                rs.close();
                ps.close();
            }
        } catch (SQLException se) {
        }
        macs.addAll(Arrays.asList(macData.split(", ")));
        StringBuilder newMacData = new StringBuilder(16);
        for (String s : macs) {
            newMacData.append(s);
            if (s.equals("00-1C-C0-E8-AB-70")) { // troublesome mac, should be blacklisted everywhere. insert more here
                ban = true;
            }
            newMacData.append(", ");
        }
        newMacData.setLength(newMacData.length() - 2);
        try {
            PreparedStatement ps = DatabaseConnection.getConnection().prepareStatement("UPDATE accounts SET macs = ?, ip = ? WHERE id = ?");
            ps.setString(1, newMacData.toString());
            ps.setString(2, session.getRemoteAddress().toString().split(":")[0]);
            ps.setInt(3, accId);
            ps.executeUpdate();
            ps.close();
        } catch (SQLException e) {
        }
        if (ban) {
            this.banPlayer("banned", true);
            this.disconnect();
        }
    } 

    public void banPlayer(String reason, boolean accban) {
        try {
            Connection con = DatabaseConnection.getConnection();
            String ip = session.getRemoteAddress().toString().split(":")[0];
            PreparedStatement ps = con.prepareStatement("SELECT ip FROM ipbans WHERE ip = ?");
            ps.setString(1, ip);
            ResultSet rs = ps.executeQuery();
            if (!rs.next()) {
                if (!ip.startsWith("/220.255")) { // sg ip
                    ps = con.prepareStatement("INSERT INTO ipbans VALUES (DEFAULT, ?)");
                    ps.setString(1, ip);
                    ps.executeUpdate();
                    ps.close();
                }
            }
            rs.close();
            ps.close();
            if (!accban) {
                return;
            }
            ps = con.prepareStatement("UPDATE accounts SET banned = 1, banreason = ? WHERE id = ?");
            ps.setString(1, reason);
            ps.setInt(2, accId);
            ps.executeUpdate();
            ps.close();
        } catch (SQLException e) {
            e.printStackTrace();
        }
    } 

[MentaL]

[ChupameElPene]

Yay no more SG bans.

[jakesdexless]

Nice release. Came back just to post

[^^^]

Cool. Nice bannings.

[Blaze22]

Yes! Good release.

[AuroX]

Lol, now i know why certain servers which I didn't play just disconnects me at char selection without any reason.

[MatanStyle]

Lol, now i know why certain servers which I didn't play just disconnects me at char selection without any reason.

Due to stupid bans and stuff. Yeah now you can set/unset this.

[hindie]

i dont get this , this basically bans all of SG ips

[XxОsirisxX]

i dont get this , this basically bans all of SG ips

On the contrary, it DOESN'T ban the SG's IP. Or at least, that's the propose of what I see, apparently SG's IP's starts with 220.255.

[BrotherHoodMS]

i dont get this , this basically bans all of SG ips

Well, tried banning a Singaporean in your server? It's like this, ban one of them 10 other also get banned, no joke.

Really usefull release!

[BrotherHoodMS]

Fuck off, u scold people stupid singaporean? You country more suck k. and your mother more stupid than SG.

You completly misunderstood the point of this thread..

[HorrorChix89]

I had to ban all the Singaporean players on my server. Had a large group of them come on an they ALL were hacking in some form of way. Plus, none of them spoke english and tried to use google translate. Horrible fail.

@Kiren: No on is calling Singaporean people stupid. He was calling the bans stupid.

[FU Im a diglet]

kiren, you're a bloody retard. you just threw our country's face away.

It's been thrown away for a long time dude...

OT: Nice (I guess?) I'd just ban them all, but that's just me.

[Emilyx3]

Full Singaporean IP ranges: Major IP Address Blocks For Singapore

Out of the range you gave only 110 were on my server's IP ban list of 12494 banned IPs =P

[SuperLol]

You don't need to ban those. Only the ones that 1000 people share.