AstralMS Based Source Ping Fix -> v145 Fix

[ExtremeDevilz]

I really have no idea why was this disabled....

 @Override    
        public void sessionIdle(final IoSession session, final IdleStatus status) throws Exception {
        MapleClient client = (MapleClient) session.getAttribute(MapleClient.CLIENT_KEY);
        
        if (client != null) {
            client.sendPing ();
        }
        super.sessionIdle(session, status);
    }

Send

PING((short) 0x12),

Recv

PONG(false, (short) 0x46),

[MentaL]

[HawtMaple]

This will make people with slow computers DC before they reach the login screen, unless you increase the time in sendping.

The default 60s is not enough, I had people who took 10 minutes to reach login.

    public final void sendPing() {
        lastPing = System.currentTimeMillis();
        session.write(LoginPacket.getPing());

        Timer.PingTimer.getInstance().schedule(new Runnable() {
            @Override
            public void run() {
                try {
                    if (getLatency() < 0) {
                        disconnect(true, false);
                        if (getSession().isConnected()) {
                            getSession().close(true);
                        }
                    }
                } catch (NullPointerException e) {
                    System.out.println(e.toString());
                }
            }
        }, 900000); // 15mins
    }

[Fraysa]

This will make people with slow computers DC before they reach the login screen, unless you increase the time in sendping.

The default 60s is not enough, I had people who took 10 minutes to reach login.

    public final void sendPing() {
        lastPing = System.currentTimeMillis();
        session.write(LoginPacket.getPing());

        Timer.PingTimer.getInstance().schedule(new Runnable() {
            @Override
            public void run() {
                try {
                    if (getLatency() < 0) {
                        disconnect(true, false);
                        if (getSession().isConnected()) {
                            getSession().close(true);
                        }
                    }
                } catch (NullPointerException e) {
                    System.out.println(e.toString());
                }
            }
        }, 900000); // 15mins
    }

I'm pretty sure the client still pongs when it's being loaded.

[Minike]

This will make people with slow computers DC before they reach the login screen, unless you increase the time in sendping.

The default 60s is not enough, I had people who took 10 minutes to reach login.

Only start ping cycle when the client gives the "oke" when its at login?
Aka you didnt code it properly, gj

[ExtremeDevilz]

This will make people with slow computers DC before they reach the login screen, unless you increase the time in sendping.

The default 60s is not enough, I had people who took 10 minutes to reach login.

    public final void sendPing() {
        lastPing = System.currentTimeMillis();
        session.write(LoginPacket.getPing());

        Timer.PingTimer.getInstance().schedule(new Runnable() {
            @Override
            public void run() {
                try {
                    if (getLatency() < 0) {
                        disconnect(true, false);
                        if (getSession().isConnected()) {
                            getSession().close(true);
                        }
                    }
                } catch (NullPointerException e) {
                    System.out.println(e.toString());
                }
            }
        }, 900000); // 15mins
    }

what are you on about ? the client sents a ping when it receive a pong..

[Fraysa]

what are you on about ? the client sents a ping when it receive a pong..

Uhhh... what? What are you on about? Does the server ping it's clients, or does the client ping it's server?! Obviously the server has to ping it's client to make sure the connection is still alive. Pong is the response, Ping is the action of pinging.
Anyways, he meant that the client won't respond to your pings if it's loading. It will, though.

[Halcyon]

PING, PONG, PING, PONG, PING, PONG.

OT: With Hawt's cilent, It always takes me a long time to connect, like he said.

[Fraysa]

Well, after looking again the client does not respond on load, what a shame. Although I'm pretty sure Nexon are most likely using what minike mentioned, and ignoring the ping fails until the login screen actually shows up.

Fun fact : Nexon pings their clients approx. every 13.5s on average.

[retep998]

I know from personal experience with my laptop, that because it takes over a minute to load up MapleStory, I cannot connect to either private servers or the official servers. The moment I hit the login screen it immediately shuts down saying I was disconnected.

[SilentThief]

Multo, do you test your code before releasing it?

Agreed @Dynamik

[kevintjuh93]

Indeed, I had the same as Peter. Now what I thought that the opcode that is being sent to the server (which some of you use as AUTO_LOGIN), is some sort of START_ALIVE_ACK.