Better Online Command

[Red Tape]

            String online;
            for (int i = 1; i <= ChannelServer.getAllInstances().size(); i++) {
                online = "[CHANNEL " + i + "] ";
                for (MapleCharacter chr : ChannelServer.getInstance(i).getPlayerStorage().getAllCharacters())
                    online += MapleCharacter.makeMapleReadable(chr.getName()) + ", ";
                player.message(online);
            } 

[MentaL]

[XkelvinchiaX]

Nicely, 1st Post

[Faithless]

Looks nice :) I remember I was searching for this long ago. Well done!

[Emilyx3]

Probably should switch to StringBuilders if your server has a lot of people and this command is made available to normal players.

[SpottedCow]

This isn't better.

[GoldenKevin]

Where's the stringbuilder? It's costly to continually concatenate an immutable string compared to a mutable one.

[Red Tape]

This isn't better.

yes because clearly, the one that only got one channel is better then getting from all channels

[watzmename]

yes because clearly, the one that only got one channel is better then getting from all channels

There was an !onlinew
Shows everyone on each channel.

[Red Tape]

There was an !onlinew
Shows everyone on each channel.

I have never had that ever

[Klay]

Here's my improved version of the Online Command.

if (sp[0].equals("online")) {
    if (sp.length < 2) {
        int connected = 0;

        for (ChannelServer chs : ChannelServer.getAllInstances()) {
            int clients = chs.getPlayerStorage().getAllCharacters().size();
            connected += clients;
            mc.dropMessage(6, "Channel " + chs.getChannel() + " : " + clients);
        }

        mc.dropMessage(6, "Connected clients : " + connected);
    } else {
        int cId = Integer.parseInt(sp[1]);
        ChannelServer chs = ChannelServer.getInstance(cId);

        if (chs != null) {
            Collection<MapleCharacter> ch = new LinkedHashSet<MapleCharacter>(chs.getPlayerStorage().getAllCharacters());
            StringBuilder characters = new StringBuilder();

            for (MapleCharacter cha : ch)
                characters.append(MapleCharacter.makeMapleReadable(cha.getName()) + ", ");

            mc.dropMessage(6, "Channel " + cId + " : " + ch.size());
            mc.dropMessage(6, characters.substring(0, characters.length() - 2));
        } else {
            mc.dropMessage(5, "Channel " + cId + " is offline.");
        }
    }
}