Guild Hideouts

[Lapje]

Hi guys,

My first contribution to the Maple Community, altho it's been partly released already. I did write it from scratch with mainly saveToDB and other saving functions as an example.

In MapleGuild.java add these two functions. Anywhere will do.

    public int getHideout() {
        return hideout;
    }
    
    public void setHideout(int id) {
        this.hideout = id;        
    } 

At the top of the file, look for this:

private int id, gp, logo, logoColor, leader, capacity, logoBG, logoBGColor, signature, allianceId; 

Add hideout to it:

private int id, gp, logo, logoColor, leader, capacity, logoBG, logoBGColor, signature, allianceId, hideout; 

Now in PlayerCommands.java (or w/e you use as player commands file)

        } else if (sub[0].equalsIgnoreCase("hideout")) {
             if (c.getPlayer().getGuildId() == 0) {
                 chr.dropMessage("You are currently not in a guild.");
             } else {
                 int guildId = c.getPlayer().getGuildId();
                 int map = c.getPlayer().getGuild().getHideout();
                 chr.changeMap(cserv.getMapFactory().getMap(map), cserv.getMapFactory().getMap(map).getPortal(0));
             }
         } else if (sub[0].equalsIgnoreCase("sethideout")) {
             if (c.getPlayer().getGuildId() != 0) {
                 if (c.getPlayer().getGuildRank() == 1) {
                     c.getPlayer().getGuild().setHideout(c.getPlayer().getMapId());
                     chr.dropMessage("You have changed your Guilds Hideout.");  
                 } else {
                    chr.dropMessage("You are not allowed to change this Guilds Hideout.");
                 }
             } else {
                 chr.dropMessage("You are currently not in a guild.");
             } 

In MySQL execute this piece of code:

ALTER TABLE `moopledev`.`guilds` ADD COLUMN `hideout` INT(11) NOT NULL DEFAULT 100000000 AFTER `allianceId`;

Where moopledev is your scheme, u should change it to yours.
100000000 is the default map (I have henesys in case the guild leader didn't set a hideout yet).
and allianceId is just the last column on the table, if you don't have it just scroll all the way right and put whatever is the last one there.

Credits to me for most of the stuff, Kevin for the setHideout function and askHugo explaining to me why it's better to have this in MapleGuild.java .
Hope u guys like it =].

[MentaL]

[<ÄrtΣMis>]

Cool release ;D

[mertjuh]

Lmao, I did exactly the same a few weeks ago.

     return 10000;

And why did you do this?

[Lapje]

Lol thanks Adam,

@mertjuh
Yah I know, I stole it from ya =x, No, jokes. I did make this myself ;].

[CodeSomeBS]

I still don't understand why the hideout field is in MapleCharacter.

[Lapje]

I still don't understand why the hideout field is in MapleCharacter.

I guess u're askHugo? I told you, I'm a nub and I don't see why it would matter if it's in MapleGuild. =].

[Expedia]

I guess u're askHugo? I told you, I'm a nub and I don't see why it would matter if it's in MapleGuild. =].

Because it's called a Guild Hideout not a character hideout. If it's in MapleGuild, you'll only have to load the id once not continuously for each character of the guild.

[iRawr]

Because it's called a Guild Hideout not a character hideout. If it's in MapleGuild, you'll only have to load the id once not continuously for each character of the guild.

Yeah, just adding it to MapleGuild would be less work.

But this way it's more "noob-friendly" (imo).
Because people can just add it, instead of editing and spamming posts like "ErRoRz Pl0X ... DUN WoRkZ?!?!?" ;D

So...
Good Job (:

[Lapje]

Because it's called a Guild Hideout not a character hideout. If it's in MapleGuild, you'll only have to load the id once not continuously for each character of the guild.

Mm yah that's what Hugo told me too. Alright, next time I'll do that, but for now I'm staying with this x].
-------------------
Edit: Kk lols, I do know understand what u guys are trying to say. Thanks for that x].

---------- Post added at 10:04 PM ---------- Previous post was at 09:59 PM ----------

Lmao, I did exactly the same a few weeks ago.

     return 10000;

And why did you do this?

In case it could not load from the db o_O. So it'd have a default map to go to. And it needed a return value

[CodeSomeBS]

In case it could not load from the db o_O. So it'd have a default map to go to. And it needed a return value

Edit: Nvm.
And no, I'm not AskHugo.

[Sparrow]

All this is doing is setting a map. What's the point of having a guild hideout?

[Lapje]

Well err, a map for you and your guild alone. It's private and u can easily warp to it. Like it or not, but my players find it awesome o_O.
If you find a nice map it has more value then assigning fm to it >.>

Soz if this does not live up to your expectations, I had quite a hard time getting this working..
-----------
I shouldn't say it's private cause the map is not blocked for other players, but if you choose your map carefully you can find a map that players rarely visit. There are plenty of those map which are great for using as hideouts.

[AskHugo]

I guess u're askHugo? I told you, I'm a nub and I don't see why it would matter if it's in MapleGuild. =].

No he's not me.

First of all, the 'int hideout' at the top of the MapleCharacter is now rendered useless. What's the point of caching it if you're sending queries every time you save and load it anyways?

Secondly, you are sending queries to the database every time a player uses both commands, which isn't really that good for your server. Notice that almost everything is cached (look at loadCharFromDB in MapleCharacter)

Thirdly, it would've been much easier if you had the hideout load and cache once the guild is loaded in MapleGuild, then you could make a function to return that value.


Here, let me fix it up for you.

Delete everything you have to do with hideouts from MapleCharacter.

in MapleGuild:

add:

    private int hideout; 

after:

    private int capacity; 

and:

            hideout = rs.getInt("hideout"); 

after:

            allianceId = rs.getInt("allianceId"); 

add these near the other functions:

    public int getHideout() {
        return hideout;
    }
    
    public void setHideout(int id) {
        hideout = id;        
    } 

in WriteToDB change:

                sql += "capacity = ?, " + "notice = ? WHERE guildid = ?"; 

to

                sql += "capacity = ?, notice = ?, hideout = ? WHERE guildid = ?"; 

and:

                ps.setInt(13, this.id); 

to:

                ps.setInt(14, this.id); 

and before it add:

                ps.setInt(13, hideout); 

Now if you want to set hideouts just to player.getGuild().setHideout(id) and if you want to load just player.getGuild().getHideout()


EDIT: I forgot your commands.

         } else if (sub[0].equalsIgnoreCase("hideout")) {
             if (c.getPlayer().getGuild() == null) {
                 chr.dropMessage("You are currently not in a guild");
             } else {
                 int map = c.getPlayer().getGuild().getHideout(c.getPlayer().getGuildId());
                 chr.changeMap(cserv.getMapFactory().getMap(map), cserv.getMapFactory().getMap(map).getPortal(0)); // you sure you don't have an easier version of changeMap in your source? 
             }
         } else if (sub[0].equalsIgnoreCase("sethideout")) {
             if (c.getPlayer().getGuild() != null) {
                 if (c.getPlayer().getGuildRank() == 1) {
                     c.getPlayer().getGuild().setHideout(c.getPlayer().getMapId());
                     chr.dropMessage("You have changed your guild's hideout");  
                 } else {
                    chr.dropMessage("You are not allowed to change your guild's hideout");
                 }
             } else {
                 chr.dropMessage("You are currently not in a guild");
             } 

[FateJiki]

I thought this was released before in '08. x)

[AskHugo]

I thought this was released before in '08. x)

Look around in the releases section for a page or two and calculate the ratio between new/been done before (Count the new threads, not old bumped ones). It's not going to be very high.