Item Effect's fix (v83)

[King Grub]

Replace your "itemEffect" packet with this:

    public static MaplePacket itemEffect(int characterid, int itemid) {
        MaplePacketLittleEndianWriter mplew = new MaplePacketLittleEndianWriter();
        mplew.writeShort(SendPacketOpcode.SHOW_ITEM_EFFECT.getValue());
        mplew.writeInt(characterid);
        mplew.writeInt(itemid);
        mplew.writeInt(0);
        return mplew.getPacket();
    } 

[MentaL]

[iAkira]

So what is this for like MoopleDev or LocalMS?

[King Grub]

Both, I think. I fixed it for LocalMS-Source.

[HorrorChix89]

Isn't it for all V83 that doesn't have Item Effects?

[King Grub]

Isn't it for all V83 that doesn't have Item Effects?

This is for all V83 sources with wrong "itemEffect" packet.

[HorrorChix89]

That's what I thought. kk

[Buya]

Thanks, the header is 0xc2 right?
And what is this used for? Morphs?

[King Grub]

Thanks, the header is 0xc2 right?
And what is this used for? Morphs?

SHOW_ITEM_EFFECT = 0xB0 

Chair effects, CS effects...etc

[Buya]

SHOW_ITEM_EFFECT = 0xB0 

Chair effects, CS effects...etc

REMOVE_SPECIAL_MAPOBJECT = B0;
I dont think 2 packets can have the same header : )

[kevintjuh93]

What? This is bullshit. The writeInt(0); isn't even used. There was only one fix for the itemEffect and that was in the handler. If you don't believe me, test my source. You will see it is working. I've tested it several times.

[King Grub]

I added it, and it worked -.-'.

[kevintjuh93]

Lol, what happened before? Did the other player crash? No! That's why it isn't a packet issue. Just compare my handler with yours. There was something wrong with the check if it was 0. If I remember it correctly.

[Xerixe]

Seeing how you said the header was 0xB0, there's a huge chance this isn't item effect.
Since 0xB0 is used to removed summons from map.
Unless of course, your headers were wrong and item effects caused you / other people to error which caused you to think that item effects were bugged.

[Buya]

Can anyone please clarify this?
Either the summon or the item effect header is wrong.
(see my previous post)

[Xerixe]

Yea, item effect header is 0xC2. Summon is 0xB0, also, sending a the 0xB0 packet, even if the summon doesn't exist, it won't dc/error anyone. But of course, if the packet isn't complete, ( which explains why he added mplew.writeInt(0); ) it'll dc/error, i think. Not really sure.