[Release] All scrolls work for GM's (OdinMS)

[Sathon]

This is somewhat-tested, so if there is a problem, let me know.

It's four simple modifications that will make it so all scrolls, no matter what %, will work all the time for GM's. I did this because scrolling godly items that there aren't GM scrolls for (eg. Earring Int) was a pain in the ass.

I realize this is a very simple edit, but I consider it a useful one and unexperienced server hosts might not know how to do this without help.

So anyways,

---------------------------------------------------------------------------------------------

In ScrollHandler.java, which is located in net.sf.odinms.net.channel.handler, find these lines:

if (scroll.getQuantity() <= 0) {
throw new InventoryException("<= 0 quantity when scrolling");
}

Below that, add this line:

boolean checkIfGM = c.getPlayer().isGM();

---------------------------------------------------------------------------------------------

In the same file, find this line (right below the edit you just made):

IEquip scrolled = (IEquip) ii.scrollEquipWithId(toScroll, scroll.getItemId());

Change it to this (the modified part is bolded):

IEquip scrolled = (IEquip) ii.scrollEquipWithId(toScroll, scroll.getItemId(), checkIfGM);

---------------------------------------------------------------------------------------------

In MapleItemInformationProvider.java, which is located in net.sf.odinms.server, find this line:

public IItem scrollEquipWithId(IItem equip, int scrollId) {

Change it to this (modified part in bold):

public IItem scrollEquipWithId(IItem equip, int scrollId, boolean checkIfGM) {

---------------------------------------------------------------------------------------------

Also in MapleItemInformationProvider.java, find this line (a couple of lines down):

if (nEquip.getUpgradeSlots() > 0 && Math.ceil(Math.random() * 100.0) <= stats.get("success")) {

Change that to this:

if (nEquip.getUpgradeSlots() > 0 && ((Math.ceil(Math.random() * 100.0) <= stats.get("success")) || (checkIfGM == true))) {

---------------------------------------------------------------------------------------------

That should do it. Like I said, if there is an error somewhere, please let me know.

To get it to work with SeanPack and other newer repacks:
http://forum.ragezone.com/showpost.p...4&postcount=42
(thanks the3l0b)

[MentaL]

[Cuumquat]

Great idea man. Can anyone code this for Rev007 please? Love the idea :D

I did this because scrolling godly items that there aren't GM scrolls for (eg. Earring Int) was a pain in the ass.

I feel the same way lol. Great work.

[iCarot]

Theres a Red circle with a exclamation mark on the line i put this

IEquip scrolled = (IEquip) ii.scrollEquipWithId(toScroll, scroll.getItemId(), checkIfGM);

[crackbaby]

Great idea man. Can anyone code this for Rev007 please? Love the idea :D



I feel the same way lol. Great work.

Java and C++ are way different I don't think that it would work... Plus it's for OdinMS.

[Cuumquat]

I didn't say it would work for C++. and i know its for OdinMS. im asking if anyone can use this kinda as a base, or use this idea, and code this for Rev007. O.o
Where did you get

Java and C++ are way different I don't think that it would work... Plus it's for OdinMS.

from. O.o

[shaun166]

so u mean by adding all this things gm scroll whatever scroll will always pass?

[Cuumquat]

YEs, only for GM's though. As you can see the SCRIPT.

IEquip scrolled = (IEquip) ii.scrollEquipWithId(toScroll, scroll.getItemId(), checkIfGM);

It says, CheckifGM.

[theonendonly]

its not really a pain it takes me usually only 50 white scrolls and i have a perfect one .
its quite easy .

[Cuumquat]

LOL. 50 white scrolls, you know, thats not a pain :P

[crackbaby]

its not really a pain it takes me usually only 50 white scrolls and i have a perfect one .
its quite easy .

Not when you have to use 30% earring scrolls for dex and use them. My hand gets all sore and sometimes 4 of them work on an earring and the last slot BOOM.

[Cuumquat]

Lol? O.o Well yea, it is true, having this is great to have. :D

[theonendonly]

Not when you have to use 30% earring scrolls for dex and use them. My hand gets all sore and sometimes 4 of them work on an earring and the last slot BOOM.

still painless for me
i've done it countless times .
plus its only 5 slots so its not too hard .
patience is key .

[Cuumquat]

some people arnt patient, such as myself :P

[Itachi08]

humm i can't find some of the lines up there.. i looked very closely are you sure its there?
can you upload the edited files please?

[usazn2proforu]

Heyy dam.... if this works Thanks man i hope my server in future if i have one >.> will be happy with tis =P