[Release] Better jail - works even after someone relogs

[WlZET]

In MapleCharacter:

Add this variable:

private int jailtime; 

Add this in loadCharFromDb:

ret.jailtime = rs.getInt("jailtime"); 

Add this with all the other things in saveToDb (I don't feel like showing you how to add...)

jailtime 

Add these methods in MapleCharacter:

    public void setJailTime(int x) {
        this.jailtime = x;
    }

    public int getJailTime() {
        return this.jailtime;
    }

    public boolean inJail() {
        return getMapId() == 200090300;
    }

    public void jail(int minutes) {
        changeMap(200090300, 0);
        this.canTalk = false;
        jailTimeReset();
        setJailTime(minutes);
    }

    public void unJail() {
        if (getMapId() == 200090300) {
            changeMap(100000000, 0);
            this.canTalk = true;
            dropMessage("You have been unjailed");
        }
    }

    public void jailTimeReset() {
        TimerManager.getInstance().schedule(new Runnable() {

            public void run() {
                if (inJail() && getJailTime() > 0) { // If not in Jail Map / do not have any jail time does nothing
                    setJailTime(getJailTime() - 1);
                    dropMessage(5, "One minute has passed. You now have " + getJailTime() + " minutes left to go.");
                    jailTimeReset();
                    if (getJailTime() <= 0) {
                        unJail();
                    }
                }
            }
        }, 1 * 60 * 1000);
    } 

Add this in PlayerLoggedInHandler:

        if (player.inJail() && player.getJailTime() > 0) {
            player.message("You have scheduled jailtime for " + player.getJailTime() + " minutes. You will have to make up for jail-time you have missed if you have log off.");
            player.jailTimeReset();
        } 

Add these commands to temp jail / perm jail:

        } else if (splitted[0].equals("!permjail")) {
            MapleCharacter victim = cserv.getPlayerStorage().getCharacterByName(splitted[1]);
            if (victim != null) {
                victim.jail(-1);
                victim.message("You have been permenently jailed, but your account is not banned. This character will not be available any longer.");
            } else {
                player.message("The player is not in this channel or offline.");
            }

        } else if (splitted[0].equals("!tempjail")) {
            MapleCharacter victim = cserv.getPlayerStorage().getCharacterByName(splitted[1]);
            if (victim != null) {
                if (!splitted[3].equalsIgnoreCase("quiet")) {
                    try {
                        cserv.getWorldInterface().broadcastMessage(player.getName(), MaplePacketCreator.serverNotice(6, ServerConstants.SERVER_NAME + " Jail: " + victim.getName() + " has been jailed for " + splitted[2] + " minutes. Reason: " + StringUtil.joinStringFrom(splitted, 4)).getBytes());
                    } catch (RemoteException e) {
                        c.getChannelServer().reconnectWorld();
                    }
                }
                victim.jail(Integer.parseInt(splitted[2]));
                mc.dropMessage(victim.getName() + " was  temporary jailed! for " + splitted[2] + " minutes.");
                victim.dropMessage(5, "You have been temporary jailed for " + splitted[2] + " minutes. You will have to make up for minutes you have missed if you log off.");
            } else {
                mc.dropMessage(splitted[1] + " not found!");
            } 

[MentaL]

[Soul]

Good job rich :)

[redeemer34]

Its kinda mean that they have to be in-game to take up time, but it's pretty cool otherwise.

[rice]

good job, but if you wanted to do what your title says, just make a Boolean and throw an if then statement into playerloggedinhwndler.
if (player.shouldBeJailed() == true) {
player.warpToJailMap();
}
Posted via Mobile Device

[GoldenKevin]

good job, but if you wanted to do what your title says, just make a Boolean and throw an if then statement into playerloggedinhwndler.
if (player.shouldBeJailed() == true) {
player.warpToJailMap();
}
Posted via Mobile Device

I lol when people use logic like yours. "== true"? Makes the code redundant and slower, because it has to check if the boolean expression is equal to true. "true == true" will return "true" anyway, so why do something like that?

[GoldenKevin]

good job, but if you wanted to do what your title says, just make a Boolean and throw an if then statement into playerloggedinhwndler.
if (player.shouldBeJailed() == true) {
player.warpToJailMap();
}
Posted via Mobile Device

I lol when people use logic like yours. "== true"? Makes the code redundant and slower, because it has to check if the boolean expression is equal to true. "true == true" will return "true" anyway, so why do something like that?

[WlZET]

I lol when people use logic like yours. "== true"? Makes the code redundant and slower, because it has to check if the boolean expression is equal to true. "true == true" will return "true" anyway, so why do something like that?

lol double post

[blawgwarmzz]

good job, but if you wanted to do what your title says, just make a Boolean and throw an if then statement into playerloggedinhwndler.
if (player.shouldBeJailed() == true) {
player.warpToJailMap();
}
Posted via Mobile Device

goldenkevin tells the truth but theres more to it

that wouldn't work because they'd only be warped to the jailmap and jailtime wouldnt reset, making them trapped there (problems with old jail were the same). The way rich did is the way that works. and therefore your statement makes no sense, if he wanted to do what the title says he'd do anything but that

[Emilyx3]

I see a mem leak:

public void jailTimeReset() {
        TimerManager.getInstance().schedule(new Runnable() {

            public void run() {
                if (inJail() && getJailTime() > 0) { // If not in Jail Map / do not have any jail time does nothing
                    setJailTime(getJailTime() - 1);
                    dropMessage(5, "One minute has passed. You now have " + getJailTime() + " minutes left to go.");
                    jailTimeReset();
                    if (getJailTime() <= 0) {
                        unJail();
                    }
                }
            }
        }, 1 * 60 * 1000);
    }

Use this enough times or if jailed people relog enough times and you'll have tons of scheduled
"if (inJail() && getJailTime() > 0)" checks, that wind up doing nothing anyway.

Also, for !permjail, you forgot to include jailTheNoob() in MapleCharacter.java.

[PinkGatsby]

I lol when people use logic like yours. "== true"? Makes the code redundant and slower, because it has to check if the boolean expression is equal to true. "true == true" will return "true" anyway, so why do something like that?

You're too focused on performance, the difference would probably be less than a thousandth of a microsecond. If it makes it easier for the developer then he/she should continue using '== true/false'.

[Sparrow]

In MapleCharacter:

Add this variable:

private int jailtime; 

Add this in loadCharFromDb:

ret.jailtime = rs.getInt("jailtime"); 

Add this with all the other things in saveToDb (I don't feel like showing you how to add...)

jailtime 

Add these methods in MapleCharacter:

    public void setJailTime(int x) {
        this.jailtime = x;
    }

    public int getJailTime() {
        return this.jailtime;
    }

    public boolean inJail() {
        return getMapId() == 200090300;
    }

    public void jail(int minutes) {
        changeMap(200090300, 0);
        this.canTalk = false;
        jailTimeReset();
        setJailTime(minutes);
    }

    public void unJail() {
        if (getMapId() == 200090300) {
            changeMap(100000000, 0);
            this.canTalk = true;
            dropMessage("You have been unjailed");
        }
    }

    public void jailTimeReset() {
        TimerManager.getInstance().schedule(new Runnable() {

            public void run() {
                if (inJail() && getJailTime() > 0) { // If not in Jail Map / do not have any jail time does nothing
                    setJailTime(getJailTime() - 1);
                    dropMessage(5, "One minute has passed. You now have " + getJailTime() + " minutes left to go.");
                    jailTimeReset();
                    if (getJailTime() <= 0) {
                        unJail();
                    }
                }
            }
        }, 1 * 60 * 1000);
    } 

Add this in PlayerLoggedInHandler:

        if (player.inJail() && player.getJailTime() > 0) {
            player.message("You have scheduled jailtime for " + player.getJailTime() + " minutes. You will have to make up for jail-time you have missed if you have log off.");
            player.jailTimeReset();
        } 

Add these commands to temp jail / perm jail:

        } else if (splitted[0].equals("!permjail")) {
            MapleCharacter victim = cserv.getPlayerStorage().getCharacterByName(splitted[1]);
            if (victim != null) {
                victim.jailTheNoob(-1);
                victim.message("You have been permenently jailed, but your account is not banned. This character will not be available any longer.");
            } else {
                player.message("The player is not in this channel or offline.");
            }

        } else if (splitted[0].equals("!tempjail")) {
            MapleCharacter victim = cserv.getPlayerStorage().getCharacterByName(splitted[1]);
            if (victim != null) {
                if (!splitted[3].equalsIgnoreCase("quiet")) {
                    try {
                        cserv.getWorldInterface().broadcastMessage(player.getName(), MaplePacketCreator.serverNotice(6, ServerConstants.SERVER_NAME + " Jail: " + victim.getName() + " has been jailed for " + splitted[2] + " minutes. Reason: " + StringUtil.joinStringFrom(splitted, 4)).getBytes());
                    } catch (RemoteException e) {
                        c.getChannelServer().reconnectWorld();
                    }
                }
                victim.jail(Integer.parseInt(splitted[2]));
                mc.dropMessage(victim.getName() + " was  temporary jailed! for " + splitted[2] + " minutes.");
                victim.dropMessage(5, "You have been temporary jailed for " + splitted[2] + " minutes. You will have to make up for minutes you have missed if you log off.");
            } else {
                mc.dropMessage(splitted[1] + " not found!");
            } 

Nice Job :) Btw, the Trade and Cash button are disabled right?

[WlZET]

Nice Job :) Btw, the Trade and Cash button are disabled right?

The map I used already has them disabled.

[rice]

Nice Job :) Btw, the Trade and Cash button are disabled right?

I hate it when you people quote the whole damn release.

[waijoobenmi]

I hate it when you people quote the whole damn release.

Who cares what you hate, idiot.

[mariokiller64]

Yeah, where is the Jailthenoob function...

[WlZET]

Yeah, where is the Jailthenoob function...

Use the "jail" function.

[kevintjuh93]

You're too focused on performance, the difference would probably be less than a thousandth of a microsecond. If it makes it easier for the developer then he/she should continue using '== true/false'.

It still counts and anyways what is so hard about:
if (shouldBeJailed) {
}
or
if (!shouldBeJailed) {
}

[PinkGatsby]

It still counts and anyways what is so hard about:
if (shouldBeJailed) {
}
or
if (!shouldBeJailed) {
}

Did you not understand the last point I made ?

[Shawn]

Who cares what you hate, idiot.

I do o.0

[tonynguyenpro]

nice job

[WlZET]

It still counts and anyways what is so hard about:
if (shouldBeJailed) {
}
or
if (!shouldBeJailed) {
}

They won't get out anyway so it doesn't matter..

[.:LastBreath:.]

Nice release