[Release] Clone system

[Traitor]

Have fun, report all errors.

In all files you edit add:

import net.sf.odinms.server.maps.FakeCharacter;

In MapleCharacter change:

private MapleCharacter() {

to

public MapleCharacter() {

and add:

private List<FakeCharacter> fakes = new ArrayList<FakeCharacter>();
    
    public boolean isfake = false;

and

public void setID(int id){
     this.id = id;
    }
    
    public void setJob(int job){
        this.job = MapleJob.getById(job);
    }
    
    public void setInventory(MapleInventoryType type, MapleInventory inv) {
        inventory[type.ordinal()] = inv;
    }

    public boolean hasFakeChar()
    {
        for (FakeCharacter ch : fakes) {
            if(ch != null)
                return true;
        }
        return false;
    }
    
    public List<FakeCharacter> getFakeChars()
    {
        return fakes;
    }
    
    public void addFakeChar(FakeCharacter f)
    {
       fakes.add(f);
    }

In net.sf.odinms.server.maps add FakeCharacter.java

package net.sf.odinms.server.maps;

import net.sf.odinms.client.IItem;
import net.sf.odinms.client.MapleCharacter;
import net.sf.odinms.client.MapleInventoryType;

/**
 *
 * @author Patrick/PurpleMadness
 */
public class FakeCharacter {
    private MapleCharacter ch;
    
    public FakeCharacter(MapleCharacter player, int id)
    {
        MapleCharacter fakechr = new MapleCharacter();
        fakechr.setHair(player.getHair());
        fakechr.setFace(player.getFace());
        fakechr.setSkinColor(player.getSkinColor());
        fakechr.setName(player.getName());
        fakechr.setID(id + 100000);
        fakechr.setLevel(player.getLevel());
        fakechr.setJob(player.getJob().getId());
        fakechr.setMap(player.getMap());
        fakechr.setPosition(player.getPosition());
        fakechr.silentGiveBuffs(player.getAllBuffs());
        
        for(IItem equip : player.getInventory(MapleInventoryType.EQUIPPED)){
            fakechr.getInventory(MapleInventoryType.EQUIPPED).addFromDB(equip);
        }
        
        fakechr.isfake = true;
        
        player.getMap().addBotPlayer(fakechr);
        
        ch = fakechr;
    }
    
    public MapleCharacter getFakeChar()
    {
        return ch;
    }
}

In MapleMap.java add:

/**
     * Adds a player to this map and sends nescessary data
     *
     * @param chr
     */
    public void addBotPlayer(MapleCharacter chr) {
        //log.warn("[dc] [level2] Player {} enters map {}", new Object[] { chr.getName(), mapid });
        synchronized (characters) {
            this.characters.add(chr);
        }
        synchronized (this.mapobjects) {
            if (!chr.isHidden()) {
                broadcastMessage(chr, (MaplePacketCreator.spawnPlayerMapobject(chr)), false);
                /*MaplePet[] pets = chr.getPets();
                for (int i = 0; i < 3; i++) {
                    if (pets[i] != null) {
                        broadcastMessage(chr, MaplePacketCreator.showPet(chr, pets[i], false, false), false);
                    }
                }*/
            }
            this.mapobjects.put(Integer.valueOf(chr.getObjectId()), chr);
        }
    }

In MapleMap.java change:

if (chr.getPosition().distanceSq(mapobject.getPosition()) <= MapleCharacter.MAX_VIEW_RANGE_SQ) {

to

if (chr.getPosition().distanceSq(mapobject.getPosition()) <= MapleCharacter.MAX_VIEW_RANGE_SQ && !chr.isfake) {

and

private void broadcastMessage(MapleCharacter source, MaplePacket packet, double rangeSq, Point rangedFrom) {
        synchronized (characters) {
            for (MapleCharacter chr : characters) {
                if (chr != source) {

to

private void broadcastMessage(MapleCharacter source, MaplePacket packet, double rangeSq, Point rangedFrom) {
        synchronized (characters) {
            for (MapleCharacter chr : characters) {
                if (chr != source && !chr.isfake) {

and

private void updateMapObjectVisibility(MapleCharacter chr, MapleMapObject mo) {

to

private void updateMapObjectVisibility(MapleCharacter chr, MapleMapObject mo) {
        if(chr.isfake)
            return;

and

public void movePlayer(MapleCharacter player, Point newPosition) {
        player.setPosition(newPosition);

to

public void movePlayer(MapleCharacter player, Point newPosition) {
        player.setPosition(newPosition);
        if(player.isfake)
            return;

In MovePlayerHandler.java add

if(c.getPlayer().hasFakeChar())
                        {
                            int i = 1;
                            for (final FakeCharacter ch : c.getPlayer().getFakeChars()) {
                                ScheduledFuture<?> scheduleRemove = TimerManager.getInstance().schedule(new Runnable() {
                                    @Override
                                    public void run() {
                                        MaplePacket packet = MaplePacketCreator.movePlayer(ch.getFakeChar().getId(), res);
                                        ch.getFakeChar().getMap().broadcastMessage(ch.getFakeChar(), packet, false);
                                        updatePosition (res, ch.getFakeChar(), 0);
                                        ch.getFakeChar().getMap().movePlayer(ch.getFakeChar(), ch.getFakeChar().getPosition());
                                    }
                                }, i * 300);
                                i++;
                            }
                        }

after

c.getPlayer().getMap().movePlayer(c.getPlayer(), c.getPlayer().getPosition());

Add

import net.sf.odinms.server.TimerManager;
import java.util.concurrent.ScheduledFuture;

and change:

List<LifeMovementFragment> res = parseMovement(slea);

to

final List<LifeMovementFragment> res = parseMovement(slea);

In MapleClient.java add

if(chr.hasFakeChar())
                    {
                        for (FakeCharacter ch : chr.getFakeChars()) {
                            ch.getFakeChar().getMap().removePlayer(ch.getFakeChar());
                        }
                    }

after

public void disconnect() {
        // pingTask.cancel(true);
        MapleCharacter chr = this.getPlayer();
        if (chr != null && isLoggedIn()) {

In CloseRangeDamageHandler add

if(c.getPlayer().hasFakeChar())
                {
                    for (FakeCharacter ch : c.getPlayer().getFakeChars()) {
                        MaplePacket packett = MaplePacketCreator.closeRangeAttack(ch.getFakeChar().getId(), attack.skill, attack.stance,
            attack.numAttackedAndDamage, attack.allDamage, attack.speed);
                        player.getMap().broadcastMessage(ch.getFakeChar(), packett, false, true);
                        applyAttack(attack, ch.getFakeChar(), maxdamage, attackCount);
                    }
                }

after

applyAttack(attack, player, maxdamage, attackCount);

In FacialExpressionHandler.java add

for (FakeCharacter ch : c.getPlayer().getFakeChars()) {
                    c.getPlayer().getMap().broadcastMessage(ch.getFakeChar(), MaplePacketCreator.facialExpression(ch.getFakeChar(), emote), false);
                }

after

c.getPlayer().getMap().broadcastMessage(c.getPlayer(), MaplePacketCreator.facialExpression(c.getPlayer(), emote), false);

In MapleMonster.java change:

@Override
	public void sendSpawnData(MapleClient client) {
		if (!isAlive()) {
			return;
		}

to

@Override
	public void sendSpawnData(MapleClient client) {
		if (!isAlive() || client.getPlayer().isfake) {
			return;
		}

in maplecharacter.java
add:

if(hasFakeChar())
        {
            for (FakeCharacter ch : getFakeChars()) {
                ch.getFakeChar().getMap().removePlayer(ch.getFakeChar());
            }
        }

before

getClient().getSession().write(warpPacket);

Here's the command:

else if (splitted[0].equals("!fakechar")) {
                    for(int i = 0; i < getOptionalIntArg(splitted, 1, 1); i++)
                    {
                        FakeCharacter fc = new FakeCharacter(c.getPlayer(), c.getPlayer().getId() + c.getPlayer().getFakeChars().size() + 1);
                        c.getPlayer().addFakeChar(fc);
                    }
                    mc.dropMessage("Please move around for it to take effect.");
                }

and that should give you a basic clone.
if there's an error, just reply and I should be able to help.
edit:
forgot to say, lol flam at wil!
edit:
Forgot to add, thanks to PurpleMadness for his FakeCharacter.java that I edited.

[MentaL]

[EspadaFung]

LOL i love this, thanks dude :D

is this similar to alcove's? or even better?

[Traitor]

It's similar.
Alcove's is more complete (And better!), I just quit on this because it wasn't worth continuing it.
edit:
Forgot to mention, everything else is easy to add yourself.

[chuayaowei]

Thanks dude.

[OmgItsParm]

looks nice

good job on it

[kanters]

<3 all i have to say xD !

[JdeeCanada]

This is perfect. I love you.

[Traitor]

Also, I recommend to not spawn 600+, it gets really laggy,

[Darkz111]

O.o thx for this realease...i love it =D

[terens]

i got this error : Any Fixes?

C:\Documents and Settings\T ' ce\My Documents\RenzMs Pack\Ems Repack\Ems Repack\src\net\sf\odinms\net\channel\handler\CloseRangeDamageHandler.java:148: cannot find symbol
symbol : variable speed
location: class net.sf.odinms.net.channel.handler.AbstractDealDamageHandler.AttackInfo
attack.numAttackedAndDamage, attack.allDamage, attack.speed);
C:\Documents and Settings\T ' ce\My Documents\RenzMs Pack\Ems Repack\Ems Repack\src\net\sf\odinms\net\channel\handler\MovePlayerHandler.java:73: cannot find symbol
symbol : class ScheduledFuture
location: class net.sf.odinms.net.channel.handler.MovePlayerHandler
ScheduledFuture<?> scheduleRemove = TimerManager.getInstance().schedule(new Runnable() {
C:\Documents and Settings\T ' ce\My Documents\RenzMs Pack\Ems Repack\Ems Repack\src\net\sf\odinms\server\maps\FakeCharacter.java:16: MapleCharacter() has private access in net.sf.odinms.client.MapleCharacter
MapleCharacter fakechr = new MapleCharacter();
C:\Documents and Settings\T ' ce\My Documents\RenzMs Pack\Ems Repack\Ems Repack\src\net\sf\odinms\server\maps\FakeCharacter.java:21: cannot find symbol
symbol : method setID(int)
location: class net.sf.odinms.client.MapleCharacter
fakechr.setID(id + 100000);
C:\Documents and Settings\T ' ce\My Documents\RenzMs Pack\Ems Repack\Ems Repack\src\net\sf\odinms\server\maps\FakeCharacter.java:23: cannot find symbol
symbol : method setJob(int)
location: class net.sf.odinms.client.MapleCharacter
fakechr.setJob(player.getJob().getId());
C:\Documents and Settings\T ' ce\My Documents\RenzMs Pack\Ems Repack\Ems Repack\src\net\sf\odinms\server\maps\FakeCharacter.java:26: cannot find symbol
symbol : method getAllBuffs()
location: class net.sf.odinms.client.MapleCharacter
fakechr.silentGiveBuffs(player.getAllBuffs());
6 errors
BUILD FAILED (total time: 1 second)

[lxCrAzYsEl]

You nid a command to spawn it ? O.O

[terens]

Yes. This command = !fakechar

[SkillzMS]

should i use this one or the one already released

[JdeeCanada]

GetFakeChars?

init:
deps-jar:
Compiling 242 source files to C:\Users\Johann\Desktop\Repack\build\classes
C:\Users\Johann\Desktop\Repack\Repack\src\net\sf\odinms\provider\xmlwz\FileStoredPngMapleCanvas.java:14: warning: com.sun.imageio.plugins.png.PNGImageReaderSpi is Sun proprietary API and may be removed in a future release
import com.sun.imageio.plugins.png.PNGImageReaderSpi;
C:\Users\Johann\Desktop\Repack\Repack\src\net\sf\odinms\client\messages\CommandProcessor.java:1219: cannot find symbol
symbol  : method getFakeChars()
location: class net.sf.odinms.client.MapleCharacter
                        FakeCharacter fc = new FakeCharacter(c.getPlayer(), c.getPlayer().getId() + c.getPlayer().getFakeChars().size() + 1);
C:\Users\Johann\Desktop\Repack\Repack\src\net\sf\odinms\client\messages\CommandProcessor.java:1219: operator + cannot be applied to int,net.sf.odinms.client.MapleCharacter.getFakeChars.size
                        FakeCharacter fc = new FakeCharacter(c.getPlayer(), c.getPlayer().getId() + c.getPlayer().getFakeChars().size() + 1);
C:\Users\Johann\Desktop\Repack\Repack\src\net\sf\odinms\client\messages\CommandProcessor.java:1219: operator + cannot be applied to <nulltype>,int
                        FakeCharacter fc = new FakeCharacter(c.getPlayer(), c.getPlayer().getId() + c.getPlayer().getFakeChars().size() + 1);
C:\Users\Johann\Desktop\Repack\Repack\src\net\sf\odinms\client\messages\CommandProcessor.java:1219: cannot find symbol
symbol  : constructor FakeCharacter(net.sf.odinms.client.MapleCharacter,<nulltype>)
location: class net.sf.odinms.server.maps.FakeCharacter
                        FakeCharacter fc = new FakeCharacter(c.getPlayer(), c.getPlayer().getId() + c.getPlayer().getFakeChars().size() + 1);
C:\Users\Johann\Desktop\Repack\Repack\src\net\sf\odinms\client\messages\CommandProcessor.java:1220: cannot find symbol
symbol  : method addFakeChar(net.sf.odinms.server.maps.FakeCharacter)
location: class net.sf.odinms.client.MapleCharacter
                        c.getPlayer().addFakeChar(fc);
C:\Users\Johann\Desktop\Repack\Repack\src\net\sf\odinms\client\messages\CommandProcessor.java:2330: cannot find symbol
symbol  : method showFakeDamage(net.sf.odinms.client.MapleCharacter,java.awt.Point,int,int,int)
location: class net.sf.odinms.server.maps.FakeCharacter
                                    FakeCharacter.showFakeDamage(c.getPlayer(), pos, 133333337, monster.getObjectId(), nummobs);
C:\Users\Johann\Desktop\Repack\Repack\src\net\sf\odinms\net\channel\handler\CloseRangeDamageHandler.java:142: cannot find symbol
symbol  : method hasFakeChar()
location: class net.sf.odinms.client.MapleCharacter
if(c.getPlayer().hasFakeChar())
C:\Users\Johann\Desktop\Repack\Repack\src\net\sf\odinms\net\channel\handler\CloseRangeDamageHandler.java:144: cannot find symbol
symbol  : method getFakeChars()
location: class net.sf.odinms.client.MapleCharacter
                    for (FakeCharacter ch : c.getPlayer().getFakeChars()) {
C:\Users\Johann\Desktop\Repack\Repack\src\net\sf\odinms\net\channel\handler\CloseRangeDamageHandler.java:146: cannot find symbol
symbol  : variable speed
location: class net.sf.odinms.net.channel.handler.AbstractDealDamageHandler.AttackInfo
            attack.numAttackedAndDamage, attack.allDamage, attack.speed);
C:\Users\Johann\Desktop\Repack\Repack\src\net\sf\odinms\net\channel\handler\FaceExpressionHandler.java:54: cannot find symbol
symbol  : method getFakeChars()
location: class net.sf.odinms.client.MapleCharacter
for (FakeCharacter ch : c.getPlayer().getFakeChars()) {
C:\Users\Johann\Desktop\Repack\Repack\src\net\sf\odinms\net\channel\handler\MovePlayerHandler.java:66: cannot find symbol
symbol  : method hasFakeChar()
location: class net.sf.odinms.client.MapleCharacter
if(c.getPlayer().hasFakeChar())
C:\Users\Johann\Desktop\Repack\Repack\src\net\sf\odinms\net\channel\handler\MovePlayerHandler.java:69: cannot find symbol
symbol  : method getFakeChars()
location: class net.sf.odinms.client.MapleCharacter
                            for (final FakeCharacter ch : c.getPlayer().getFakeChars()) {
C:\Users\Johann\Desktop\Repack\Repack\src\net\sf\odinms\net\channel\handler\MovePlayerHandler.java:70: cannot find symbol
symbol  : class ScheduledFuture
location: class net.sf.odinms.net.channel.handler.MovePlayerHandler
                                ScheduledFuture<?> scheduleRemove = TimerManager.getInstance().schedule(new Runnable() {
C:\Users\Johann\Desktop\Repack\Repack\src\net\sf\odinms\provider\xmlwz\FileStoredPngMapleCanvas.java:47: warning: com.sun.imageio.plugins.png.PNGImageReaderSpi is Sun proprietary API and may be removed in a future release
                        ImageReaderSpi readerSpi = iioRegistry.getServiceProviderByClass(PNGImageReaderSpi.class);
                                                                                         ^
C:\Users\Johann\Desktop\Repack\Repack\src\net\sf\odinms\server\maps\FakeCharacter.java:32: cannot find symbol
symbol  : variable isfake
location: class net.sf.odinms.client.MapleCharacter
        fakechr.isfake = true;
C:\Users\Johann\Desktop\Repack\Repack\src\net\sf\odinms\server\maps\FakeCharacter.java:34: cannot find symbol
symbol  : method addBotPlayer(net.sf.odinms.client.MapleCharacter)
location: class net.sf.odinms.server.maps.MapleMap
        player.getMap().addBotPlayer(fakechr);
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
15 errors
2 warnings
BUILD FAILED (total time: 7 seconds)

:P

Also, is this important?

fakechr.silentGiveBuffs(player.getAllBuffs());

Cause I don't have PlayerValueBuff thing, or whatever.

[SaintsIan]

yea, alcove's one is more advance and uniqque but this is a good base starter to dev on for people that dont have their hands on one and its good :D nice release.

[lxCrAzYsEl]

Seems like thr is alot of errors in the bat files.
And its causing accounts stuck and map object dun spawn properly O.O

Nice release anyway !

[c325sA]

You forgot to add import fakecharacter in almost all the files..



edit :
and you also forgot to add this import :
import java.util.concurrent.ScheduledFuture;

in MovePlayerHandler. java

and thank for the release!
this is awesome

[JdeeCanada]

How bout getFakeChars?

[jasontjakra]

can some1 explain this to me?

[keane6]

Nice release x)
Lol at the don't spawn 600+ ;P

[shadowerr]

Does the clone talk or something?

[blac2002]

Nice release !

but...

in MapleCharacter.java
error has been identified.

--------------------------------------------------
public boolean hasFakeChar() {
for (FakeCharacter ch : fakes) {
if(ch != null)
return true;
}
return false;
}
---------------------------------------------------

Other relation methods are not enough...

Thank you for reading!

[Miwi]

I hate it when it doesnt complie... it will say the same thing as above...

[Traitor]

well,what's the error?

[Evilsinxd]

if use clone then press !map commands your char will stuck you will saw nothing on map mean npc... you must relog after that