[Release]Fix Login Hack

[iPhantom]

Coded by reakw0n from CEF. I posted it here because this will stop those hackers fucking other ones' accounts.

Open up your MySQLM.cpp and add this function:

int MySQL::checkChar(int charid){
   MYSQL_RES *mres;
   MYSQL_ROW mrow;
   char query[255];
    sprintf_s(query, 255, "select userid from characters where ID='%d';", charid);
   mysql_real_query(&maple_db, query, strlen(query));
   printf(mysql_error(&maple_db));
   mres = mysql_store_result(&MySQL::maple_db);
   mrow = mysql_fetch_row(mres);
   printf(mysql_error(&maple_db));
   int ret = 0;
   printf(mysql_error(&maple_db));
   if(mysql_num_fields(mres) > 0){
      string mr = string((char*)mrow[0]);
      istringstream buffer(mr);
      buffer >> ret;
   }
   return ret;
}

Now open MySQLM.h and add this line:

static int checkChar(int charid);

Now open Characters.cpp and replace your "Characters::connectGame" function with mine:

void Characters::connectGame(PlayerLogin* player, unsigned char *packet){
    int charid = getInt(packet);
    if(MySQL::checkChar(charid) != player->getUserid())
        return;    
    bool check=false;
    int ids[3];
    int num = player->getIDs(ids);
    for(int i=0; i<num; i++){
        if(ids[i] == charid){
            check=true;
            break;
        }
    }
    if(!check){
        // hacking
        return;
    }
    LoginPacket::connectIP(player, charid);
}

Done!

[MentaL]

[Cruceo]

I created a much shorter fix to this............. HERE

[xnBlaze]

I think advertising other websites aren't allowed Cruceo.

[SneakyMS]

Cruceo theres nothing on that FORUM. Stop advertising

[SneakyMS]

Also thanks for this sorry for the double post.

[Innovative]

------ Build started: Project: MapleStoryServer, Configuration: Debug Win32 ------
Compiling...
Characters.cpp
c:\documents and settings\chris wong\desktop\khaosms\maplestoryserver\characters.cpp(163) : error C2039: 'getIDs' : is not a member of 'PlayerLogin'
c:\documents and settings\chris wong\desktop\khaosms\maplestoryserver\playerlogin.h(7) : see declaration of 'PlayerLogin'
Build log was saved at "file://c:\Documents and Settings\Chris Wong\Desktop\KhaosMS\MapleStoryServer\Debug\BuildLog.htm"
MapleStoryServer - 1 error(s), 0 warning(s)
========== Build: 0 succeeded, 1 failed, 2 up-to-date, 0 skipped ==========

Yes i have tried...

[ups2000ups]

I think advertising other websites aren't allowed Cruceo.

spam isent allowed eighter

[xBlackLabel]

#include "MySQLM.h"
#include "playerlogin.h"

make sure those are there in chars.cpp which they should be already but thats all I can help without adding this to my server.

[Innovative]

Both are in the includes =\

[oot3000]

Yes i have tried...

Me too. >.<

[xBlackLabel]

chars.h? lol, usually those are are by not including files but thats just what I think.

[npmaple]

what is this does?

[ralazo]

thanks works good for me
------ Build started: Project: MapleStoryServer, Configuration: Debug Win32 ------
Compiling...
Characters.cpp
Build log was saved at "file://c:\Maplelive\MapleStoryServer\MapleStoryServer\Debug\BuildLog.htm"
MapleStoryServer - 0 error(s), 0 warning(s)
========== Build: 1 succeeded, 0 failed, 0 up-to-date, 0 skipped ==========

[Innovative]

Then what did i do wrong? ._.

[lukyjay]

what is this does?

If you send a packet to the server it lets you login to the account last logged in (sometimes a GM account) and you have full access. Very big security issue, this is a fix to address this.

[shlomivman]

I get error same as Innovative got ,followed the steps and 100% I did all correct.

[iPhantom]

Are you guys using Rev007 or Rev008?.

[shlomivman]

I Use v7

[jjaim]

rev 007 and some files from 8 :]

[Cruceo]

Fine, don't listen to me... A simpler fix is there in that link I gave you. If you don't want to go there and fix the 16 00, 18 00, and crash packet issues, that's fine with me...

If you want them, go ahead and look. They're there.

[Zaser]

It works fine. compailed without an error :)

ty for the release keep up the good releases :)

[Whymes]

Try this to fix your error:

void Characters::connectGame(PlayerLogin* player, unsigned char *packet){
   int charid = getInt(packet);
      if(MySQL::checkChar(charid) != player->getUserid())
            return;
   LoginPacket::connectIP(player, charid);
}

Might want to edit the post.. this works on v7 but you must use the code i posted, reakwon said so on CEF,

[Dinosauru]

coo.thx

[Cruceo]

Try this to fix your error:

void Characters::connectGame(PlayerLogin* player, unsigned char *packet){
   int charid = getInt(packet);
      if(MySQL::checkChar(charid) != player->getUserid())
            return;
   LoginPacket::connectIP(player, charid);
}

Might want to edit the post.. this works on v7 but you must use the code i posted, reakwon said so on CEF,

LMAO that's the fix I created and posted on my site ahahahaha

[Gippo]

MySQLM.cpp
.\MySQLM.cpp(255) : warning C4101: 'mres' : unreferenced local variable
.\MySQLM.cpp(256) : warning C4101: 'mrow' : unreferenced local variable
.\MySQLM.cpp(271) : warning C4244: 'initializing' : conversion from 'my_ulonglong' to 'int', possible loss of data
.\MySQLM.cpp(291) : warning C4244: 'initializing' : conversion from 'my_ulonglong' to 'int', possible loss of data
Player.cpp

Help