[Release]Holy Symbol - Rev 7 - Working Version (Normal + GM)

[Ruezu]

I might as well release mine since I got it working perfectly.

Skills.ccp

  else if(strcmp(name, "end2311003") == 0) Skills::end2311003(player); // Holy Symbol
        else if(strcmp(name, "end5101002") == 0) Skills::end5101002(player); // GM Holy Symbol

            else if(skillid == 2311003){ // Holy Symbol
        timer->stop(player, "end2311003");
        end2311003(player);
    }
            else if(skillid == 5101002){ // GM Holy Symbol
        timer->stop(player, "end5101002");
        end5101002(player);
    }

                else if(skillid == 2311003){  // Holy Symbol
        timer->stop(player, "end2311003");
        vals.push_back(skills[skillid][level].x);
        SkillsPacket::useSkill(player, Maps::info[player->getMap()].Players , skillid, skills[skillid][level].time*1000, 0, 0, 0, (char) 0x1, 0, 0, 0, 0, vals,  1);
        timer->setSkillTimer(player, "end2311003", skills[skillid][level].time*1000);
                player->setHS(true);
    }
                else if(skillid == 5101002){ // GM Holy Symbol
        vals.push_back(50);
		for (unsigned int x=0; x<Maps::info[player->getMap()].Players.size(); x++){
        SkillsPacket::useSkill(Maps::info[player->getMap()].Players[x], Maps::info[player->getMap()].Players, skillid, 1800*1000, 0, 0, 0, (char) 0x1, 0, 0, 0, 0, vals,  1);
        Player *curplayer = Maps::info[player->getMap()].Players[x];
		curplayer->setGHS(true);
		timer->setSkillTimer(Maps::info[player->getMap()].Players[x], "end5101002", 1800*1000);
		}
    }

void Skills::end2311003(Player* player){ // Holy Symbol
    SkillsPacket::endSkill(player, Maps::info[player->getMap()].Players, 0, 0, 0, (char)0x1, 0, 0, 0, 0, 1);
        player->setHS(false);
}
void Skills::end5101002(Player* player){ // GM Holy Symbol
    SkillsPacket::endSkill(player, Maps::info[player->getMap()].Players, 0, 0, 0, (char)0x1, 0, 0, 0, 0, 1);
        player->setGHS(false);
}

Mobs.ccp

Find:
Levels::giveEXP(player, mobinfo[mob->getMobID()].exp);

Replace:
    float hsrate = 0;
    float exprate2 = 0;
        if (player->getHS() == true) {
        hsrate = Skills::skills[2311003][player->skills->getSkillLevel(2311003)].x;
    }
        
                else if (player->getGHS() == true) {
        hsrate = 50;

    }

                            exprate2 = 1+(hsrate/100);
Levels::giveEXP(player, mobinfo[mob->getMobID()].exp * exprate2);

or for those of you who have the int EXPRATE at the top.

    float hsrate = 0;
    float exprate2 = 0;
        if (player->getHS() == true) {
        hsrate = Skills::skills[2311003][player->skills->getSkillLevel(2311003)].x;
    }
        
                else if (player->getGHS() == true) {
        hsrate = 50;

    }

                            exprate2 = 1+(hsrate/100);
    Levels::giveEXP(player, mobinfo[mob->getMobID()].exp * EXPRATE * exprate2);

Skills.h

    static void end2311003(Player* player); // Holy Symbol
        static void end5101002(Player* player); // GM Holy Symbol

Player.h

Player ()

        holysymbol=false;
        gholysymbol=false;

Public:

        bool getHS() {
        return holysymbol;
    }
    void setHS(bool holysymbol) {
        this->holysymbol = holysymbol;
    } 
        bool getGHS() {
        return gholysymbol;
    }
    void setGHS(bool gholysymbol) {
        this->gholysymbol = gholysymbol;
    }

Private:

      bool gholysymbol;
            bool holysymbol;

Credits: Doyos and LeoDirk

Ja Ne~

[MentaL]

[Krytical]

Then where are the getHS and getGHS coming from?

[DarkVenom2]

This wonnot work ! I just try it ~~

[Ruezu]

Woops, I forgot some important stuff, editted.

[Krytical]

Now how are you going to get all players affected?
...................

		for (unsigned int x=0; x<Maps::info[player->getMap()].Players.size(); x++) {
        SkillsPacket::useSkill(Maps::info[player->getMap()].Players[x], Maps::info[player->getMap()].Players, skillid, 1800*1000, 0, 0, 0, (char) 0x1, 0, 0, 0, 0, vals,  1);
        timer->setSkillTimer(Maps::info[player->getMap()].Players[x], "end5101002", 1800*1000);
                player->setGHS(true);
		}
    }

[Ruezu]

Now how are you going to get all players affected?

They already are affected...X_X? when you Super GM HS.

Edit: I already put that code in on my 1st edit with all the stuff.

[Krytical]

No, you still have it wrong
I doubt you tested it with a lot of ppl i currently doing it with my live test as we speak

[Ruezu]

Work on my server...maybe I didn't write something here...I'll check.

Edit: Yeah, I didn't write a line correctly...I did code on my home computer
Then had to retype the code here at cafe from memory o.O

Thank Q very much - Ari~

[DarkZero88]

hmm your code are messed up like you should wrap them in dif PHP, not all in the same >_>

[gogodr]

I had to fix it but I got it working perfectly , thanks

[lanbo]

this doesnt work for me:

else if(skillid == 5101002){ // GM Holy Symbol
timer->stop(player, "end5101002");
vals.push_back(50);
for (unsigned int x=0; xgetMap()].Players.size(); x++) {
SkillsPacket::useSkill(Maps::info[player->getMap()].Players[x], Maps::info[player->getMap()].Players, skillid, 1800*1000, 0, 0, 0, (char) 0x1, 0, 0, 0, 0, vals, 1);
timer->setSkillTimer(Maps::info[player->getMap()].Players[x], "end5101002", 1800*1000);
player->setGHS(true);
}
}
player->setGHS(true);
}
}

gives me an error

[LeoDirk]

this doesnt work for me:

else if(skillid == 5101002){ // GM Holy Symbol
timer->stop(player, "end5101002");
vals.push_back(50);
for (unsigned int x=0; xgetMap()].Players.size(); x++) {
SkillsPacket::useSkill(Maps::info[player->getMap()].Players[x], Maps::info[player->getMap()].Players, skillid, 1800*1000, 0, 0, 0, (char) 0x1, 0, 0, 0, 0, vals, 1);
timer->setSkillTimer(Maps::info[player->getMap()].Players[x], "end5101002", 1800*1000);
player->setGHS(true);
}
}
player->setGHS(true);
}
}

gives me an error

lmao is the kid even trying anymore? x.x that script isnt even close to coded correctly, the last part " player->setGHS(true);
}
}" isn't even included in anything, thats what the error is.

[NeverGiveUp315]

nice release can u code it for rev 008 please

[LeoDirk]

nice release can u code it for rev 008 please

-cough- this is the second rev7 remake from the original rev8 that was posted by Doyos. Find it on the forum, I'm too lazy to find it and repost it for you.

[lanbo]

lmao is the kid even trying anymore? x.x that script isnt even close to coded correctly, the last part " player->setGHS(true);
}
}" isn't even included in anything, thats what the error is.

i took it out and i still get

1>------ Build started: Project: MapleStoryServer, Configuration: Release Win32 ------
1>Compiling...
1>Skills.cpp
1>.\Skills.cpp(370) : warning C4305: 'argument' : truncation from 'int' to 'bool'
1>.\Skills.cpp(412) : warning C4244: 'initializing' : conversion from 'float' to 'int', possible loss of data
1>.\Skills.cpp(590) : error C3861: 'xgetMap': identifier not found
1>.\Skills.cpp(590) : error C2143: syntax error : missing ';' before ']'
1>.\Skills.cpp(590) : error C2143: syntax error : missing ')' before ']'
1>.\Skills.cpp(590) : error C2143: syntax error : missing ';' before ']'
1>.\Skills.cpp(590) : error C2065: 'x' : undeclared identifier
1>.\Skills.cpp(590) : error C2059: syntax error : ')'
1>.\Skills.cpp(590) : error C2143: syntax error : missing ';' before '{'
1>.\Skills.cpp(591) : error C2065: 'x' : undeclared identifier
1>.\Skills.cpp(592) : error C2065: 'x' : undeclared identifier
1>.\Skills.cpp(844) : warning C4305: 'argument' : truncation from 'int' to 'bool'
1>Build log was saved at "file://c:\LanboMs\MapleStoryServer\Release\BuildLog.htm"
1>MapleStoryServer - 9 error(s), 3 warning(s)
========== Build: 0 succeeded, 1 failed, 2 up-to-date, 0 skipped ==========


o-O

[LeoDirk]

i took it out and i still get

1>------ Build started: Project: MapleStoryServer, Configuration: Release Win32 ------
1>Compiling...
1>Skills.cpp
1>.\Skills.cpp(370) : warning C4305: 'argument' : truncation from 'int' to 'bool'
1>.\Skills.cpp(412) : warning C4244: 'initializing' : conversion from 'float' to 'int', possible loss of data
1>.\Skills.cpp(590) : error C3861: 'xgetMap': identifier not found
1>.\Skills.cpp(590) : error C2143: syntax error : missing ';' before ']'
1>.\Skills.cpp(590) : error C2143: syntax error : missing ')' before ']'
1>.\Skills.cpp(590) : error C2143: syntax error : missing ';' before ']'
1>.\Skills.cpp(590) : error C2065: 'x' : undeclared identifier
1>.\Skills.cpp(590) : error C2059: syntax error : ')'
1>.\Skills.cpp(590) : error C2143: syntax error : missing ';' before '{'
1>.\Skills.cpp(591) : error C2065: 'x' : undeclared identifier
1>.\Skills.cpp(592) : error C2065: 'x' : undeclared identifier
1>.\Skills.cpp(844) : warning C4305: 'argument' : truncation from 'int' to 'bool'
1>Build log was saved at "file://c:\LanboMs\MapleStoryServer\Release\BuildLog.htm"
1>MapleStoryServer - 9 error(s), 3 warning(s)
========== Build: 0 succeeded, 1 failed, 2 up-to-date, 0 skipped ==========


o-O

lmfao, not at you lanbo, the kid that did the script.. He seriously doesn't know what he was doing with that code at all, look for " for (unsigned int x=0; xgetMap()].Players.size(); x++) {" in it, replace with "for (unsigned int x=0; x<Maps::info[player->getMap()].Players.size(); x++) {"

[Ruezu]

You didn't know what you were doing with your code, child.

Like I said I typed it up while in boredom at Internet Cafe

- Fixed Script Up :D (Copied from My Rev, So It Is 100% Working) - Please Update it! Krytical's Fix Makes The Player Have HS Icon on Top for GM HS BUT no HS Effect. I've fixed it so it has an HS effect now.

[lanbo]

lmfao, not at you lanbo, the kid that did the script.. He seriously doesn't know what he was doing with that code at all, look for " for (unsigned int x=0; xgetMap()].Players.size(); x++) {" in it, replace with "for (unsigned int x=0; x<Maps::info[player->getMap()].Players.size(); x++) {"

thx, fixed it <3 but the GM HS doesnt work :(

[shijobaby]

http://vcpperrormsgfatal.blogspot.co...fier-blog.html

[sockerkids]

Lol.. u bumped last year's thread..

[GoldenKevin]

Lol, titanms.