Simple point script

Quote:

---

Originally Posted by chunkarama

+1 for those multidimensional arrays! I can't tell you how many people to this day continue to have 1000 lines of if statements.. :(

---

@chunkarama ME! huehue :D

Thank you for doing this. I wish more Maple developers would pay attention to flexibility and ease-of-use in their code design.

Some improvements to this; Add a check to status == 3

Code:

---

if (cm.canHold(ITEMS[STORAGE1][STORAGE2][0])) {
            cm.getPlayer().gainEventPoints(-ITEMS[STORAGE1][STORAGE2][1]);
            cm.gainItem(ITEMS[STORAGE1][STORAGE2][0], 1);
            cm.sendOk("Enjoy your #i"+ITEMS[STORAGE1][STORAGE2][0]+"# #t"+ITEMS[STORAGE1][STORAGE2][0]+"##k!");
} else {
cm.sendOk("It seems you don't have enough room in your inventory for #t"+ITEMS[STORAGE1][STORAGE2][0]+"#k.");
}

---

And matter of opinion, but adding a message if the user selects no in status == 2

Code:

---

if (status == 2 && mode == 0) {
cm.sendOk("Something");
cm.dispose();
}

---

Also, making it a three-dimensional array allowing quantities as well would've been nice, but this is a great foundation~
Good job :)

Quote:

---

Originally Posted by chunkarama

Nice one, that's an even shorter return line :)



I reduce lines because in my opinion (it's just the way I program) I would prefer to have shorter code. If i'm going to be returning a single int or string, I'm going to use ternary because I can fit it all into one line rather than using if-else-if-else-if-else ... However, yes, if I can use an array like Fraysa had did that would end up being even shorter (again, to me the shorter the better). I also prefer to use ternary within all my NPC's actions whenever I can (instead of using if). ex. (m == 1 ? cm.warp(1, 0) : cm.killPlayer()); and so on. It really just depends on the person I guess.

---

Make sure it doesn't conflict with the ability to run code. Now I know there shouldn't be performance issues with your code if in the event it was given bigger values (maybe the ternary would be really annoying to write, which in that case you would use an array instead), but shorter code doesn't always equal efficient code.

Quote:

---

Originally Posted by Cygnus

Some improvements to this; Add a check to status == 3

Code:

---

if (cm.canHold(ITEMS[STORAGE1][STORAGE2][0])) {
            cm.getPlayer().gainEventPoints(-ITEMS[STORAGE1][STORAGE2][1]);
            cm.gainItem(ITEMS[STORAGE1][STORAGE2][0], 1);
            cm.sendOk("Enjoy your #i"+ITEMS[STORAGE1][STORAGE2][0]+"# #t"+ITEMS[STORAGE1][STORAGE2][0]+"##k!");
} else {
cm.sendOk("It seems you don't have enough room in your inventory for #t"+ITEMS[STORAGE1][STORAGE2][0]+"#k.");
}

---

Also, making it a three-dimensional array allowing quantities as well would've been nice, but this is a great foundation~
Good job :)

---

sorry, i dont really get what you meant by 'add a check to status == 3'
also, about the quantities, i made this script with the idea of selling equips, a friend requested it. So i didnt really think of the quantities, but its a nice idea, i might add it if somebody needs it

Quote:

---

Originally Posted by NmZero

sorry, i dont really get what you meant by 'add a check to status == 3'
also, about the quantities, i made this script with the idea of selling equips, a friend requested it. So i didnt really think of the quantities, but its a nice idea, i might add it if somebody needs it

---

What I mean is to add a check to confirm the user can hold the item previous to giving it to them. Without the check, if you try purchasing an item with a full inventory; you'd lose your points without gaining the item.

I will say, despite the fact that I highly doubt you are who your name (I guess indirectly?) implies you're taking the reputation of...
Your scripting is extremely identical.


But, regardless, good release. This should help those less fortunate. (I know, I'm really late on this)

Thank you for this. :love: