[v144.3] Acernis

[mor339k]

~Hayato : Battoujutsu Stance skill (first job) does not work.
~Zero : in Zero's shared skill list,Rhinne's protection doesnt work, the animations play and everything is fine but you do not get the buff.
~Zero : in Zero's shared skill list,Divine Speed doesnt work, the animations play and everything is fine but you do not get the buff.
~Zero : in Zero's shared skill list,Divine Force doesnt work, the animations play and everything is fine but you do not get the buff.
~Zero : in Zero's shared skill list,Temple Recall doesnt work, the animations play and everything is fine but you do not get the buff.
~Luminous is completely fucked up, i assume kaiser is too. (even though in the character creation screen it says theyre not available so maybe they werent actually made completely during v143? i didnt play the official maple since v117 to know myself).
~Not all items are included in the Cash Shop.
~some uncoded NPC's (obviously).
~Monster park car does not take you back to the town you were in after you try and get out of the monster park map
~Potions do not drop in Dojo.
~Cant restore my full HP and MP with potions or anything, it only goes up to the half bar leaving you with a little more than half HP and MP bar (notice this only happens as far as i can tell AFTER using the max skill npc : Professor Dreamboat).
~The teleporter from the entrance to the Dojo do not take you back, youll stay stuck in the Dojo entrance.
~Since were only 2 people (me and a friend) we cant check all the PQ's and most of them supposedly do not work (not surprising at all).
~NX cash items are not droppable (not a bug obviously).
~Tried learning Mining, cant use pickaxe on ores, it tells you to press Space-bar key to mine, it does nothing you just jump instead. (bug or i didnt play for too long?)
~After beating the normal mode of boss PQ, you are stuck in a small map in ariant near an npc that nothing happens when you click him and near a teleporter that nothing happens if you try to use it, npc name is Cesar.
~in Zero's Character Stats tab, when you hover your mouse over TF it says the description about mana points (MP) instead. (not a big deal but still a bug as far as i know).

i know its probably known already and isnt helpful, but i thought id give it a try and post it anyway just incase, i cant code in java, so i try to help in other ways, even if it doesnt help... atleast i tried. i didnt test all the jobs, i assume @Novak did, but if he didnt id be glad to do it for him to save him time.. or anything else i guess, just trying to contribute in some sort of way i suppose.

[Novak]

@mor339k
~Hayato : Battoujutsu Stance skill (first job) does not work.

Noted, being worked on.

~Zero : in Zero's shared skill list......

Noted, being worked on.

~Luminous is completely fucked up, i assume kaiser is too. (even though in the character creation screen it says theyre not available so maybe they werent actually made completely during v143? i didnt play the official maple since v117 to know myself).

Fun fact, besides combo-key's, all kaiser skills actually fully work. ALL OF THEM, but the morph packet is outdated (error 38)
Luminous is one of the jobs that's being worked on the most atm.
As for "not available jobs" I disabled all jobs that had bugs that made them 'unplayable'. Next rev will have resistance available again ;)

~Not all items are included in the Cash Shop.

I know, but i'm not going to add them manual. It seems as if you were to sniff from a v142 server, you could let it fill itself. But it's no priority now.

~some uncoded NPC's (obviously).

Yeah, obviously, not important now, but npc's are simple, look into them if you want them fixed faster. Any gms-like npc you create, will be added.

~Monster park car does not take you back to the town you were in after you try and get out of the monster park map

Yup, dun care now.

~Potions do not drop in Dojo.
Honoustly, it's suprising how many pq's i've allready gotten to work. Many just have little quirks that need to be dealed with. All i did was import all developments v117's PQ scripts on day 1, and change the event handlers in the source to run them.
These little things can be fixed easily, just not now, because there are way too many error 38 issues (job wise mostly) that need to be handled first.

~Cant restore my full HP and MP with potions or anything, it only goes up to the half bar leaving you with a little more than half HP and MP bar (notice this only happens as far as i can tell AFTER using the max skill npc : Professor Dreamboat).

This is actually important. Will look into it.

~The teleporter from the entrance to the Dojo do not take you back, youll stay stuck in the Dojo entrance.

There are teleporter commands, but yeah, just fix that npc if ya can't wait.

~Since were only 2 people (me and a friend) we cant check all the PQ's and most of them supposedly do not work (not surprising at all).

Known pq things:
- Kerning PQ (should) work
- LudiPQ works, but portals in stage 4/5 (idk which one) don't work yet.
- Monster carnaval is completely ffed (at least the lobby, never got past the lobby lol)
- Monster park kinda works, but far from the way it should (easily fixable with some different portal/ event scripts.)

~NX cash items are not droppable (not a bug obviously).

yeah...

~Tried learning Mining, cant use pickaxe on ores, it tells you to press Space-bar key to mine, it does nothing you just jump instead. (bug or i didnt play for too long?)

Oh that's interesting. Crafting fully works, never tested mining itself, Ill look into that.

~After beating the normal mode of boss PQ, you are stuck in a small map in ariant near an npc that nothing happens when you click him and near a teleporter that nothing happens if you try to use it, npc name is Cesar.

Either add an npc script (or fix the current one), code the portal, or just use a command like @fm. It's far from important now.

~in Zero's Character Stats tab, when you hover your mouse over TF it says the description about mana points (MP) instead. (not a big deal but still a bug as far as i know).

Yeah, that is because it's basically the same bar, with the same points, just handled different. I wouldn't know (yet) how to fix that.

i know its probably known already and isnt helpful, but i thought id give it a try and post it anyway just incase, i cant code in java, so i try to help in other ways, even if it doesnt help... atleast i tried. i didnt test all the jobs, i assume @Novak did, but if he didnt id be glad to do it for him to save him time.. or anything else i guess, just trying to contribute in some sort of way i suppose.

Thanks a lot for the list! A lot of things are allready know, and a bunch is unimportant in this stage of development, but the more we know the better.
A bunch of important things i had no clue about.

[Mallissy]

@mor339k
~Hayato : Battoujutsu Stance skill (first job) does not work.

Noted, being worked on.

~Zero : in Zero's shared skill list......

Noted, being worked on.

~Luminous is completely fucked up, i assume kaiser is too. (even though in the character creation screen it says theyre not available so maybe they werent actually made completely during v143? i didnt play the official maple since v117 to know myself).

Fun fact, besides combo-key's, all kaiser skills actually fully work. ALL OF THEM, but the morph packet is outdated (error 38)
Luminous is one of the jobs that's being worked on the most atm.
As for "not available jobs" I disabled all jobs that had bugs that made them 'unplayable'. Next rev will have resistance available again ;)

~Not all items are included in the Cash Shop.

I know, but i'm not going to add them manual. It seems as if you were to sniff from a v142 server, you could let it fill itself. But it's no priority now.

~some uncoded NPC's (obviously).

Yeah, obviously, not important now, but npc's are simple, look into them if you want them fixed faster. Any gms-like npc you create, will be added.

~Monster park car does not take you back to the town you were in after you try and get out of the monster park map

Yup, dun care now.

~Potions do not drop in Dojo.
Honoustly, it's suprising how many pq's i've allready gotten to work. Many just have little quirks that need to be dealed with. All i did was import all developments v117's PQ scripts on day 1, and change the event handlers in the source to run them.
These little things can be fixed easily, just not now, because there are way too many error 38 issues (job wise mostly) that need to be handled first.

~Cant restore my full HP and MP with potions or anything, it only goes up to the half bar leaving you with a little more than half HP and MP bar (notice this only happens as far as i can tell AFTER using the max skill npc : Professor Dreamboat).

This is actually important. Will look into it.

~The teleporter from the entrance to the Dojo do not take you back, youll stay stuck in the Dojo entrance.

There are teleporter commands, but yeah, just fix that npc if ya can't wait.

~Since were only 2 people (me and a friend) we cant check all the PQ's and most of them supposedly do not work (not surprising at all).

Known pq things:
- Kerning PQ (should) work
- LudiPQ works, but portals in stage 4/5 (idk which one) don't work yet.
- Monster carnaval is completely ffed (at least the lobby, never got past the lobby lol)
- Monster park kinda works, but far from the way it should (easily fixable with some different portal/ event scripts.)

~NX cash items are not droppable (not a bug obviously).

yeah...

~Tried learning Mining, cant use pickaxe on ores, it tells you to press Space-bar key to mine, it does nothing you just jump instead. (bug or i didnt play for too long?)

Oh that's interesting. Crafting fully works, never tested mining itself, Ill look into that.

~After beating the normal mode of boss PQ, you are stuck in a small map in ariant near an npc that nothing happens when you click him and near a teleporter that nothing happens if you try to use it, npc name is Cesar.

Either add an npc script (or fix the current one), code the portal, or just use a command like @fm. It's far from important now.

~in Zero's Character Stats tab, when you hover your mouse over TF it says the description about mana points (MP) instead. (not a big deal but still a bug as far as i know).

Yeah, that is because it's basically the same bar, with the same points, just handled different. I wouldn't know (yet) how to fix that.

i know its probably known already and isnt helpful, but i thought id give it a try and post it anyway just incase, i cant code in java, so i try to help in other ways, even if it doesnt help... atleast i tried. i didnt test all the jobs, i assume @Novak did, but if he didnt id be glad to do it for him to save him time.. or anything else i guess, just trying to contribute in some sort of way i suppose.

Thanks a lot for the list! A lot of things are allready know, and a bunch is unimportant in this stage of development, but the more we know the better.
A bunch of important things i had no clue about.

~Cant restore my full HP and MP with potions or anything, it only goes up to the half bar leaving you with a little more than half HP and MP bar (notice this only happens as far as i can tell AFTER using the max skill npc : Professor Dreamboat).

This is because some passive's are not handled properly it also happens when you wear an equip set that gives hp % the only source (That I know of) that has that working perfectly is MapleCrystal

[Novak]

Well, i like to showoff too. Credits to @Mallissy for getting giveMount sorted out :D
Credits to me for fixing up all error 38's and being locked into siege mode.



Still looking at what the problem is causing you not to stay in a perticular mode, should be solved at the next release :D!

[Fraysa]

Well, i like to showoff too. Credits to @Mallissy for getting giveMount sorted out :D
Credits to me for fixing up all error 38's and being locked into siege mode.



Still looking at what the problem is causing you not to stay in a perticular mode, should be solved at the next release :D!

Good job! Did you check the GM thingy? I'm still curious about this!

[Novak]

Good job! Did you check the GM thingy? I'm still curious about this!

Only took a quick peek. All i noticed in getCharList was: addCharEntry(mplew, chr, (!chr.isGM()) && (chr.getLevel() >= 30), false);

But i'm not sure yet what part of the packet sends the ranking. Would have to take a look in the BMS leak for that.
If it just so happens to be this line, i'd better check if !chr.isGM includes the right gm leves/ the gm job.

- - - Updated - - -

Nope wait, wouldn't make sense.

Since it checks for the gmlevel of the character, which is gmlvl 2+, and it also happens on my admin character ;)

[Fraysa]

Only took a quick peek. All i noticed in getCharList was: addCharEntry(mplew, chr, (!chr.isGM()) && (chr.getLevel() >= 30), false);

But i'm not sure yet what part of the packet sends the ranking. Would have to take a look in the BMS leak for that.
If it just so happens to be this line, i'd better check if !chr.isGM includes the right gm leves/ the gm job.

- - - Updated - - -

Nope wait, wouldn't make sense.

Since it checks for the gmlevel of the character, which is gmlvl 2+, and it also happens on my admin character ;)

I see. addCharEntry does write the ranking as far as I remember. It includes addCharStats, addCharLook and the ranking (the bottom 4 integers). That's actually really weird. Perhaps do it the other way around? Remove the GM check? So..

addCharEntry(mplew, chr, (chr.getLevel() >= 30), false);

[Novak]

Did check the error, it indeed crashes upon sending CHARLIST so that would mean that it has to be getCharList, as you said :p
What i noticed, that i get an error 38, so that would indicate that there is a problem in length.

Does that mean what you said? That i'm sending bytes for ranking that have to be deleted? And that's why there is a length error?

EDIT:

Only now see your reply, gonna try that.

Actually, im trying no ranking at all first.

- - - Updated - - -

Allright, this is interesting. No error 38, but a d/c when not writing ranking at all.

- - - Updated - - -

addCharEntry(mplew, chr, false, false);

- - - Updated - - -

When using addCharEntry(mplew, chr, (chr.getLevel() >= 30), false); it's just a error 38.

- - - Updated - - -

How bout, it being the pvp rank in addCharStats ? Best guess i can make now.

- - - Updated - - -

gonna try this now:

mplew.writeInt(chr.isGM() ? 0 : chr.getStat().pvpExp);
mplew.write(chr.isGM() ? 0 : chr.getStat().pvpRank);

- - - Updated - - -

Nope nothing. Not sure what causes is, will have to put some prints in there probably to see which of the packets is causing it.

[Fraysa]

Don't mess with other statistics - it's only about the rankings. You're getting error 38 because the client won't decode the rankings if the character is GM, so the original code is working fine. I'm not sure why you're getting crashed though, I'll take a look into that later.

[Novak]

Don't mess with other statistics - it's only about the rankings. You're getting error 38 because the client won't decode the rankings if the character is GM, so the original code is working fine. I'm not sure why you're getting crashed though, I'll take a look into that later.

Appreciated :p.

Now i'm curious too xD

[Snopboy]

Mind uploading a mirror? Mega is down o.o

[Eric]

@Novak what Fraysa's trying to point out is the Job Ranking bytes at the end of the OnSelectWorldResult packet (in OdinMS this is getCharlist)

This is what it looks like (and the fix -- GM Job's are not valid ranks in the WZ files resulting in a -2147 error code):

if (chr.isGM() || chr.getJob().getId() == 900 || chr.getJob().getId() == 910) { // no wz node for 900/910, and we don't want gm on ranks
                mplew.write(0);
            } else {
                mplew.write(1);
                mplew.writeInt(chr.getRank()); // world rank
                mplew.writeInt(chr.getRankMove()); // move (negative is downwards)
                mplew.writeInt(chr.getJobRank()); // job rank
                mplew.writeInt(chr.getJobRankMove()); // move (negative is downwards)
            }

However, if you're not dcing with -2147 as a GM, it's most likely not a ranking issue as ranking with GM wouldn't cause an error 38 if regular ranks work.

[Fraysa]

@Novak what Fraysa's trying to point out is the Job Ranking bytes at the end of the OnSelectWorldResult packet (in OdinMS this is getCharlist)

This is what it looks like (and the fix -- GM Job's are not valid ranks in the WZ files resulting in a -2147 error code):

if (chr.isGM() || chr.getJob().getId() == 900 || chr.getJob().getId() == 910) { // no wz node for 900/910, and we don't want gm on ranks
                mplew.write(0);
            } else {
                mplew.write(1);
                mplew.writeInt(chr.getRank()); // world rank
                mplew.writeInt(chr.getRankMove()); // move (negative is downwards)
                mplew.writeInt(chr.getJobRank()); // job rank
                mplew.writeInt(chr.getJobRankMove()); // move (negative is downwards)
            }

However, if you're not dcing with -2147 as a GM, it's most likely not a ranking issue as ranking with GM wouldn't cause an error 38 if regular ranks work.

He's getting error 38 probably because the client stops reading at the point before ranking after knowing the character is a GM, but he still writes the ranking bytes. Therefore it throws an exception.

[Novak]

@cunkarama

I got what he ment :p I made sure to write

addCharEntry(mplew, chr, false, false);

so that

addCharEntry(MaplePacketLittleEndianWriter mplew, MapleCharacter chr, boolean ranking, boolean viewAll)

would not write

if (ranking) {
            mplew.writeInt(chr.getRank());
            mplew.writeInt(chr.getRankMove());
            mplew.writeInt(chr.getJobRank());
            mplew.writeInt(chr.getJobRankMove());

But this is exactly why i'm not sure what the problem is, because according @Fraysa the problem would be related to those few ints being sent.
So yeah, maybe you are right and it's something else. But i'm not sure what it is yet, at all.

On the other hand, it could be that the client stops reading anything else that is sent? Idk. At all. :o

Will look into it more when i get home, thanks for all of your input! Both of you xD
Hoping we will be able to figure this out!! (dying to know who was right and what the prob was)

[Eric]

@Novak lol @Fraysa had pointed out your problem right there haha

above if (ranking) { is a byte. This byte is a boolean, and when > 0 will need to send 4 ints. Because you are making sure that it's NOT writing, now the length is too short and you are crashing. in if (ranking) { add mplew.write(1); above chr.getRank(). Then, do } else {, and add mplew.write(0);. See if that fixes the problem.