Working MaxMastery function on the way it should (MoopleDev rev 116)

[joost1500]

Here is the fix for MaxMastery in NPCConversationManager.java.
The function does now max the masterlevels but it doesn't set all the skills to 0.
Credits to Polaris Repack and a bit to me.

    public void maxMastery() {
        for (MapleData skill_ : MapleDataProviderFactory.getDataProvider(new File(System.getProperty("wzpath") + "/" + "String.wz")).getData("Skill.img").getChildren()) {
            try {
                ISkill skill = SkillFactory.getSkill(Integer.parseInt(skill_.getName()));
                if ((skill.getId() / 10000 % 10 == 2 || (getClient().getPlayer().isCygnus() && skill.getId() / 10000 % 10 == 1) || (getClient().getPlayer().isAran() && skill.getId() / 10000 % 10 == 2)) && getPlayer().getSkillLevel(skill) < 1) {
                    getPlayer().changeSkillLevel(skill, (byte) 0, skill.getMaxLevel(), -1);
                }
            } catch (NumberFormatException nfe) {
                break;
            } catch (NullPointerException npe) {
                continue;
            }
        }
    }

[MentaL]

[Luxray]

Here is the fix for MaxMastery in NPCConversationManager.java.
The function does now max the masterlevels but it doesn't set all the skills to 0.
Credits to Polaris Repack and a bit to me.

    public void maxMastery() {
        for (MapleData skill_ : MapleDataProviderFactory.getDataProvider(new File(System.getProperty("wzpath") + "/" + "String.wz")).getData("Skill.img").getChildren()) {
            try {
                ISkill skill = SkillFactory.getSkill(Integer.parseInt(skill_.getName()));
                if ((skill.getId() / 10000 % 10 == 2 || (getClient().getPlayer().isCygnus() && skill.getId() / 10000 % 10 == 1) || (getClient().getPlayer().isAran() && skill.getId() / 10000 % 10 == 2)) && getPlayer().getSkillLevel(skill) < 1) {
                    getPlayer().changeSkillLevel(skill, (byte) 0, skill.getMaxLevel(), -1);
                }
            } catch (NumberFormatException nfe) {
                break;
            } catch (NullPointerException npe) {
                continue;
            }
        }
    }

Doesn't set all skills to 0? What do you mean by that?

[Liv3]

Here is the fix for MaxMastery in NPCConversationManager.java.
The function does now max the masterlevels but it doesn't set all the skills to 0.
Credits to Polaris Repack and a bit to me.

    public void maxMastery() {
        for (MapleData skill_ : MapleDataProviderFactory.getDataProvider(new File(System.getProperty("wzpath") + "/" + "String.wz")).getData("Skill.img").getChildren()) {
            try {
                ISkill skill = SkillFactory.getSkill(Integer.parseInt(skill_.getName()));
                if ((skill.getId() / 10000 % 10 == 2 || (getClient().getPlayer().isCygnus() && skill.getId() / 10000 % 10 == 1) || (getClient().getPlayer().isAran() && skill.getId() / 10000 % 10 == 2)) && getPlayer().getSkillLevel(skill) < 1) {
                    getPlayer().changeSkillLevel(skill, (byte) 0, skill.getMaxLevel(), -1);
                }
            } catch (NumberFormatException nfe) {
                break;
            } catch (NullPointerException npe) {
                continue;
            }
        }
    }

wouldn't the 0 need to get getPlayer().getSkillLevel(skill) or w/e?

[Rampenbram]

is this a fix for Skill mastery of just a skill maxer 0.o

[Xerdox]

getPlayer().changeSkillLevel(skill, (byte) 0, skill.getMaxLevel(), -1); 

It isn't skill maxer. It only fix skill mastery (for 4th job?).

[joost1500]

Yes, it is to fix skill mastery, for 4th jobs, so that people don't need to find all the mastery books

[Basis]

Cool, so it actually doesn't "function the way it should" according to the official MapleStory (that's my understanding). It's just to bypass collecting books to allow you to train and advance the mastery skill like any other skill as you level.

[joost1500]

Well, the MaxMastery function is created to just Max the Mastery levels, and nothing more than that.