Mangos Mangos + YTDB + Scriptdev2 + Changelog

[DjAligator]

almost 3 years not sure it was public and no one sayed anything.
It's same thing ad.exe ore direct maps

 

[DjAligator]

Mangos 8696 - 8715
Add describtion for a new quest flag added in 3.1.2.
Replace pure virtual functions for better error output.
Check creature/GO spawnmask at server loading.

Note: this check only out of range value in masks.
And not detect another possible DB problem:

After last client switch spawnmask for raid dengeons need update for
correct work.
In expection same spawn for both normal or both heroic modes:
raid normal spawn mask from 1 to 3 (1|2)
raid heroic spawn mask from 2 to 12 (4|8)

In other case heroic spawn will used for 25-normal mode with empty heroic
mode instances.
Better way check spawn masks (for specific map)

Also note: i has been totaly wrong in my last notes in prev. commit (
Old "heroic raid" fine map to new normal 25. Sorry.
fixed problems with isInvisbleForAlive

removed redundant check at MoveInLos
this check is already done in istargetableForAttack
thx to NoFantasy

fixed in isVisibleForOrDetect that isInvisbleForAlive
wasn't checked.. and therefore all spiritserviceprovider
got visible
thx to NetSky
Fix instance bound difficulty selection.

This must fix crashes at enter to heroic mode instances and raids showup
after client switch.

Signed-off-by: VladimirMangos <vladimir@getmangos.com>

I can't repeat crashes with existed raids after changes apply but possible
in some cases
need drop content of related DB table for resolve some crashes.
fixed very high reputation in alterac valley

bug happened when one team owned a mine at the end of the match
and is caused through an uninitalized variable
through that players could gain or lose _very_ much reputation

sorry :x
Fixes and inprovements in pool system.

* Fixed object is removed from guid->object map but still spawned in world
under some conditions
* Fixed possibility to spawn already spawned object
* Fixed objects despawning (missing part for explicitly chanced objects
added)
removed startup-error for creature_loot_template id=0

for alterac valley we've defined Player-loot inside creature_loot_template

with id=0
this hack is used, so that we won't need to create an extra table
player_loot_template for just one case

if later more player-loot will be needed, we should implement
new table and remove this

also added sql-fix for reputation of last commit
it will just fix those which are hated by faction 729/730
Remove templates and some used functions from ObjectAccessor.
Fixed crash "Object with certain key already in but objects are
different!"

* It possible in result events
1) creature move from respawn grid
2) respawn grid unloaded by timeout, but not current grid for creature
3) respawn grid loaded before current grid with creture unload
4) duplicate attempt created in old grid

Until recent guid storage move to map we create duplicate creature with
same (continent) or diff guid.
With diff strange possible result in it work in world.
Move DynamicObject guid counting from global levle to map.

This is first step in guid counting for map local object types at map
level.
Map local countin let
1) have more wide guid space and then more seldom have problems with guid
counter overflow
2) possible implement (later) restart map at guid overflow without server
shutdown.
3) let use static guids (not for DynamicOPbject that not stored in DB
anyway) in instances instead dynamic allocated.
Fixed typo in [8704]
fixed linuxbuild
Fixed damage from spell 1120 and ranks when target below or equal
25% of health.
Show spell miss as miss, not resist
Make vehicle guid counter per-map local.

Also update/drop/move to Map some dependent functions.
Fixed work .instance unbind all

C-strings can't be compared by !=
Fixed commit [8708]

* Now final damage counted also with spell bonus.

Thanks Corfen for pointing this out.
Moved calculation of absorbed damage amount into
Unit::HandleProcTriggerSpell for spell 62606.
Fix compilation on Visual Studio 2010 Beta 2.
Fixed possible crashes and some typos

---------- Post added at 08:47 PM ---------- Previous post was at 08:41 PM ----------

YTDB 188
+ All fixes from the forum and editing of bug reports (see "adopted patches")
+ Settlement
+ Scripts quests
+ Hallow's End: Quests (115) / settlement
+ Hallow's End: Headless Horseman - updated stats / Loot
+ "Item_template" updated field on WDB-3.2.2a: stackable / ItemLevel / RequiredLevel / RequiredSkill / RequiredSkillRank
+ 30 new quests available in the game process
+ Handled 79 caches (3.2.2a)
Added forgotten file =) 515_EventAI_YTDB_QUEST.sql

 

[DjAligator]

Mangos 8716 - 8738
Update of enum HolidayIds, add missing names
Fixed SPELL_EFFECT_TAMECREATURE broken after [8686] Remove most GetObjectInWorld functions and move some map local to
Map

Also mape pet guid counter per-map (in different expecte to be global pet
number)
More early detection possible crash sources at object deletion.

* If object still in world at delete
* If object still listed in client update queue

Possible with this crash reports will more informative and let find
porblem.
Added missing ReqItem 5 and 6 to database.
Allow guildmaster to withdraw money before first bank tab is
purchased.

Attached sql file needs to be run to repair existing structure.
Fixed possible creash.

Crash may happen if you try summon pet by spell and certain NPC is not in
your DB (than CreatureInfo* is NULL).
Rename table `achievement_criteria_data` =>
`achievement_criteria_requirement`

And make related renames in code for types, variables and functions.
To make more clear difference achievement createria type from old
achievment criteria data type
in DB and code.
Fixed energize amount for spell 48389
Fixed bug with crash at forced logout in combat in instance.

In fact this old bug that just has been triggred more often after recent
code changes,
so with some chance maybe some other logout related crashes fixed.

Also small cleanup in avoid double calls RemoveFromWorld and
CleanupsBeforeDelete in some cases.
Fixed spell proc flags for spell 62600.
Cleanup in ObjectAccessor::FindHelper.

* This commit also restores compilability under some platforms and gcc
combinations.
Store current realmid for online account in realm Db account table.


* Replace old `account`.`online` field by `account`.`active_realm_id`.
It have 0 if account offline.

NOTE: this break all scripts that use `online` field for seelct online
characters, and it required update.
But from other side this reolve
* Bug with reset online state active realm at restart another realm.
* Let easy select online accounts for some specific realm if need.
Fix crash added in [8725]. Sorry.
Fixed spell 51770 after my recent changes in auras trigger system.
Restore difficulty 1 spawn use for creatures with special
difficulty 1 versions.

* Rename creature template `heroic_entry` => `difficulty_entry_1`
Possible need add 2 more fields for 2-3
* Use 2 more EventAI EFLAG_* flags for 2-3 difficulty support, update
checks.
* Update area trigger code.

Note: support for specialized creature version for difficulties 2-3 not
added yet
and will be used same as difficulty 1 mode.

TODO: Rename area triggers heroickey/etc fields ?
Not drop at save action button assign to value that recently
removed from it.
Access to chat channels by case-insensitive channel names.

But remember original case of name.
Re-implement talent 31789

* Allow apply to enemies of attacked party member
* Correctly apply effect to 3 attackers
New memory allocator for MaNGOS, based on Intel Threading Building
Blocks library. Performance gains depend greatly on OS you use!

You should add two libraries into your server binaries:
tbb.so/tbbmalloc.so on *nix and tbb(_debug).dll/tbbmalloc(_debug).dll on
Windows!!!

Define USE_STANDARD_MALLOC while compiling 'framework' project to use OS'
default memory allocator!
operator new[] based version of strdup() function to get bonuses
from Intel Memory allocator mainly in DB code
Restore some some VC80 build modes work after TBB lib add.

* Hide TBB libs in lib dirs in simialr way as hide ACE libs.
* Avoid use broken lib/*_debug_nppch dirs, and restore use debug version
for debug_nopch mode
* Avoid unexpected creating .tlb fiel in bin subdirs
* Restore 0.15-dev as current developed release version in mangosd.
* Set to correct values debug_nopch mode fields in tbb.vcproj
Restore some some VC90 build modes work after TBB lib add.

* Avoid use broken lib/*_debug_nppch dirs, and restore use debug version
for debug_nopch mode
* Avoid unexpected creating .tlb file in bin subdirs
* Set to correct values debug_nopch mode fields in tbb.vcproj

 

[DjAligator]

Added YTDB 209

---------- Post added at 10:20 AM ---------- Previous post was at 09:52 AM ----------

Mangos 8812
totems with no spell shouldn't cast anything

not all totems must have a spell

---------- Post added at 10:35 AM ---------- Previous post was at 10:20 AM ----------

Added Mangos sql updates and scriptdev2 sql updates.

 

[DjAligator]

Mangos 8813 to 8823
Re-implement some changes in [8799], but with mutex calls
commented.
removed some spells which made creatures invisible for dead
Reimplemented bgQueues announces, fixed possible problems with
multithreaded queues Mutexes have to be still commented because of ACE
bug. When player enters new bg from battleground, do not rewrite his
m_BgData with zeros. patch is tested.
call uncharm for all units at delete

currently it was only done for players - but units
also can have charms which must be removed
remove corpses from world at halting server

this fixes the crash after .server shutdown
Language.h cleanup, TODO cleanup WS and EY messages. Removed 2
minutes starting message from battlegrounds.
remove objects if unit leaves map

prior this - the objects were only removed when
unit itself gots removed
this fix some crashes with Object::SetUint64

thx to juansalvador and vladimir
drop unneded check at sessionupate

session will never get NULL there
removed some redundant player->SaveToDB calls

SaveToDB will already be called at "SpawnCorpseBones"
so no need to do this twice
one big insert for character_aura and _SaveSpellCooldowns

this is much faster than many multiple inserts..

code is partly stolen from AchievementMgr inserts
removed ban-cleanup queries from realmd at login

now they just getting executed when realmd is started

i think this will improve speed a bit.. cause we don't need to cleanup
those
bans so often we just can check the conditions inside the select

 

[DjAligator]

Added mangos update and url to mangos core. Sorry I forgot to add config files to version 8812 but now are added enjoy

 

[DjAligator]

Mangos 8824 - 8828
Implement 3.2.x changes for spell 5308 and ranks.
At fail start db connections stop all started db connection
threads.

This will restore state before start Db function call and prevent crashes
at delayed access to log singleton in case outdated DB structure
detection.
Set creatures PvP state flag based on creature faction and rename
related enum

Condition with custom flag civilian and player team only is not
sufficient. This update also disallow use *_addon -table (second byte of
bytes2) to set flag manually (small chance it may be needed)
Add a missing stand_state definition (and fill in with a few
unknown)
Independent instance reset time for different difficulties.

* Store reset time for map/difficulty pairs.
* Use DBC data for reset time and max players instead `instance_template`
fields (dropped)
for each existed map/difficulty pair.
* Fix some "heroic" related checks in spells/etc.

 

[DjAligator]

Mangos 8829 to 8854
some more places where we call redundant SaveToDB

i also added now my assert with which i've found them..
maybe someone want's to look at other cases too
Restore build at *nix. Make MAKE_PAIR* users includes explicit.

Comment for recently added field also.
Restore build at *nix. Make MAKE_PAIR* users includes explicit.

Comment for recently added field also.
Helper function add and move for diffficulties.

* Use regular naming for 0 spwanmode/difficulty for clean consistence
names (used at well known wiki)
* Move difficulty related data access from InstancedMap to Map class.
Fixed typo in difficulty name
Implement new commands for add/remove/lookup titles.

Inspired by patch suggested by LordJZ.
Small fix for sql update remove part.
.lookup title command DB description for prev commits.
Include revision_sql.h in src/shared makefile and VC project
Fixed client side visual bug with login in "combat" mode.
Avoid attempts to install tbb libraries without honouring $DESTDIR
Correct "outdated OpenSSL" warning message.
Correct proc flags for 53601.

Spell have in dbc wrong flags because copy its for dummy aura from
triggred spell for client use.
Implement talent 65661 and ranks.

SQL part prepeared by Laise.
send SMSG_PARTYKILLLOG when player kills an unit

thx to darkevil for investigations and help
Drop support removed in 3.2.x spells 31892, 53720.
log ACE-version at startup
fixed some gcc warnings
corrections for my last commit

thx to vladimir and apoc
Implement talent 20335 and ranks.
Fixed bidding on auctions below starting bid

This was possible by using cheating tools only; the client denies such
actions without sending CMSG_AUCTION_PLACE_BID.
Thanks to leak for reporting this vulnerability.
Fix a typo in STATUS_LOGGEDIN_OR_RECENTLY_LOGGEDOUT.
Check packet opcode for >= NUM_MSG_TYPES before queueing.

Also add check for wrong packet status requirement in code.
Add expected talent triggering cooldown.
Implement effects for item 47464 and 47303
Not attempt output not existed name in opcode table.
Implement heal back part of spell 48181.






Added and SQL updates

 

[DjAligator]

YTDB 210
+ All fixes from the forum and editing of bug reports (see "adopted patches")
+ Settlement
+ Scripts quests
+ Adjusted mobs in the Battlegrounds
+ Adjustment field "Method", "ZoneOrSort", "QuestLevel" table "quest_template" by WDB
+ Adjustment fields "item_template" by WDB
+ Adjustment fields "gameobject_template" by WDB
+ Reference an item: class = 9 AND Quality = 2
+ Reference an item: class = 9 AND Quality = 3
+ Reference an item: class = 2,4 AND Quality = 4
+ Reference an item: class = 0 AND Quality = 1 AND Subclass = 4
+ Adjustment chances pull ore
+ Handled 147 caches (3.2.2a)

 

[DjAligator]

Update scriptdev2 SQL

 

[DjAligator]

Mangos 8855 - 8869
fixed banproblem after [8823]

so only realmd accepted login but mangosd haven't done it
thx to the_game_master for pointing it out
Implement glyph 43534.
Add default value setting for WorldLogTimestamp in
mangosd.conf.dist.in
Implement client inform about creature threat list changes.
fixed bug which allowed to loot items multiple times

thx to burned for reporting
Prevent spam to clients by iupdates non-modifed threat list.

Also make more stricted access to threat list content.

Add peeking support to LockedQueue.
Revert "[8859] fixed bug which allowed to loot items multiple
times"

This reverts commit 47c743890e671d8f29a8a71e7a08e5d523f1c070.

bug wasn't fixed through this commit.. also those checks were wrong

in future it should work totaly different:
when lootwindow is opened the items must already be destroyed
moving items on the stack should be allowed
thx to seizerkiller for testing..

in this commit i just check if the item which should get moved
is getting looted
in Item::swap and guildbank this is already checked..
only the check at moving to own bank was missing
Fixed sql data added in [8856]
Not set target field at client side unit selection.

This fix second part problem (partly fixed early) when player with in
client selection
some unit (including self selection) show at loading another map
or far teleport as in attack animation. Target propertly already set at
attack command.
Fix area detection for zone 4395.
Replace [8864] by more correct way fix attack stance problem.

Thanks to TOM_RUS for help in more deep reseach problem source.
Implement expected combat stop with friendly faction

In case force reaction apply/remove.
Remove access to low level threat hacks from scripts.

Not need after force reaction fix.
Implement talent 15273 and ranks.


Also add data for SpellEffect.cpp last weeks changes to `spell_check`
table.

---------- Post added at 09:26 PM ---------- Previous post was at 09:15 PM ----------

Added mangos SQL update

 

[DjAligator]

Added YTDB updates.

 

[DjAligator]

Mangos 8870 to 8881
Fix problem with max pet distance from owner.

* Avoid use hardcoded and different max distance from owner for pet (more
at contienets and less in instances)
Use instaed max visibility for map as expected.
* Explicitly pet remove at move pet to non-visible distance for player
owner.
Avoid use StopMoving when creature is already stopped.

Some additional code cleanup in related code.
Avoid spam for not completed packet read for CMSG_MOVE_SPLINE_DONE
Implement proper spell activation for 56815.

Learn part suggested by Lightguard
Spell proc part sugested by Fullburned.
Extract player skills from data blob.

Thanks to vladimir for the update query.

Please make sure to make BACKUPs before you update your database.

The update might take a while depending on the size of your database.
Update spell 51505 and ranks work for 3.2.x
Fixed spell 724 and ranks.

Required Db support (gameobject templates)
Revert "[8876] Fixed spell 724 and ranks."

This reverts commit 5b96e3a2250755dec615e683c54a2ed056739370.

Spells expected summon creatures. This proved by related data.
Update regent percent for spell 57669 and 61782.
Re-implement buff selection for item 47499.
Some adjustments/additions for updateflag_living and flying
creatures
Fixed aura SPELL_AURA_MOD_MECHANIC_DAMAGE_TAKEN_PERCENT(255) apply.


Function use wrong base at fact that spell misc values for this aura store
single value instead mask.

 

[DjAligator]

Mangos 8882 - 8898
Implement talent 63625 and ranks.
Implement instant healing part of talent 63534 and ranks.
Fix heroic dungeons maxPlayers issue
More correct animation for spell 48181 and ranks.
Add username/password prompts to Remote Admin
Fixed lost auras at login from spells learned at skill load.

This is mostly buffs form profession skill levels.
Use ACE for access to script lib

* This allow have more portable code and resolve some related portability
problems.
* Also make default script library name lowcase at Windows in same way as
used for Unix case.
Allow non-permanent pets have auras from `spell_pet_auras`.

Also add one from related cases to DB.
Fix sql update name.
Implement talent 64976.
Implement spell 29166 and glyph 40908.

Original patch provided by bobaz.
Fixed typo in `mangos_string`
Add missing and avoid redundent Aura::GetCaster calls.
Use NULL-terminator instead table count in pdump code.

Also rename function to avoid use same name with type.
Include `character_skills` table in pdump and drop at character
delete.
More stricted checks for store operations.

* Use stricted definition valid pos for expected explicit pos cases
* Prevent attempts add bag to self at autostore.
Fix typo: get SPELL_AURA_MOD_MECHANIC_DAMAGE_TAKEN_PERCENT data
from victim.

 

[Crico]

CRICO:
Hello DJAligator download the new releases and I have many problems, I can not update the database, but MYSQLYOG exporters with the emulator does not start asking me different files HANDLES SQL, for example I have 8777 but can not export it gives me error please I pray help me please.
Thanks in advance Cristian = (

 

[DjAligator]

give more information. What it say what error appear. Maybe you didn't made something.

 

[DjAligator]

YTDB 218
+ All fixes from the forum and editing of bug reports (see "adopted patches")
+ Settlement
+ Scripts quests
+ Resettlement colors: Durotar, The Barrens, Mulgore, Desolace
+ Editing articles of all NPC under 3.2.2a
+ Update trainers
+ Handled 190 caches (3.2.2a)

---------- Post added at 05:47 PM ---------- Previous post was at 05:41 PM ----------

Scriptdev 1513
Added saving/loading of instance data for Zul'Gurub.
Move Hakkar health management from boss scripts to instance script.
Restore compile for Mangos Rev 8900+

---------- Post added at 05:56 PM ---------- Previous post was at 05:47 PM ----------

Mangos 8899 - 8913
Implement glyph 43374

Original patch provided by Splinter.
Move most gossip related functions from Creature to Player class

Adjust arguments passed in functions accordingly, for easier
implementation of gossip for Gameobjects in future.
Some additional code cleanup in affected functions.
Implement rage save part of talent 29723 buff and ranks.

Original patch provided by Wojta with improvments from darkstalker.
Do can store check at loading item to bag in same way as for other
cases
Stop anti-freeze thread eraly to prevent it triggering at shutdown
operations.
In spell effect debug string outpu also spell id and effect index.
Dispel work with aura stacks fixes.

* Implement set of remove aura functions for remove single aura from
stack.
Also some order function declarations for more clear show different aura
remove functions.
* Change Spell::EffectDispel to dispel single aura instead all similar
auras from caster.
Implement 64127 and ranks in part of additional dispel.
Avoid set intelect bonus to mana amunt if character not have mana.

This fix bug when not non-caster classes show mana subbar
in way as it must be show only for druid in form.
Make spell 27681 and ranks as alt. branhc (2-4 ransk) from spell
27681.

This made this spell buffs unstackable for any ranks and still have
expected req. for learning.

Original patch provided by Splinter.
Fixed talent 64127 and ranks speed bonus part.
Implement spell 62124 damage part.
Show item expire time in realtime case.
Fix item 47668.
Fixed typo in recent Spell::EffectDispel code changes.

Also some code cleanup.





Added Mangos sql update

 

[Crico]

CRICO::?:
Dj Aligator hello I have a doubt had the fix mangoes mangos 8779 with 518 vendors who had enj ogrimar input volumes were several that sold saddles armor, etc. all but the upgrade to 8881 and disappeared as I put them back please help you agradecere it ok THANKS FOR ADVANCE:O::huh::*:

 

[DjAligator]

Mangos 8914 - 8937
Implement full damage absorbing chance with telent 11189
Fixed rage calculation for spell 5308 and ranks.
Fixed spell stacking problem for somr sprlls with spell icon 240.
Fixed `spell_proc_event` data for spell 65661
Fix mangos.sql
Implement telant 44394 and ranks.
Fixed glyph 42408 by move code to more correct place.
Implemement talent 53583 and ranks refresh part for spell 54428
Implement telant 46859 and ranks additional debuff apply.

Thanks to xXxRRLxXx and KAPATEJIb for patch prepering.
Restructure gossip menus and make it possible to build selections
by database

As result, gossip for GO is now possible. Moved related data structures
and remove useless from code.
Please note that after some time, table npc_gossip will be fully removed
(use menuId in _template in relation to gossip_menu as replacement).
Special thanks to GriffonHeart for help with research, discussions and
ideas of code and thanks to Vladimir for helpful input.
Implement reapply permanent area auras for group.
Implement 34297 and rank in part health/mana effects.

Original patch from unknown author.
Used version provided by nanounico & KAPATEJIb

Rewrited in more proper way.
BattleGround: call correct function at playerleave

it will now correctly drop the flag and correctly remove the player from
eye of the storm objectives

+ also avoid the spamming of all "Player not found!" messages in
battlegrounds

maybe all existing "player not found!" places should now get an
assert(false)
since this shouldn't happen anymore

+ also better error output in GetBattleGroundQueueIdFromLevel
added missing continue for last commit
Rename internal names for gossipLocale and also correct reload
gossip tables
Implement gossip scripts to be used with
gossip_menu_option.action_script_id

Note that script is implemented for GOSSIP_OPTION_GOSSIP only (as not
expected needed for other gossip options).
Also add a few more startup checks for LoadGossipMenuItems with check for
basic errors in fields
Implement bonus periodic heal part for spell 19750 and ranks.
Fixed typo om `spell_bonus_data` for spell 172
Add spell_chain data for spell 50518 and ranks.
Fxied typo in mangos.sql `gossip_menu_option`
Implement aura PELL_AURA_MOD_MINIMUM_SPEED (305) and it used for
FORM_GHOSTWOLF.
Implement talent 51480 and ranks buff at dispel 8050 and ranks.
Implement spell 48743
Small lost change, just more correct code by form.

 

[DjAligator]

Mangos 8938 - 8953
Implement talent 50880 and ranks.
Fixed talent 49200 and ranks triggered spell for arcane school.
Make players and totems always immune to taunt.
Limit used energe as expected for spell 22568 and ranks.

Thanks also to Sarjuuk for code simplification.
Spells 20911 and 25899 stats bonus.
Add spell_chain data for 24604 and ranks.
Use DBC data for summon effect functionality.

Also some more local fixes:
* Alow multiply same type guardians req. for some spells.
* Apply spell duration mods to summons

Many summon spells must start work.

Great work qsa!

Thanks The_Game_Master for updaing patch to recent sources.
Update work triggered effect for 20271
Implement talent 57499.
Implement aura SPELL_AURA_MOD_DURATION_OF_MAGIC_EFFECTS (245)

Used in spell 6117 (5/6 ranks)
Not check victim at apply SPELL_AURA_MOD_SPELL_CRIT_CHANCE_SCHOOL
for ranged spells

In same way as for other cases. For consistance.
Implement proper support spell auras with maxstack > 1 and charges
> 0.

* Like auras expected to be proccessed in spell proc event code (not lost
charge at use in spellmods code).
Exist examples for like spells that affect value in spellmods but have
different expire requirements.
* Propertly work with stacked auras in spell proc event code
- remove only one auras from stack
- in case charges exist in same time not touch charges but return expire

(all really used auars with maxstack>1 and charges have 1 in one from
this values)
Implement talent 55198.
Remove trailing spaces
Fixed loading `locales_gossip_menu_option`.
Use default gossip menu options if no options exist for "top level"
menu.

Also not close gossip menu in cases where no action_menu_id is set.
Apply spell mutiplier to final damage for health calculation in
Spell::EffectHealthLeech.

---------- Post added at 01:35 PM ---------- Previous post was at 01:32 PM ----------

Added and Mangos sql updates