Mangos Mangos + YTDB + Scriptdev2 + Changelog

[DjAligator]

Mangos 8954 - 8975
Implement spells 65495 and 65386.
Check gossip_menu_option table for GOSSIP_OPTION_NONE and output
error if exist
Implement aura SPELL_AURA_ALLOW_ONLY_ABILITY.

(cherry picked from commit f4d1e05)
Implement talent 53754.
Inlcude 15407 and ranks damage in talent 15286 affect.
Implement talent 15318 and ranks and move talent 44745 and ranks
code.
fix crash introduced with 8805

or actualy i didn't introduce a new crash there.. the old crash
just changed a bit..
after we force the player to logout without valid mapcoords the player
wasn't in
world anymore and through that Getplayer()->GetMap()->RemoveFromWorld()
caused a crash..

i changed now the error handling inside farteleport there.. instead of
forcing
a logout without saving, i just port him to his homebind
which will be much nicer

(minor cleanup with the other homebind teleportation.. we don't need to
check
for the error there.. homebind realy should be a valid coord)
Prevent crash in Aura::HandleAddModifier for far group member
Check player class instead of just active pet for gossip stable
option
Make bindpoint field private and add required functions for use.
Return in TeleportToHomebind return result from TeleportTo
Implement `quit` command for close RA connection.
Restore full stack bufs from talent 51528 and ranks using unique
aura type.
Fixed division by zero in Unit::CalcAbsorbResist.

This also fix spell 31662 work.
Implement gossip menu options for GameObject
Ignore in stacking check pure dummy spells.

One more hacks to SpellMgr::IsNoStackSpellDueToSpell
This fix for example 53601 with 20911 stacking.
Implement CONDITION_AREA_FLAG

Value1 is for "include flag", Value2 for "not include flag"
Correct mangos.sql after changes to creature_template in rev 8923
Some hacks to our hackish IsPositiveEffect function.

In attempt improve positive spells detection.
Clarify ICON_POI_* changes from 2.4.3 in comment.
Increase z limit for at transport coordinates for bettr support big
height lifts.
Spell 34914 and ranks will deals damage at dispel.

(cherry-picked from commit 6ff5b6a)

 

[GunGrave21]

hi djAligator i have some problem. i have mangos rev 8964 with UDB_0.11.6_Core_8734_SD2_1480. ok i compiled my server, put all updates from mangos/sql folder and for mangos db i put udb. everything worked fine.
but there is some problems with death knight class. some quests are buged and i have question is it db related or mangos. the quest whic was buged was when u need to open cell for unworthy initate he suposed to get up put clothes and start fight with me. so pls help with this matter. thx in adv.

 

[DjAligator]

Mangos 8976 - 8993
Implement CONDITION_RACE_CLASS

Condition has independent value1 (race mask) and value2 (class mask)
fields and can be used with one or both.
Not send npcflag stablemaster to non-hunter player

Also check for player class vs stablemaster flag in
GetNPCIfCanInteractWith()
Fix wrongly apply weapon damage mods to broken weapon.
Remove unexpected added lines in prev. commit.
Avvoid apply spell bonuses to glyph 42408 heal amount.
Re-apply sql update from [8211] that not included in mangos.sql in
past.
Prevent infinity recusion at repally auras at sepllmod change.

Passive auras (in different area auras) not affected by another group
member spellmods.
In different from owned unit case.
Implement item 42988 buf expire effect.
Fixed max channaled spell distance check at aura update.

Radius for target applied chanmaled auras around affect, not for caster
diatance check.
So use spell range and _only_ for explicit pointed channled target for
spell.
Remove morph from spells including aura
SPELL_AURA_MOD_PACIFY_SILENCE

This fix at damage transformation remove for spell 51514/47585 and ranks.

Thanks to KAPATEJIb for prepare compatible version for current sources.
Implement resilience on periodic crits
Allow swap spell and command/reaction in pet action bar.

* Also prevent command/action drop from action bar
* Pet action bar will recetn at this revision use single time for all
pets.
Overwrite default wrong class family mask for spell 53817.
Clean up parts of WaypointMovementGen code for better readability
Correctly return DEFAULT_GOSSIP_MESSAGE and never 0 as gossipTextId


Fixes problem with summoned and gossip and where no textId is defined in
database
Merge 2 switch in Unit::HandleProcTriggerSpell
Fixed spell proc data for

* 19184 and ranks
* 53290 and ranks
* 34506 and ranks
* 35100 and ranks
* 46913 and ranks
* 51521 and ranks (use cooldown for prevent triggred spells proccessing)
* also 34457, 20784
Fix sql update for prev. commit.
Fixed spell family mask 53817 one more time.



Added Mangos SQL updade

 

[gregon13]

HEY remove the links to maps and vmaps, users have to own the game in the first place for the server

 

[DjAligator]

Implemented Slad'Ran encounter in Gun'Drak.

Snake Wrap work needs research.


Mangos 8994 - 9007
Re-implement remove auras from channeled target

* Old way have problem with auras that have last tick avent at one from
caster/target:
depndent from auras update order in caster/target pair ti can wrongly
not triggered.
* Fxied possible problem with remove same spell non-caster auras at
target/caster at spell cast cancel
* Also fix memory lost in old deleted auras cleanup.
Overwrite wrong proc flags for glyph 43539 triggering.
Implement 2 items effect from itemsets 803/-33
Implement SUMMON_PROP_TYPE_REPAIR_BOT(12) support

Used only for item 49040 summon. Need DB support for proper work summoned
creature.
Allow pet guid to have gossip options like creature guid.
Make creature wild summoned by item 49040

This make it usable by other players, not only owner.
Also sort summon types by value in switch.
Reset time in more proper way.
Add internal cooldown for for item 42987 effect.
Make 8923_01_mangos_gossip.sql more propertly work

if rename target table exist by some reason.
Revert "[9000] Reset time in more proper way."

This reverts commit 8e8f7710e8baf29196256c6e0afcce1b7d3f3671.

Main reason: unexpected work in debug with breakpoints.
Also have other reports with strange effects.
Drop dead code case
Add internal cooldown for item 40373 effect.

Thanks to Splinter for cleanup query.
Trailing whitespace cleaning

Sorry for a (bit) delayed commit.
Set internal cooldowns for trinkets and some other items/spells.

Including items: 27683, 28418, 30619, 30626, 43134, 38579, 38212, 40767,
37559, 40865, 38071, 38072, 43462, 43470, 43573, 43829,
28190, 49076, 40682, 28034, 37220, 37390, 37064, 44308,
37660, 37264, 39229, 37657, 40258, 40382, 41385, 43838.

Also included data prepared by co-authors: Sephiroth1983, nos4r2zod,
Sarjuuk, oc_redfox, Alez.


Added Mangos SQL update

 

[DjAligator]

YTDB
+ All fixes from the forum and editing of bug reports (see "adopted patches")
+ Settlement
+ Scripts quests
+ Gossip-menu mobs
+ Editing DPP type = 2 under the "gossipy"
+ Adjustment "fishing_loot_template"
+ Adjustment "skinning_loot_template"
+ Adjustment "prospecting_loot_template"
+ Adjustment "disenchant_loot_template"
+ A complete rewrite of loot all bosses Crypt Arkavona
+ Handled 235 caches (about 2x gigs инфы) (3.2.2a), probably the last



Mangos 9008 - 9020
modelids for shapeshifts from dbc

this will correct some modelids:
form old model, new model
FORM_TRAVEL: 632 --> 918 (now a bit smaller)
FORM_GHOUL: 10045 --> 25527 (whisp --> ghoul)
FORM_CREATUREBEAR: 902 --> 2281 (old brown horse -> bear)

implement shapeshift for spell 24347

this commit also
fix the errormessages with: "Race %u not found in DBC: wrong DBC files"
which were triggered from this code
and will fix the modelid for creature 2038
since it's also using a shapeshift aura and only got the horde-modelid

+ some new entries in ShapeshiftForm-enum
+ some research for the shapeshift.dbc
More fixes in pet action bar buttons swap.
Implement realmd support realms for different client versions

* Supported 1.12.1, 1.12.2, 2.4.3, 3.2.2a in same time as relams in same
realmlist
* mangosd by self check correct for it client build and reject all
incorrect cases
* realmd know from mangosd what builds supported each realm and
if realm not support it then in relamlist for specific client this relam
show as offline.
Not need any manual settings for this.
Drop unused enum.
fix crash when achievement is completed and player isn't in world

also don't divide money loot for players who are not inside the
same map..
and player shouldn't be able to reclaim his corpse if it isn't in same map


and some other related cleanups
shapeshift spells

some shapeshift forms will give the player spells
so we need to tell the server that the player has those new
spells else he can't cast them since the server is thinking the player is
cheating

ps forms with spells:
FORM_GHOUL
FORM_THARONJA_SKELETON
FORM_TEST_OF_STRENGTH
FORM_BLB_PLAYER
FORM_TEST
FORM_ZOMBIE

--
so this mostly won't affect any ingame experience.. but good to have this
feature anyway..

also changed errormessage if player has no reagents for spell..
thx to nofantasy
Fixed unexpected error output for "unused" `db_script_string`.

When it reallt used in `gossip_scripts`.
Fixed spell 34914 ranks dispel damage and spell 29722 and ranks
bonus damage.

In both cases not expected additional spell damage bonus apply.
Add missing value for recently aded field in `realmd.sql
Fix typo in GO gossipID check for type 10
Implement aditional form specific bonus for 16857.

SQL data prepered by MrLama.
Add/update some hidden threat values for warrior/druid spells.
Re-implement 1680 (and triggred spell for 46924) in less hack way.

 

[DjAligator]

Mangos 9021 - 9043
Implement item 21213 effect work.
Fixed small typo in creature_template.difficulty_entry_N checks.
Fixed some hunter sting affects.

* spell 1978 and ranks RAP bonus
* spell 53209 affect from spell 3034 dot.
Fixed RAP bonus percent for spell 56641 and ranks.
Implement talent 63373 and ranks.

Idea with AddTriggeredSpell use suggested by darkstalker.
Implement ACHIEVEMENT_CRITERIA_REQUIRE_INSTANCE_SCRIPT.

This achievement criteria requirement type let set in table
`achievement_criteria_requirement`
that specific criteria id for achievmenet connected with some instance
must be checked by new InstanceData call
bool CheckAchievementCriteriaMeet(uint32 criteria_id,Player const*
source, Unit const* target, uint32 miscvalue1)

It expected to be used for cases: kill boss without raid members death or
for some limited time
or without kill before some other boss helpers and etc. Implementation
expected base at collection some data/counters update
in instance data at specific event and then make check by query and retunr
success for specific criteri or fail requirements.
Restore spell bonus apply to dot damage for 17962 damage
calculation.

In fact reverting wrong part of my one from prev. commits.
Better error output for
ACHIEVEMENT_CRITERIA_REQUIRE_INSTANCE_SCRIPT.
Fixed spell 0451 and ranks buff apply.

In fact drop now wrong redundent code.
Fixed: remove spell 30451 and ranks buffs stack at another arcane
spells.

(cherry-picked from commit 8dbbc7b)
Fixed: remove talent 44404 buff at spell mod apply triggering.
Correctky cast rank 2 mana regent triggred effect for 53228 and
ranks.
Fixed percent mana regneration from spell 53228 and ranks buff.
Add internal cooldown for item 47215 effect.
Attempt make more fast and less hackish spell target checks

* Enable server side recheck clear negative to friend or positive to enemy
casts that already checks at client side
* Use more fast way check in similar cases for non-players, and fall back
to old way in unclear (for while at least)

Please report if some spell stop propertly casted at friends/enemies.
Typo in function name.
Cleanups in spellmode apply code.

* Add constructores for spellmode creating instead explcit fields init
* Use uint32 for family mask 2 instead unneded uint64

Also drop one from manual applies for uno-existed now spell.
Update highest threat enemy at move to offline list.

It will restored if still highest at move back and fix
at least visual bug with GM-mode on still show for GM
as highest threat enemy for creature.
Allow have more one hunter aspect from different casters.
Update code for talent 17056 and ranks correct work.
Move enum CastFlags from eventAI to creatureAI for access to all AI
Remove double apply bonuses for spell 635/31935 and ranks

One time in code and second time by DB data.
Fxied build at *nix systems.



Added and Dual spec and anticheat Enjoy

 

[DjAligator]

YTDB 231
+ All fixes from the forum and editing of bug reports (see "adopted patches")
+ Settlement
+ Scripts quests
+ Adjustment "gameobject_template" type = 0,1,10 for WDB
+ Adjustment loot money from the NPC
+ Gossip-menus mobs

 

[DjAligator]

Mangos 9044 - 9071
Exclude TARGET_SELF from I***plicitPositiveTarget.

This must fix triggred spells casting in case when it self casted but cast
code send diff target.
Implement talent 48539 and ranks.

Signed-off-by: VladimirMangos <vladimir@getmangos.com>

Also some typos in mangos.sql field order fixes (sql updates in past ahe
been correct)
Correctly send channeling start/update packets to clients

(cherry-picked from commit 1bc38f7)
Support triggered spells that have cast time.

Like spell will placed in unit event list for cast at next tick or later
dependent from cast timer.
Before all triggered spell ignore cast time and casted explcitly from
related cast caller code.
This must fix some spell work like 17086 in damage apply time part and
also in preventing possible
stack overflow because this spell triggering by chain 19 spell casts from
each other.

This also exclude from triggered arg of CastSpell function meaning that
this cast will instant alsways.
So triggred arg now meaning only that this seppl casted nit from player
side and then not send
in some cases cast info to client if not vosula effect expected.
Add src\bindings\universal\Scripts\sc_defines.cpp to script.vcproj
Additional fixes for talent 17056 and ranks.

Thanks to Sarjuuk for clarify existed problems and help in prepare fix.
Add MAX_EXPANSION define for config option Expansion check.

This will prevent case when expansion set to high for supported client
in config and account have also too high expansion setting.
Client in like case receive too high expnasion and reject connection
because it think that have not installed expansion for connection account.


This possible for example for account case when single realmd used for
diff client versions and account have high expansion setting for most
recent client support. And in same time mamngos.conf for specific realm
have wrong Expansion value.
Make code more compatible with C++ standart strict follow compilers.
Fixed possible crash at fake items swap packet.
Fxied some mage DoTs stacking.
Implement expire/dispell damage for spell 44457 and ranks.
Fixed charge amount for spell 64823 to expected 1
Not exclude real caster from TARGET_ALL_ENEMY_IN_AREA_INSTANT.

Not found cases when this need for affected case (without 27/28 effects)
Implement some damage related spell attributes support.

* SPELL_ATTR_EX4_STACK_DOT_MODIFIER
* SPELL_ATTR_EX6_NO_DMG_PERCENT_MODS
Implement spell 7057
Implement expire effect for spell 28169
Fixed leave combat by timer.

This also fix some problems with stealth detection.
Fixed SPELL_AURA_MOD_CRIT_DAMAGE_BONU (163) use in calculations.

* Renamed from SPELL_AURA_MOD_CRIT_DAMAGE_BONUS_MELEE
* Also apply to non-melee damage also
Implement two helper-functions for casting spell in creatureAI.

Function will return a cast result, with fail reasons if spell can not be
casted (can be used to take alternative action). Please note this is not a
full list of cast fail errors/reasons, but will cover a few basic errors
that may occur.
The virtual function CanCastSpell() may be adjusted for custom needs from
script library if not the default is sufficient.
Add one more expected spell cast at spell 28169 debuf expire.
More internal cooldowns for some intem spells.
Implement motionmaster function UpdateFinalDistanceToTarget()

To update a creatures distance to it's target without creating a new
movement generator. Note it can only be used where creature is using
TargetedMovementGenerator.
Small cleanups in spell code.

Mostly avoid unclear "lost" break case
Restore build at *nix.
Include spell 35395 in trigger list for talent 53380 and ranks.
Also remove wrong masks from talent 53486 and ranks.
Drop outdated code.
Add explcit 6 sec triggering cooldown to 58597.
Fixed exclusive triggering 2 buff versions for talent 48516 and
ranks.

 

[Shirou]

Anticheat system not compiled with 9071?? Tested it just now and not working.

 

[DjAligator]

I didn't added on 9071 i will add in next release.

 

[Shirou]

I didn't added on 9071 i will add in next release.

ok thanks

 

[DjAligator]

Mangos 9072 - 9091
Implement periodic dummy aura for spells 50792, 59859, 50801 and
59858
Implement hack way detection for cave area 571.
Fix typo in 'server shutdown' description.
Fixed direction of move for SPELL_EFFECT_PLAYER_PULL
Another SPELL_EFFECT_PLAYER_PULL problem fix.

If base points porvided then this is _max_ pull distance, not direct
distance.
Fixes for pet work in case mounted owner.

* No unsummon temporary pet at non-fly mounting.
* Implement client side disable pet's action bar for mountted owner time

Signed-off-by: VladimirMangos <vladimir@getmangos.com>

* implement server side action disabled case (action bar modify, aggro
reaction and autocast)
Allow stacking healing buffs from spell 33763 and 48438, and ranks.
Less strict check related to TARGET_SCRIPT_COORDINATES

Fixes and enables ~20 more summon related spells. Some minor cleanup in
related code
Add custom/preset unMaxTargets for a few spells where info is not
present

Thanks to kamillys and KAPATEJIb for original code and research!
Fixed DoT damage from 12834 and ranks.
Correct some spells unMaxTarget (ref [9080]) to depend on map
difficulty
Rename maps naming used in spell targeting code for easier
readability
Implement periodic dummy aura for spell 50789 and 59860
Implement periodic dummy aura for spell 50824
Limit maxTargets for spell 33711 and 38794

Also remove not strict required difficulty check for some spells and add
lost comment from [9085]
Fixes in pet unsummons

* Not unsummon warlock pets at logout.
* Prevent overwrite current saved pet at save secondary pet (with
temporary unsummoned first).
This possible at arena for example.
* Not fixed: in char list at login pet don't must be show with character
if character saved at mount in game.
Not critical and maybe not need fix as feature
Prevent unsummon permanent pets at arenas.
Check explicit target correctness by all effect target modes.

All effect target modes start from client provided target data
so all its must be used for checking explicit target modes.
For example exist spells that have as first effect SELF non-explicit
target mode.
but in same time negative to explicit target.

Signed-off-by: VladimirMangos <vladimir@getmangos.com>

Also add caching IsHostileTo/IsFriendlyTo for avoid recall this not fast
functions.
Implement tick counting in periodic auras.

This can be used for some tick number dependent aura effects.
Also in some cases impossible claculate tickes count pass,
for example for infinity duration auras.
Add max targets limit for spell 34861 and ranks.
Also implement glyph 42396 work for referenced spells.


YTDB
+ All fixes from forum
+ spawn
+ quest scripts
+ mob's gossip menues
+ fix "item_template"
+ fix "quest_template"

 

[Shirou]

Thanks for the update.

 

[Shirou]

This new Core is very very unstalbe crashes every 10min with 30+ people online

 

[DjAligator]

Mangos 9092 - 9112
Fixed typo in function name.
Implement periodic dummy aura for spell 48630 and 59275
Implement periodic dummy aura for spell 46041
Allow apply .modify scale to targeted creature (without save
scale).

Also add command description to mangos.sql.
Implement periodic dummy aura for spell 52441

Note speed is not really reduced as expected, this need correction in
other parts of code.
Implement periodic dummy aura for spell 53520
More correct targets selection for target pairs with TARGET_SELF2

* Many spell effects that have A target mode SELF2 expected applied to
enemy
target selected by targetmode B so we need skip SELF2 target mode.
* remove SEFL2 from explicit positive target modes.

Implement periodic dummy aura for spell 55592

Also correct second cast, expected for spell 53520
Set MaxTargets limit for spell 31347
Correct target mode 48, and rename to something more meaningful

Also adjust target 49/50 angles to be really left/right.
Use FillRaidOrPartyHealthPriorityTargets for 34861 and ranks.
Make gcc happy with muti-byte char casts and use more readable
magic strings.
Avoid send reset warning to map/difficulty cases without fixed
reset time.
Add missing argument in error message, _LoadSkills()
Add script effect for spell 47097

Also add areaflag hack to detect correct areaId
Fix most of the gcc warnings

* use UI64FMTD instead of "%u" for uint64 output
* on most *NIX systems, I64FMT is "%016lX" and not "%016llX"
* also fix typo: renamed GridMap::loadHeihgtData to
GridMap::loadHeightData

Note: there are still many warnings from the 3rd party libraries g3dlite
and ACE. Those warnings won't be fixed with that commit.
Also, a few warnings from MaNGOS are left, they'll be fixed later.
Adjust max nextMoveTime to 10000+totalTravelTime for random
movement

This is apparently closer to how the world should look like, which is
still of course a best guesstimate.
Removing the option for run chance from generic random movement
generator

Npcs with random movement in general do not behave like this, and movement
that fits the pattern of a mixed movement run/walk must be made instead if
needed.
Some cosmetic cleanup in random movement code.
Implement ConditionType CONDITION_LEVEL for PlayerCondition
Limit maxTargets for spell 42005


just DTS and AC

 

[DjAligator]

YTDB 236
+ All fixes from forum
+ spawn
+ quest scripts
+ mob's gossip menues
+ many the operating time
Mangos 9113 - 9130
Add helper functions to set/getSummonLocation

This should help the poor homeless that does not have a database defined
home at evade (such as "wild summon" without owner).
Limit maxTargets for spell 28542 and 55665

Also add missing comment for target exclusion
Fix typo in error output.
Lost break/return in CONDITION_LEVEL cases.
Add dummy effect at aura removal for spell 32286
Fixed problem with not set
AchievementCriteriaRequirementSet::criteria_id

This important for support ACHIEVEMENT_CRITERIA_REQUIRE_INSTANCE_SCRIPT
Add achievement creteria requirements for
ACHIEVEMENT_CRITERIA_TYPE_BE_SPELL_TARGET*

Most ACHIEVEMENT_CRITERIA_TYPE_BE_SPELL_TARGET and
ACHIEVEMENT_CRITERIA_TYPE_BE_SPELL_TARGET2
not need any additional requirements (so just
ACHIEVEMENT_CRITERIA_REQUIRE_NONE(0) in DB) but some
need map difficualty checks and some
ACHIEVEMENT_CRITERIA_REQUIRE_INSTANCE_SCRIPT also.
Implement option to use delay in ForcedDespawn for creature
Implement dummy effects for spell 50926,51026,51592 and 51961

Note: Some adjustments in addition to original patch, using delay despawn.

Also provide sql update for proper work of affected spells (if already
exist in database).
Updated copyright notice for new year.

Also fix some lost in past cases.
One lost cases in year update
Fixed typo in README.
Add dummy effect of spell 46167

SQL update included to ensure proper work (if database has existing data)
Correct makefile copyright notice year, again

Blame the tools!
Allow use delayed forced despawn also in EAI.
Updated doc/EventAI.txt version.
Rename BG/arena queue_id to bracket_id and related functions/etc

This is more consistent to wide used terms

Also some other cleanups.
Implement spell 48603 script effect.

Also apply some ordering to existed spell cases code.

 

[DjAligator]

Mangos 9131 - 9171
Use more generic check for IsLootCraftingSpell

This include spell 69412 to autoloot generation spells.
Some enum fixes.
Merge remote branch 'origin/master' into 330
Fixed crash at loading from `player_classlevelstats` level 0 data.

Added check that prevent loading data for unexpected level 0.
Compile fix.
Fixes in talent 11129 work.

* Restore after client switch talent triggering.
* Propertly remove triggred auras stack or main spell aura at
expire/cancel.
MaNGOS 0.15 release.
Bump for 0.16.0 development.
Merge branch '330' - Switch to support client version 3.3.0A

You need extract new dbc.

Also recommended extract new map/vmaps.

And apply ofc sql updates that including character convertion.

Special thanks to TOM_RUS for continue work at next client versions
support
Add prev/new supported builds explcitly to realmd supported builds
list.
Implement glyph 45783.
Implement glyph 40913
Let aura after seal do at least one finish tick for stealer.

* Set periodic to fit new aura max duration range for this
* This also prevent crash for soem auras at steal.
Prevent memory lost at pet declined names loading.
Move start outfit items check to server loading.

Also drop one not needed now hack.
Typos
Propertly update combat ratings fields.

* Implemented proper combat rating fields update like other stats fields.
This will prevent reset combat ratings at .reset stats for example.
* Skill loading moved after InitStatsForLevel for prevent reset fields
setup
as part of aura apply from skill set triggered spell casts.
This fix for example talent 53125 work (combat rating set at skill
loading)
Small cleanups in pool system code

* Mark some pool system functions as constant
* Drop unused field.
More poolmgr cleanps.

* Replace mixed values used type args by function template specializations

* More explcilty show fact that poolmgr work only with db guids.
More code cleanup in poolmgr.

* Use normal result pointer instead args pair in pool roll.
* Send PoolObject pointer into (Re)Spawn1Object and set internaly spawned
field.
Revert "[9042] Remove double apply bonuses for spell 635/31935 and
ranks"

* This reverts commit 2157bc1b2fb064bd6bf0dfa5b4152d13760450c5.
* And drop DB bonus data.

Thanks to MrLama and pasdVn for reseach problem.
Drop code and DB data for removed 31892/53720 and related spells.
Fixed some paladin spell bonuses

* Use stack size in additional spell damage for 31803/53742.
* Use in code calculation for additional spell 20187/20375 damage

Thanks to MrLama for small cleanups and patch updating.
More paladin spells fixes

* Allow stacking caster effect with target effect at same player for
53736. Provided by KAPATEJIb.
* Allow proc 53736/31801 at melee hits or melee like spell hits
Prevent unexpected removal of move flag for following creatures not
in combat
Use in code heal amount calculation for 20165.

Thanks to MrLama for small cleanups and patch updating.
Implement spell 20375 targets amount depndence from triggering
source spell.
Update spell_proc_event for spell 20375, 21084, 31801.
Implement talent 19552 and ranks affect of spell 61846 and ranks.
Prevent crash after .goname/namego teleports at same bg/arena.
Fixed build errors for contrib/extractor at some x64 plaforms
Skip invisible/stealthed and not detected targets from threat list
at next target selection.

This will fix work spell 58984 and similar in combat.
Implement and use PROC_EX_FULL_BLOCK

It used for spell 31245 and ranks new proc flags.

Original patch provided by dardennf.
Drop unexpected added copy of sql update.
Allow SPELL_AURA_PERIODIC_LEECH to crit if able to.

This allow DoT crits from 2944 and ranks for example.

(based on commit be72957)

Also included improvement from Lynx3d for resilence and crit threat
affect.
Update splitConfig.txt for vmap generations.

This will fix large size some generated vmap files and optimize server
work with its.

NOTE: in fact no changes in real in game data but for optimize work better
regenerate vmaps with new splitConfig.txt.
Use enum for CONFIG_SKIP_CINEMATICS values.

Just small code cleanup
Implement speed reduction at creatures DoFleeToGetAssistance
Fixes/cleanups in extarctor code.

* Avoid create debug binary version with space in name, ignore it in git
changes.
* Alow filenum == 0 in archive file lists. Some currently not loaded fiels
have its
for example in case when in archive single file.

NOTE: no change in extracted files, so not need re-execute.
Remove unused arg in new function added to prev. commit.

Also update ad.exe
Correctly work with alternative locale names.

Allow use enGB locale subdirectory for DBC files.
Move accaptable builds check/list preparing to functions.

Maybe DBCStore.* not best place for its but we not have src/game local
file for common functions...
Impleament DBCs build check at server startup.

* Extractor now include in extarcted DBC dir data file with build info.
* Mangosd use this data for check at startup for main DBC dir and DBC
local subdirs intergrity.
* Also updates DBC checks for raw data.

NOTE: You need reextract DBC data by _new_ extractor for correct work
mangosd.
Update pet and minipet monster move flag at player toggle walk/run

 

[DjAligator]

Mangos 9172 - 9209
Fixed unreaded packet tail spam at group inviting.
Remove character_queststatus_daily data at character delete.

Data deleted anyway at next daily status update so just more early and
expected cleanup.
Target limit for spell 25991.
Remove duplicate fclose call.

At some platform can cause cras at server startup.
Add commented check for unit_class == 0.

In fact creature unit class must not be 0, but some creatures (like
triggers) have this.
Remove /Wp64 option for git_id vcproj files.
Lost changesat my prev. push
Update formula for GameObject 'autoclose' time (dataN-field in
_template)

This require database support/dataN-fields update for correct calculation
of time (now in milliseconds)
Add function to send custom animation for GameObject

Replace in code where packet used explicit.
Rewrite parts of GameObject use for GO type 10

This implement using autoclose time for type 10 and also sending a custom
animation for some.
To avoid duplicate code, remove code from SendLoot() (handled in Use()
instead)
Replace 0 with NULL in a few CastSpell calls (removed where not
needed)
Add filter in VC project files for motion/movement generators and
related
Fixed unread packet tail spam for CMSG_LEAVE_BATTLEFIELD
Auto-leave player at login back to bg/arena when bg/arena finished.
Templated functions for apply some code to all controlled units.

Also fix some related problems with not updates totems/etc
Fixed problem with non-attackable pes/totems at arenas

... and other FFA areas. Problem is result chnages in related flags work
after old 3.x switch.

* Added high-level functions for FFAPvP state set for unit
* Apply FFA PvP to all controlled units also at set, and at summon/load
Implement MoveGen::Interrupt call.

It can be used in time when need do some tasks before
another movement generator add on top to motion stack.
This just finish pair Interrupt->Reset similar Initilize->Finilize
In general movementgenerator have states:

Initilize=>Interrupt<=>[-some addition movegen->]<=>Reset=>Finalize
Fixed build error at *nix.
Remove not needed and currently unused header file
Fixed crashes related to recently totem acccess function

* No search if not in world (no totems then)
* Check NULL.
Fixed typo in error output for lock id gameobject template data
check.
Implement dummy effect for 46797.
Implement default min player per team at BG same as max players.

This let use now default requirement for not set in
`battleground_template` min/max values (or =0)
In other cases just set expected data into template table.
Update some comments for GO autoCloseTime to reflect changes in
9179
Prevent corrupt in-game used strings by DB escaping.
More propertly update walk mode for player pets.

* Use AddMonsterMoveFlag instead SetMonsterMoveFlags for set walk-mode
* Apply walk/run mode to all copntrolled units (except totems).
* Synchronize walk/run mode at pet creating/loading.
Replace targeted movegen by 2 new: chase/follow movegens.

NOTE: this is mostly just formal adding 2 movegens with very limited
cleanups.
Real result from adding 2 new movegens possible after apply more deep
cleanups/fixes
in UNIT_STAT_CHASE/UNIT_STAT_FOLLOW set. But this will need more cereful
changes
because we have currently sometime strange dependences and places for set
for this flags.
Similar cleanups required for other movegen related flags. Infact i have
related patches but
need more testing before apply step by step.
Clarify debug log message in GameObject::Use
Move handling of most GO's from SendLoot() to GameObject::Use()
Fix typo from [9200] and clean up code in function.
In attempt make GCC happy with chase/follow movegens code.
Use CalculateSimpleValue as delay, used in spell effect 86
Possible queue bug fix.
Player flags enum update.
Move remaining handling of GO from SendLoot to GameObject::Use
Move script call GOHello to GameObject::Use

This provide more accurate call in case of delay use from spell effects
Some code cleanups.

* UNIT_STAT_SEARCHING not used
* Remove some commented wrong code
* WaypointMovementGenerator<Creature>::Initialize() not have code
Fixed chase/follow functions calls in movegen templates system.

This commit specially made indeepndent from other changes for show problem

in my prev. commit where 2 new movegens added.

For proper call Initilize/Finilize/Reset/Interrupt/Update functions
_important_
set second template arg in MovementGeneratorMedium< T, D >
in _last_ class in class chain. In other case in chase/follow instead
TargetedMovementGeneratorMedium
In other cases will called referenced functions from
TargetedMovementGeneratorMedium
instead proper subclasses.
Big cleanup in UNIT_STAT_* use

* Re-number enums by function groups and use where possible new defined
masks in code instead raw enum |-lists.
* Avoid use movement generator generic state markers like
UNIT_STAT_CONFUSED for mark movement stoped.
Add special shadow UNIT_STAT_CONFUSED_MOVE/etc states for like use.
UNIT_STAT_CONFUSED in like case will be safe expect use for normal
checks confused state presence
And UNIT_STAT_CONFUSED_MOVE for check real move in this state
Finish synchonization walk mode for pets.

* Re-sync at follow mode switches
* Support sync for creature pets

Also
* Attempt fix build at *nix
* Drop unused unut state mask with typo in name.
YTDB 246
+ All fixes from forum;
+ spawn
+ quest scripts
+ mob's gossip menues
++ branch 3.2.2a => 3.3.0a
+ "quest_template" + 204 (full for 3.3.0a)
+ "creature_template" + 390
+ "gameobject_template" + 181
+ "item_template" + 818
+ "creature_involvedrelation" + 47
+ "creature_questrelation" + 48
+ "creature_loot_template" + 1666
+ "gameobject_loot_template" + 95
+ "disenchant_loot_template" + 149
+ "item_loot_template" + 36
+ "skinning_loot_template" + 3
+ "npc_vendor" + 988
+ spawn (including new quests)
- new event quests in the game are not available yet (no data, will be available later), also (to avoid the "freebie") are not available, some normal quests - they are all still in the development.
+ Icecrown Citadel: Halls of Reflection ("alpha")
+ Icecrown Citadel: Pit of Saron ("alpha")
+ Icecrown Citadel: The Forge of Souls ("alpha")
- Icecrown Citadel (Raids) - closed (in dev)
+ processed 273 caches (3.3.0a)

---------- Post added at 06:09 PM ---------- Previous post was at 04:22 PM ----------

added DBC, maps, buildings.

 

[storek55]

Thanks for update...But why i cant download mangos and scriptdev and stuff? For some it gives me to it currently unavaible