Mangos Mangos + YTDB + Scriptdev2 + Changelog

[DjAligator]

Mangos 10637 - 10658

Better totem summon cases selection.

But added check still not allways work. Unclear better way selections for summon prop id 61
More appropriate for warrior spell fail result for combo point check fail.
Making dummy effect of spell 54530 be positive effect.
Implement instance guids with proper HIGHGUID_INSTANCE use.
Fixed use item dynamic/item proto flags.

* List its independelty. Each from this 2 fields have own flags. Cleanup lists.
* Not copy proto flags to item flags update field. This fix heroic item versions
  show in client in result mixed use ITEM_DYNFLAG_WRAPPED (0x8) with ITEM_FLAG_HEROIC (0x8)
* Update uses to proto case use for some cases where before wrongly has been used item dyn.flags
* For ITEM_DYNFLAG_UNLOCKED (0x4) set for item at unlock and check for prevent re-unlocking.
  This mostly for future case when will be implemented partly loting items support.
* For ITEM_FLAG_LOOTABLE (0x4) check loot absent or conflicting setting with containers/casted at use items.
  Report wrong cases art loading.
* Better check related loot tables content using ITEM_FLAG_PROSPECTABLE and ITEM_FLAG_MILLABLE
Implement spell 56826
Update the ACE part we use to 5.8.2
Remove wrong check preventing lootable itesm have at-use spell casts.

But note: like at use spells cast at loot open not implemnted yet.

Also fixed typo in ITEM_DYNFLAG_READABLE.
Use more make sense corpse expire check timer period.

Use 3 hours timer when bones really expired by Corpse::IsExpired code each 1 hr
just lol ;) So restore old 20 min time used long time ago.

Thanks to TGM for pointing to patch.
Preserve creature dynamic flags at UpdateEntry
Show die animation at totem destroy.

Or any creature type die with linked unsummon.

Original patch provided by Eggxp.
Typos in mangosd.conf.dist.in

Also thanks to Marik for additional typo fix and diff preparing
 Enchanted spell 8017 and ranks should apply to weapon by client auto selection
One more typo in mangosd.conf.dist.in
Fixed combat log being bugged by pets without name
Allow set pvp flags from creatures *_addon data
Implemented MSG_MOVE_KNOCK_BACK opcode

 * Player's knockback movement now smooth and doesn't looks like teleporting
 * Cleanup WorldSession::HandleMovementOpcodes, separated opcode specific and generic movement handlers code
 * Handle Feign Death aura interrupting into more appropriate place
Allow creature to offer same quest for more than one game event
Add support for monthly quests

Quest that can repeated each month are set by quest_template.SpecialFlags |0x04 flag
Quest are reset at midnight the first day of each month.
Note: for the time being, quest must also be set repeatable (SpecialFlags |0x01)
Rename quest function HasFlag to HasQuestFlag
Separate quest_template.QuestFlags from SpecialFlags

Create enum for SpecialFlags (database flags and internally computed)
Added related functions for specialFlags and update code accordingly.
Add enum as argument for quest special/flags functions

YTDB 348

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus

 

[ElderScroll]

2010-11-08 20:47:14 Using configuration file mangosd.conf.
2010-11-08 20:47:14 World Database: 127.0.0.1;3306;****;*******;mangos
2010-11-08 20:47:14 MySQL client library: 5.1.49
2010-11-08 20:47:14 MySQL server ver: 5.1.52-community
2010-11-08 20:47:14 Character Database: 127.0.0.1;3306;****;*******;characters
2010-11-08 20:47:14 MySQL client library: 5.1.49
2010-11-08 20:47:14 MySQL server ver: 5.1.52-community
2010-11-08 20:47:14 ERROR:SQL: SELECT required_10655_01_characters_character_queststatus_monthly FROM character_db_version LIMIT 1
2010-11-08 20:47:14 ERROR:query ERROR: Unknown column 'required_10655_01_characters_character_queststatus_monthly' in 'field list'
2010-11-08 20:47:14 ERROR:The table `character_db_version` in your [CHARACTER] database indicates that this database is out of date!
2010-11-08 20:47:14 ERROR:
2010-11-08 20:47:14 ERROR: [A] You have: --> `10160_02_characters_pet_aura.sql`
2010-11-08 20:47:14 ERROR:
2010-11-08 20:47:14 ERROR: You need: --> `10655_01_characters_character_queststatus_monthly.sql`
2010-11-08 20:47:14 ERROR:
2010-11-08 20:47:14 ERROR:You must apply all updates after [A] to to use mangos with this database.
2010-11-08 20:47:14 ERROR:These updates are included in the sql/updates folder.
2010-11-08 20:47:14 ERRORlease read the included [README] in sql/updates for instructions on updating.

 

[DjAligator]

Long time no updates


Mangos 10659 - 10737

Fixed mistake in [10653] that causes player to fall from the transport at teleporting to another map
Make quest for game event be independent of source

Create new table and convert existing data.
Simplify how game event quests are activated during event by adding generic function to set quest active/inactive.
Any quest in game_event_quest are disabled until event start (and deactivated once stopped)
Update VC10 filers for new ACE
Implement partly item looting

* Not deleted normal item loot at first loot window close.
* Save current item loot content to DB for later continue looting.
* Cleanup spell effect SPELL_EFFECT_OPEN_LOCK check code
* Cleanup Player::AutoStoreLoot calls
Fix totem animation at normal unsummon.
Rename arena_team_stats fields for better fit to stored values.
Allow use faction data for cases raceMask==0

Also some related code cleanup
Implement ACHIEVEMENT_CRITERIA_TYPE_HIGHEST_*_RATING
Timed Achievements, Fail-Support and Opcodes
Implement CONDITION_*ITEM_WITH_BANK conditions.

Similar CONDITION_*ITEM but including character bank content in counting.
Fixed mana amount for overheal case for talent 31785 and ranks.

Also thanks to Wojta for patch code improvements.
Restore build at real C++ compilers after recent timed achievements commit.
Convert some Unit owner/etc guids to ObjectGuid way.
Allow damage own pet in sanctuary.

Also mome repeating code to new function.
Include `item_loot` into pdumps
Show some SPELL_AURA_MOD_DODGE_PERCENT auras as debufs as expected.
Ignore BOA items reputation requirements at use.

Item reputation requirements checked at buy, and in quest case
related quests expected to have own reputation requirements
preventing rewarding items with not fit reputation requirements.
Fix repeating looting for milling/prospecting.
Send to creature/etc Update call real diff from last update and use it.

Now in case when creature/etc some tices not updates in result stay
in not active (no near players or active objects) cell some important
timers (corpse decay, summon timers, group loot expire, aura durations, etc) will
updates at real diff time from last prev. update call.

For some systems added exclude use real diff time because current limitations
like move generators. So its stay use last tick diff and considered freeze and
skip all time while creature in not active map part.
Revert "[10675] Ignore BOA items reputation requirements at use."

This reverts commit 4ce902e5d9c3cfc635c0eff1ba3552da5ecd0c5b.

Check done at client side so useless skip it at server side.
Proper fix expect show diff items in vendor list depndent from required reputation.
New table `npc_vendor_template` for comon item data for diff vendors.

In vendor list show own vedor items + template ites if any.
Vendor template item lists selected by id stored in creature_template.vendor_id
Update item buy code for new way vendor item lists work.
Added new Cell::Visit* functions to visit grids with center in (x,y) coords

* This fixes possible problems with Spell::FillAreaTargets(center of search should be (x,y) position, not spell caster's position)
* Cleanup Cell class, removed old and unused code
New table 'item_convert' for convertion items.

* Implment vendor at show replace BoA item with reputation requirement
  by identical item without rep. reqs for player that fit this requirements
  of original item.

* Table also can be used for store item convertion data form one team items
  to similar other team items. This case not impement but added function easy
  used for it.

* Note: strict single convert for item not created problem for both way use:
  item converted for same team or all, can't be original item for conversion to
  another team.
Revert "[10677] Send to creature/etc Update call real diff from last update and use it."

This reverts commit 10784a8c7cc81c468b5411e973d36ecf31de9603.

Main reason: impossibility for me as commiter test problem and fix all corner cases problems.
Fixed mangos.sql `creature_template` default content after adding vendor_id
Fixed creature_template loading after vendor changes.

Thanks to insider42 for problem research.
Update outdated comment
UInt32 timer class copies instead using time_t timers for mstime cases.

Also cleanup weather update code and some random code cleanups.
New version of patch for send real diff from last update.

In new version last update time stopred for specific Cell that store all world objects
placed in it. All objects of Cell updated (or not updated) in same time.

Original version provided by ciphercom.
Restore some item checkes for temporary loot case.
Fixed *nix build problem after recent commits.
Add dummy effect of spell 53475, 53487 and 54015
Fixed some GCC warnings and code errors.

Thanks to freghar for provide cleaned list of warning messages.
Fixed wrongly use %d for guids in DB queries.

This can affect correct result in cases big guid values
(out of range for possitive part of int32 range) at x86 platforms.

Some other cases addded in addition to original patch fixes
where %d wrongly/unsafe used for unsigned values.
Update SpellEntry based on the work of TOM_RUS
Use portable ACE way msecs time value calculation

Avoid use unsafe code for non-Windows platforms
Thanks to Marik for research the problem and Ambal for helping me with this patch
Cleanup some death state enums usage.
 Avoid selection despawned creatures as spell autoselected targets.

Original patch provided by virusav.
Less strict check for update at war state for factions

Clarify in comments of recent added spell dummy effect
Compute cell area bounds for active objects in the same way like it done for players
Add debug note for not implemented summon property group
Remove unused structure GridUpdater.
Correct check percent spell costs in AI::CanCast

Also use uint32 for spell cost fields/results
Fixed loading mails broken after [10692]
Check SPELL_ATTR_IMPOSSIBLE_DODGE_PARRY_BLOCK for special attacks.
Add the option to close gossip window in gossip system

Field action_menu_id in gossip_menu_option table can be set to -1 where close gossip is expected, instead of sending a new menu.
Simplify CellArea calculation
Implement talent 30326 for spell 5138.
Move Glancing Blow early in melee outcome results.
Update ACHIEVEMENT_CRITERIA_TYPE_LOOT_* with group roll.
Prevent wrongly use transport guid as unittarget in spell targets
Fixed typos in my previous commit
Check localization data for existance main table entres.

Data will skipped for nonexistent entries, and reported with
disabled LogFilter_DbStrictedCheck filter.
Startup checks for `gossip_menu` and `gosip_menu_option` table data.

Existance `gosup_menu` id refercned from gameobject field and unused meni ids
activated only with disabled LogFilter_DbStrictedCheck.
player/group instance binding fixes.

* Use anum instead raw uint8 type in args
* Fixed crash when gm at continent invite to group gm in instance
  and then teleport to instance using .goname.
  When group leader teleport to instance it must get group bind instead solo bind.
* In other semilar cases detection report error as before but replace solo by group bind instead
  assert crash at enter to map.
Avoid unexpected error at action_menu_id < 0 after recent loading checks adding.
Fixed move in inventory items with ItemLimitCategory.
Typo show commit before revet all realddiff one more time.

Typos show that in fact "working" has been result typos diabled state for relamd.
Cell-based way have not avoidable problems with case when object added to not active
long time Cell. If someone find more working sollution it can be readded ofc.
Revert "[10716][10688] New version of patch for send real diff from last update."

This reverts commit 8398a55fa274471daae115e00c627b299a3fdbbd.
This reverts commit 06e2d6859ba3d7fd47be72c23a64e68ae039701f.
Partly revert "[10687] UInt32 timer class copies instead using time_t timers for mstime cases."

This reverts commit 967877fefd91e00895f9790dc006b532b94d41b7
in part MapManager/World timers.

Main reason: unclear source cases wrong mstime diff generation at WorldRunnable level at *nix systems.
So need have existed in past hacks that skip its.
Implement proper calculation quest honor reward.

Now server side rewar same as reported at client side.

Also thanks to KiriX for patch prepering to commit and testing.
Implement check `gossip_menu_option`.`npc_option_npcflag`.

For cases main menu options used by creature but impossible show in result absent
related npcflags for any creatures used that menu.
Use required_quest instead of _heroic for non_instance areatrigger teleport
Fill target map for TARGET_RANDOM_NEARBY_DEST(b) cases.

Corrects ~35 spells, where most has summon effects.
Backports from 400 branch.
Add dummy aura effect of 51405 and dummy effect of 51420
Fixed wrong error message for quest related areatriggers.
Fix TARGET_AREAEFFECT_CUSTOM, need to obey type when DB target entry exist
Add a few comments for SUMMON_PROP_TYPE_CRITTER
Correct one SQL in tools, table was renamed.
Map system re-engineered. Special thanks to Blueboy for tests.
Fix Deathly Stare spell
Add dummy aura effect of spell 47178 and dummy effect of 47176

Note: see comments in code for spell 47176
Check if Pet's target is a valid target (isTargetableForAttack)
Remove redundant isAlive-check, thanks LordJZ for notice
Not send session fields as args into HandleMoverRelocation/VerifyMovementInfo.

Also mark args as constant where expected in this functions.
Implement defencive guardians pet type for creatures like 28120
Rename and clarify SummonPropertiesEntry.Type->Title field meaning.

This also show why we have some problems with sorting sumons by types base at this field.

Thanks to TOM_RUS for research.
Fixed spell 51420 work by use recently added protector pets as expected.

Thanks to NoFantasy for problem research (and prev. new pet type adding case research aslo) ;)
Fixed  unexpected typo in prev. commit.

YTDB 351

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus

 

[DjAligator]

Mangos 10738 - 10777

In fact set pet name to empety state redundent.

Client work propertly also if used default name from creature template (set in create code).
Cleanup pet remove code and some fixes.

* Merge Player::RemovePet and Pet::Remove function code to Pet::Unsummon
  This let be sure that in all cases all required steps doen. For example this fix
  creature's guardians propertly remove from guardians list.
* Add new pet save mode PET_SAVE_REAGENTS as replacement PET_SAVE_NOT_IN_SLOT+true-arg stable pair in old function args
  This will avoid use reagent save arg with wrong different save modes.
* Fixed recently added code with absent check for re-summon protector pet call.
 Cleanups in spell effects names.
Add AI function OwnerKilledUnit for protector pets (when owner kills unit)
Add `spell_bonus_data`.`spell_bonus_data` field and support for RAP bonuses use for spells damage from table.

Thanks to insider42 for prepering patch for mangos repo.
Also added loading check for redundant ap/ap_dot data in table.
Add AP/RAP bonus data to `spell_bonus_data`.

Also remove related hardcoded cases.
Prevent equip/unequip items in process logout
Use ObjectGuid in spellauraholders instead uint64

(based on rsa's repo commit 06342c1)
Use objetguid for other .list auras command part
Some other aura caster object guid use cases.
Convert MonsterSay/Say and similar functions to ObjectGuid use.
Convert Gameobject owner to objectguid use.
Convert Gameobject owner to objectguid use.
Use objectguids in item code.

Also
* Fixed unexpected container updated state after inventory load
* Make .debug getitemstate command more friendly by args.
Convert to objetguids map scripts and finally drop IS_PLAYER_GUID.
Lost mangos.sql changes in one from recent commits.
Use UNIT_FIELD_CRITTER for store minipet guid.

Also move related code to Unit and allow summon minipets by creatures.
Also fix creature's totems unsummon at owner remove from world.
Use class specific combat rating factors from gtOCTClassCombatRatingScalarStore.dbc

* Some classes had effect of melee haste buffed
* Change to armor penetration rating was hidden there too
Implement armor penetration limitations

The tool-tip says "up to X%" for a reason...
Implement zone limited pets unsummon at leave allowed zones.

* Also remove redundant zone/area args for zone/area update function like UpdateZoneDependentAuras.
* Merge Player::*AllControlledUnits functions to Unit version with replace option args by mask arg.
* Unit::*AllControlledUnits guardian iteration make working with internal unsummon call suport for guardians case.
Fixed typo in CONTROLED_*
Correctly reset mob orientation upon reaching spawn point. Should also improve visualisation of mob orientation on clients
Remove unneeded non-player Say et al.

Now expected direct use non-player WorldObject::MonsterSay/etc version
Basic support for target-name in MonsterSay/etc

Change MonsterSay's target to pointer.
Implement SPELL_AURA_IGNORE_UNIT_STATE (252).

Original patch provided by Wojta

Note: From patch excluded talent 44543 and ranks stacking code.
      It look like need another implemention different from suggested,
      or at least more research.
In patch added enum IgnoreUnitState and related checks now more cheating protected.
Move comments at 61 line, no functional changes.
Implement talent 44543 and ranks charges work.
Also fix IGNORE_UNIT_TARGET_NON_FROZEN in part allow casting spell that required frozen target.
Implement SPELL_AURA_MOD_PERIODIC_HEAL (259)
Allow AURA_FORCE_MOVE_FORWARD to work on creatures and vehicles. For example, it fixes spell [68284]
Show <overkill> value in combat logs.
Remove useless code in PetAI::_stopAttack()

Those are all processed elsewhere and _stopAttack() can not be called when pet is not alive.
Fixed trainer flags uses for pet trainers.

* Not exclude trainer flags for client for pet trainers.
* Not report error for pet trianers empty spell lists.

TODO:
* Add check for redundent trainer spell data for pet trainers at server startup
* Need hide train gossip option for pet trainers, but currently without it gossip
  window not open for pet trainer by some unknown reason.
Fixed auction items filering by quality.
Explictly include Threading.h into WorldRunnable.h

Instead dependent from includes order in mangosd\WorldRunnable.cpp and mangosd\Master.cpp
Fixed build for different PostgreSQL version at diff platforms.

* Fixed Problem in different place define OID enums.
  Enums hardcoded in mangos code now as done for many other projects using PostgreSQL

* Other PostgreSQL detection fixes.
Fixed crash at empty build list in realm string.
Implement more generic reputation spillover

* Also fixes factions 1037 and 1052
* More correct client output when reputation assigned to parent faction
* reputation_spillover_template can still be used to override spillover from dbc
Use separate vars to indicate whether reputation needs to be sent or needs to be saved.
Not mark `reputation_spillover_template` empty state as error

Now expected by default data used from dbc fields.
Explictly include Threading.h into CliRunnable.h

 

[DjAligator]

Mangos 10778 - 10792

Make AI call OwnerKilledUnit() more proper.

Affect any pet that are not being controlled (minipet/guardian/protector) and will also apply to pets owned by another creature.
Allow ITEM_ENCHANTMENT_TYPE_COMBAT_SPELL to proc on special attacks too.
Fixed warning in ReputationMgr::SetReputation.
Use BattleGround(AV)TeamIndex enum types in AV battleground code.

* Added BattleGroundAVTeamIndex enum type for 3-case special team list fo AV.
* Rename BattleGroundTeamId -> BattleGroundTeamIndex for clarify
* Some safe checks added and dropped bogus call RewardReputationToTeam in BattleGroundAV::HandleQuestComplete
  for BattleGroundTeamIndex as faction. Unclear for what it expected used so dropped.
Use Team enum types in all appropriate cases and catches bug in result fix.

* Fixed wrong arenaid use at leave arena queue.
* Fixed memory lost and etc at not virtual EndBattleground call
* Fixed crash at arena join with fake data from client.
* Code cleanups.
Fixed comment in characters.sql
Restrict items with generated loot really to single character only.
Fixed warnings at comparison BattleGroundTeamIndex and BattleGroundAVTeamIndex

Maybe adding special operator== or != can be more nice way but for small used cases this
not look so need really.
A bit spell proc housekeeping

* PPM values for enchanting spells 13898, 20029, 20032, 44524, 44576
* Correct cooldown for enchanting spell 59625
* Add procEx and cooldown for item 50198
Add explicitly header dependences for Database/QueryResult.h
Replace bytes in single field `bytes2` by independent fields for `creature_addon`.
Allow use old non-builting ACE versions (pre-ACE-5.5.4) at Unix-side.

This fix build error in relamd code in result
nonexistence ACE_OFF_T in old ACE versions.
Moved vmap code from shared to game project

After this, realmd code does not contain anymore vmap code
Small cleanup in VC100 filter about vmap files
Fixed more warnings with BattleGroundTeamIndex/BattleGroundAVTeamIndex mixed use.
Fixed warnings and need in redundent char* casts in database access code.

YTDB 354

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus

 

[DjAligator]

Mangos 10793 - 10834

Fixed build problems for vc90 after recent vmaps dir move.

VC80/VC100 not affected by this.
Player.h expected DBCStores.h including.

So make it direct.
I must less press random buttons before push in monkey mode.
Use regular map case in all trigger checks.
Check for valid sheath state in creature addon at startup.
Some more warning fixes related to BattleGroundTeamIndex/BattleGroundAVTeamIndex.
Add GetGuidStr() short call for GetObjectGuid().GetString() and use it.
Use ObjectGuid in some battleground structures.

Also fix some catches bugs in code in result.
More ObjectGuid uses in battleground code.
Use ObjectGuid in Mail code.

Some catched bugs fixed in mixed uint32/guid values using cases.
Use ObjectGuid in player loading code.
Restore build at *nix.
Remove code duplication in visibility distance check.

at_same_transport already include player checks at assign and
it move to common if make 3 distance cases exactly same.
Fixed typo in m_PrematureCountDownTimer initila value set.

Just fo note: in fact initial value assign not used because
m_PrematureCountDownTimer always init and used only in case
m_PrematureCountDonw == true
Typo fix and memory layout optimization.
Small cleanup and optimization in transport current point update.
Remove diplicate World::GetQueueSize and rename functions to consistence naming
More ObjectGuids specially in petition code.

Some uint64<->uin32 bugs fixed at read guids from DB in petition code.

Still exist 29 GUID_LOPART uses in code.
Use ObjectGuids in chat commands.

Still exist 15 GUID_LOPART uses in code.
Use ObjectGuid for corpse owner guid.

Still exist 9 GUID_LOPART uses in code.
Use ObjectGuid for aura holder cast item guid.

Still exist 7 GUID_LOPART uses in code.
Convert to ObjectGuid aura cast item guid access function.
Use in social lists API ObjectGuid form.

0 GUID_LOPART uses in code. :)
Remove GUID_LOPART/GUID_HIPART

* Now no correct way access to internal structure of guid in uint64 form.
  For this always must be used ObjectGuid form.
* Guids in uint64 form still used in some cases (many) but it uses as-is
  Main source of uint64 guids is non-converted opcode handlers.
* Also ofc, possible cases wrong created uint64 guids by assign uint32 to uint64.
  For catch all cases need finish convertion to ObjectGuid all non-converted yet code.
Add explicit include for ObjectGuid.h in AchievementMgr.h.
Add dummy effect of spell 47170
Fixed creature's speed recalculation, forgotten DB speed mods are used now

Also properly update speeds at creature entry change(in case there are aura speed bonuses), thanks to Vladimir for pointing
Speedup and cleanup quest counters update code.

* Always use QuestStatus data for current counters set
  This let be sure that that we not have non sync values in client view and server state.
* Remove some access functions for quest update fields that expected to be only updated/set.
Restore anti-cheating check work at buy item
Fixed "unsigned is never < 0" warning.
Clear way access/set UNIT_FIELD_BYTES_*/PLAYER_BYTES* byte fields.

Fix some bugs when all uint32 field modified instead byte parts.
In some cases added byte way set/get but code line itself need additinal reserch/fix
for use correctness in line pos.
Fixed copy-paste typo in prev. commit.
Move specific SQLStorage defines to game dir

This let have in shared dir only generic declarations of class SQLStorage
Not game specific details.
Fix vmap_assembler compilation after vmap folder move

Also make vmap_assembler compile sucessfuly with VC80.
Add VC80 projects and solutions files where missing like vmap_extractor
Fix warnings for TBB projects compilation using Visual Studio 10

Also fix a small typo in prev commit.
Update SpellFamily check functions.

* Move SPELLFAMILY_* to DBCEnums.h and name it as SpellFamily
* Use enum in Unit::GetAura, move family mask code to new SpellEntry helper function.
* Avoid all auras scan in search of triggred spell for 20243.
 Prevent spell_proc_event entries to proc on any spell cast when SpellFamilyName is zero.

Now only spells that actually deal damage or heal will trigger
when neither SpellFamilyName nor ProcEx & PROC_EX_EX_TRIGGER_ALWAYS are set.
Before, setting a SchoolMask would override this check, causing many bogus procs.
Fixed crash at send mail from console

Inspired by patch from rsa.
Spawn pool at aura 63471 dispel in water.
Avoid use unsafe remove auras in aura apply code.

Specailly example Aura::HandleModCharm code where old code
call RemoveSpellsCausingAura or (a) dead and not called,
or (b) will remove aura self at call.

* Added safe for aura holder context version of RemoveSpellsCausingAura
* Cleanup old simple RemoveSpellsCausingAura code also.
 Cleanup shapeshift form code.

YTDB 355

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ processed 46 caches (4.0.1)

 

[DjAligator]

Mangos 10835 - 10866

Add/correct a couple more spell_proc_event entries for trinket related spells

*Affected items: 45131, 45219, 50359, 50366, 50360, 50365,
          50353, 50348, 50362, 50363, 50342, 50343, 50358
Again ignore EffectSpellClassMask when SchoolMask given in spell_proc_event.

There's just too much garbage in dbc...
Should restore some damage school based talents broken with [10830],
hopefully without excessively triggering other spells again that shouldn't.
Implement script effect of spell 26218.

Also do small spells ordering around.
Not report error for missing reqs for some quest timed achievements.

This achievements in fact not required any additional checks.
At far teleport fail retunr player to source point instead homebind.
Implement server side part of SPELL_AURA_ADD_MECHANIC_ABILITIES (293) work.

Also fix stealth/invisibility visual affect flags changed at some 3.x switch.
Implement charges counting for magnet target auras.

Also implement skip spell effects redirecting if magnet target can't be
targeted by this spell effect base at spell effect target data requirements.
Allow fill DB table spell_script_target for TARGET_AREAEFFECT_INSTANT(7)

Without any database entries for spell, spell will work like before.
Valid targets filled to database can only be creature type (corpse or alive).
Fix AuraType 138 to not affect ranged haste, and rename to SPELL_AURA_MOD_MELEE_HASTE.

Also type 192 had misleading name, rename to SPELL_AURA_MOD_MELEE_RANGED_HASTE.
Remove small redundency in magnet spell charges checks.
Add dummy effect of spell 49634 and dummy aura of spell 56511

note* spell will need data in spell_script_target to work properly.
note* the effect of 56511 does not work, see comment in code for details (code added in any case, to not forget the problem)
Add dummy aura of spell 43874 (indirectly related to spell/effect 50133)
Unsummon guardians at second item use for items without cooldown.
New system for parallelizing client packet processing. Handle WorldSession updates in Map::Update() where we are safe to proceed. Thank you for all your feedback!
Fix build with gcc.
Move common check part for recently added filter classes to helper function.

This is more safe have expected tio be same check in one function.

Also apply some code style fixes.
Small function order in sources update.
Fixed typo in [10847]
 Report about GM invisible state at login if enable.
Fixed crash at .character erase command use.
Add TARGET_AREAEFFECT_GO_AROUND_DEST(52) (renamed from TARGET_AREAEFFECT_CUSTOM_2)

Target selects all gameobject around destination, limited by adding spell with a corresponding gameobject entry in database table spell_script_target.
Correct two whitespace errors
Complete set Byte/ShortFlag value functions and use it for PLAYER_FIELD_BYTES proper access.

Not expected any changes in work.
Add triggered spell part for dummy effect of spell 43572
Search for linked GO using the original used GO as base of the search

Add some comments for future improvements of this function.
Handle GAMEOBJECT_TYPE_TRAP in Use, as done for other GO types.

This just move parts of existing code from TriggeringLinkedGameObject and does not affect summoned trap type GO's (or related to summoned).
Large flightless birds (emu) think they are invisible, even when they are not.

Only if _not_ isGMVisible, invisible notification can be sent :)
Fixed not show and lost mail items in returned expire mails.

Also
* Use typename for mail item info vector.
* Include tools/characters_mail_items_cleanup.sql for cleanup lost mail items.
  It also included as sql update part. Sql update also fix receiver for stored
  in DB expired mail items.
Fixed triggering/use effects for item 54589, 54573, 37734, 32500, 28590.
Implement itemsets 881, 882 at heal/damage target effect.
Make DB code thread-safe. Original patch by Machiavelli and Kero99.
Unsummon guardians at re-cast only for non-triggered case.

YTDB 356

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB

 

[DjAligator]

Mangos 10867 - 10894

Implement templates for trainer spell data in `npc_trainer_template`.

New table let avoid duplication similar trainer spells for different trainers.
Fixed spell 53479.

(based on insider42's repo commit b0343e1)
Fixed typo in mangos.sql added in recent commit.
Properly remove deleted character from friends of online players.
Avoid lost arena match at leave queue (before invite to match)
Grr, restore code style.
Fixed crash for case when trainer have only data in npc_trainer_template.

Good know base at report that this feature so quick start used actively ;)
 Update ACE to v5.8.3

(based on zergtmn's repo commit 3a8c259)
(based on zergtmn's repo commit 946c1a8)
 Update ACE version in NEWS/ChangeLog
Really fix crash in SendTrainerList :/
Traditional 'Waypoint' post-fix in mangos.sql
Update achievement at maximize skill level by command or config option.
Remove support unused option SocketSelectTime in mangosd.conf
 Avoid constant re-save BG entry data at each save for player at bg/arena.
Lost important line in prev. commit.
No error output for empty npc_trainer* tables
Implement item 49982, 50641 equip effect
Pet with same level as owner must have xp = 0

Thanks to Click for original patch and problem description.
Hunter pet can't have < owner-5 level
Also make tame time check call safe.
Fixed crash at GO use in case GO owner/first user offline state.
Add dummy aura effect of spell 42515
Use 0.0f in one function and prevent some compiler warnings.
Add dummy aura effect of spell 42517
Merge apply/remove cases for recently added dummy auras.
Access for core/scripts to creature race info in model dbc
Fix load creature *addon data from database
Speedup check code at `gossip_menu_option` loading.
Fixed problems with new ACE lib on Darwin systems

(based on cipherCOM's repo commit ce2638f)

YTDB 357

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus

 

[DjAligator]

Mangos 10895 - 10944

Description for found gender field in CreatureDisplayInfoExtraEntry.
Detect self-referenced model info in `creature_model_info`.
Small typos in error message.
Fix for pool system problems after map rewrite.
Remove default value for removed config option SocketSelectTime.
Remove SPELL_AURA_MOD_POSSESS_PET auras in Unit::Uncharm()
Allow vehicles to have gossip menu

In addition rename IsGameobject -> IsGameObject.
Simplify code for triggering linked trap
Drop unused code in Unit::MeleeDamageBonusDone()
Cleanup character_battleground_data when deleting characters from database
Fixed vendor templates work.

* Avoid unexpected errors at template loading for shared templates for many npc.
* Really use vendor template in work.
Fix Glyph 45806 to trigger from 49184 and ranks instead of unrelated spells.

Also fix attack power coefficient for 49184 and ranks.
Allow mounts on map 603
Imporve detection need use reagents by triggered spell.

Now regagent used if main spell (if infor about provided to triggered cast)
not have regent data.

This fix reagetn use for spell 43723. But maybe need another fixes for proper animation.
Code style cleanups in scripting related functions
Use provided target instead of caster for SPELL_EFFECT_QUEST_COMPLETE
Fix GCC warning
Move scripting related functions from ObjectMgr to ScriptMgr
Fix db_script_string loading
Remove ObjectLevelLockable inheritance in Map class + cleanup locks in Map code. Restore build after recent commits.
Use HasFlag function for check flags instead raw access.
Restore GameEvent system work after last Map terain rewrite.
Implement dummy aura for spell 75973
Allow SPELL_AURA_MOD_PACIFY auras to affect creatures
Add support for ITEM_MOD_SPELL_PENETRATION
Actually use spell penetration gained by items in calculations
Prevent server freeze at strnage radisu used by item 34124 spell cast
Allow from mute player chat messages CHAT_MSG_AFK and CHAT_MSG_DND.
Revert "[8722] Fixed possible creash."

This reverts commit 8dd3e4b31a31bb6dfc4d9fb51b1b7e67bad4ca16.

This is impossible crash case. Creature object can't be created without creatureInfo != NULL
So crash source can be only result wrong calling ClearInCombat() for deleted or NULL creature.
Cleanup some magic numbers
Send time diff between Update() calls for object - should help with mob respawn on inactive grids etc. Based on patches by VladimirMangos and cipherCOM. All issues from previous patches should be finally fixed now.
Few more vehicle flags

All vehicles with these flags have corresponding movement flags.
Remove player-only limit for HandleAuraTransform where miscvalue is 0

Add error output for unhandled spells plus minor code cleanup
Prevent null-pointer dereference in AI calls
Uncomment all races in enum Races

Race can also be creature race and needed for future implementation of spells.
RACE_UNDEAD_PLAYER renamed to more proper RACE_UNDEAD
Move game event creature morphing code to Creature::UpdateEntry

* This is allow have more clean logic in feature work.
* Prevent modify static creature data.
Add models for spell 65528 and 65529

Add spells in commented form that will need custom handling in similar way for the same aura effect.
Fix mangos build with old ACE libraries after [10924].
Imporvments gameevent creature morphing.

* Table `game_event_model_equip` renamed to `game_event_creature_data`
* Table allow now store same creatures for different events, BUT
  expected that related events no active in same time.
* Added possibility switch entry at gameevent time.
  This let have diff factions/loot and etc for creatures.
* Added possibility cast spells at gameevent start/end.
  Exist some spells that expected casted to creature at gameevent start
  for model replace, and for animation in other cases.

Note: `game_event_creature_data`.`modelid` field posisble will removed soon in fowor related spell use.
      Ofc, when spells will implemented in core.
Fixed crash at modified data from client at trainer spell learn.
Implement dummy effect of spell 7671.

Thanks to X-Savior for reserch.
Move script calls to ScriptMgr

- Script library presence is now optional.
- Some script hooks have new names. Scripting libraries need to be adjusted accordingly.
Correctly show online status of 1.12.1 realms
Add models for spell aura 50517 and 51926
Some adjustments to script calls OnQuestChooseReward replaced with OnQuestRewarded. Also fix compile in VC 8.0 and VC 9.0.
Check non-unit target case for avoid crash in EffectQuestComplete.
Apply mangos code style to in class {} indent.
More strict check player race/class allowed values.
Implement .reload npc_text.
Fixed mangos.sql after rename table to `game_event_creature_data`
Lock action buttons before unlearning talents on spec switch.

This prevents client from automatically requesting removal of buttons that use unlearned spells.

YTDB 359

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB

 

[daddy]

Hi there,
The DK quest "The Light of Dawn" its working in this pack?

Its one of the last quests of DK when you have to assault a church, its basically an event, if you didnt know about it
quest id is = 12801

I tried it but when i click on Highlord Darion Mograin and select "I'm ready HighLord. Let the siege of Light Hope's Begin" nothing happens, also if i tried to autocomplete it and go to Scourge Commander Thalanor , i can't finish the quest by clicking "Quest Complete".
Im choosing the reward but still nothing happens when i click "Quest Complete"

Any ideea?
Thank you

 

[torion]

Re: Previous Update Files Unavailable

:?:

Mangos 10867 - 10894

Implement templates for trainer spell data in `npc_trainer_template`.

New table let avoid duplication similar trainer spells for different trainers.
Fixed spell 53479.

YTDB 357

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus

Where can I get the files for this update? (currently 2nd from last update) I am getting a 'file missing' error from the links and can't get to latest version without the missing SQL updates.

---------- Post added at 10:21 AM ---------- Previous post was at 10:19 AM ----------

BTW... THANK YOU DJ for taking the time and making the effort to post these updates out where we can find them!

 

[reloaded90]

3.3.5.12340????

 

[torion]

3.3.5.12340????

That is the client version you have to be patched up to (NOT PAST). So if you install WOW from disks and start patching you will want to stop prior to the latest Blizzard version. Looking in my folder it appears the patches from 3.3.3 to 3.3.5 were:

WoW-3.3.3.11723-to-3.3.5.12213-enUS-patch
WoW-3.3.5.12213-to-3.3.5.12340-enUS-patch

So when you see these you need to be careful not to patch past the version required.

 

[DjAligator]

mangos script dev mangos sql

all updates from last version here

YTDB

full db then updates

I'm back with updates if you like them

 

[DjAligator]

Mangos 11618 - 11625

Remove depricated GetGUID and forbit implicit uint64->ObjectGuid casts
Make equipment manager handle "ignore this slot" option properly.

Also fix SQL fields to use unsigned values as expected in code, otherwise large values will get lost.
Fixed broken DB update when item updated in DB at loading for some reason.
Really use DB value for creature walking speed after speed update.
Implement ClassFamilyMask as wrapper for uint64+uint32 spell family masks

Inspired by patch suggested by darkstalker

Also
* Remove existed enums for family masks as contra-productive for developement.
* Drop one from horrible hack checks in SpellMgr::IsNoStackSpellDueToSpell
  (spells for any fimilies with exactly 0x800 mask) I fail find useful cases
  for current spell data with this check. All cases expected work correct without it.
  If will some problems detected with this please report for fix in less strange way.
Use 12 bits for high guids
Update comment

Update 2222 - 2225

Fix Compile for MaNGOS Rev [11619]
Use IsFitToFamilyMask wrapper instead of direct access
Update TBC-patch

 

[cuki]

godddddddddddddddd

 

[DjAligator]

Mangos 11626 - 11652

Fix VC100 filters for g3dlite
Restore spelmods apply after ClassFamilyMask commit.
Add explicit to ObjectGuid(uint32 const&)

No reason have implicit wrong uses catch version when main version
of constrictor have `explicit`. This also avoid unexpected selection
catch-version with less readable error output at implicit uses.
Item 8345 energy part.
Possible fixed recent problems with build.

Removed support hash_value look like not used directly in MaNGOS
by testing diff Visual Studio versions and start create rpoblem
after recent changes.
Fix wrong overriding aura stack amount and proc charges at loading

Need to consider spell mods, partial dispels and etc...
Revert part of 11631
Implement function Unit::HasAffectedAura
Periodic damage from spell 1943 and ranks can produce critical strikes
Revert "[11615] Apply normal stealth at expire spell 1856 and ranks"

This reverts commit 1c0bd32.

Thanks to SeT for providing proves for commit wrong way work.
Add two missing initial world states
Implement 10% healing reduction on BGs and arenas
Implement additional damage on expire 29865 and 55053 auras
Limit spells 74410 and 74411 only to bg and arenas
Implement TradeSkill.GMIgnore.* config options

Options let set GM level that allow ignore at training level/skill/maxprofs
Mostly for allow avoid use commands when need learn prof ranks.
Arenapoint Distribution Time can shift every week ~5 min.
 Fixed some added in prev commit warnings.
Restore skill/level checks at traning non-prof spells.
Sets rage to zero and energie to 100% when entering battleground and arena

Move related code to Aura::HandleArenaPreparation (un-)apply code.
Fixed work EffectSummonChangeItem, for example, for item. 17223

Also
* Move item comvert code from spell effect to new function.
* Some code style cleanups.
Implement support item converting at expire

Example: items 44623->44625->44627 convertion chain

* New table `item_enchantment_template` store original->final item pairs
  Original item must have duration setup.
* Small change in GetItemConvert for consistence (now 0 returned if no convert pair instead original entry id)
 Implement glyph 43427.
Breath/fatigue/fire damage timers tick each 2 sec.
Make visible final duration of talent 31221 and ranks effect.
Group members see same group member ghosts.

Also drop battleground case that just same check in fact.

Original patch and research provided by Den.
Not alow show arena statistics before arena end.
Diminishing returns for some paladin abilities.

YTDB 381

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus

 

[DjAligator]

Mangos 11653 - 11668

Add script effect of spells 62521, 62524 and 62525
Implement periodic dummy aura 62566
Add script effect of spell 62678 and 62688

Target 91 may require further adjustments.
For not first repeating quest avoid reward money as xp replacement.
Daily/weekly quests must still reward expirience/max level money at repeating
Revert "[11298] NearUsedPosDo searcher should add only units with correct coordinates. Possibly can help with freezes when 'DetectPosCollision = 1'."

This reverts commit a79ca96.

This restore work object pos selector for units.
Reverted commit make fully disabled it work for multiply attackers case.
Rewrite object pos selector.

* Instead coordinates use angle projections to expected pos distance circle.
  This let do mostly only angle comparison and then speedup checks.
* Fixed some long existed bugs in algo and simplify code. Possible more work need.
Fixed glyph 43427 apply.

Now must affect targets amount only for ability main spell.
Set cooldowns and spell school masks for some trinket spell procs.
Spell 37433 targeting only non-swiming players.

Original patch provided by anti-freak.
 Check at EventAI scripts load diff reqs for event ai real call

* Script existence <-> `creature_template`.`AIName`="EventAI"
* In strict DB check mode: script existence conflict with setting `creature_template`.`ScriptName`
Spell 12298 and ranks must triggering also at parry/dodge.
 Mage T10 2P Bonus trigger only at proc charges aura remove.
Warrior T10 Protection 4P Bonus
Implement transport path rotation

Transport rotation transforms transport path - this makes possible to have few transports with same entry but with modified paths.
This also solvers problems with some transports (like deeprun tram).
TODO: some transports has non standart rotations, that must be stored in db
drop redundand line from prev. commit

Scriptdev 2226

Comment weird return in Scarlet Monastery, thanks to Goaul for pointing

 

[Eisenblaetter]

Hi,

super job!!!

can you compile the last version with AH.
Thanks...

 

[DjAligator]

Mangos 11669 - 11708

Remove script use with EventAI check.

It's not problem if script not have own AI part.
Implement in proper way ITEM_SPELLTRIGGER_ON_STORE (5)

Item spells with this trigger mode expected casted at item add
to inventory/equip slots (exclude bank), and spell auras (if any)
applied while item in like slots. Item expected destroyed at aura
remove by some reason.

Implementation note: because 2 step way item moves from slot to slot
related auras not removed at internal RemoveItem call and removed only
at directly item destroy/remove from player function calles, or at StoreItem
(if item added to not appropriate slot). So need in future careful with new
RemoveItem call cases.
Druid t8 Restoration 4p bonus
Implement glyph 42414.
Fixed spellfamily mask for glyph 45735 triggering.
Fixed names of pets summoned by npc.

* Add check to make sure that creature controlled pet use default name from template.
* Add localization support to pet name query for above pets type.
Skip some unexpected results in ObjectPosSelector::AddUsedArea
Implement glyph 42746
Paladin T10 Holy 2P Bonus
Paladin T8 Holy 2P Bonus
allow 31785 and ranks proc from periodic heals
Druid T8 Balance 4P Bonus
Rogue T9 2P Bonus
Priest T10 Healer 2P Bonus
More consitence use m_target for DestroyItemWithOnStoreSpell call in aura.

This don't must be cases when caster != m_target but anyway not reason have
not nice look code.
Hunter T7 4P Bonus
Death Knight T9 Melee 2P Bonus
Fixed startup error for 31785 in `spell_proc_event`
Mage T8 2P Bonus
Priest T8 Shadow 4P Bonus
Priest T8 Healer 4P Bonus
Shaman T10 Restoration bonus
Typo in select proper spell difficulty function
Fixed damage/heal amount from some triggered HoTs/DoTs.
Send main spell info in EffectForceCast

This help in proper reagents use in related triggered spell.
Implement spell 28560
Implement spell 24780 (switching target every 10s)
Implement spell 51336
fix damage and duration of reflected spells
Fixed spells 50756 and 50758 stack check

Original patch provided by Xfurry.
fix reflect damage if caster can reflect too
Implement SPELL_AURA_DETECT_AMORE (170)

For example used by item 35125.
Command .auction item and support auction without owner.

* New command allow place auction from chat/console and create auction without owner.
* Same code can be used in other place when server code want create generated auction
  without need have associated player. Auction code update for support this case.
* MailDraft::SendMailTo now allow "send" mails to non-players. It correcly drop items in like case.
Alsways attempt generate randomProperty for item in at create if value not pre-selected.

This resolve all existed cases when we miss assign random property id.

Also move random property/suffix check from item creating to server load time.
Proper way create items in Item::CreateItem/CloneItem for items not for inventory

Old code way work not allow create item without providing targeting player.
In result creating item that will not placed to inventory required additional hacks
for undo redundent links to player structures.
Resolve possible crash in auction code for paiment pending state.

Source of crash in sharing item object for sent mail to new owner
and in same time use it in still existed auction for show pending paiment.
Crash possible if new onwer get mail in less hour delay and will drop item
at receive.

Solution: Added fields in memory auction object and table `auction` for
store item stack size and random property id. This let not use auction item
except points where item send to owner at expire and new owner at
buyout/timeout auction with bid.
 Allow have auction bid generated by server

Some code cleanups also.

Fir generation bids can be used auction->UpdateBid(price) call without player pointer.
Use proper text structure in auction mail subject/text

This for example will enable show random property suffix in item name
in auction mails.
Drop unused in 3.x AuctionHouseMgr::SendAuctionSalePendingMail
add negative auras, channeled and regeneration spells immunity for totems

Scriptdev 2223 - 2233

Fix Compile for MaNGOS Rev [11619]
Use IsFitToFamilyMask wrapper instead of direct access
Update TBC-patch
Comment weird return in Scarlet Monastery, thanks to Goaul for pointing
Implement Drak Tharon Keep - Novos the Summoner

Thanks to Nonid for old EventAI script for timers and base mechanics
The visual Beam Channel spells need some core fix to proper ignore LoS barriers
Implement summon Timmy the Cruel support in Stratholme

Also fix Typo from 2227
Implement Doomgrip summon event in BRD
Various small Changes

* Improve Add-handling for Utgarde Keep, Prince Keleseth (research done by ZPS)
* Comment improvements in BRD
* Code improvements for Ragnaros (replace std::list with std::vector
Update TBC Compatibility patch
Housegardening in sc_gossip.h

Remove two invalid (since at least 2008) macros:
* SEND_QUEST_DETAILS
* SEND_REQUESTEDITEMS

Please feedback about your use of other in sc_gossip.h defined macros,
because I intend to remove the ones that we don't use in SD2!
A few dragon tunings

* Remove unneeded spell-enums in Onyxia (thanks to Cher0 for pointing)
* Also improve Onyxia Whelp handling (Remove invalid array access, make whelps less agressive)
* Add some additional comment to Sapphirion, set summoned npcs into combat
* Fix Seeping Fog Summon Timer for Emerald Dragons (thanks to Click for noting)

YTDB 382

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus