[VS22] v19.1

[Int16]

Thanks Ketchup
For everyone that is not familiar with forks and pull request on github should search it up so we can all work together on it :)

[Ketchup]

Thanks Ketchup
For everyone that is not familiar with forks and pull request on github should search it up so we can all work together on it :)

Hey np, if you have legit updates and you to contribute your more then welcome to send them to me or w/e and ill look them over. Sorry it took so long tbh shit has been absolutely crazy here.

[Int16]

Im also not that active atm but i managed to contribute a little fix taken from the 21 source and also proper text positioning in the messenger

I made a pull request on github so you can look over it :)

Edit: "I will not generally respond on github so please report back issues." i did not see that my badd

Crash Fix :

Spoiler:

BOOL CWndQuestQuickInfo::Process( void )
{
#ifdef __SECURITY_FIXES
    if (g_pPlayer == NULL)
        return TRUE;
#endif //__SECURITY_FIXES

    CRect rtQuickInfoApplet = GetWindowRect();

....
}

Messenger Text positioning :

Spoiler:

@"voidCWndMessengerEx::OnDraw( C2DRender*p2DRender )
Change the textout x to 49 & 48

#if __VER >=19
    CString pszName = g_pPlayer->GetName( TRUE );
    int nMaxSize = 12;
    if( pszName.GetLength() > nMaxSize ) 
    {
        int nReduceCount = 0;
        while( nReduceCount < nMaxSize )
        {
            nReduceCount += (IsDBCSLeadByte( pszName[ nReduceCount ] ))? 2 : 1;
        }

        pszName = pszName.Left( nReduceCount );
        pszName += "...";
    }
    p2DRender->TextOut( 49, 7, 1, 1, pszName, 0xFF606060 ); //here
    p2DRender->TextOut( 48, 6, 1, 1, pszName, 0xFFFFFFFF );
    p2DRender->TextOut( 48, 20, 1, 1, strState, 0xff36E052 );
#else // __VER >= 19

also change the x on all appearances of this to 175 :
before:

p2DRender->TextOut( 158, 12, 1, 1, strServerName, 0xffF6CC4D );
p2DRender->TextOut( 158, 24, 1, 1, strServerName, 0xffF6CC4D );

after:

p2DRender->TextOut( 175, 12, 1, 1, strServerName, 0xffF6CC4D );
p2DRender->TextOut( 175, 24, 1, 1, strServerName, 0xffF6CC4D );

[Ketchup]

Im also not that active atm but i managed to contribute a little fix taken from the 21 source and also proper text positioning in the messenger

I made a pull request on github so you can look over it :)

Edit: "I will not generally respond on github so please report back issues." i did not see that my badd

Crash Fix :

Spoiler:

BOOL CWndQuestQuickInfo::Process( void )
{
#ifdef __SECURITY_FIXES
    if (g_pPlayer == NULL)
        return TRUE;
#endif //__SECURITY_FIXES

    CRect rtQuickInfoApplet = GetWindowRect();

....
}

Messenger Text positioning :

Spoiler:

@"voidCWndMessengerEx::OnDraw( C2DRender*p2DRender )
Change the textout x to 49 & 48

#if __VER >=19
    CString pszName = g_pPlayer->GetName( TRUE );
    int nMaxSize = 12;
    if( pszName.GetLength() > nMaxSize ) 
    {
        int nReduceCount = 0;
        while( nReduceCount < nMaxSize )
        {
            nReduceCount += (IsDBCSLeadByte( pszName[ nReduceCount ] ))? 2 : 1;
        }

        pszName = pszName.Left( nReduceCount );
        pszName += "...";
    }
    p2DRender->TextOut( 49, 7, 1, 1, pszName, 0xFF606060 ); //here
    p2DRender->TextOut( 48, 6, 1, 1, pszName, 0xFFFFFFFF );
    p2DRender->TextOut( 48, 20, 1, 1, strState, 0xff36E052 );
#else // __VER >= 19

also change the x on all appearances of this to 175 :
before:

p2DRender->TextOut( 158, 12, 1, 1, strServerName, 0xffF6CC4D );
p2DRender->TextOut( 158, 24, 1, 1, strServerName, 0xffF6CC4D );

after:

p2DRender->TextOut( 175, 12, 1, 1, strServerName, 0xffF6CC4D );
p2DRender->TextOut( 175, 24, 1, 1, strServerName, 0xffF6CC4D );

Thanks, i will take a look @ it tomorrow after work