[Development] Bug Free Season 2 (Open Source) - 2014 Edition

[Th3AnG3L]

Sometimes after log in to character, reset, dying in pvp or from monster you re spawn with 0 hp, pots won't increase your hp, after several switch char or dying for several times, hp get to 1 and potions will work.
Hope it's enough details.

Ty.

this problem comes from /reset function
if bug the tables in db to - stats thats why maybe you got problems have you checked this?

[InsidiousMu]

The bug appears suddenly, not just after reset.

[Recove]

What do you mean? trading works fine for me.

Are you saying if you use packet hack now it disconnects all?



any info on how to reproduce this bug? never had or heard of it before.

packet 0x36
i send trade to player i get dc

[NanoGuy]

@Shatter

Hi Shatter ,

you can block packet : C1 0F F3 7B C7 75 EA 99 BA 12 EC 5A 13 4E 77
create character DW no nick

fix:

    case 0xF3:
        if(aRecv[3] == 0x01)
        {
            int Namelength = strlen((char*)&aRecv[4]);
            if(NameLength > 0)
            {
                for(int i = 0; i < Namelength);
                ++i)
                {
                    if(isalnum(aRecv[4 + i]) == 0)
                    {
                        Log.AddTime("[Anti-Hack][Crash Attempt] [Create Character] (%s)(%s)",gObj[aIndex].AccountID,gObj[aIndex].Name);
                        Log.Hack("[Anti-Hack][Crash Attempt] [Create Character] (%s)(%s)",gObj[aIndex].AccountID,gObj[aIndex].Name);
                        CloseClient(aIndex);
                        return;
                    }
                }
            }
            else
            {
                Log.AddTime("[Anti-Hack][Crash Attempt] [Create Character] (%s)(%s)",gObj[aIndex].AccountID,gObj[aIndex].Name);
                Log.Hack("[Anti-Hack][Crash Attempt] [Create Character] (%s)(%s)",gObj[aIndex].AccountID,gObj[aIndex].Name);
                CloseClient(aIndex);
                return;
            }
        }
        break;
    }

[Lejman]

packet 0x36
i send trade to player i get dc

I tested this and don't get dc when I send Trade to my second account from first account and back.

P.S.
There is a chance that in these areas showed you what is the vip? Or where I can change this text?

[Shatter]

it is possible but requires some work, the left one is in message_kor.wtf and right one in text.bmd, client side.

oh and i'll be posting the sources on github from now on, when i get it up running.


- S

[Recove]

it is possible but requires some work, the left one is in message_kor.wtf and right one in text.bmd, client side.

oh and i'll be posting the sources on github from now on, when i get it up running.


- S

Shatter you you code packet trade npc not fixed

I send regular user Commerce server and I'm getting disconnecting anyone who sends a detachment receives trade

[Lejman]

I try add configs for Senior Mix but I have a problem.
I found offsets in GSCS and defined in Configurations.h:

#define SENIOR_BLESS (0x004AC597)
#define SENIOR_SOUL (0x004AC59D)
#define SENIOR_GUARDIAN (0x004AC5A3)
#define SENIOR_MAXZEN (0x004AC643)

Next I add configs in Configurations.cpp:

void SeniorMix(char* File)
{
#if(GS_CASTLE)
BYTE RequireBless;
RequireBless = GetPrivateProfileInt("GameServerInfo","SeniorMixBundleBlessRequired",3,COMMONSERVER_PATH);
*(unsigned char*) SENIOR_BLESS = RequireBless;

BYTE RequireSoul;
RequireSoul = GetPrivateProfileInt("GameServerInfo","SeniorMixBundleSoulRequired",3,COMMONSERVER_PATH);
*(unsigned char*) SENIOR_SOUL = RequireSoul;

BYTE RequireGuardian;
RequireGuardian = GetPrivateProfileInt("GameServerInfo","SeniorMixGuardianRequired",30,COMMONSERVER_PATH);
*(unsigned char*) SENIOR_GUARDIAN = RequireGuardian;

DWORD maxzen;
maxzen = GetPrivateProfileInt("GameServerInfo","SeniorMixZenRequired",1000000000,COMMONSERVER_PATH);
*(unsigned int*) SENIOR_MAXZEN = maxzen;
#endif
}

But always have Mix Failed. How to fix it?

[S1lvik]

Shatter you have sources for client? please add calculator caracter , thxx

[IrukaSennin]

Shatter, can you check DataServers? Because have problem StandBy.

[InsidiousMu]

It should be nice to make DataServer work correctly on every OS! If anyone know to do that it would be really appreciated !

[Shatter]

It should be nice to make DataServer work correctly on every OS! If anyone know to do that it would be really appreciated !

Has worked for me on all 32bit systems so far, im guessing muserver doesn't have much 64bit compatibility since the whole code is ancient. i'm not saying it won't work on 64bit, but to avoid unnecessary and weird problems i'd recommend using just 32bit windows.

- S

[InsidiousMu]

For me not worked on win 7 home premium 32 bit on win 7 ultimate 64bit worked but GS just stopped working after a while, Now on win 7 ultimate sp1 64 bits GS works ok but DS have same problem, I think is a sql connection error cuz data from GS stops going to sql so DS goes to standby. Just an opinion, I really can't understand what is happening, now i have some problems installing sql 2005 on windows server 2003 r2 sp2 on VPS after I solve that maybe will work without problems.

[Pinkof]

i will share some sources

// Fix LevelUpPointAdd (InitDll.cpp)
*(DWORD*)((0x0404D4F+ 1)) = (DWORD)&gObjLevelUpPointAdd - (0x0404D4F+ 5);
*(BYTE*)(0x0404D4F) = 0xE9;

//Fixes.cpp
BOOL gObjLevelUpPointAdd(BYTE type, OBJECTSTRUCT*lpObj)
{
int TotalPoints = 0;


if ( lpObj->Type > OBJECT_NPC )
{
Log.Error("error to add points %s",lpObj->Name);
return FALSE;
}


if ( lpObj->LevelUpPoint < 1 )
{
return FALSE;
}


switch ( type )
{
case 0:
TotalPoints = GetStrength((int) lpObj->m_Index) + 1;

if(TotalPoints>65535)
{
GCServerMsgStringSend("[FULL STAT]Can't add more Strength points",lpObj->m_Index,1);
return FALSE;
}
else
{
lpObj->Strength++;
}
break;


case 1:
TotalPoints = GetAgility((int) lpObj->m_Index) + 1;
if(TotalPoints>MAXSTAT)
{
GCServerMsgStringSend("[FULL STAT]Can't add more Agility points",lpObj->m_Index,1);
return FALSE;
}
else
{
lpObj->Dexterity++;
}
break;


case 2:
TotalPoints = GetVitality((int) lpObj->m_Index) + 1;
if(TotalPoints>MAXSTAT)
{
GCServerMsgStringSend("[FULL STAT]Can't add more Vitality points",lpObj->m_Index,1);
return FALSE;
}
else
{
lpObj->Vitality++;


lpObj->MaxLife += lpObj->VitalityToLife;
gObjCalcMaxLifePower(lpObj->m_Index);
}
break;


case 3:
TotalPoints = GetEnergy((int) lpObj->m_Index) + 1;
if(TotalPoints>MAXSTAT)
{
GCServerMsgStringSend("[FULL STAT]Can't add more energy points",lpObj->m_Index,1);
return FALSE;
}
else
{
lpObj->Energy++;
lpObj->MaxMana += lpObj->EnergyToMana;
}
break;


case 4:
TotalPoints = GetCommand((int) lpObj->m_Index) + 1;
if(TotalPoints>MAXSTAT)
{
GCServerMsgStringSend("[FULL STAT]Can't add more command points",lpObj->m_Index,1);
return FALSE;
}
else
{
lpObj->Leadership++;
}
break;
}


lpObj->LevelUpPoint--;
MygObjCalCharacter(lpObj->m_Index);

return TRUE;
}

//fixes.h
BOOL gObjLevelUpPointAdd(BYTE type, OBJECTSTRUCT*lpObj);

[InsidiousMu]

From VPS with windwos server 2003 r2 sp2 32 bit, server don't even start (too many errors to talk about it)... I think this dataserver standby thing will be always a problem for me...

Edit: Maybe on later version like season 4/6 I will not have this problem.... maybe my solution is to try use new seasons what I really hate....