zTeam source + fixes STABLE

[ftewegw1]

Hello, since the development topic is pretty much dead and the other topics in release are not open source and bugged as hell and since my files are stable and have a lot of fixes, I decided to start a new open source thread in order to further develop these nice files :)

As of customs I've only enabled ShopPointEx , OffTrade and ConnectEx wich I've tested and work properly




CHANGELOG:

- Fixed Poison/Ice Strengthener
- Fixed Gens Msg Display Error
- Fixed Soul Bug Offtrade
- Fixed Sphere LVL 1 Drop
- Fixed Some Annoying Logs When CS Not Running
- Added Config For Luck/Skill Drop
- Fixed IT (client ttlci.dll)

KNOWN ISSUES:

- Mussenger Doesn't Work 
- Gift Shop Doesn't Work
- Dark Side Mana Bug When No Targets
- Deathstab Skill Visual Bug // => client side bug
- Agility Bug On Some Skills

ofc some of the fixes are sloppy,but there's the source so you can optimize that sht
that's all , pls report bugs and don't spam

also credits go to :
WebZen
zTeam
Community for many fixes

and mostly Webmonkey for senting me many fixes and working together with me on some as well , dude has huge experiense :)


About zClient Source:
I'm not going to post a source since I think anyone can customize the client as he wishes to;
I'm Only going to post fixes that affect the gameplay or have an effect on GS stability.

fix visual show offtrade type (zClient.dll source) :

add this in protocol.cpp:

case 0x3F:
   {
     gOffTrade.RecvPShop((PMSG_ANS_BUYLIST_FROM_PSHOP*)Data);// <- here 
   }
   break;

and then in offtrade.cpp change the wcoin check like this:

if(!strcmp(Data->szPShopText,WCOIN_SHOP))

link UPDATE (31/8/2014 - 17:00):
https://mega.co.nz/#!C9012BhC!y8luEd...aLP2TH0t6-u_ic

full client:
http://www.gamershell.com/download_83972.shtml
patch it with zClient files that you can find on other ragezone topics, dont be lazy -.-

[MentaL]

[[RCZ]ShadowKing]

I moved it into development section as it's work in progress.
Please post only if you can contribute (bug reports, fixes, ideas) and ask for help in the help section!

[ScriptKid]

Nice seeing another thread with zteam.

about offtrade i think webmonkey already fixed it together with Nam4

cheers!
@ftewegw1 can you release the full server file?

Thanks!

[webmonkey]

Indeed we have, I just skyped you the fix. Still some work left to do, but its nice to see a topic for someone who cares to help and ask for help. looking forward to merge some more of my code into your project.

[ftewegw1]

Nice seeing another thread with zteam.

about offtrade i think webmonkey already fixed it together with Nam4

cheers!
@ftewegw1 can you release the full server file?

Thanks!

there's nothing changed in the rest of them, everything different I posted here :)

[ScriptKid]

I see. everytime i build the source the zGameserver.exe says M drive not found.

- - - Updated - - -

Update: works now my bad.
@webmonkey: could you post the fix for offtrade here?

Thanks!

[Meet Your Maker]

is this for Season 8 Ep2 files?

[LTPTeam]

is this for Season 8 Ep2 files?

No. It's 6.3

[phgkhh]

Does this include the /openware function? Thanks,

It's great if webmonkey can share the source to completely fix the /offtrade here :)

[ftewegw1]

Does this include the /openware function? Thanks,

It's great if webmonkey can share the source to completely fix the /offtrade here :)

/offtrade is completely fixed and included in the sources, only thing missing is in zClient.dll some code to show zen/wcoin/soul
at the moment it only shows zen but it's only visual cause items cost wcoin or souls if its wcoin/soul shop

as for /ware, I said it before I've not included/coded almost any customs , thx and keep testing

[phgkhh]

/offtrade is completely fixed and included in the sources, only thing missing is in zClient.dll some code to show zen/wcoin/soul
at the moment it only shows zen but it's only visual cause items cost wcoin or souls if its wcoin/soul shop

as for /ware, I said it before I've not included/coded almost any customs , thx and keep testing

Thanks for the info,

Could you also share the source of your client?

Best,

[ftewegw1]

Thanks for the info,

Could you also share the source of your client?

Best,

I havent changed anything in client besides the fix that i posted for offtrade

[phgkhh]

@webmonkey: Do you know how to add the command /ware to have multi-vault command function into this source?

[Wortex]

Just stop with the customs... No one gives a flying fuck for "openware" or "custom jewels" or anything like that.
These sources are NOT perfect, there are bugs. Plenty of them.

Compile the sources and test for fucks sake. I feel ashamed for this community, no wonder no one shares anything. Current moto: get as much crappy customs as possible and sellout the server to donators. I just don't even...

@ftewegw1 Organize your thread! Add a client that people could download and test. Do you want to fix bugs which arise from an incomplete client ripped from some childish website? General client (the one you use) would limit the bugs to the things you at least have sources for.

[quskevel]

Just stop with the customs... No one gives a flying fuck for "openware" or "custom jewels" or anything like that.
These sources are NOT perfect, there are bugs. Plenty of them.

Compile the sources and test for fucks sake. I feel ashamed for this community, no wonder no one shares anything. Current moto: get as much crappy customs as possible and sellout the server to donators. I just don't even...

@ftewegw1 Organize your thread! Add a client that people could download and test. Do you want to fix bugs which arise from an incomplete client ripped from some childish website? General client (the one you use) would limit the bugs to the things you at least have sources for.

need to update know issues /if fixed -> delete if not stay and add new bugs
i dont tested now this source, but in my previous i found bug with castle siege.
If u not config CastleSiege in DB u have error with error-L2 : header error (wsJoinServerCli.cpp 295)lOfs:0, size:36
and with this error if u restart fast gs (~2-3 times) u have block join to server.

and ofc we are waiting for Nam4 release, btw it intresting how many bugs he fixed (not show in changelogs.)

and ofc soon i added all customs in this release or add code of small fixes and extensial.


First fix command:
Search for COMMAND_RESETCLASS
and add it:
case 98:
lpObj->DbClass = 98;
break;
zTeam forgot for RF >.<

and maybe we are create GitHub and give good users access to editing? it really help for fix bugs =/
in planed i rewrite all commands ... and release commands source for it.

[xtreme17]

Please make this repack without customs :) thank you .

[quskevel]

Please make this repack without customs :) thank you .

it easy, but need more time. for first time i think need fix current bugs list.

- - - Updated - - -

Fix gens message, after kill gens player you have recieve message about like this ->"5 contribution point(s) would be lost"

Search for %d contribution point(s) would be lost
and change:
GCServerMsgStringSend(Text, lpObj->m_Index, 1);
to
GCServerMsgStringSend(Text, lpTargetObj->m_Index, 1);

[webmonkey]

First fix command:
Search for COMMAND_RESETCLASS
and add it:
case 98:
lpObj->DbClass = 98;
break;
zTeam forgot for RF >.<

since the switch case is DBCLASS, your code there is doing absolutely nothing. its like

if (somevariable == 1)
   somevariable = 1;

I think that fist master is 98 and rage fighter 96, so code should be:

case 98:
lpObj->DbClass = 96;
break;

that being said, count me in if you start a public repo.

[quskevel]

since the switch case is DBCLASS, your code there is doing absolutely nothing. its like

if (somevariable == 1)
   somevariable = 1;

I think that fist master is 98 and rage fighter 96, so code should be:

case 98:
lpObj->DbClass = 96;
break;

that being said, count me in if you start a public repo.

Oh my carelessness :D
//PublicRepo:
Ok, today or tomorrow i create repo on github and give invites u and all Good Coders.

- - - Updated - - -

Hi guys i create repo
WebMonkey and topic creator i sent message, but if you learn c++ or good coder and think about fix this release please leave me message about it!

[quskevel]

if( g_PostChatColor < 1 || g_PostChatColor > 8 )
Post Chat Color Crash fix

Socket Seed fix drop:

    if ( this->m_SphereDropLevel[0] <= iMonsterLevel )
    {
        iSphereLevel = 1;
    }
    else if( this->m_SphereDropLevel[1] <= iMonsterLevel )
    {
        iSphereLevel = 2;
    }
    else if( this->m_SphereDropLevel[2] <= iMonsterLevel )
    {
        iSphereLevel = 3;
    }
    else if( this->m_SphereDropLevel[3] <= iMonsterLevel )
    {
        iSphereLevel = 4;
    }
    else if( this->m_SphereDropLevel[4] <= iMonsterLevel )
    {
        iSphereLevel = 5;
    }
    else
    {
        return -1;
    }
    // ----
    for( int i = 0; i < iSphereLevel; i++ )
    {
        if(this->m_SphereDropRate[i] >= GetLargeRand() % MAX_SPHERE_DROP )
        {
            iItemCode = i + ITEMGET(12, 70);
        }
    }

Massive spam log fix (just delete following lines):

        if ( iTotalShieldDamage > 0 )
        {
            LogAddTD("[PvP System] Victim:[%s][%s], Attacker:[%s][%s] - SD[%d] HP[%f] -> SD[%d] HP[%f]",
                lpTargetObj->AccountID, lpTargetObj->Name, lpObj->AccountID, lpObj->Name,
                lpTargetObj->iShield + iTotalShieldDamage, lpTargetObj->Life + AttackDamage, 
                lpTargetObj->iShield, lpTargetObj->Life);
        }

i see u use my "FIX":

    else if( !this->EmptyPointInventory(lpUser, lpUser->Inventory1[ItemPos].m_iPShopValue) ) //remove the !

But it dont fix offtrade for item. No recieve soul for sell item.

OffExp Timer fix:

#ifdef OFFEXP
            if ( lpObj->OffExp == 1 )
            {
                OffExp.TickTimes(n);
            }
#endif

Add To Bug list after this message gs block to join server:

				if( this->CheckSync() == FALSE )
				{
					LogAddC(2, "[CastleSiege] CCastleSiege::Init() - CheckSync() == FALSE");
					MsgBox("[CastleSiege] CCastleSiege::Init() - CheckSync() == FALSE");
					MsgOutput(iIndex, lMsg.Get(3202));
					return;
				}

with error:
error-L2: header error (wsJoinServercli.cpp 295)lOfs:0, size:28

[webmonkey]

i see u use my "FIX":

    else if( !this->EmptyPointInventory(lpUser, lpUser->Inventory1[ItemPos].m_iPShopValue) ) //remove the !

that's not your fix, thats a z-team typo corrected xD

In order to receive soul from buyer you need to recode a big chunk of the offtrade, currently it closes the client before updating inventory.

[quskevel]

In order to receive soul from buyer you need to recode a big chunk of the offtrade, currently it closes the client before updating inventory.

i think need add delay for closed user if item are sold.
but ofc we are fix it soon :D for me offtrade not needed function... only for trading (zen/wcoin).

Delay for PShop open, because you no have time for start offtrade or correct price you item.
This delay created only by me :D with my "true" skill xD
Test it:
search for:

		LogAddTD("[PShop] [%s][%s] is Receiving PShop List From [%s][%s]",
		gObj[aSourceIndex].AccountID, gObj[aSourceIndex].Name, lpObj->AccountID, lpObj->Name);


		gObj[aSourceIndex].m_bPShopWantDeal = true;
		gObj[aSourceIndex].m_iPShopDealerIndex = lpObj->m_Index;
		memcpy(gObj[aSourceIndex].m_szPShopDealerName, lpObj->Name, MAX_ACCOUNT_LEN);
		::CGPShopAnsBuyList(aSourceIndex, lpObj->m_Index, 1, false);

and change this function to:

	if ( gOpenDelay > lpObj->gOpenDelayTick )
	{
		int Delay = gOpenDelay - lpObj->gOpenDelayTick;
		char Text[100];
		sprintf(Text, "Protect disabled after: %dsecond(s)", Delay);
		GCServerMsgStringSend(Text, aSourceIndex, 1);
		::CGPShopAnsBuyList(aSourceIndex, -1, 3, 0);
		return;
	}
	else
	{
		LogAddTD("[PShop] [%s][%s] is Receiving PShop List From [%s][%s]",
		gObj[aSourceIndex].AccountID, gObj[aSourceIndex].Name, lpObj->AccountID, lpObj->Name);


		gObj[aSourceIndex].m_bPShopWantDeal = true;
		gObj[aSourceIndex].m_iPShopDealerIndex = lpObj->m_Index;
		memcpy(gObj[aSourceIndex].m_szPShopDealerName, lpObj->Name, MAX_ACCOUNT_LEN);
		::CGPShopAnsBuyList(aSourceIndex, lpObj->m_Index, 1, false);
	}

search for lpObj->OffExpSpeed = 0;
and after add this:
lpObj->gOpenDelayTick = 0;

in user.cpp search:
if(lpObj->Connected > PLAYER_LOGGED && lpObj->Type == OBJ_USER)
in this function u see check OffExp,TickTimes(n)
after this check add this:

if( lpObj->m_bPShopOpen )
			{
				lpObj->gOpenDelayTick++;
			}
			else
			{
				lpObj->gOpenDelayTick = 0;
			}

in user.h add:
int gOpenDelayTick;
after
DWORD m_PotionTick;

ofc need create config variable:
in GameMain.cpp add:
int gOpenDelay;
after
BOOL gDoPShopOpen;

in next u need search 3xTimes
gDoPShopOpen = GetPrivateProfileInt("GameServerInfo","PersonalShopOpen", 0, gDirPath.GetNewPath("commonserver.cfg"));
and add this after (in all of 3x):
gOpenDelay = GetPrivateProfileInt("GameServerInfo","PersonalShopDelay", 0, gDirPath.GetNewPath("commonserver.cfg"));

search for:
extern BOOL gDoPShopOpen;
and add after:
extern int gOpenDelay;

if you do this u need add in CommonServer.cfg
PersonalShopDelay = 60 //-> Personal shop open delay [0-65535]

[ftewegw1]

i think need add delay for closed user if item are sold.
but ofc we are fix it soon :D for me offtrade not needed function... only for trading (zen/wcoin).

Delay for PShop open, because you no have time for start offtrade or correct price you item.
This delay created only by me :D with my "true" skill xD
Test it:
search for:

		LogAddTD("[PShop] [%s][%s] is Receiving PShop List From [%s][%s]",
		gObj[aSourceIndex].AccountID, gObj[aSourceIndex].Name, lpObj->AccountID, lpObj->Name);


		gObj[aSourceIndex].m_bPShopWantDeal = true;
		gObj[aSourceIndex].m_iPShopDealerIndex = lpObj->m_Index;
		memcpy(gObj[aSourceIndex].m_szPShopDealerName, lpObj->Name, MAX_ACCOUNT_LEN);
		::CGPShopAnsBuyList(aSourceIndex, lpObj->m_Index, 1, false);

and change this function to:

	if ( gOpenDelay > lpObj->gOpenDelayTick )
	{
		int Delay = gOpenDelay - lpObj->gOpenDelayTick;
		char Text[100];
		sprintf(Text, "Protect disabled after: %dsecond(s)", Delay);
		GCServerMsgStringSend(Text, aSourceIndex, 1);
		::CGPShopAnsBuyList(aSourceIndex, -1, 3, 0);
		return;
	}
	else
	{
		LogAddTD("[PShop] [%s][%s] is Receiving PShop List From [%s][%s]",
		gObj[aSourceIndex].AccountID, gObj[aSourceIndex].Name, lpObj->AccountID, lpObj->Name);


		gObj[aSourceIndex].m_bPShopWantDeal = true;
		gObj[aSourceIndex].m_iPShopDealerIndex = lpObj->m_Index;
		memcpy(gObj[aSourceIndex].m_szPShopDealerName, lpObj->Name, MAX_ACCOUNT_LEN);
		::CGPShopAnsBuyList(aSourceIndex, lpObj->m_Index, 1, false);
	}

search for lpObj->OffExpSpeed = 0;
and after add this:
lpObj->gOpenDelayTick = 0;

in user.cpp search:
if(lpObj->Connected > PLAYER_LOGGED && lpObj->Type == OBJ_USER)
in this function u see check OffExp,TickTimes(n)
after this check add this:

if( lpObj->m_bPShopOpen )
			{
				lpObj->gOpenDelayTick++;
			}
			else
			{
				lpObj->gOpenDelayTick = 0;
			}

in user.h add:
int gOpenDelayTick;
after
DWORD m_PotionTick;

ofc need create config variable:
in GameMain.cpp add:
int gOpenDelay;
after
BOOL gDoPShopOpen;

in next u need search 3xTimes
gDoPShopOpen = GetPrivateProfileInt("GameServerInfo","PersonalShopOpen", 0, gDirPath.GetNewPath("commonserver.cfg"));
and add this after (in all of 3x):
gOpenDelay = GetPrivateProfileInt("GameServerInfo","PersonalShopDelay", 0, gDirPath.GetNewPath("commonserver.cfg"));

search for:
extern BOOL gDoPShopOpen;
and add after:
extern int gOpenDelay;

if you do this u need add in CommonServer.cfg
PersonalShopDelay = 60 //-> Personal shop open delay [0-65535]

i dont think this will work
anyway the idea is correct, we need some kind of delay

now for the other post u made:

1. the chat fix u added, can u explain more? i dont know whats wrong with chat
2. sphere drop, whats wrong? explain pls, I dont see anything different between ur fix and original code
3. offexp fix I will add, i remember that u posted it before but I didnt bother adding it cause i am not using it, but i will add it now
4. the bug u want me to add to the list is not a bug I think, if u setup the cs this doesnt appear, and even if u dont setup cs and this appears, it does nothing really to affect GS

send me ur skype id

[quskevel]

i dont think this will work
anyway the idea is correct, we need some kind of delay

now for the other post u made:

1. the chat fix u added, can u explain more? i dont know whats wrong with chat
2. sphere drop, whats wrong? explain pls, I dont see anything different between ur fix and original code
3. offexp fix I will add, i remember that u posted it before but I didnt bother adding it cause i am not using it, but i will add it now
4. the bug u want me to add to the list is not a bug I think, if u setup the cs this doesnt appear, and even if u dont setup cs and this appears, it does nothing really to affect GS

send me ur skype id

2. -> try to setup drop and u see drop from spiders seed (but lvl for +1 110+ (/spider 1lvl)) for example.
2. -> with my fix this problem solved and seed sphere not droped from small then in config level.

1. -> i small dont understand.. quote me(fix) for understand you.
4. -> it serious bug because if you dont setup CS you dont login to server and ofc on account. This bug knows Nam4 and he promised help me with it.


About Offtrade i maybe know how to fix fast bug with not save souls....it's a bit like my fix from steal pshop items if you do off trade..

and ofc i sent u and webmonkey invite to repo, need sync this current repository and apply all fix. Today i not sleep and now i go to sleep XD

[webmonkey]

No need to add all that. A delay is not needed, just a smarter way to deal with empty offtraders.